Issue 879657 link

Starred by 3 users

Issue metadata

Status:	Started
Owner:	wfh@chromium.org
Cc:	dtapu...@chromium.org
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	2
Type:	Bug
Build

Blocked on: View detail
issue 881966
issue 883105
issue 881008

Blocking:
issue 588506
issue 919981

enable -Wshorten-64-to-32 for 64-bit builds

Project Member Reported by wfh@chromium.org, Aug 31

Issue description

Previous to clang, MSVC would warn for 64-bit size_t -> 32-bit implicit conversions under warning 4267.

With the move to clang, we lost some of these warnings. They are all tracked by parent issue 588506 as part of -Wconversion.

This bug is to track enabling the equivalent -Wshorten-64-to-32 for clang.

-Wshorten-64-to-32 is a superset of the MSVC "size_t -> 32-bit" warning because it covers all 64-bit types. It also covers 64-bit to 32-bit conversions on 32-bit (e.g. long long -> size_t on 32-bit).

As this latter implicit conversion (64->32 on 32-bit builds) was never a warning as part of previous MSVC builds, enabling this for 32-bit builds will be tracked in a future issue as it involves far more code changes.

Project Member

Comment 1 by bugdroid1@chromium.org, Aug 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/817db9941cb87e5e6df7798874039f32307776b6

commit 817db9941cb87e5e6df7798874039f32307776b6
Author: Will Harris <wfh@chromium.org>
Date: Fri Aug 31 20:29:50 2018

Mark thirdparty/ots as non-Chromium code.

This suppresses a number of warnings that will be enabled in the future.

Remove unneeded extra warnings, as these are covered by a global config.

../../third_party/ots/src/prep.cc(25,20):  warning: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long long') to 'uint32_t' (aka 'unsigned int') [-Wshorten-64-to-32]
  this->m_length = length;
                 ~ ^~~~~~

../../third_party/ots/src/fpgm.cc(24,18):  warning: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long long') to 'uint32_t' (aka 'unsigned int') [-Wshorten-64-to-32]
  this->length = length;
               ~ ^~~~~~

../../third_party/ots/src/post.cc(104,44):  warning: implicit conversion loses integer precision: 'std::vector<std::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::basic_string<char, std::char_traits<char>, std::allocator<char> > > >::size_type' (aka 'unsigned long long') to 'const unsigned int' [-Wshorten-64-to-32]
  const unsigned num_strings = this->names.size();
                 ~~~~~~~~~~~   ~~~~~~~~~~~~^~~~~~

../../third_party/ots/src/cvt.cc(28,18):  warning: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long long') to 'uint32_t' (aka 'unsigned int') [-Wshorten-64-to-32]
  this->length = length;
               ~ ^~~~~~

../../third_party/ots/src/cmap.cc(153,49):  warning: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long long') to 'uint32_t' (aka 'unsigned int') [-Wshorten-64-to-32]
    ranges[i].id_range_offset_offset = subtable.offset();
                                     ~ ~~~~~~~~~^~~~~~~~
../../third_party/ots/src/cmap.cc(884,42):  warning: implicit conversion loses integer precision: 'std::vector<ots::OpenTypeCMAPSubtableVSRecord, std::allocator<ots::OpenTypeCMAPSubtableVSRecord> >::size_type' (aka 'unsigned long long') to 'const unsigned int' [-Wshorten-64-to-32]
    const unsigned num_records = records.size();
                   ~~~~~~~~~~~   ~~~~~~~~^~~~~~
../../third_party/ots/src/cmap.cc(886,30):  warning: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long long') to 'uint32_t' (aka 'unsigned int') [-Wshorten-64-to-32]
        !out->WriteU32(this->subtable_0_5_14_length) ||
              ~~~~~~~~ ~~~~~~^~~~~~~~~~~~~~~~~~~~~~
../../third_party/ots/src/cmap.cc(901,44):  warning: implicit conversion loses integer precision: 'std::vector<ots::OpenTypeCMAPSubtableVSRange, std::allocator<ots::OpenTypeCMAPSubtableVSRange> >::size_type' (aka 'unsigned long long') to 'const unsigned int' [-Wshorten-64-to-32]
        const unsigned num_ranges = ranges.size();
                       ~~~~~~~~~~   ~~~~~~~^~~~~~
../../third_party/ots/src/cmap.cc(916,48):  warning: implicit conversion loses integer precision: 'std::vector<ots::OpenTypeCMAPSubtableVSMapping, std::allocator<ots::OpenTypeCMAPSubtableVSMapping> >::size_type' (aka 'unsigned long long') to 'const unsigned int' [-Wshorten-64-to-32]
        const unsigned num_mappings = mappings.size();
                       ~~~~~~~~~~~~   ~~~~~~~~~^~~~~~
../../third_party/ots/src/cmap.cc(963,40):  warning: implicit conversion loses integer precision: 'std::vector<ots::OpenTypeCMAPSubtableRange, std::allocator<ots::OpenTypeCMAPSubtableRange> >::size_type' (aka 'unsigned long long') to 'const unsigned int' [-Wshorten-64-to-32]
    const unsigned num_groups = groups.size();
                   ~~~~~~~~~~   ~~~~~~~^~~~~~
../../third_party/ots/src/cmap.cc(985,40):  warning: implicit conversion loses integer precision: 'std::vector<ots::OpenTypeCMAPSubtableRange, std::allocator<ots::OpenTypeCMAPSubtableRange> >::size_type' (aka 'unsigned long long') to 'const unsigned int' [-Wshorten-64-to-32]
    const unsigned num_groups = groups.size();
                   ~~~~~~~~~~   ~~~~~~~^~~~~~

../../third_party/ots/src/cff.cc(69,36):  warning: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long long') to 'uint32_t' (aka 'unsigned int') [-Wshorten-64-to-32]
    index->offset_to_next = table->offset();
                          ~ ~~~~~~~^~~~~~~~
../../third_party/ots/src/cff.cc(112,28):  warning: implicit conversion loses integer precision: 'unsigned long long' to 'unsigned int' [-Wshorten-64-to-32]
        object_data_offset + (rel_offset - 1));  // less than length(), 1GB.
        ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~

../../third_party/ots/src/ots.cc(545,23):  warning: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long long') to 'Cr_z_uLongf' (aka 'unsigned long') [-Wshorten-64-to-32]
    uLongf dest_len = *table_length;
           ~~~~~~~~   ^~~~~~~~~~~~~
../../third_party/ots/src/ots.cc(776,33):  warning: implicit conversion loses integer precision: 'unsigned long long' to 'uint32_t' (aka 'unsigned int') [-Wshorten-64-to-32]
        out.length = end_offset - out.offset;
                   ~ ~~~~~~~~~~~^~~~~~~~~~~~
../../third_party/ots/src/ots.cc(793,21):  warning: implicit conversion loses integer precision: 'const size_t' (aka 'const unsigned long long') to 'off_t' (aka 'long') [-Wshorten-64-to-32]
  if (!output->Seek(table_record_offset)) {
               ~~~~ ^~~~~~~~~~~~~~~~~~~
../../third_party/ots/src/ots.cc(819,39):  warning: implicit conversion loses integer precision: 'unsigned long long' to 'off_t' (aka 'long') [-Wshorten-64-to-32]
  if (!output->Seek(head_table_offset + 8)) {
               ~~~~ ~~~~~~~~~~~~~~~~~~^~~
../../third_party/ots/src/ots.cc(826,21):  warning: implicit conversion loses integer precision: 'const size_t' (aka 'const unsigned long long') to 'off_t' (aka 'long') [-Wshorten-64-to-32]
  if (!output->Seek(end_of_file)) {
               ~~~~ ^~~~~~~~~~~

BUG=879657

Change-Id: I7a69310b9672657f7373bdc79b6a4b4cb9181c12
Reviewed-on: https://chromium-review.googlesource.com/1199489
Commit-Queue: Will Harris <wfh@chromium.org>
Reviewed-by: Behdad Esfahbod <behdad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588149}
[modify] https://crrev.com/817db9941cb87e5e6df7798874039f32307776b6/third_party/ots/BUILD.gn

Project Member

Comment 2 by bugdroid1@chromium.org, Sep 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4db09b47af1ce81b29be32852a43921b38ef4018

commit 4db09b47af1ce81b29be32852a43921b38ef4018
Author: Will Harris <wfh@chromium.org>
Date: Sat Sep 01 00:26:32 2018

Suppress -Wshorten-64-to-32 warnings in gles2 generated code.

Also remove legacy /WD4267 and replace with the compiler config.

Warnings being suppressed are here: https://pastebin.com/raw/QkwwCZLb

BUG=879657

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: If145532f415cdcc4c52a48dc11f421171538b25d
Reviewed-on: https://chromium-review.googlesource.com/1199869
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Will Harris <wfh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588226}
[modify] https://crrev.com/4db09b47af1ce81b29be32852a43921b38ef4018/gpu/command_buffer/client/BUILD.gn
[modify] https://crrev.com/4db09b47af1ce81b29be32852a43921b38ef4018/gpu/command_buffer/common/BUILD.gn
[modify] https://crrev.com/4db09b47af1ce81b29be32852a43921b38ef4018/gpu/gles2_conform_support/BUILD.gn

Comment 3 by dtapu...@chromium.org, Sep 4

Cc: dtapu...@chromium.org

I've periodically been working on fixing blink wrt to this flag.

Comment 4 by wfh@chromium.org, Sep 4

Owner: wfh@chromium.org
Status: Started (was: Untriaged)

Comment 5 by wfh@chromium.org, Sep 5

Blockedon: 881008

Comment 6 by wfh@chromium.org, Sep 7

Blockedon: 881966

Project Member

Comment 7 by bugdroid1@chromium.org, Sep 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb0d05104f1736fcbaa2ae83d7de301cd3954148

commit fb0d05104f1736fcbaa2ae83d7de301cd3954148
Author: Will Harris <wfh@chromium.org>
Date: Sat Sep 08 03:35:26 2018

Fix one more -Wshorten-64-to-32 warning in chrome_elf

../../chrome_elf/chrome_elf_test_stubs.cc(91,18):  warning: implicit conversion loses integer precision: 'long long' to 'uint32_t' (aka 'unsigned int') [-Wshorten-64-to-32]
  return tracker - buffer;
  ~~~~~~ ~~~~~~~~^~~~~~~~

BUG=879657

Change-Id: Ie9044aae8fffebd05fa45c26ee5a63649ea228f5
Reviewed-on: https://chromium-review.googlesource.com/1214743
Reviewed-by: Robert Shield <robertshield@chromium.org>
Commit-Queue: Robert Shield <robertshield@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589767}
[modify] https://crrev.com/fb0d05104f1736fcbaa2ae83d7de301cd3954148/chrome_elf/chrome_elf_test_stubs.cc

Project Member

Comment 8 by bugdroid1@chromium.org, Sep 10

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/63aa0e5b7001affb6a564049cf5b09e21083e332

commit 63aa0e5b7001affb6a564049cf5b09e21083e332
Author: Will Harris <wfh@chromium.org>
Date: Mon Sep 10 22:30:49 2018

Fix 64-bit -> 32-bit implicit conversions in libangle.

../../third_party/angle/src/libANGLE/renderer/gl/StateManagerGL.cpp(910,63):  warning: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long long') to 'GLuint' (aka 'unsigned int') [-Wshorten-64-to-32]
        const gl::ImageUnit &imageUnit = glState.getImageUnit(imageUnitIndex);
                                                 ~~~~~~~~~~~~ ^~~~~~~~~~~~~~
../../third_party/angle/src/libANGLE/renderer/gl/StateManagerGL.cpp(914,30):  warning: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long long') to 'GLuint' (aka 'unsigned int') [-Wshorten-64-to-32]
            bindImageTexture(imageUnitIndex, textureGL->getTextureID(), imageUnit.level,
            ~~~~~~~~~~~~~~~~ ^~~~~~~~~~~~~~
../../third_party/angle/src/libANGLE/renderer/gl/StateManagerGL.cpp(920,30):  warning: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long long') to 'GLuint' (aka 'unsigned int') [-Wshorten-64-to-32]
            bindImageTexture(imageUnitIndex, 0, imageUnit.level, imageUnit.layered, imageUnit.layer,
            ~~~~~~~~~~~~~~~~ ^~~~~~~~~~~~~~

../../third_party/angle/src/tests/gl_tests/VertexAttributeTest.cpp(1080,66):  warning: implicit conversion loses integer precision: 'GLsizeiptr' (aka 'long long') to 'GLuint' (aka 'unsigned int') [-Wshorten-64-to-32]
        glVertexAttribFormat(mTestAttrib, 1, GL_FLOAT, GL_FALSE, inputRelativeOffset);
        ~~~~~~~~~~~~~~~~~~~~                                     ^~~~~~~~~~~~~~~~~~~

BUG=chromium:879657

Change-Id: Ic6e8e5ebc0dc5fd38c15a48a936ceafd5407bba8
Reviewed-on: https://chromium-review.googlesource.com/1208315
Commit-Queue: Will Harris <wfh@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

[modify] https://crrev.com/63aa0e5b7001affb6a564049cf5b09e21083e332/src/libANGLE/renderer/gl/StateManagerGL.h
[modify] https://crrev.com/63aa0e5b7001affb6a564049cf5b09e21083e332/src/libANGLE/renderer/gl/StateManagerGL.cpp
[modify] https://crrev.com/63aa0e5b7001affb6a564049cf5b09e21083e332/src/tests/gl_tests/VertexAttributeTest.cpp
[modify] https://crrev.com/63aa0e5b7001affb6a564049cf5b09e21083e332/src/libANGLE/State.cpp
[modify] https://crrev.com/63aa0e5b7001affb6a564049cf5b09e21083e332/src/libANGLE/State.h

Project Member

Comment 9 by bugdroid1@chromium.org, Sep 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cbb4d247c3aa86d582fcc3745aa120182c341ceb

commit cbb4d247c3aa86d582fcc3745aa120182c341ceb
Author: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Tue Sep 11 00:29:34 2018

Roll src/third_party/angle 8e9d23405644..63aa0e5b7001 (1 commits)

https://chromium.googlesource.com/angle/angle.git/+log/8e9d23405644..63aa0e5b7001


git log 8e9d23405644..63aa0e5b7001 --date=short --no-merges --format='%ad %ae %s'
2018-09-10 wfh@chromium.org Fix 64-bit -> 32-bit implicit conversions in libangle.


Created with:
  gclient setdep -r src/third_party/angle@63aa0e5b7001

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:879657
TBR=ynovikov@chromium.org

Change-Id: Ia03df51b8f891829159e37a52cd2c77b408a28e5
Reviewed-on: https://chromium-review.googlesource.com/1217806
Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#590132}
[modify] https://crrev.com/cbb4d247c3aa86d582fcc3745aa120182c341ceb/DEPS

Project Member

Comment 10 by bugdroid1@chromium.org, Sep 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d9b7ffc64596fb83ad40308f4665941c2a17af2

commit 3d9b7ffc64596fb83ad40308f4665941c2a17af2
Author: Will Harris <wfh@chromium.org>
Date: Tue Sep 11 00:38:38 2018

Fix an implicit conversion warning in cc/paint.

Needed to enable -Wshorten-64-to-32 on 64-bit builds.

In file included from ../../printing/metafile_skia_unittest.cc:7:
In file included from ../..\cc/paint/paint_record.h:9:
../..\cc/paint/paint_op_buffer.h(939,16):  warning: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long long') to 'uint32_t' (aka 'unsigned int') [-Wshorten-64-to-32]
    op->skip = skip;
             ~ ^~~~
../../printing/metafile_skia_unittest.cc(28,11):  note: in instantiation of function template specialization 'cc::PaintOpBuffer::push<cc::DrawRectOp, const SkRect &, cc::PaintFlags &>' requested here
  record->push<cc::DrawRectOp>(page_rect, flags);
          ^
In file included from ../../printing/metafile_skia_unittest.cc:7:
In file included from ../..\cc/paint/paint_record.h:9:
../..\cc/paint/paint_op_buffer.h(939,16):  warning: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long long') to 'uint32_t' (aka 'unsigned int') [-Wshorten-64-to-32]
    op->skip = skip;
             ~ ^~~~
../../printing/metafile_skia_unittest.cc(30,11):  note: in instantiation of function template specialization 'cc::PaintOpBuffer::push<cc::CustomDataOp, const unsigned int &>' requested here
  record->push<cc::CustomDataOp>(content_id);
          ^

BUG=879657

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I272f2eb17e5ebb348e6960226949f3f18e4696f2
Reviewed-on: https://chromium-review.googlesource.com/1217903
Reviewed-by: enne <enne@chromium.org>
Commit-Queue: Will Harris <wfh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590140}
[modify] https://crrev.com/3d9b7ffc64596fb83ad40308f4665941c2a17af2/cc/paint/paint_op_buffer.h

Project Member

Comment 11 by bugdroid1@chromium.org, Sep 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f6b636c6d5bae3551ad58d90363ec39300db0bc

commit 3f6b636c6d5bae3551ad58d90363ec39300db0bc
Author: Will Harris <wfh@chromium.org>
Date: Tue Sep 11 03:30:05 2018

Fix -Wshorten-64-to-32 warnings in ui/events.

../../ui/events/keycodes/dom/dom_keyboard_layout_map_win.cc(58,32):  warning: implicit conversion loses integer precision: 'std::vector<HKL__ *, std::allocator<HKL__ *> >::size_type' (aka 'unsigned long long') to 'int' [-Wshorten-64-to-32]
      keyboard_layout_handles_.size(), keyboard_layout_handles_.data());
      ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~
../../ui/events/keycodes/dom/dom_keyboard_layout_map_win.cc(75,35):  warning: implicit conversion loses integer precision: 'std::vector<HKL__ *, std::allocator<HKL__ *> >::size_type' (aka 'unsigned long long') to 'uint32_t' (aka 'unsigned int') [-Wshorten-64-to-32]
  return keyboard_layout_handles_.size();
  ~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~

../../ui/events/keycodes/dom/dom_keyboard_layout_map_base.cc(32,44):  warning: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long long') to 'int' [-Wshorten-64-to-32]
        keyboard_layout_manager->GetLayout(i);
                                 ~~~~~~~~~ ^
../../ui/events/keycodes/dom/dom_keyboard_layout_map_base.cc(33,20):  warning: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long long') to 'uint32_t' (aka 'unsigned int') [-Wshorten-64-to-32]
    PopulateLayout(i, dom_keyboard_layout);
    ~~~~~~~~~~~~~~ ^

../../ui/events/test/event_generator.cc(673,51):  warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'DWORD' (aka 'unsigned long') [-Wshorten-64-to-32]
      (ui::EventTimeForNow() - base::TimeTicks()).InMicroseconds();
      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~

../../ui/events/win/events_win_utils.cc(257,36):  warning: implicit conversion loses integer precision: 'const LPARAM' (aka 'const long long') to 'DWORD' (aka 'unsigned long') [-Wshorten-64-to-32]
    return gfx::Point(native_event.lParam);
           ~~~        ~~~~~~~~~~~~~^~~~~~

../../ui/events/event_utils.cc(112,41):  warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'base::HistogramBase::Sample' (aka 'int') [-Wshorten-64-to-32]
                                  delta.InMicroseconds(), 1, 1000000, 50);
                                  ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../..\base/metrics/histogram_macros.h(189,15):  note: expanded from macro 'UMA_HISTOGRAM_CUSTOM_COUNTS'
        name, sample, min, max, bucket_count,                                  \
        ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../..\base/metrics/histogram_macros_internal.h(128,19):  note: expanded from macro 'INTERNAL_HISTOGRAM_CUSTOM_COUNTS_WITH_FLAG'
        name, Add(sample),                                                     \
              ~~~ ^~~~~~
../..\base/metrics/histogram_macros_internal.h(120,27):  note: expanded from macro 'STATIC_HISTOGRAM_POINTER_BLOCK'
                          histogram_add_method_invocation,                     \
                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../..\base/metrics/histogram_macros_internal.h(104,24):  note: expanded from macro 'HISTOGRAM_POINTER_USE'
    histogram_pointer->histogram_add_method_invocation;                        \
                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../ui/events/event_utils.cc(116,41):  warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'base::HistogramBase::Sample' (aka 'int') [-Wshorten-64-to-32]
                                  delta.InMicroseconds(), 1, 1000000, 50);
                                  ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../..\base/metrics/histogram_macros.h(189,15):  note: expanded from macro 'UMA_HISTOGRAM_CUSTOM_COUNTS'
        name, sample, min, max, bucket_count,                                  \
        ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../..\base/metrics/histogram_macros_internal.h(128,19):  note: expanded from macro 'INTERNAL_HISTOGRAM_CUSTOM_COUNTS_WITH_FLAG'
        name, Add(sample),                                                     \
              ~~~ ^~~~~~
../..\base/metrics/histogram_macros_internal.h(120,27):  note: expanded from macro 'STATIC_HISTOGRAM_POINTER_BLOCK'
                          histogram_add_method_invocation,                     \
                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../..\base/metrics/histogram_macros_internal.h(104,24):  note: expanded from macro 'HISTOGRAM_POINTER_USE'
    histogram_pointer->histogram_add_method_invocation;                        \
                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../ui/events/event_utils.cc(120,41):  warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'base::HistogramBase::Sample' (aka 'int') [-Wshorten-64-to-32]
                                  delta.InMicroseconds(), 1, 1000000, 50);
                                  ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../..\base/metrics/histogram_macros.h(189,15):  note: expanded from macro 'UMA_HISTOGRAM_CUSTOM_COUNTS'
        name, sample, min, max, bucket_count,                                  \
        ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../..\base/metrics/histogram_macros_internal.h(128,19):  note: expanded from macro 'INTERNAL_HISTOGRAM_CUSTOM_COUNTS_WITH_FLAG'
        name, Add(sample),                                                     \
              ~~~ ^~~~~~
../..\base/metrics/histogram_macros_internal.h(120,27):  note: expanded from macro 'STATIC_HISTOGRAM_POINTER_BLOCK'
                          histogram_add_method_invocation,                     \
                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../..\base/metrics/histogram_macros_internal.h(104,24):  note: expanded from macro 'HISTOGRAM_POINTER_USE'
    histogram_pointer->histogram_add_method_invocation;                        \
                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../ui/events/event_utils.cc(124,41):  warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'base::HistogramBase::Sample' (aka 'int') [-Wshorten-64-to-32]
                                  delta.InMicroseconds(), 1, 1000000, 50);
                                  ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../..\base/metrics/histogram_macros.h(189,15):  note: expanded from macro 'UMA_HISTOGRAM_CUSTOM_COUNTS'
        name, sample, min, max, bucket_count,                                  \
        ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../..\base/metrics/histogram_macros_internal.h(128,19):  note: expanded from macro 'INTERNAL_HISTOGRAM_CUSTOM_COUNTS_WITH_FLAG'
        name, Add(sample),                                                     \
              ~~~ ^~~~~~
../..\base/metrics/histogram_macros_internal.h(120,27):  note: expanded from macro 'STATIC_HISTOGRAM_POINTER_BLOCK'
                          histogram_add_method_invocation,                     \
                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../..\base/metrics/histogram_macros_internal.h(104,24):  note: expanded from macro 'HISTOGRAM_POINTER_USE'
    histogram_pointer->histogram_add_method_invocation;                        \
                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
4 warnings generated.
[22971/48339] CXX obj/ui/events/events/keyboard_hook_win.obj
../../ui/events/win/keyboard_hook_win.cc(117,25):  warning: implicit conversion loses integer precision: 'WPARAM' (aka 'unsigned long long') to 'UINT' (aka 'unsigned int') [-Wshorten-64-to-32]
    MSG msg = {nullptr, w_param, ll_hooks->vkCode,
              ~         ^~~~~~~

../../ui/events/event.cc(1137,47):  warning: implicit conversion loses integer precision: 'const WPARAM' (aka 'const unsigned long long') to 'int32_t' (aka 'int') [-Wshorten-64-to-32]
    key_ = DomKey::FromCharacter(native_event.wParam);
           ~~~~~~                ~~~~~~~~~~~~~^~~~~~

BUG=879657

Change-Id: If41fb68b2e054ff4f429396e78048d48f71a3e38
Reviewed-on: https://chromium-review.googlesource.com/1214682
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Will Harris <wfh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590185}
[modify] https://crrev.com/3f6b636c6d5bae3551ad58d90363ec39300db0bc/ui/events/event.cc
[modify] https://crrev.com/3f6b636c6d5bae3551ad58d90363ec39300db0bc/ui/events/event_utils.cc
[modify] https://crrev.com/3f6b636c6d5bae3551ad58d90363ec39300db0bc/ui/events/test/event_generator.cc
[modify] https://crrev.com/3f6b636c6d5bae3551ad58d90363ec39300db0bc/ui/events/win/events_win_utils.cc
[modify] https://crrev.com/3f6b636c6d5bae3551ad58d90363ec39300db0bc/ui/events/win/keyboard_hook_win.cc

Project Member

Comment 12 by bugdroid1@chromium.org, Sep 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/497051b9accc6e0e45f1acfc2a782e2541696e42

commit 497051b9accc6e0e45f1acfc2a782e2541696e42
Author: Will Harris <wfh@chromium.org>
Date: Tue Sep 11 18:36:14 2018

Fix implicit 64 to 32 conversion in Chrome process finder.

../../chrome/browser/win/chrome_process_finder.cc(97,41):  warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'int' [-Wshorten-64-to-32]
  timeout_in_milliseconds = new_timeout.InMilliseconds();
                          ~ ~~~~~~~~~~~~^~~~~~~~~~~~~~~~

BUG=879657

Change-Id: I2a711f97feb92925a3b53e08d06af5da1b61820e
Reviewed-on: https://chromium-review.googlesource.com/1214744
Commit-Queue: Will Harris <wfh@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590416}
[modify] https://crrev.com/497051b9accc6e0e45f1acfc2a782e2541696e42/chrome/browser/win/chrome_process_finder.cc

Project Member

Comment 13 by bugdroid1@chromium.org, Sep 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cf285d2d1ee651f104ccaa5d2c657b8d1a1386d3

commit cf285d2d1ee651f104ccaa5d2c657b8d1a1386d3
Author: Will Harris <wfh@chromium.org>
Date: Tue Sep 11 20:48:30 2018

Fix two implicit conversions warnings in mojo/service_manager.

../../services/service_manager/tests/lifecycle/lifecycle_unittest.cc(329,28):  warning: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long long') to 'int' [-Wshorten-64-to-32]
      base::BarrierClosure(instance_count, loop.QuitClosure());
      ~~~~                 ^~~~~~~~~~~~~~
../../services/service_manager/tests/lifecycle/lifecycle_unittest.cc(365,28):  warning: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long long') to 'int' [-Wshorten-64-to-32]
      base::BarrierClosure(instance_count, loop.QuitClosure());
      ~~~~

../../mojo/public/cpp/platform/tests/platform_handle_unittest.cc(108,61):  warning: implicit conversion loses integer precision: 'std::basic_string<char, std::char_traits<char>, std::allocator<char> >::size_type' (aka 'unsigned long long') to 'int' [-Wshorten-64-to-32]
    test_file.WriteAtCurrentPos(kTestData.data(), kTestData.size());
              ~~~~~~~~~~~~~~~~~                   ~~~~~~~~~~^~~~~~
../../mojo/public/cpp/platform/tests/platform_handle_unittest.cc(130,40):  warning: implicit conversion loses integer precision: 'std::vector<char, std::allocator<char> >::size_type' (aka 'unsigned long long') to 'int' [-Wshorten-64-to-32]
    file.Read(0, buffer.data(), buffer.size());
         ~~~~                   ~~~~~~~^~~~~~

BUG=879657

Change-Id: Icddec5f4ba2e5e0365fe4e70268730ef4e5aa99d
Reviewed-on: https://chromium-review.googlesource.com/1220471
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Will Harris <wfh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590459}
[modify] https://crrev.com/cf285d2d1ee651f104ccaa5d2c657b8d1a1386d3/mojo/public/cpp/platform/tests/platform_handle_unittest.cc
[modify] https://crrev.com/cf285d2d1ee651f104ccaa5d2c657b8d1a1386d3/services/service_manager/tests/lifecycle/lifecycle_unittest.cc

Project Member

Comment 14 by bugdroid1@chromium.org, Sep 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a73abb20a4a61306840b19fe70f412ab862e1ddb

commit a73abb20a4a61306840b19fe70f412ab862e1ddb
Author: Will Harris <wfh@chromium.org>
Date: Tue Sep 11 21:07:11 2018

Fix -Wshorten-64-to-32 warnings in ui/base.

../../ui/base/test/ui_controls_internal_win.cc(204,9):  warning: implicit conversion loses integer precision: 'WPARAM' (aka 'unsigned long long') to 'UINT' (aka 'unsigned int') [-Wshorten-64-to-32]
        w_param, reinterpret_cast<MOUSEHOOKSTRUCT*>(l_param));
        ^~~~~~~
../../ui/base/test/ui_controls_internal_win.cc(405,25):  warning: implicit conversion loses integer precision: 'std::vector<tagINPUT, std::allocator<tagINPUT> >::size_type' (aka 'unsigned long long') to 'UINT' (aka 'unsigned int') [-Wshorten-64-to-32]
  if (::SendInput(input.size(), input.data(), sizeof(INPUT)) != input.size())
      ~~          ~~~~~~^~~~~~
../../ui/base/test/ui_controls_internal_win.cc(520,25):  warning: implicit conversion loses integer precision: 'std::vector<tagINPUT, std::allocator<tagINPUT> >::size_type' (aka 'unsigned long long') to 'UINT' (aka 'unsigned int') [-Wshorten-64-to-32]
  if (::SendInput(input.size(), input.data(), sizeof(INPUT)) != input.size())
      ~~          ~~~~~~^~~~~~

BUG=879657

Change-Id: Iea866217701ef4b9f67b63a58a6ab6a35a88b1a8
Reviewed-on: https://chromium-review.googlesource.com/1217848
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590471}
[modify] https://crrev.com/a73abb20a4a61306840b19fe70f412ab862e1ddb/ui/base/test/ui_controls_internal_win.cc

Comment 15 by wfh@chromium.org, Sep 11

Blockedon: 883105

Project Member

Comment 16 by bugdroid1@chromium.org, Sep 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/abb942bb0393005f547a298b82cb843b9c8d513e

commit abb942bb0393005f547a298b82cb843b9c8d513e
Author: Will Harris <wfh@chromium.org>
Date: Mon Sep 17 19:26:05 2018

Fix implicit 64 to 32 conversions in components/signin.

../../components/signin/core/browser/signin_metrics.cc(787,38):  warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'base::HistogramBase::Sample' (aka 'int') [-Wshorten-64-to-32]
      base::TimeDelta::FromDays(365).InSeconds(), 100);
      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~
../../components/signin/core/browser/signin_metrics.cc(525,66):  note: expanded from macro 'INVESTIGATOR_HISTOGRAM_CUSTOM_COUNTS'
      UMA_HISTOGRAM_CUSTOM_COUNTS(name "_Periodic", sample, min, max,      \
      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~
../..\base/metrics/histogram_macros.h(189,28):  note: expanded from macro 'UMA_HISTOGRAM_CUSTOM_COUNTS'
        name, sample, min, max, bucket_count,                                  \
        ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../..\base/metrics/histogram_macros_internal.h(129,48):  note: expanded from macro 'INTERNAL_HISTOGRAM_CUSTOM_COUNTS_WITH_FLAG'
        base::Histogram::FactoryGet(name, min, max, bucket_count, flag))
        ~~~~                                   ^~~
../..\base/metrics/histogram_macros_internal.h(121,27):  note: expanded from macro 'STATIC_HISTOGRAM_POINTER_BLOCK'
                          histogram_factory_get_invocation);                   \
                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../..\base/metrics/histogram_macros_internal.h(87,27):  note: expanded from macro 'HISTOGRAM_POINTER_USE'
      histogram_pointer = histogram_factory_get_invocation;                    \
                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../components/signin/core/browser/signin_metrics.cc(786,54):  warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'base::HistogramBase::Sample' (aka 'int') [-Wshorten-64-to-32]
      "Signin.CookieJar.StableAge", type, stable_age.InSeconds(), 1,
      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~
../../components/signin/core/browser/signin_metrics.cc(525,53):  note: expanded from macro 'INVESTIGATOR_HISTOGRAM_CUSTOM_COUNTS'
      UMA_HISTOGRAM_CUSTOM_COUNTS(name "_Periodic", sample, min, max,      \
      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~
../..\base/metrics/histogram_macros.h(189,15):  note: expanded from macro 'UMA_HISTOGRAM_CUSTOM_COUNTS'
        name, sample, min, max, bucket_count,                                  \
        ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../..\base/metrics/histogram_macros_internal.h(128,19):  note: expanded from macro 'INTERNAL_HISTOGRAM_CUSTOM_COUNTS_WITH_FLAG'
        name, Add(sample),                                                     \
              ~~~ ^~~~~~
../..\base/metrics/histogram_macros_internal.h(120,27):  note: expanded from macro 'STATIC_HISTOGRAM_POINTER_BLOCK'
                          histogram_add_method_invocation,                     \
                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../..\base/metrics/histogram_macros_internal.h(104,24):  note: expanded from macro 'HISTOGRAM_POINTER_USE'
    histogram_pointer->histogram_add_method_invocation;                        \
                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../components/signin/core/browser/signin_metrics.cc(787,38):  warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'base::HistogramBase::Sample' (aka 'int') [-Wshorten-64-to-32]
      base::TimeDelta::FromDays(365).InSeconds(), 100);
      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~
../../components/signin/core/browser/signin_metrics.cc(529,66):  note: expanded from macro 'INVESTIGATOR_HISTOGRAM_CUSTOM_COUNTS'
      UMA_HISTOGRAM_CUSTOM_COUNTS(name "_OnChange", sample, min, max,      \
      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~
../..\base/metrics/histogram_macros.h(189,28):  note: expanded from macro 'UMA_HISTOGRAM_CUSTOM_COUNTS'
        name, sample, min, max, bucket_count,                                  \
        ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../..\base/metrics/histogram_macros_internal.h(129,48):  note: expanded from macro 'INTERNAL_HISTOGRAM_CUSTOM_COUNTS_WITH_FLAG'
        base::Histogram::FactoryGet(name, min, max, bucket_count, flag))
        ~~~~                                   ^~~
../..\base/metrics/histogram_macros_internal.h(121,27):  note: expanded from macro 'STATIC_HISTOGRAM_POINTER_BLOCK'
                          histogram_factory_get_invocation);                   \
                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../..\base/metrics/histogram_macros_internal.h(87,27):  note: expanded from macro 'HISTOGRAM_POINTER_USE'
      histogram_pointer = histogram_factory_get_invocation;                    \
                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../components/signin/core/browser/signin_metrics.cc(786,54):  warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'base::HistogramBase::Sample' (aka 'int') [-Wshorten-64-to-32]
      "Signin.CookieJar.StableAge", type, stable_age.InSeconds(), 1,
      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~
../../components/signin/core/browser/signin_metrics.cc(529,53):  note: expanded from macro 'INVESTIGATOR_HISTOGRAM_CUSTOM_COUNTS'
      UMA_HISTOGRAM_CUSTOM_COUNTS(name "_OnChange", sample, min, max,      \
      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~
../..\base/metrics/histogram_macros.h(189,15):  note: expanded from macro 'UMA_HISTOGRAM_CUSTOM_COUNTS'
        name, sample, min, max, bucket_count,                                  \
        ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../..\base/metrics/histogram_macros_internal.h(128,19):  note: expanded from macro 'INTERNAL_HISTOGRAM_CUSTOM_COUNTS_WITH_FLAG'
        name, Add(sample),                                                     \
              ~~~ ^~~~~~
../..\base/metrics/histogram_macros_internal.h(120,27):  note: expanded from macro 'STATIC_HISTOGRAM_POINTER_BLOCK'
                          histogram_add_method_invocation,                     \
                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../..\base/metrics/histogram_macros_internal.h(104,24):  note: expanded from macro 'HISTOGRAM_POINTER_USE'
    histogram_pointer->histogram_add_method_invocation;                        \
                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

BUG=879657

Change-Id: I250b5d44e03210ad7d22d8502a5839a8a2584138
Reviewed-on: https://chromium-review.googlesource.com/1219903
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Will Harris <wfh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591775}
[modify] https://crrev.com/abb942bb0393005f547a298b82cb843b9c8d513e/components/signin/core/browser/signin_metrics.cc

Project Member

Comment 17 by bugdroid1@chromium.org, Sep 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa3a008e47c1318f3e4f442a8bdd2367cfed97fc

commit fa3a008e47c1318f3e4f442a8bdd2367cfed97fc
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Tue Sep 18 14:09:01 2018

Fix 64 bit truncation errors in blink/core/dom

Use wtf_size_t when dealing with WTF types.

BUG=879657

Change-Id: I9db3182f9194360c8729e174a31ac77493f63f87
Reviewed-on: https://chromium-review.googlesource.com/1226023
Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592031}
[modify] https://crrev.com/fa3a008e47c1318f3e4f442a8bdd2367cfed97fc/third_party/blink/renderer/core/dom/attribute_collection.h
[modify] https://crrev.com/fa3a008e47c1318f3e4f442a8bdd2367cfed97fc/third_party/blink/renderer/core/dom/distributed_nodes.cc
[modify] https://crrev.com/fa3a008e47c1318f3e4f442a8bdd2367cfed97fc/third_party/blink/renderer/core/dom/distributed_nodes.h
[modify] https://crrev.com/fa3a008e47c1318f3e4f442a8bdd2367cfed97fc/third_party/blink/renderer/core/dom/document.cc
[modify] https://crrev.com/fa3a008e47c1318f3e4f442a8bdd2367cfed97fc/third_party/blink/renderer/core/dom/dom_token_list.cc
[modify] https://crrev.com/fa3a008e47c1318f3e4f442a8bdd2367cfed97fc/third_party/blink/renderer/core/dom/element.cc
[modify] https://crrev.com/fa3a008e47c1318f3e4f442a8bdd2367cfed97fc/third_party/blink/renderer/core/dom/element.h
[modify] https://crrev.com/fa3a008e47c1318f3e4f442a8bdd2367cfed97fc/third_party/blink/renderer/core/dom/events/event_dispatcher.cc
[modify] https://crrev.com/fa3a008e47c1318f3e4f442a8bdd2367cfed97fc/third_party/blink/renderer/core/dom/events/event_listener_map.cc
[modify] https://crrev.com/fa3a008e47c1318f3e4f442a8bdd2367cfed97fc/third_party/blink/renderer/core/dom/events/event_listener_map.h
[modify] https://crrev.com/fa3a008e47c1318f3e4f442a8bdd2367cfed97fc/third_party/blink/renderer/core/dom/events/event_path.cc
[modify] https://crrev.com/fa3a008e47c1318f3e4f442a8bdd2367cfed97fc/third_party/blink/renderer/core/dom/events/event_path.h
[modify] https://crrev.com/fa3a008e47c1318f3e4f442a8bdd2367cfed97fc/third_party/blink/renderer/core/dom/events/event_target.cc
[modify] https://crrev.com/fa3a008e47c1318f3e4f442a8bdd2367cfed97fc/third_party/blink/renderer/core/dom/events/event_target.h
[modify] https://crrev.com/fa3a008e47c1318f3e4f442a8bdd2367cfed97fc/third_party/blink/renderer/core/dom/frame_request_callback_collection.cc
[modify] https://crrev.com/fa3a008e47c1318f3e4f442a8bdd2367cfed97fc/third_party/blink/renderer/core/dom/layout_tree_builder.cc
[modify] https://crrev.com/fa3a008e47c1318f3e4f442a8bdd2367cfed97fc/third_party/blink/renderer/core/dom/layout_tree_builder_traversal.cc
[modify] https://crrev.com/fa3a008e47c1318f3e4f442a8bdd2367cfed97fc/third_party/blink/renderer/core/dom/live_node_list_registry.cc
[modify] https://crrev.com/fa3a008e47c1318f3e4f442a8bdd2367cfed97fc/third_party/blink/renderer/core/dom/named_node_map.cc
[modify] https://crrev.com/fa3a008e47c1318f3e4f442a8bdd2367cfed97fc/third_party/blink/renderer/core/dom/node.cc
[modify] https://crrev.com/fa3a008e47c1318f3e4f442a8bdd2367cfed97fc/third_party/blink/renderer/core/dom/shadow_root_v0.cc
[modify] https://crrev.com/fa3a008e47c1318f3e4f442a8bdd2367cfed97fc/third_party/blink/renderer/core/dom/space_split_string.cc
[modify] https://crrev.com/fa3a008e47c1318f3e4f442a8bdd2367cfed97fc/third_party/blink/renderer/core/dom/space_split_string.h
[modify] https://crrev.com/fa3a008e47c1318f3e4f442a8bdd2367cfed97fc/third_party/blink/renderer/core/dom/tree_ordered_list.h
[modify] https://crrev.com/fa3a008e47c1318f3e4f442a8bdd2367cfed97fc/third_party/blink/renderer/core/dom/tree_scope.cc
[modify] https://crrev.com/fa3a008e47c1318f3e4f442a8bdd2367cfed97fc/third_party/blink/renderer/core/dom/v0_insertion_point.cc
[modify] https://crrev.com/fa3a008e47c1318f3e4f442a8bdd2367cfed97fc/third_party/blink/renderer/core/dom/v0_insertion_point.h

Project Member

Comment 18 by bugdroid1@chromium.org, Sep 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/03da5d69db098e7418755c6839536532eda5f934

commit 03da5d69db098e7418755c6839536532eda5f934
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Tue Sep 18 20:19:45 2018

Fix 64 bit truncation errors in blink/core/frame

Use wtf_size_t when dealing with WTF types.

BUG=879657

Change-Id: I125b0857c16db2b96835052c043e7d246cb3eb31
Reviewed-on: https://chromium-review.googlesource.com/1228129
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592172}
[modify] https://crrev.com/03da5d69db098e7418755c6839536532eda5f934/third_party/blink/renderer/core/frame/csp/content_security_policy.cc
[modify] https://crrev.com/03da5d69db098e7418755c6839536532eda5f934/third_party/blink/renderer/core/frame/csp/csp_directive_list.cc
[modify] https://crrev.com/03da5d69db098e7418755c6839536532eda5f934/third_party/blink/renderer/core/frame/csp/media_list_directive.cc
[modify] https://crrev.com/03da5d69db098e7418755c6839536532eda5f934/third_party/blink/renderer/core/frame/csp/source_list_directive.cc
[modify] https://crrev.com/03da5d69db098e7418755c6839536532eda5f934/third_party/blink/renderer/core/frame/csp/source_list_directive_test.cc
[modify] https://crrev.com/03da5d69db098e7418755c6839536532eda5f934/third_party/blink/renderer/core/frame/event_handler_registry.cc
[modify] https://crrev.com/03da5d69db098e7418755c6839536532eda5f934/third_party/blink/renderer/core/frame/find_in_page.cc
[modify] https://crrev.com/03da5d69db098e7418755c6839536532eda5f934/third_party/blink/renderer/core/frame/find_in_page_test.cc
[modify] https://crrev.com/03da5d69db098e7418755c6839536532eda5f934/third_party/blink/renderer/core/frame/frame.cc
[modify] https://crrev.com/03da5d69db098e7418755c6839536532eda5f934/third_party/blink/renderer/core/frame/frame_serializer.cc
[modify] https://crrev.com/03da5d69db098e7418755c6839536532eda5f934/third_party/blink/renderer/core/frame/link_highlights.cc
[modify] https://crrev.com/03da5d69db098e7418755c6839536532eda5f934/third_party/blink/renderer/core/frame/local_dom_window.cc
[modify] https://crrev.com/03da5d69db098e7418755c6839536532eda5f934/third_party/blink/renderer/core/frame/local_frame_view.cc
[modify] https://crrev.com/03da5d69db098e7418755c6839536532eda5f934/third_party/blink/renderer/core/frame/message_report_body.h
[modify] https://crrev.com/03da5d69db098e7418755c6839536532eda5f934/third_party/blink/renderer/core/frame/navigator.cc
[modify] https://crrev.com/03da5d69db098e7418755c6839536532eda5f934/third_party/blink/renderer/core/frame/pausable_script_executor.cc
[modify] https://crrev.com/03da5d69db098e7418755c6839536532eda5f934/third_party/blink/renderer/core/frame/screen.cc
[modify] https://crrev.com/03da5d69db098e7418755c6839536532eda5f934/third_party/blink/renderer/core/frame/smart_clip.cc
[modify] https://crrev.com/03da5d69db098e7418755c6839536532eda5f934/third_party/blink/renderer/core/frame/use_counter.cc
[modify] https://crrev.com/03da5d69db098e7418755c6839536532eda5f934/third_party/blink/renderer/core/frame/web_local_frame_impl.cc

Project Member

Comment 19 by bugdroid1@chromium.org, Sep 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/013cea99f26b009ea465b00443fa5a4b76e34cf4

commit 013cea99f26b009ea465b00443fa5a4b76e34cf4
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Tue Sep 18 21:48:00 2018

Fix 64 bit truncation errors in blink/core/paint

Use wtf_size_t when dealing with WTF types.

BUG=879657

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ic2d84e1ef5c07481c45d987a1ca1140ec4975442
Reviewed-on: https://chromium-review.googlesource.com/1228780
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592212}
[modify] https://crrev.com/013cea99f26b009ea465b00443fa5a4b76e34cf4/third_party/blink/renderer/core/paint/box_border_painter.cc
[modify] https://crrev.com/013cea99f26b009ea465b00443fa5a4b76e34cf4/third_party/blink/renderer/core/paint/box_painter_base.cc
[modify] https://crrev.com/013cea99f26b009ea465b00443fa5a4b76e34cf4/third_party/blink/renderer/core/paint/compositing/composited_layer_mapping.cc
[modify] https://crrev.com/013cea99f26b009ea465b00443fa5a4b76e34cf4/third_party/blink/renderer/core/paint/compositing/composited_layer_mapping.h
[modify] https://crrev.com/013cea99f26b009ea465b00443fa5a4b76e34cf4/third_party/blink/renderer/core/paint/compositing/compositing_layer_assigner.h
[modify] https://crrev.com/013cea99f26b009ea465b00443fa5a4b76e34cf4/third_party/blink/renderer/core/paint/compositing/compositing_requirements_updater.cc
[modify] https://crrev.com/013cea99f26b009ea465b00443fa5a4b76e34cf4/third_party/blink/renderer/core/paint/compositing/graphics_layer_tree_as_text.cc
[modify] https://crrev.com/013cea99f26b009ea465b00443fa5a4b76e34cf4/third_party/blink/renderer/core/paint/compositing/graphics_layer_tree_builder.cc
[modify] https://crrev.com/013cea99f26b009ea465b00443fa5a4b76e34cf4/third_party/blink/renderer/core/paint/compositing/paint_layer_compositor.cc
[modify] https://crrev.com/013cea99f26b009ea465b00443fa5a4b76e34cf4/third_party/blink/renderer/core/paint/first_meaningful_paint_detector.cc
[modify] https://crrev.com/013cea99f26b009ea465b00443fa5a4b76e34cf4/third_party/blink/renderer/core/paint/frame_set_painter.cc
[modify] https://crrev.com/013cea99f26b009ea465b00443fa5a4b76e34cf4/third_party/blink/renderer/core/paint/grid_painter.cc
[modify] https://crrev.com/013cea99f26b009ea465b00443fa5a4b76e34cf4/third_party/blink/renderer/core/paint/link_highlight_impl.cc
[modify] https://crrev.com/013cea99f26b009ea465b00443fa5a4b76e34cf4/third_party/blink/renderer/core/paint/ng/ng_paint_fragment_traversal.cc
[modify] https://crrev.com/013cea99f26b009ea465b00443fa5a4b76e34cf4/third_party/blink/renderer/core/paint/object_painter_base.cc
[modify] https://crrev.com/013cea99f26b009ea465b00443fa5a4b76e34cf4/third_party/blink/renderer/core/paint/paint_invalidator.h
[modify] https://crrev.com/013cea99f26b009ea465b00443fa5a4b76e34cf4/third_party/blink/renderer/core/paint/paint_layer_painter.cc
[modify] https://crrev.com/013cea99f26b009ea465b00443fa5a4b76e34cf4/third_party/blink/renderer/core/paint/paint_layer_stacking_node.cc
[modify] https://crrev.com/013cea99f26b009ea465b00443fa5a4b76e34cf4/third_party/blink/renderer/core/paint/paint_property_tree_builder.cc
[modify] https://crrev.com/013cea99f26b009ea465b00443fa5a4b76e34cf4/third_party/blink/renderer/core/paint/pre_paint_tree_walk.cc
[modify] https://crrev.com/013cea99f26b009ea465b00443fa5a4b76e34cf4/third_party/blink/renderer/core/paint/pre_paint_tree_walk.h

Project Member

Comment 20 by bugdroid1@chromium.org, Sep 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b387b0737d7104857be1274d75278060d2cd45aa

commit b387b0737d7104857be1274d75278060d2cd45aa
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Wed Sep 19 15:49:50 2018

Use appropriate integer types for core/inspector

- Use DOMNodeId where appropriate
- Use wtf_size_t when dealing with WTF containers
- Apply truncation/SafeCast where appropriate

BUG=879657

Change-Id: I4c81a2f3e10000fc04e0a56f29080c4447862c85
Reviewed-on: https://chromium-review.googlesource.com/1227187
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Alexei Filippov <alph@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592418}
[modify] https://crrev.com/b387b0737d7104857be1274d75278060d2cd45aa/third_party/blink/renderer/core/inspector/console_message_storage.cc
[modify] https://crrev.com/b387b0737d7104857be1274d75278060d2cd45aa/third_party/blink/renderer/core/inspector/console_message_storage.h
[modify] https://crrev.com/b387b0737d7104857be1274d75278060d2cd45aa/third_party/blink/renderer/core/inspector/dom_patch_support.cc
[modify] https://crrev.com/b387b0737d7104857be1274d75278060d2cd45aa/third_party/blink/renderer/core/inspector/dom_patch_support.h
[modify] https://crrev.com/b387b0737d7104857be1274d75278060d2cd45aa/third_party/blink/renderer/core/inspector/identifiers_factory.cc
[modify] https://crrev.com/b387b0737d7104857be1274d75278060d2cd45aa/third_party/blink/renderer/core/inspector/identifiers_factory.h
[modify] https://crrev.com/b387b0737d7104857be1274d75278060d2cd45aa/third_party/blink/renderer/core/inspector/inspector_animation_agent.cc
[modify] https://crrev.com/b387b0737d7104857be1274d75278060d2cd45aa/third_party/blink/renderer/core/inspector/inspector_audits_agent.cc
[modify] https://crrev.com/b387b0737d7104857be1274d75278060d2cd45aa/third_party/blink/renderer/core/inspector/inspector_css_agent.cc
[modify] https://crrev.com/b387b0737d7104857be1274d75278060d2cd45aa/third_party/blink/renderer/core/inspector/inspector_dom_agent.cc
[modify] https://crrev.com/b387b0737d7104857be1274d75278060d2cd45aa/third_party/blink/renderer/core/inspector/inspector_dom_debugger_agent.cc
[modify] https://crrev.com/b387b0737d7104857be1274d75278060d2cd45aa/third_party/blink/renderer/core/inspector/inspector_dom_snapshot_agent.cc
[modify] https://crrev.com/b387b0737d7104857be1274d75278060d2cd45aa/third_party/blink/renderer/core/inspector/inspector_emulation_agent.cc
[modify] https://crrev.com/b387b0737d7104857be1274d75278060d2cd45aa/third_party/blink/renderer/core/inspector/inspector_highlight.cc
[modify] https://crrev.com/b387b0737d7104857be1274d75278060d2cd45aa/third_party/blink/renderer/core/inspector/inspector_history.h
[modify] https://crrev.com/b387b0737d7104857be1274d75278060d2cd45aa/third_party/blink/renderer/core/inspector/inspector_layer_tree_agent.cc
[modify] https://crrev.com/b387b0737d7104857be1274d75278060d2cd45aa/third_party/blink/renderer/core/inspector/inspector_layer_tree_agent.h
[modify] https://crrev.com/b387b0737d7104857be1274d75278060d2cd45aa/third_party/blink/renderer/core/inspector/inspector_log_agent.cc
[modify] https://crrev.com/b387b0737d7104857be1274d75278060d2cd45aa/third_party/blink/renderer/core/inspector/inspector_network_agent.cc
[modify] https://crrev.com/b387b0737d7104857be1274d75278060d2cd45aa/third_party/blink/renderer/core/inspector/inspector_overlay_agent.cc
[modify] https://crrev.com/b387b0737d7104857be1274d75278060d2cd45aa/third_party/blink/renderer/core/inspector/inspector_overlay_agent.h
[modify] https://crrev.com/b387b0737d7104857be1274d75278060d2cd45aa/third_party/blink/renderer/core/inspector/inspector_page_agent.cc
[modify] https://crrev.com/b387b0737d7104857be1274d75278060d2cd45aa/third_party/blink/renderer/core/inspector/inspector_resource_container.cc
[modify] https://crrev.com/b387b0737d7104857be1274d75278060d2cd45aa/third_party/blink/renderer/core/inspector/inspector_resource_container.h
[modify] https://crrev.com/b387b0737d7104857be1274d75278060d2cd45aa/third_party/blink/renderer/core/inspector/inspector_session.cc
[modify] https://crrev.com/b387b0737d7104857be1274d75278060d2cd45aa/third_party/blink/renderer/core/inspector/inspector_style_sheet.cc
[modify] https://crrev.com/b387b0737d7104857be1274d75278060d2cd45aa/third_party/blink/renderer/core/inspector/inspector_style_sheet.h
[modify] https://crrev.com/b387b0737d7104857be1274d75278060d2cd45aa/third_party/blink/renderer/core/inspector/inspector_trace_events.cc
[modify] https://crrev.com/b387b0737d7104857be1274d75278060d2cd45aa/third_party/blink/renderer/core/inspector/main_thread_debugger.cc
[modify] https://crrev.com/b387b0737d7104857be1274d75278060d2cd45aa/third_party/blink/renderer/core/inspector/network_resources_data.h
[modify] https://crrev.com/b387b0737d7104857be1274d75278060d2cd45aa/third_party/blink/renderer/core/inspector/thread_debugger.cc
[modify] https://crrev.com/b387b0737d7104857be1274d75278060d2cd45aa/third_party/blink/renderer/core/inspector/v8_inspector_string.cc
[modify] https://crrev.com/b387b0737d7104857be1274d75278060d2cd45aa/third_party/blink/renderer/core/inspector/v8_inspector_string.h

Project Member

Comment 21 by bugdroid1@chromium.org, Sep 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4e4da5901b58b90bc5b49f686d69ce9396683277

commit 4e4da5901b58b90bc5b49f686d69ce9396683277
Author: Will Harris <wfh@chromium.org>
Date: Thu Sep 20 00:19:59 2018

Fix -Wshorten-64-to-32 warnings in chrome_cleaner.

../../chrome/chrome_cleaner/zip_archiver/test_zip_archiver_util.cc(114,69):  warning: implicit conversion loses integer precision: 'std::vector<char, std::allocator<char> >::size_type' (aka 'unsigned long long') to 'Cr_z_uLong' (aka 'unsigned long') [-Wshorten-64-to-32]
                unzip_object, &file_info, filename.data(), filename.size(),
                                                           ~~~~~~~~~^~~~~~
../../third_party/googletest/src/googletest/include\gtest/gtest.h(1961,23):  note: expanded from macro 'EXPECT_EQ'
                      val1, val2)
                      ^~~~
../../third_party/googletest/src/googletest/include\gtest/gtest_pred_impl.h(161,36):  note: expanded from macro 'EXPECT_PRED_FORMAT2'
  GTEST_PRED_FORMAT2_(pred_format, v1, v2, GTEST_NONFATAL_FAILURE_)
                                   ^~
../../third_party/googletest/src/googletest/include\gtest/gtest_pred_impl.h(146,39):  note: expanded from macro 'GTEST_PRED_FORMAT2_'
  GTEST_ASSERT_(pred_format(#v1, #v2, v1, v2), \
                                      ^~
../../third_party/googletest/src/googletest/include\gtest/gtest_pred_impl.h(76,52):  note: expanded from macro 'GTEST_ASSERT_'
  if (const ::testing::AssertionResult gtest_ar = (expression)) \
                                                   ^~~~~~~~~~

../../chrome/chrome_cleaner/test/test_service_main.cc(27,44):  warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'DWORD' (aka 'unsigned long') [-Wshorten-64-to-32]
        TestTimeouts::action_max_timeout().InMilliseconds();
        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~

../../chrome/chrome_cleaner/http/http_agent_impl.cc(465,50):  warning: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long long') to 'DWORD' (aka 'unsigned long') [-Wshorten-64-to-32]
  if (!::WinHttpReadData(request_.Get(), buffer, *count, &size_read)) {
       ~~                                        ^~~~~~

In file included from ../../chrome/chrome_cleaner/chrome_utils/extensions_util.cc:5:
In file included from ../..\chrome/chrome_cleaner/chrome_utils/extensions_util.h:14:
In file included from ../..\chrome/chrome_cleaner/json_parser/json_parser_api.h:8:
In file included from ../..\base/callback.h:14:
In file included from ../..\base/callback_internal.h:14:
In file included from ../..\base/memory/ref_counted.h:18:
../..\base/memory/scoped_refptr.h(91,18):  warning: implicit conversion loses integer precision: 'unsigned long long' to 'int' [-Wshorten-64-to-32]
  T* obj = new T(std::forward<Args>(args)...);
               ~ ^~~~~~~~~~~~~~~~~~~~~~~~
../../chrome/chrome_cleaner/chrome_utils/extensions_util.cc(307,13):  note: in instantiation of function template specialization 'base::MakeRefCounted<chrome_cleaner::(anonymous namespace)::ParseTasksRemainingCounter, unsigned long long, base::WaitableEvent *&>' requested here
      base::MakeRefCounted<ParseTasksRemainingCounter>(files_read.size(), done);
            ^

../../chrome/chrome_cleaner/zip_archiver/target/zip_archiver_impl.cc(56,32):  warning: implicit conversion loses integer precision: 'const long long' to 'int' [-Wshorten-64-to-32]
        offset, buffer.data(), std::min(length - offset, kReadBufferSize));
                               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../chrome/chrome_cleaner/zip_archiver/target/zip_archiver_impl.cc(165,23):  warning: implicit conversion loses integer precision: 'const long long' to 'int' [-Wshorten-64-to-32]
                      std::min(src_length - src_offset, kReadBufferSize));
                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

BUG=879657

Change-Id: I80fbce280cd8a7e281d6f6ad58918aaab91514dd
Reviewed-on: https://chromium-review.googlesource.com/1214050
Commit-Queue: Will Harris <wfh@chromium.org>
Reviewed-by: Joe Mason <joenotcharles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592626}
[modify] https://crrev.com/4e4da5901b58b90bc5b49f686d69ce9396683277/chrome/chrome_cleaner/chrome_utils/extensions_util.cc
[modify] https://crrev.com/4e4da5901b58b90bc5b49f686d69ce9396683277/chrome/chrome_cleaner/http/http_agent_impl.cc
[modify] https://crrev.com/4e4da5901b58b90bc5b49f686d69ce9396683277/chrome/chrome_cleaner/http/http_response.h
[modify] https://crrev.com/4e4da5901b58b90bc5b49f686d69ce9396683277/chrome/chrome_cleaner/http/mock_http_agent_factory.cc
[modify] https://crrev.com/4e4da5901b58b90bc5b49f686d69ce9396683277/chrome/chrome_cleaner/http/mock_http_agent_factory.h
[modify] https://crrev.com/4e4da5901b58b90bc5b49f686d69ce9396683277/chrome/chrome_cleaner/logging/safe_browsing_reporter.cc
[modify] https://crrev.com/4e4da5901b58b90bc5b49f686d69ce9396683277/chrome/chrome_cleaner/test/test_service_main.cc
[modify] https://crrev.com/4e4da5901b58b90bc5b49f686d69ce9396683277/chrome/chrome_cleaner/zip_archiver/target/zip_archiver_impl.cc
[modify] https://crrev.com/4e4da5901b58b90bc5b49f686d69ce9396683277/chrome/chrome_cleaner/zip_archiver/test_zip_archiver_util.cc

Project Member

Comment 22 by bugdroid1@chromium.org, Sep 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6ae67a15a8e291110b3036612c67090bcb99484c

commit 6ae67a15a8e291110b3036612c67090bcb99484c
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Thu Sep 20 13:58:36 2018

Use appropriate size type for WebPlugin::DidReceiveData

Using the appropriate type gets rid of a checked cast and a truncation.

BUG=879657

Change-Id: I30e6aa1f28ebcd6e245a95a8662a212e72986829
Reviewed-on: https://chromium-review.googlesource.com/1234016
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592783}
[modify] https://crrev.com/6ae67a15a8e291110b3036612c67090bcb99484c/components/plugins/renderer/webview_plugin.cc
[modify] https://crrev.com/6ae67a15a8e291110b3036612c67090bcb99484c/components/plugins/renderer/webview_plugin.h
[modify] https://crrev.com/6ae67a15a8e291110b3036612c67090bcb99484c/content/renderer/browser_plugin/browser_plugin.cc
[modify] https://crrev.com/6ae67a15a8e291110b3036612c67090bcb99484c/content/renderer/browser_plugin/browser_plugin.h
[modify] https://crrev.com/6ae67a15a8e291110b3036612c67090bcb99484c/content/renderer/pepper/pepper_webplugin_impl.cc
[modify] https://crrev.com/6ae67a15a8e291110b3036612c67090bcb99484c/content/renderer/pepper/pepper_webplugin_impl.h
[modify] https://crrev.com/6ae67a15a8e291110b3036612c67090bcb99484c/content/shell/test_runner/test_plugin.h
[modify] https://crrev.com/6ae67a15a8e291110b3036612c67090bcb99484c/third_party/blink/public/web/web_plugin.h
[modify] https://crrev.com/6ae67a15a8e291110b3036612c67090bcb99484c/third_party/blink/renderer/core/exported/fake_web_plugin.h
[modify] https://crrev.com/6ae67a15a8e291110b3036612c67090bcb99484c/third_party/blink/renderer/core/exported/web_plugin_container_impl.cc
[modify] https://crrev.com/6ae67a15a8e291110b3036612c67090bcb99484c/third_party/blink/renderer/core/exported/web_plugin_container_impl.h

Project Member

Comment 23 by bugdroid1@chromium.org, Sep 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f38ce4ea9af6e8a457609ec083f285032ef28ca8

commit f38ce4ea9af6e8a457609ec083f285032ef28ca8
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Thu Sep 20 19:55:36 2018

Fix 64 bit truncation errors in blink/core/html

Use wtf_size_t when dealing with WTF types.

BUG=879657

Change-Id: I14b8c97a5c749acef25b7b343cb5952c6d2dad25
Reviewed-on: https://chromium-review.googlesource.com/1234219
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592918}
[modify] https://crrev.com/f38ce4ea9af6e8a457609ec083f285032ef28ca8/third_party/blink/renderer/core/html/canvas/image_data_test.cc
[modify] https://crrev.com/f38ce4ea9af6e8a457609ec083f285032ef28ca8/third_party/blink/renderer/core/html/custom/custom_element.h
[modify] https://crrev.com/f38ce4ea9af6e8a457609ec083f285032ef28ca8/third_party/blink/renderer/core/html/custom/custom_element_reaction_queue.h
[modify] https://crrev.com/f38ce4ea9af6e8a457609ec083f285032ef28ca8/third_party/blink/renderer/core/html/custom/custom_element_reaction_stack.cc
[modify] https://crrev.com/f38ce4ea9af6e8a457609ec083f285032ef28ca8/third_party/blink/renderer/core/html/custom/custom_element_registry.h
[modify] https://crrev.com/f38ce4ea9af6e8a457609ec083f285032ef28ca8/third_party/blink/renderer/core/html/custom/v0_custom_element_callback_queue.h
[modify] https://crrev.com/f38ce4ea9af6e8a457609ec083f285032ef28ca8/third_party/blink/renderer/core/html/custom/v0_custom_element_processing_stack.cc
[modify] https://crrev.com/f38ce4ea9af6e8a457609ec083f285032ef28ca8/third_party/blink/renderer/core/html/custom/v0_custom_element_processing_stack.h
[modify] https://crrev.com/f38ce4ea9af6e8a457609ec083f285032ef28ca8/third_party/blink/renderer/core/html/forms/date_time_edit_element.cc
[modify] https://crrev.com/f38ce4ea9af6e8a457609ec083f285032ef28ca8/third_party/blink/renderer/core/html/forms/date_time_edit_element.h
[modify] https://crrev.com/f38ce4ea9af6e8a457609ec083f285032ef28ca8/third_party/blink/renderer/core/html/forms/date_time_fields_state.cc
[modify] https://crrev.com/f38ce4ea9af6e8a457609ec083f285032ef28ca8/third_party/blink/renderer/core/html/forms/email_input_type.cc
[modify] https://crrev.com/f38ce4ea9af6e8a457609ec083f285032ef28ca8/third_party/blink/renderer/core/html/forms/external_popup_menu.cc
[modify] https://crrev.com/f38ce4ea9af6e8a457609ec083f285032ef28ca8/third_party/blink/renderer/core/html/forms/file_input_type.cc
[modify] https://crrev.com/f38ce4ea9af6e8a457609ec083f285032ef28ca8/third_party/blink/renderer/core/html/forms/form_controller.cc
[modify] https://crrev.com/f38ce4ea9af6e8a457609ec083f285032ef28ca8/third_party/blink/renderer/core/html/forms/form_controller.h
[modify] https://crrev.com/f38ce4ea9af6e8a457609ec083f285032ef28ca8/third_party/blink/renderer/core/html/forms/form_data.cc
[modify] https://crrev.com/f38ce4ea9af6e8a457609ec083f285032ef28ca8/third_party/blink/renderer/core/html/forms/html_input_element.cc
[modify] https://crrev.com/f38ce4ea9af6e8a457609ec083f285032ef28ca8/third_party/blink/renderer/core/html/forms/html_select_element.cc
[modify] https://crrev.com/f38ce4ea9af6e8a457609ec083f285032ef28ca8/third_party/blink/renderer/core/html/forms/html_select_element.h
[modify] https://crrev.com/f38ce4ea9af6e8a457609ec083f285032ef28ca8/third_party/blink/renderer/core/html/forms/range_input_type.cc
[modify] https://crrev.com/f38ce4ea9af6e8a457609ec083f285032ef28ca8/third_party/blink/renderer/core/html/html_dimension.cc
[modify] https://crrev.com/f38ce4ea9af6e8a457609ec083f285032ef28ca8/third_party/blink/renderer/core/html/html_element.cc
[modify] https://crrev.com/f38ce4ea9af6e8a457609ec083f285032ef28ca8/third_party/blink/renderer/core/html/html_embed_element.cc
[modify] https://crrev.com/f38ce4ea9af6e8a457609ec083f285032ef28ca8/third_party/blink/renderer/core/html/html_frame_set_element.h
[modify] https://crrev.com/f38ce4ea9af6e8a457609ec083f285032ef28ca8/third_party/blink/renderer/core/html/html_link_element.cc
[modify] https://crrev.com/f38ce4ea9af6e8a457609ec083f285032ef28ca8/third_party/blink/renderer/core/html/html_object_element.cc
[modify] https://crrev.com/f38ce4ea9af6e8a457609ec083f285032ef28ca8/third_party/blink/renderer/core/html/html_plugin_element.cc
[modify] https://crrev.com/f38ce4ea9af6e8a457609ec083f285032ef28ca8/third_party/blink/renderer/core/html/html_slot_element.cc
[modify] https://crrev.com/f38ce4ea9af6e8a457609ec083f285032ef28ca8/third_party/blink/renderer/core/html/html_slot_element.h
[modify] https://crrev.com/f38ce4ea9af6e8a457609ec083f285032ef28ca8/third_party/blink/renderer/core/html/imports/html_import_loader.cc
[modify] https://crrev.com/f38ce4ea9af6e8a457609ec083f285032ef28ca8/third_party/blink/renderer/core/html/imports/html_imports_controller.h
[modify] https://crrev.com/f38ce4ea9af6e8a457609ec083f285032ef28ca8/third_party/blink/renderer/core/html/media/html_media_element.cc
[modify] https://crrev.com/f38ce4ea9af6e8a457609ec083f285032ef28ca8/third_party/blink/renderer/core/html/media/media_fragment_uri_parser.cc
[modify] https://crrev.com/f38ce4ea9af6e8a457609ec083f285032ef28ca8/third_party/blink/renderer/core/html/parser/atomic_html_token.h
[modify] https://crrev.com/f38ce4ea9af6e8a457609ec083f285032ef28ca8/third_party/blink/renderer/core/html/parser/background_html_input_stream.cc
[modify] https://crrev.com/f38ce4ea9af6e8a457609ec083f285032ef28ca8/third_party/blink/renderer/core/html/parser/background_html_input_stream.h
[modify] https://crrev.com/f38ce4ea9af6e8a457609ec083f285032ef28ca8/third_party/blink/renderer/core/html/parser/css_preload_scanner.cc
[modify] https://crrev.com/f38ce4ea9af6e8a457609ec083f285032ef28ca8/third_party/blink/renderer/core/html/parser/html_document_parser.cc
[modify] https://crrev.com/f38ce4ea9af6e8a457609ec083f285032ef28ca8/third_party/blink/renderer/core/html/parser/html_formatting_element_list.cc
[modify] https://crrev.com/f38ce4ea9af6e8a457609ec083f285032ef28ca8/third_party/blink/renderer/core/html/parser/html_formatting_element_list.h
[modify] https://crrev.com/f38ce4ea9af6e8a457609ec083f285032ef28ca8/third_party/blink/renderer/core/html/parser/html_meta_charset_parser.cc
[modify] https://crrev.com/f38ce4ea9af6e8a457609ec083f285032ef28ca8/third_party/blink/renderer/core/html/parser/html_meta_charset_parser.h
[modify] https://crrev.com/f38ce4ea9af6e8a457609ec083f285032ef28ca8/third_party/blink/renderer/core/html/parser/html_preload_scanner.h
[modify] https://crrev.com/f38ce4ea9af6e8a457609ec083f285032ef28ca8/third_party/blink/renderer/core/html/parser/html_source_tracker.cc
[modify] https://crrev.com/f38ce4ea9af6e8a457609ec083f285032ef28ca8/third_party/blink/renderer/core/html/parser/html_srcset_parser.cc
[modify] https://crrev.com/f38ce4ea9af6e8a457609ec083f285032ef28ca8/third_party/blink/renderer/core/html/parser/html_token.h
[modify] https://crrev.com/f38ce4ea9af6e8a457609ec083f285032ef28ca8/third_party/blink/renderer/core/html/parser/html_tokenizer.cc
[modify] https://crrev.com/f38ce4ea9af6e8a457609ec083f285032ef28ca8/third_party/blink/renderer/core/html/parser/html_tokenizer.h
[modify] https://crrev.com/f38ce4ea9af6e8a457609ec083f285032ef28ca8/third_party/blink/renderer/core/html/parser/text_resource_decoder.cc
[modify] https://crrev.com/f38ce4ea9af6e8a457609ec083f285032ef28ca8/third_party/blink/renderer/core/html/parser/text_resource_decoder.h
[modify] https://crrev.com/f38ce4ea9af6e8a457609ec083f285032ef28ca8/third_party/blink/renderer/core/html/parser/xss_auditor.cc
[modify] https://crrev.com/f38ce4ea9af6e8a457609ec083f285032ef28ca8/third_party/blink/renderer/core/html/parser/xss_auditor.h
[modify] https://crrev.com/f38ce4ea9af6e8a457609ec083f285032ef28ca8/third_party/blink/renderer/core/html/time_ranges.cc
[modify] https://crrev.com/f38ce4ea9af6e8a457609ec083f285032ef28ca8/third_party/blink/renderer/core/html/track/automatic_track_selection.cc
[modify] https://crrev.com/f38ce4ea9af6e8a457609ec083f285032ef28ca8/third_party/blink/renderer/core/html/track/cue_timeline.cc
[modify] https://crrev.com/f38ce4ea9af6e8a457609ec083f285032ef28ca8/third_party/blink/renderer/core/html/track/loadable_text_track.cc
[modify] https://crrev.com/f38ce4ea9af6e8a457609ec083f285032ef28ca8/third_party/blink/renderer/core/html/track/loadable_text_track.h
[modify] https://crrev.com/f38ce4ea9af6e8a457609ec083f285032ef28ca8/third_party/blink/renderer/core/html/track/text_track.cc
[modify] https://crrev.com/f38ce4ea9af6e8a457609ec083f285032ef28ca8/third_party/blink/renderer/core/html/track/text_track_cue_list.cc
[modify] https://crrev.com/f38ce4ea9af6e8a457609ec083f285032ef28ca8/third_party/blink/renderer/core/html/track/text_track_cue_list.h
[modify] https://crrev.com/f38ce4ea9af6e8a457609ec083f285032ef28ca8/third_party/blink/renderer/core/html/track/text_track_list.cc
[modify] https://crrev.com/f38ce4ea9af6e8a457609ec083f285032ef28ca8/third_party/blink/renderer/core/html/track/vtt/buffered_line_reader_test.cc
[modify] https://crrev.com/f38ce4ea9af6e8a457609ec083f285032ef28ca8/third_party/blink/renderer/core/html/track/vtt/vtt_parser.cc
[modify] https://crrev.com/f38ce4ea9af6e8a457609ec083f285032ef28ca8/third_party/blink/renderer/core/html/track/vtt/vtt_scanner.cc
[modify] https://crrev.com/f38ce4ea9af6e8a457609ec083f285032ef28ca8/third_party/blink/renderer/core/html/track/vtt/vtt_scanner.h

Project Member

Comment 24 by bugdroid1@chromium.org, Sep 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2203499fc882c1f239e368f984f3b83d052de585

commit 2203499fc882c1f239e368f984f3b83d052de585
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Mon Sep 24 18:23:19 2018

Fix 64 bit truncation errors in blink/core/css

Use wtf_size_t when dealing with WTF types.

BUG=879657

Change-Id: I7c36518c6b88f5d8b8b3ea3f90551eed3177d85a
Reviewed-on: https://chromium-review.googlesource.com/1240496
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593604}
[modify] https://crrev.com/2203499fc882c1f239e368f984f3b83d052de585/third_party/blink/renderer/core/css/css_basic_shape_values.cc
[modify] https://crrev.com/2203499fc882c1f239e368f984f3b83d052de585/third_party/blink/renderer/core/css/css_calculation_value_test.cc
[modify] https://crrev.com/2203499fc882c1f239e368f984f3b83d052de585/third_party/blink/renderer/core/css/css_gradient_value.cc
[modify] https://crrev.com/2203499fc882c1f239e368f984f3b83d052de585/third_party/blink/renderer/core/css/css_image_set_value.cc
[modify] https://crrev.com/2203499fc882c1f239e368f984f3b83d052de585/third_party/blink/renderer/core/css/css_keyframes_rule.cc
[modify] https://crrev.com/2203499fc882c1f239e368f984f3b83d052de585/third_party/blink/renderer/core/css/css_paint_value.cc
[modify] https://crrev.com/2203499fc882c1f239e368f984f3b83d052de585/third_party/blink/renderer/core/css/css_property_value_set.cc
[modify] https://crrev.com/2203499fc882c1f239e368f984f3b83d052de585/third_party/blink/renderer/core/css/css_selector.h
[modify] https://crrev.com/2203499fc882c1f239e368f984f3b83d052de585/third_party/blink/renderer/core/css/css_selector_list.cc
[modify] https://crrev.com/2203499fc882c1f239e368f984f3b83d052de585/third_party/blink/renderer/core/css/css_selector_list.h
[modify] https://crrev.com/2203499fc882c1f239e368f984f3b83d052de585/third_party/blink/renderer/core/css/css_syntax_descriptor.cc
[modify] https://crrev.com/2203499fc882c1f239e368f984f3b83d052de585/third_party/blink/renderer/core/css/css_value_list.cc
[modify] https://crrev.com/2203499fc882c1f239e368f984f3b83d052de585/third_party/blink/renderer/core/css/css_value_list.h
[modify] https://crrev.com/2203499fc882c1f239e368f984f3b83d052de585/third_party/blink/renderer/core/css/cssom/css_math_product.cc
[modify] https://crrev.com/2203499fc882c1f239e368f984f3b83d052de585/third_party/blink/renderer/core/css/cssom/css_math_sum.cc
[modify] https://crrev.com/2203499fc882c1f239e368f984f3b83d052de585/third_party/blink/renderer/core/css/cssom/css_math_variadic.h
[modify] https://crrev.com/2203499fc882c1f239e368f984f3b83d052de585/third_party/blink/renderer/core/css/cssom/css_numeric_value.cc
[modify] https://crrev.com/2203499fc882c1f239e368f984f3b83d052de585/third_party/blink/renderer/core/css/cssom/css_transform_value.cc
[modify] https://crrev.com/2203499fc882c1f239e368f984f3b83d052de585/third_party/blink/renderer/core/css/cssom/css_transform_value.h
[modify] https://crrev.com/2203499fc882c1f239e368f984f3b83d052de585/third_party/blink/renderer/core/css/cssom/css_unparsed_value.h
[modify] https://crrev.com/2203499fc882c1f239e368f984f3b83d052de585/third_party/blink/renderer/core/css/cssom/style_property_map_read_only.cc
[modify] https://crrev.com/2203499fc882c1f239e368f984f3b83d052de585/third_party/blink/renderer/core/css/element_rule_collector.cc
[modify] https://crrev.com/2203499fc882c1f239e368f984f3b83d052de585/third_party/blink/renderer/core/css/font_face.cc
[modify] https://crrev.com/2203499fc882c1f239e368f984f3b83d052de585/third_party/blink/renderer/core/css/font_face_set.cc
[modify] https://crrev.com/2203499fc882c1f239e368f984f3b83d052de585/third_party/blink/renderer/core/css/font_face_set.h
[modify] https://crrev.com/2203499fc882c1f239e368f984f3b83d052de585/third_party/blink/renderer/core/css/media_list.cc
[modify] https://crrev.com/2203499fc882c1f239e368f984f3b83d052de585/third_party/blink/renderer/core/css/media_query.cc
[modify] https://crrev.com/2203499fc882c1f239e368f984f3b83d052de585/third_party/blink/renderer/core/css/media_query_evaluator.cc
[modify] https://crrev.com/2203499fc882c1f239e368f984f3b83d052de585/third_party/blink/renderer/core/css/media_query_set_test.cc
[modify] https://crrev.com/2203499fc882c1f239e368f984f3b83d052de585/third_party/blink/renderer/core/css/media_values.cc
[modify] https://crrev.com/2203499fc882c1f239e368f984f3b83d052de585/third_party/blink/renderer/core/css/parser/css_lazy_parsing_test.cc
[modify] https://crrev.com/2203499fc882c1f239e368f984f3b83d052de585/third_party/blink/renderer/core/css/parser/css_lazy_property_parser_impl.cc
[modify] https://crrev.com/2203499fc882c1f239e368f984f3b83d052de585/third_party/blink/renderer/core/css/parser/css_lazy_property_parser_impl.h
[modify] https://crrev.com/2203499fc882c1f239e368f984f3b83d052de585/third_party/blink/renderer/core/css/parser/css_parser_fast_paths.cc
[modify] https://crrev.com/2203499fc882c1f239e368f984f3b83d052de585/third_party/blink/renderer/core/css/parser/css_parser_impl.cc
[modify] https://crrev.com/2203499fc882c1f239e368f984f3b83d052de585/third_party/blink/renderer/core/css/parser/css_parser_impl.h
[modify] https://crrev.com/2203499fc882c1f239e368f984f3b83d052de585/third_party/blink/renderer/core/css/parser/css_parser_token_range.h
[modify] https://crrev.com/2203499fc882c1f239e368f984f3b83d052de585/third_party/blink/renderer/core/css/parser/css_parser_token_stream.h
[modify] https://crrev.com/2203499fc882c1f239e368f984f3b83d052de585/third_party/blink/renderer/core/css/parser/css_selector_parser.cc
[modify] https://crrev.com/2203499fc882c1f239e368f984f3b83d052de585/third_party/blink/renderer/core/css/parser/css_tokenizer.cc
[modify] https://crrev.com/2203499fc882c1f239e368f984f3b83d052de585/third_party/blink/renderer/core/css/parser/css_tokenizer.h
[modify] https://crrev.com/2203499fc882c1f239e368f984f3b83d052de585/third_party/blink/renderer/core/css/parser/css_tokenizer_input_stream.h
[modify] https://crrev.com/2203499fc882c1f239e368f984f3b83d052de585/third_party/blink/renderer/core/css/part_names.cc
[modify] https://crrev.com/2203499fc882c1f239e368f984f3b83d052de585/third_party/blink/renderer/core/css/properties/computed_style_utils.cc
[modify] https://crrev.com/2203499fc882c1f239e368f984f3b83d052de585/third_party/blink/renderer/core/css/properties/css_parsing_utils.cc
[modify] https://crrev.com/2203499fc882c1f239e368f984f3b83d052de585/third_party/blink/renderer/core/css/properties/longhands/animation_direction_custom.cc
[modify] https://crrev.com/2203499fc882c1f239e368f984f3b83d052de585/third_party/blink/renderer/core/css/properties/longhands/animation_fill_mode_custom.cc
[modify] https://crrev.com/2203499fc882c1f239e368f984f3b83d052de585/third_party/blink/renderer/core/css/properties/longhands/animation_iteration_count_custom.cc
[modify] https://crrev.com/2203499fc882c1f239e368f984f3b83d052de585/third_party/blink/renderer/core/css/properties/longhands/animation_name_custom.cc
[modify] https://crrev.com/2203499fc882c1f239e368f984f3b83d052de585/third_party/blink/renderer/core/css/properties/longhands/animation_play_state_custom.cc
[modify] https://crrev.com/2203499fc882c1f239e368f984f3b83d052de585/third_party/blink/renderer/core/css/properties/longhands/font_feature_settings_custom.cc
[modify] https://crrev.com/2203499fc882c1f239e368f984f3b83d052de585/third_party/blink/renderer/core/css/properties/longhands/font_variation_settings_custom.cc
[modify] https://crrev.com/2203499fc882c1f239e368f984f3b83d052de585/third_party/blink/renderer/core/css/properties/shorthands/animation_custom.cc
[modify] https://crrev.com/2203499fc882c1f239e368f984f3b83d052de585/third_party/blink/renderer/core/css/properties/shorthands/transition_custom.cc
[modify] https://crrev.com/2203499fc882c1f239e368f984f3b83d052de585/third_party/blink/renderer/core/css/remote_font_face_source.cc
[modify] https://crrev.com/2203499fc882c1f239e368f984f3b83d052de585/third_party/blink/renderer/core/css/resolver/element_style_resources.cc
[modify] https://crrev.com/2203499fc882c1f239e368f984f3b83d052de585/third_party/blink/renderer/core/css/resolver/matched_properties_cache.cc
[modify] https://crrev.com/2203499fc882c1f239e368f984f3b83d052de585/third_party/blink/renderer/core/css/resolver/scoped_style_resolver.cc
[modify] https://crrev.com/2203499fc882c1f239e368f984f3b83d052de585/third_party/blink/renderer/core/css/resolver/style_builder_converter.cc
[modify] https://crrev.com/2203499fc882c1f239e368f984f3b83d052de585/third_party/blink/renderer/core/css/rule_feature_set_test.cc
[modify] https://crrev.com/2203499fc882c1f239e368f984f3b83d052de585/third_party/blink/renderer/core/css/rule_set.cc
[modify] https://crrev.com/2203499fc882c1f239e368f984f3b83d052de585/third_party/blink/renderer/core/css/selector_checker.cc
[modify] https://crrev.com/2203499fc882c1f239e368f984f3b83d052de585/third_party/blink/renderer/core/css/selector_filter.cc
[modify] https://crrev.com/2203499fc882c1f239e368f984f3b83d052de585/third_party/blink/renderer/core/css/style_color.cc
[modify] https://crrev.com/2203499fc882c1f239e368f984f3b83d052de585/third_party/blink/renderer/core/css/style_engine.cc
[modify] https://crrev.com/2203499fc882c1f239e368f984f3b83d052de585/third_party/blink/renderer/core/css/style_property_serializer.cc

Project Member

Comment 25 by bugdroid1@chromium.org, Sep 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/99452eeafed6a89a8a928e7311f4ab547485a0d6

commit 99452eeafed6a89a8a928e7311f4ab547485a0d6
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Tue Sep 25 13:36:08 2018

Fix 64 bit truncation errors in blink/renderer/modules

Use wtf_size_t when dealing with WTF types.

BUG=879657

Change-Id: I0c210c41c6cc121cb21d286c03b798c0c4bd0b89
Reviewed-on: https://chromium-review.googlesource.com/1240504
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593914}
[modify] https://crrev.com/99452eeafed6a89a8a928e7311f4ab547485a0d6/third_party/blink/renderer/modules/accessibility/ax_layout_object.cc
[modify] https://crrev.com/99452eeafed6a89a8a928e7311f4ab547485a0d6/third_party/blink/renderer/modules/accessibility/ax_node_object.cc
[modify] https://crrev.com/99452eeafed6a89a8a928e7311f4ab547485a0d6/third_party/blink/renderer/modules/accessibility/ax_object.cc
[modify] https://crrev.com/99452eeafed6a89a8a928e7311f4ab547485a0d6/third_party/blink/renderer/modules/accessibility/ax_relation_cache.cc
[modify] https://crrev.com/99452eeafed6a89a8a928e7311f4ab547485a0d6/third_party/blink/renderer/modules/accessibility/ax_sparse_attribute_setter.cc
[modify] https://crrev.com/99452eeafed6a89a8a928e7311f4ab547485a0d6/third_party/blink/renderer/modules/accessibility/inspector_accessibility_agent.cc
[modify] https://crrev.com/99452eeafed6a89a8a928e7311f4ab547485a0d6/third_party/blink/renderer/modules/accessibility/inspector_type_builder_helper.cc
[modify] https://crrev.com/99452eeafed6a89a8a928e7311f4ab547485a0d6/third_party/blink/renderer/modules/background_fetch/background_fetch_manager.cc
[modify] https://crrev.com/99452eeafed6a89a8a928e7311f4ab547485a0d6/third_party/blink/renderer/modules/cache_storage/inspector_cache_storage_agent.cc
[modify] https://crrev.com/99452eeafed6a89a8a928e7311f4ab547485a0d6/third_party/blink/renderer/modules/canvas/canvas2d/canvas_rendering_context_2d_state.cc
[modify] https://crrev.com/99452eeafed6a89a8a928e7311f4ab547485a0d6/third_party/blink/renderer/modules/clipboard/clipboard_promise.cc

Project Member

Comment 26 by bugdroid1@chromium.org, Oct 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5bcfa81bb3a14aaec27136c488e9cce1c417c871

commit 5bcfa81bb3a14aaec27136c488e9cce1c417c871
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Wed Oct 03 14:33:53 2018

Fix 64 bit truncation errors in blink/renderer/modules/webusb

Use wtf_size_t when dealing with WTF types.

BUG=879657

Change-Id: Ic2eec59581223c897b76675a2d7b1fb47a1327da
Reviewed-on: https://chromium-review.googlesource.com/c/1257681
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596208}
[modify] https://crrev.com/5bcfa81bb3a14aaec27136c488e9cce1c417c871/third_party/blink/renderer/modules/webusb/usb_alternate_interface.cc
[modify] https://crrev.com/5bcfa81bb3a14aaec27136c488e9cce1c417c871/third_party/blink/renderer/modules/webusb/usb_alternate_interface.h
[modify] https://crrev.com/5bcfa81bb3a14aaec27136c488e9cce1c417c871/third_party/blink/renderer/modules/webusb/usb_configuration.cc
[modify] https://crrev.com/5bcfa81bb3a14aaec27136c488e9cce1c417c871/third_party/blink/renderer/modules/webusb/usb_configuration.h
[modify] https://crrev.com/5bcfa81bb3a14aaec27136c488e9cce1c417c871/third_party/blink/renderer/modules/webusb/usb_device.cc
[modify] https://crrev.com/5bcfa81bb3a14aaec27136c488e9cce1c417c871/third_party/blink/renderer/modules/webusb/usb_device.h
[modify] https://crrev.com/5bcfa81bb3a14aaec27136c488e9cce1c417c871/third_party/blink/renderer/modules/webusb/usb_endpoint.cc
[modify] https://crrev.com/5bcfa81bb3a14aaec27136c488e9cce1c417c871/third_party/blink/renderer/modules/webusb/usb_endpoint.h
[modify] https://crrev.com/5bcfa81bb3a14aaec27136c488e9cce1c417c871/third_party/blink/renderer/modules/webusb/usb_interface.cc
[modify] https://crrev.com/5bcfa81bb3a14aaec27136c488e9cce1c417c871/third_party/blink/renderer/modules/webusb/usb_interface.h

Project Member

Comment 27 by bugdroid1@chromium.org, Oct 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/77718113022f985b29fd26851844e80ea43c546a

commit 77718113022f985b29fd26851844e80ea43c546a
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Wed Oct 03 15:31:59 2018

Fix 64 bit truncation errors in blink/renderer/modules

Use wtf_size_t when dealing with WTF types.

BUG=879657

Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I5f7d23ee54ccad62cf42961fec86ad8b4801a8c9
Reviewed-on: https://chromium-review.googlesource.com/c/1258047
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596220}
[modify] https://crrev.com/77718113022f985b29fd26851844e80ea43c546a/third_party/blink/renderer/modules/presentation/presentation_availability_state_test.cc
[modify] https://crrev.com/77718113022f985b29fd26851844e80ea43c546a/third_party/blink/renderer/modules/presentation/presentation_connection.cc
[modify] https://crrev.com/77718113022f985b29fd26851844e80ea43c546a/third_party/blink/renderer/modules/presentation/presentation_connection.h
[modify] https://crrev.com/77718113022f985b29fd26851844e80ea43c546a/third_party/blink/renderer/modules/presentation/presentation_connection_list.cc
[modify] https://crrev.com/77718113022f985b29fd26851844e80ea43c546a/third_party/blink/renderer/modules/presentation/presentation_request.cc
[modify] https://crrev.com/77718113022f985b29fd26851844e80ea43c546a/third_party/blink/renderer/modules/webmidi/midi_access.cc
[modify] https://crrev.com/77718113022f985b29fd26851844e80ea43c546a/third_party/blink/renderer/modules/webmidi/midi_output.cc
[modify] https://crrev.com/77718113022f985b29fd26851844e80ea43c546a/third_party/blink/renderer/modules/webmidi/midi_port_map.h
[modify] https://crrev.com/77718113022f985b29fd26851844e80ea43c546a/third_party/blink/renderer/modules/websockets/dom_websocket.cc
[modify] https://crrev.com/77718113022f985b29fd26851844e80ea43c546a/third_party/blink/renderer/modules/websockets/inspector_websocket_events.cc
[modify] https://crrev.com/77718113022f985b29fd26851844e80ea43c546a/third_party/blink/renderer/modules/websockets/websocket_channel_impl.cc
[modify] https://crrev.com/77718113022f985b29fd26851844e80ea43c546a/third_party/blink/renderer/modules/websockets/websocket_channel_impl.h
[modify] https://crrev.com/77718113022f985b29fd26851844e80ea43c546a/third_party/blink/renderer/modules/websockets/websocket_channel_impl_test.cc
[modify] https://crrev.com/77718113022f985b29fd26851844e80ea43c546a/third_party/blink/renderer/modules/websockets/websocket_handle.h
[modify] https://crrev.com/77718113022f985b29fd26851844e80ea43c546a/third_party/blink/renderer/modules/websockets/websocket_handle_impl.cc
[modify] https://crrev.com/77718113022f985b29fd26851844e80ea43c546a/third_party/blink/renderer/modules/websockets/websocket_handle_impl.h
[modify] https://crrev.com/77718113022f985b29fd26851844e80ea43c546a/third_party/blink/renderer/modules/xr/xr_webgl_layer.h

Project Member

Comment 28 by bugdroid1@chromium.org, Oct 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d90876be428603f0e129d4d58804efec78e9f6c

commit 9d90876be428603f0e129d4d58804efec78e9f6c
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Wed Oct 03 19:37:16 2018

Fix 64 bit truncation errors in blink/renderer/modules

Use wtf_size_t when dealing with WTF types.

BUG=879657

Change-Id: I62c9193ac74ea77280197438b1d91fa252200f1e
Reviewed-on: https://chromium-review.googlesource.com/c/1257149
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596326}
[modify] https://crrev.com/9d90876be428603f0e129d4d58804efec78e9f6c/third_party/blink/renderer/modules/cache_storage/cache.cc
[modify] https://crrev.com/9d90876be428603f0e129d4d58804efec78e9f6c/third_party/blink/renderer/modules/cache_storage/cache_test.cc
[modify] https://crrev.com/9d90876be428603f0e129d4d58804efec78e9f6c/third_party/blink/renderer/modules/canvas/canvas2d/base_rendering_context_2d.cc
[modify] https://crrev.com/9d90876be428603f0e129d4d58804efec78e9f6c/third_party/blink/renderer/modules/crypto/crypto_key.cc
[modify] https://crrev.com/9d90876be428603f0e129d4d58804efec78e9f6c/third_party/blink/renderer/modules/crypto/normalize_algorithm.cc
[modify] https://crrev.com/9d90876be428603f0e129d4d58804efec78e9f6c/third_party/blink/renderer/modules/eventsource/event_source_parser.cc
[modify] https://crrev.com/9d90876be428603f0e129d4d58804efec78e9f6c/third_party/blink/renderer/modules/eventsource/event_source_parser.h
[modify] https://crrev.com/9d90876be428603f0e129d4d58804efec78e9f6c/third_party/blink/renderer/modules/eventsource/event_source_parser_test.cc
[modify] https://crrev.com/9d90876be428603f0e129d4d58804efec78e9f6c/third_party/blink/renderer/modules/exported/web_ax_object.cc
[modify] https://crrev.com/9d90876be428603f0e129d4d58804efec78e9f6c/third_party/blink/renderer/modules/exported/web_idb_key.cc
[modify] https://crrev.com/9d90876be428603f0e129d4d58804efec78e9f6c/third_party/blink/renderer/modules/filesystem/dom_file_path.cc
[modify] https://crrev.com/9d90876be428603f0e129d4d58804efec78e9f6c/third_party/blink/renderer/modules/filesystem/file_writer.cc
[modify] https://crrev.com/9d90876be428603f0e129d4d58804efec78e9f6c/third_party/blink/renderer/modules/filesystem/local_file_system.cc
[modify] https://crrev.com/9d90876be428603f0e129d4d58804efec78e9f6c/third_party/blink/renderer/modules/gamepad/navigator_gamepad.cc
[modify] https://crrev.com/9d90876be428603f0e129d4d58804efec78e9f6c/third_party/blink/renderer/modules/indexeddb/idb_database.cc
[modify] https://crrev.com/9d90876be428603f0e129d4d58804efec78e9f6c/third_party/blink/renderer/modules/indexeddb/idb_event_dispatcher.cc
[modify] https://crrev.com/9d90876be428603f0e129d4d58804efec78e9f6c/third_party/blink/renderer/modules/indexeddb/idb_key.cc
[modify] https://crrev.com/9d90876be428603f0e129d4d58804efec78e9f6c/third_party/blink/renderer/modules/indexeddb/idb_key_path.cc
[modify] https://crrev.com/9d90876be428603f0e129d4d58804efec78e9f6c/third_party/blink/renderer/modules/indexeddb/idb_key_path_test.cc
[modify] https://crrev.com/9d90876be428603f0e129d4d58804efec78e9f6c/third_party/blink/renderer/modules/indexeddb/idb_object_store.cc
[modify] https://crrev.com/9d90876be428603f0e129d4d58804efec78e9f6c/third_party/blink/renderer/modules/indexeddb/idb_request.cc
[modify] https://crrev.com/9d90876be428603f0e129d4d58804efec78e9f6c/third_party/blink/renderer/modules/indexeddb/idb_test_helper.cc
[modify] https://crrev.com/9d90876be428603f0e129d4d58804efec78e9f6c/third_party/blink/renderer/modules/indexeddb/idb_value.cc
[modify] https://crrev.com/9d90876be428603f0e129d4d58804efec78e9f6c/third_party/blink/renderer/modules/indexeddb/idb_value_wrapping.cc
[modify] https://crrev.com/9d90876be428603f0e129d4d58804efec78e9f6c/third_party/blink/renderer/modules/indexeddb/idb_value_wrapping_test.cc
[modify] https://crrev.com/9d90876be428603f0e129d4d58804efec78e9f6c/third_party/blink/renderer/modules/indexeddb/inspector_indexed_db_agent.cc
[modify] https://crrev.com/9d90876be428603f0e129d4d58804efec78e9f6c/third_party/blink/renderer/modules/indexeddb/web_idb_callbacks_impl.cc
[modify] https://crrev.com/9d90876be428603f0e129d4d58804efec78e9f6c/third_party/blink/renderer/modules/keyboard/keyboard_layout_map.h
[modify] https://crrev.com/9d90876be428603f0e129d4d58804efec78e9f6c/third_party/blink/renderer/modules/media_capabilities/media_capabilities.cc
[modify] https://crrev.com/9d90876be428603f0e129d4d58804efec78e9f6c/third_party/blink/renderer/modules/media_controls/media_controls_orientation_lock_delegate.cc
[modify] https://crrev.com/9d90876be428603f0e129d4d58804efec78e9f6c/third_party/blink/renderer/modules/mediacapturefromelement/html_media_element_capture.cc
[modify] https://crrev.com/9d90876be428603f0e129d4d58804efec78e9f6c/third_party/blink/renderer/modules/mediasession/media_metadata.cc
[modify] https://crrev.com/9d90876be428603f0e129d4d58804efec78e9f6c/third_party/blink/renderer/modules/mediasource/media_source.cc
[modify] https://crrev.com/9d90876be428603f0e129d4d58804efec78e9f6c/third_party/blink/renderer/modules/mediasource/source_buffer.cc
[modify] https://crrev.com/9d90876be428603f0e129d4d58804efec78e9f6c/third_party/blink/renderer/modules/nfc/nfc.cc
[modify] https://crrev.com/9d90876be428603f0e129d4d58804efec78e9f6c/third_party/blink/renderer/modules/nfc/nfc.h
[modify] https://crrev.com/9d90876be428603f0e129d4d58804efec78e9f6c/third_party/blink/renderer/modules/notifications/notification.cc
[modify] https://crrev.com/9d90876be428603f0e129d4d58804efec78e9f6c/third_party/blink/renderer/modules/notifications/notification_data.cc
[modify] https://crrev.com/9d90876be428603f0e129d4d58804efec78e9f6c/third_party/blink/renderer/modules/notifications/notification_data_test.cc

Project Member

Comment 29 by bugdroid1@chromium.org, Oct 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/363b8d9d6bf33aa8c3eb71799ea25a78eba6f6bc

commit 363b8d9d6bf33aa8c3eb71799ea25a78eba6f6bc
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Thu Oct 04 17:30:22 2018

Fix 64 bit truncation errors in blink/renderer/core

Use wtf_size_t when dealing with WTF types.
Add RefVector iterators.

BUG=879657

Change-Id: I748ab38b1c9f66b3e5405c1fa75f981c5d5f0a14
Reviewed-on: https://chromium-review.googlesource.com/c/1259496
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596732}
[modify] https://crrev.com/363b8d9d6bf33aa8c3eb71799ea25a78eba6f6bc/third_party/blink/renderer/core/mojo/mojo_handle.cc
[modify] https://crrev.com/363b8d9d6bf33aa8c3eb71799ea25a78eba6f6bc/third_party/blink/renderer/core/mojo/tests/js_to_cpp_test.cc
[modify] https://crrev.com/363b8d9d6bf33aa8c3eb71799ea25a78eba6f6bc/third_party/blink/renderer/core/script/modulator_impl_base.cc
[modify] https://crrev.com/363b8d9d6bf33aa8c3eb71799ea25a78eba6f6bc/third_party/blink/renderer/core/script/script_runner_test.cc
[modify] https://crrev.com/363b8d9d6bf33aa8c3eb71799ea25a78eba6f6bc/third_party/blink/renderer/core/scroll/scrollbar.h
[modify] https://crrev.com/363b8d9d6bf33aa8c3eb71799ea25a78eba6f6bc/third_party/blink/renderer/core/style/basic_shapes.cc
[modify] https://crrev.com/363b8d9d6bf33aa8c3eb71799ea25a78eba6f6bc/third_party/blink/renderer/core/style/computed_style.cc
[modify] https://crrev.com/363b8d9d6bf33aa8c3eb71799ea25a78eba6f6bc/third_party/blink/renderer/core/style/filter_operations.cc
[modify] https://crrev.com/363b8d9d6bf33aa8c3eb71799ea25a78eba6f6bc/third_party/blink/renderer/core/style/filter_operations.h
[modify] https://crrev.com/363b8d9d6bf33aa8c3eb71799ea25a78eba6f6bc/third_party/blink/renderer/core/style/shadow_list.cc
[modify] https://crrev.com/363b8d9d6bf33aa8c3eb71799ea25a78eba6f6bc/third_party/blink/renderer/core/testing/internal_settings.cc
[modify] https://crrev.com/363b8d9d6bf33aa8c3eb71799ea25a78eba6f6bc/third_party/blink/renderer/core/testing/internals.cc
[modify] https://crrev.com/363b8d9d6bf33aa8c3eb71799ea25a78eba6f6bc/third_party/blink/renderer/core/testing/internals.h
[modify] https://crrev.com/363b8d9d6bf33aa8c3eb71799ea25a78eba6f6bc/third_party/blink/renderer/core/workers/worker_animation_frame_provider.cc
[modify] https://crrev.com/363b8d9d6bf33aa8c3eb71799ea25a78eba6f6bc/third_party/blink/renderer/platform/wtf/ref_vector.h

Project Member

Comment 30 by bugdroid1@chromium.org, Oct 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dcbd5ac766a7c2b10e6d4061c1cc1ccae7e48237

commit dcbd5ac766a7c2b10e6d4061c1cc1ccae7e48237
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Thu Oct 04 20:07:01 2018

Fix 64 bit truncation errors in blink/renderer/platform/text

Use wtf_size_t when dealing with WTF types.

BUG=879657

Change-Id: I2cbfc4160306b01f20b7dcb347f8fa491016f31a
Reviewed-on: https://chromium-review.googlesource.com/c/1262079
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596819}
[modify] https://crrev.com/dcbd5ac766a7c2b10e6d4061c1cc1ccae7e48237/third_party/blink/renderer/core/layout/layout_text.cc
[modify] https://crrev.com/dcbd5ac766a7c2b10e6d4061c1cc1ccae7e48237/third_party/blink/renderer/core/testing/mock_hyphenation.cc
[modify] https://crrev.com/dcbd5ac766a7c2b10e6d4061c1cc1ccae7e48237/third_party/blink/renderer/core/testing/mock_hyphenation.h
[modify] https://crrev.com/dcbd5ac766a7c2b10e6d4061c1cc1ccae7e48237/third_party/blink/renderer/platform/text/bidi_resolver.h
[modify] https://crrev.com/dcbd5ac766a7c2b10e6d4061c1cc1ccae7e48237/third_party/blink/renderer/platform/text/character.cc
[modify] https://crrev.com/dcbd5ac766a7c2b10e6d4061c1cc1ccae7e48237/third_party/blink/renderer/platform/text/character.h
[modify] https://crrev.com/dcbd5ac766a7c2b10e6d4061c1cc1ccae7e48237/third_party/blink/renderer/platform/text/decode_escape_sequences.h
[modify] https://crrev.com/dcbd5ac766a7c2b10e6d4061c1cc1ccae7e48237/third_party/blink/renderer/platform/text/hyphenation.cc
[modify] https://crrev.com/dcbd5ac766a7c2b10e6d4061c1cc1ccae7e48237/third_party/blink/renderer/platform/text/hyphenation.h
[modify] https://crrev.com/dcbd5ac766a7c2b10e6d4061c1cc1ccae7e48237/third_party/blink/renderer/platform/text/hyphenation/hyphenation_minikin.cc
[modify] https://crrev.com/dcbd5ac766a7c2b10e6d4061c1cc1ccae7e48237/third_party/blink/renderer/platform/text/hyphenation/hyphenation_minikin.h
[modify] https://crrev.com/dcbd5ac766a7c2b10e6d4061c1cc1ccae7e48237/third_party/blink/renderer/platform/text/hyphenation_test.cc
[modify] https://crrev.com/dcbd5ac766a7c2b10e6d4061c1cc1ccae7e48237/third_party/blink/renderer/platform/text/line_ending.cc
[modify] https://crrev.com/dcbd5ac766a7c2b10e6d4061c1cc1ccae7e48237/third_party/blink/renderer/platform/text/locale_to_script_mapping.cc
[modify] https://crrev.com/dcbd5ac766a7c2b10e6d4061c1cc1ccae7e48237/third_party/blink/renderer/platform/text/mac/hyphenation_mac.cc
[modify] https://crrev.com/dcbd5ac766a7c2b10e6d4061c1cc1ccae7e48237/third_party/blink/renderer/platform/text/platform_locale.cc
[modify] https://crrev.com/dcbd5ac766a7c2b10e6d4061c1cc1ccae7e48237/third_party/blink/renderer/platform/text/quoted_printable.cc
[modify] https://crrev.com/dcbd5ac766a7c2b10e6d4061c1cc1ccae7e48237/third_party/blink/renderer/platform/text/quoted_printable.h
[modify] https://crrev.com/dcbd5ac766a7c2b10e6d4061c1cc1ccae7e48237/third_party/blink/renderer/platform/text/text_break_iterator_icu.cc
[modify] https://crrev.com/dcbd5ac766a7c2b10e6d4061c1cc1ccae7e48237/third_party/blink/renderer/platform/text/text_encoding_detector.cc
[modify] https://crrev.com/dcbd5ac766a7c2b10e6d4061c1cc1ccae7e48237/third_party/blink/renderer/platform/text/text_encoding_detector.h
[modify] https://crrev.com/dcbd5ac766a7c2b10e6d4061c1cc1ccae7e48237/third_party/blink/renderer/platform/text/text_run.cc
[modify] https://crrev.com/dcbd5ac766a7c2b10e6d4061c1cc1ccae7e48237/third_party/blink/renderer/platform/text/unicode_utilities.cc
[modify] https://crrev.com/dcbd5ac766a7c2b10e6d4061c1cc1ccae7e48237/third_party/blink/renderer/platform/wtf/text/collator.cc
[modify] https://crrev.com/dcbd5ac766a7c2b10e6d4061c1cc1ccae7e48237/third_party/blink/renderer/platform/wtf/text/collator.h
[modify] https://crrev.com/dcbd5ac766a7c2b10e6d4061c1cc1ccae7e48237/third_party/blink/renderer/platform/wtf/text/text_codec.h
[modify] https://crrev.com/dcbd5ac766a7c2b10e6d4061c1cc1ccae7e48237/third_party/blink/renderer/platform/wtf/text/text_codec_icu.cc
[modify] https://crrev.com/dcbd5ac766a7c2b10e6d4061c1cc1ccae7e48237/third_party/blink/renderer/platform/wtf/text/text_codec_icu.h
[modify] https://crrev.com/dcbd5ac766a7c2b10e6d4061c1cc1ccae7e48237/third_party/blink/renderer/platform/wtf/text/text_codec_latin1.cc
[modify] https://crrev.com/dcbd5ac766a7c2b10e6d4061c1cc1ccae7e48237/third_party/blink/renderer/platform/wtf/text/text_codec_latin1.h
[modify] https://crrev.com/dcbd5ac766a7c2b10e6d4061c1cc1ccae7e48237/third_party/blink/renderer/platform/wtf/text/text_codec_replacement.cc
[modify] https://crrev.com/dcbd5ac766a7c2b10e6d4061c1cc1ccae7e48237/third_party/blink/renderer/platform/wtf/text/text_codec_replacement.h
[modify] https://crrev.com/dcbd5ac766a7c2b10e6d4061c1cc1ccae7e48237/third_party/blink/renderer/platform/wtf/text/text_codec_replacement_test.cc
[modify] https://crrev.com/dcbd5ac766a7c2b10e6d4061c1cc1ccae7e48237/third_party/blink/renderer/platform/wtf/text/text_codec_user_defined.cc
[modify] https://crrev.com/dcbd5ac766a7c2b10e6d4061c1cc1ccae7e48237/third_party/blink/renderer/platform/wtf/text/text_codec_user_defined.h
[modify] https://crrev.com/dcbd5ac766a7c2b10e6d4061c1cc1ccae7e48237/third_party/blink/renderer/platform/wtf/text/text_codec_utf16.cc
[modify] https://crrev.com/dcbd5ac766a7c2b10e6d4061c1cc1ccae7e48237/third_party/blink/renderer/platform/wtf/text/text_codec_utf16.h
[modify] https://crrev.com/dcbd5ac766a7c2b10e6d4061c1cc1ccae7e48237/third_party/blink/renderer/platform/wtf/text/text_codec_utf8.cc
[modify] https://crrev.com/dcbd5ac766a7c2b10e6d4061c1cc1ccae7e48237/third_party/blink/renderer/platform/wtf/text/text_codec_utf8.h
[modify] https://crrev.com/dcbd5ac766a7c2b10e6d4061c1cc1ccae7e48237/third_party/blink/renderer/platform/wtf/text/text_codec_utf8_test.cc
[modify] https://crrev.com/dcbd5ac766a7c2b10e6d4061c1cc1ccae7e48237/third_party/blink/renderer/platform/wtf/text/text_encoding.cc
[modify] https://crrev.com/dcbd5ac766a7c2b10e6d4061c1cc1ccae7e48237/third_party/blink/renderer/platform/wtf/text/text_encoding.h
[modify] https://crrev.com/dcbd5ac766a7c2b10e6d4061c1cc1ccae7e48237/third_party/blink/renderer/platform/wtf/text/text_position.cc
[modify] https://crrev.com/dcbd5ac766a7c2b10e6d4061c1cc1ccae7e48237/third_party/blink/renderer/platform/wtf/text/text_position.h

Project Member

Comment 31 by bugdroid1@chromium.org, Oct 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c6a42f1e43b9b7da6aa297a0a3bf8ac386ed83e4

commit c6a42f1e43b9b7da6aa297a0a3bf8ac386ed83e4
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Tue Oct 09 15:29:09 2018

Fix 64 bit truncation errors in blink/renderer/modules/speech

Use wtf_size_t when dealing with WTF types.
Use uint32_t when dealing with unsigned long IDL bindings.

BUG=879657

Change-Id: Ic426e11bef4526b694de05ee4d4e1c8aed6b140c
Reviewed-on: https://chromium-review.googlesource.com/c/1262625
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597922}
[modify] https://crrev.com/c6a42f1e43b9b7da6aa297a0a3bf8ac386ed83e4/third_party/blink/renderer/modules/speech/speech_recognition.cc
[modify] https://crrev.com/c6a42f1e43b9b7da6aa297a0a3bf8ac386ed83e4/third_party/blink/renderer/modules/speech/speech_recognition.h
[modify] https://crrev.com/c6a42f1e43b9b7da6aa297a0a3bf8ac386ed83e4/third_party/blink/renderer/modules/speech/speech_recognition_controller.cc
[modify] https://crrev.com/c6a42f1e43b9b7da6aa297a0a3bf8ac386ed83e4/third_party/blink/renderer/modules/speech/speech_recognition_controller.h
[modify] https://crrev.com/c6a42f1e43b9b7da6aa297a0a3bf8ac386ed83e4/third_party/blink/renderer/modules/speech/speech_recognition_event.cc
[modify] https://crrev.com/c6a42f1e43b9b7da6aa297a0a3bf8ac386ed83e4/third_party/blink/renderer/modules/speech/speech_recognition_event.h
[modify] https://crrev.com/c6a42f1e43b9b7da6aa297a0a3bf8ac386ed83e4/third_party/blink/renderer/modules/speech/speech_synthesis.cc
[modify] https://crrev.com/c6a42f1e43b9b7da6aa297a0a3bf8ac386ed83e4/third_party/blink/renderer/modules/speech/speech_synthesis.h

Project Member

Comment 32 by bugdroid1@chromium.org, Oct 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/95e8eb828b1fb75a6d9ba9f840b97d5dcf34a3a1

commit 95e8eb828b1fb75a6d9ba9f840b97d5dcf34a3a1
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Tue Oct 09 18:41:47 2018

Fix 64 bit truncation errors in blink platform fonts & geometry

Use wtf_size_t when dealing with WTF types.

BUG=879657

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I80cdde8873eb81603a3396b05c60d96ca79a91fc
Reviewed-on: https://chromium-review.googlesource.com/c/1269763
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598005}
[modify] https://crrev.com/95e8eb828b1fb75a6d9ba9f840b97d5dcf34a3a1/third_party/blink/renderer/platform/fonts/font_custom_platform_data.cc
[modify] https://crrev.com/95e8eb828b1fb75a6d9ba9f840b97d5dcf34a3a1/third_party/blink/renderer/platform/fonts/font_fallback_iterator.cc
[modify] https://crrev.com/95e8eb828b1fb75a6d9ba9f840b97d5dcf34a3a1/third_party/blink/renderer/platform/fonts/font_metrics.h
[modify] https://crrev.com/95e8eb828b1fb75a6d9ba9f840b97d5dcf34a3a1/third_party/blink/renderer/platform/fonts/opentype/font_settings.h
[modify] https://crrev.com/95e8eb828b1fb75a6d9ba9f840b97d5dcf34a3a1/third_party/blink/renderer/platform/fonts/opentype/open_type_vertical_data.cc
[modify] https://crrev.com/95e8eb828b1fb75a6d9ba9f840b97d5dcf34a3a1/third_party/blink/renderer/platform/fonts/script_run_iterator.cc
[modify] https://crrev.com/95e8eb828b1fb75a6d9ba9f840b97d5dcf34a3a1/third_party/blink/renderer/platform/fonts/script_run_iterator.h
[modify] https://crrev.com/95e8eb828b1fb75a6d9ba9f840b97d5dcf34a3a1/third_party/blink/renderer/platform/fonts/shaping/harfbuzz_face.cc
[modify] https://crrev.com/95e8eb828b1fb75a6d9ba9f840b97d5dcf34a3a1/third_party/blink/renderer/platform/fonts/shaping/harfbuzz_shaper.cc
[modify] https://crrev.com/95e8eb828b1fb75a6d9ba9f840b97d5dcf34a3a1/third_party/blink/renderer/platform/fonts/shaping/shape_result.cc
[modify] https://crrev.com/95e8eb828b1fb75a6d9ba9f840b97d5dcf34a3a1/third_party/blink/renderer/platform/fonts/shaping/shape_result.h
[modify] https://crrev.com/95e8eb828b1fb75a6d9ba9f840b97d5dcf34a3a1/third_party/blink/renderer/platform/fonts/shaping/shape_result_inline_headers.h
[modify] https://crrev.com/95e8eb828b1fb75a6d9ba9f840b97d5dcf34a3a1/third_party/blink/renderer/platform/fonts/shaping/shape_result_test_info.cc
[modify] https://crrev.com/95e8eb828b1fb75a6d9ba9f840b97d5dcf34a3a1/third_party/blink/renderer/platform/fonts/shaping/shape_result_test_info.h
[modify] https://crrev.com/95e8eb828b1fb75a6d9ba9f840b97d5dcf34a3a1/third_party/blink/renderer/platform/fonts/skia/font_cache_skia.cc
[modify] https://crrev.com/95e8eb828b1fb75a6d9ba9f840b97d5dcf34a3a1/third_party/blink/renderer/platform/fonts/unicode_range_set.cc
[modify] https://crrev.com/95e8eb828b1fb75a6d9ba9f840b97d5dcf34a3a1/third_party/blink/renderer/platform/fonts/unicode_range_set.h
[modify] https://crrev.com/95e8eb828b1fb75a6d9ba9f840b97d5dcf34a3a1/third_party/blink/renderer/platform/geometry/blend.h
[modify] https://crrev.com/95e8eb828b1fb75a6d9ba9f840b97d5dcf34a3a1/third_party/blink/renderer/platform/geometry/float_rect.cc
[modify] https://crrev.com/95e8eb828b1fb75a6d9ba9f840b97d5dcf34a3a1/third_party/blink/renderer/platform/geometry/int_point.h
[modify] https://crrev.com/95e8eb828b1fb75a6d9ba9f840b97d5dcf34a3a1/third_party/blink/renderer/platform/geometry/int_rect.cc
[modify] https://crrev.com/95e8eb828b1fb75a6d9ba9f840b97d5dcf34a3a1/third_party/blink/renderer/platform/geometry/layout_rect.cc
[modify] https://crrev.com/95e8eb828b1fb75a6d9ba9f840b97d5dcf34a3a1/third_party/blink/renderer/platform/geometry/region.cc
[modify] https://crrev.com/95e8eb828b1fb75a6d9ba9f840b97d5dcf34a3a1/third_party/blink/renderer/platform/geometry/region.h

Project Member

Comment 33 by bugdroid1@chromium.org, Oct 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ca3bde3991d455e83be955090e99470c2bb4d0d6

commit ca3bde3991d455e83be955090e99470c2bb4d0d6
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Wed Oct 10 16:58:07 2018

Fix 64 bit truncation errors in blink platform heap

Use wtf_size_t when dealing with WTF types.

BUG=879657

Change-Id: Ic9de1cd3b227d72d275cb8f2e18c28b9f9b1984c
Reviewed-on: https://chromium-review.googlesource.com/c/1273262
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598367}
[modify] https://crrev.com/ca3bde3991d455e83be955090e99470c2bb4d0d6/third_party/blink/renderer/platform/heap/gc_info.cc
[modify] https://crrev.com/ca3bde3991d455e83be955090e99470c2bb4d0d6/third_party/blink/renderer/platform/heap/heap_compact_test.cc
[modify] https://crrev.com/ca3bde3991d455e83be955090e99470c2bb4d0d6/third_party/blink/renderer/platform/heap/heap_page.cc
[modify] https://crrev.com/ca3bde3991d455e83be955090e99470c2bb4d0d6/third_party/blink/renderer/platform/heap/page_memory.h
[modify] https://crrev.com/ca3bde3991d455e83be955090e99470c2bb4d0d6/third_party/blink/renderer/platform/heap/thread_state.cc
[modify] https://crrev.com/ca3bde3991d455e83be955090e99470c2bb4d0d6/third_party/blink/renderer/platform/heap/thread_state.h

Project Member

Comment 34 by bugdroid1@chromium.org, Oct 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e401f3e7c049d1ca951b79f277cd940cb980418

commit 8e401f3e7c049d1ca951b79f277cd940cb980418
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Wed Oct 10 18:42:17 2018

Fix 64 bit truncation errors in blink platform

Use wtf_size_t when dealing with WTF types.

BUG=879657

Change-Id: Id50afe9add249a2f08d26f7ae9818cc1247fe8e6
Reviewed-on: https://chromium-review.googlesource.com/c/1271584
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598423}
[modify] https://crrev.com/8e401f3e7c049d1ca951b79f277cd940cb980418/third_party/blink/renderer/modules/document_metadata/copyless_paste_extractor.cc
[modify] https://crrev.com/8e401f3e7c049d1ca951b79f277cd940cb980418/third_party/blink/renderer/platform/feature_policy/feature_policy.cc
[modify] https://crrev.com/8e401f3e7c049d1ca951b79f277cd940cb980418/third_party/blink/renderer/platform/json/json_parser.cc
[modify] https://crrev.com/8e401f3e7c049d1ca951b79f277cd940cb980418/third_party/blink/renderer/platform/json/json_values.cc
[modify] https://crrev.com/8e401f3e7c049d1ca951b79f277cd940cb980418/third_party/blink/renderer/platform/json/json_values.h
[modify] https://crrev.com/8e401f3e7c049d1ca951b79f277cd940cb980418/third_party/blink/renderer/platform/language.cc
[modify] https://crrev.com/8e401f3e7c049d1ca951b79f277cd940cb980418/third_party/blink/renderer/platform/language.h
[modify] https://crrev.com/8e401f3e7c049d1ca951b79f277cd940cb980418/third_party/blink/renderer/platform/mhtml/mhtml_archive.cc
[modify] https://crrev.com/8e401f3e7c049d1ca951b79f277cd940cb980418/third_party/blink/renderer/platform/mhtml/mhtml_parser.cc
[modify] https://crrev.com/8e401f3e7c049d1ca951b79f277cd940cb980418/third_party/blink/renderer/platform/plugins/plugin_data.cc
[modify] https://crrev.com/8e401f3e7c049d1ca951b79f277cd940cb980418/third_party/blink/renderer/platform/plugins/plugin_data.h
[modify] https://crrev.com/8e401f3e7c049d1ca951b79f277cd940cb980418/third_party/blink/renderer/platform/testing/image_decode_bench.cc
[modify] https://crrev.com/8e401f3e7c049d1ca951b79f277cd940cb980418/third_party/blink/renderer/platform/testing/test_paint_artifact.cc
[modify] https://crrev.com/8e401f3e7c049d1ca951b79f277cd940cb980418/third_party/blink/renderer/platform/testing/test_paint_artifact.h
[modify] https://crrev.com/8e401f3e7c049d1ca951b79f277cd940cb980418/third_party/blink/renderer/platform/transforms/affine_transform.cc
[modify] https://crrev.com/8e401f3e7c049d1ca951b79f277cd940cb980418/third_party/blink/renderer/platform/transforms/transform_operations.cc
[modify] https://crrev.com/8e401f3e7c049d1ca951b79f277cd940cb980418/third_party/blink/renderer/platform/transforms/transform_operations.h
[modify] https://crrev.com/8e401f3e7c049d1ca951b79f277cd940cb980418/third_party/blink/renderer/platform/waitable_event.cc
[modify] https://crrev.com/8e401f3e7c049d1ca951b79f277cd940cb980418/third_party/blink/renderer/platform/web_icon_sizes_parser.cc
[modify] https://crrev.com/8e401f3e7c049d1ca951b79f277cd940cb980418/third_party/blink/renderer/platform/weborigin/kurl.cc
[modify] https://crrev.com/8e401f3e7c049d1ca951b79f277cd940cb980418/third_party/blink/renderer/platform/wtf/dtoa.cc

Project Member

Comment 35 by bugdroid1@chromium.org, Oct 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d3c04350e194839ab4b708f8f906467dba4ecb8f

commit d3c04350e194839ab4b708f8f906467dba4ecb8f
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Fri Oct 12 15:13:41 2018

Fix 64 bit truncation errors in platform/network

Use wtf_size_t when dealing with WTF types.

BUG=879657

Change-Id: I1dd426d03ac459c627299b6a301c64f9e58002c3
Reviewed-on: https://chromium-review.googlesource.com/c/1274448
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599219}
[modify] https://crrev.com/d3c04350e194839ab4b708f8f906467dba4ecb8f/third_party/blink/renderer/core/fetch/multipart_parser.cc
[modify] https://crrev.com/d3c04350e194839ab4b708f8f906467dba4ecb8f/third_party/blink/renderer/core/loader/resource/multipart_image_resource_parser.cc
[modify] https://crrev.com/d3c04350e194839ab4b708f8f906467dba4ecb8f/third_party/blink/renderer/platform/network/encoded_form_data.cc
[modify] https://crrev.com/d3c04350e194839ab4b708f8f906467dba4ecb8f/third_party/blink/renderer/platform/network/encoded_form_data.h
[modify] https://crrev.com/d3c04350e194839ab4b708f8f906467dba4ecb8f/third_party/blink/renderer/platform/network/encoded_form_data_test.cc
[modify] https://crrev.com/d3c04350e194839ab4b708f8f906467dba4ecb8f/third_party/blink/renderer/platform/network/form_data_encoder.cc
[modify] https://crrev.com/d3c04350e194839ab4b708f8f906467dba4ecb8f/third_party/blink/renderer/platform/network/http_header_map.cc
[modify] https://crrev.com/d3c04350e194839ab4b708f8f906467dba4ecb8f/third_party/blink/renderer/platform/network/http_header_map.h
[modify] https://crrev.com/d3c04350e194839ab4b708f8f906467dba4ecb8f/third_party/blink/renderer/platform/network/http_parsers.cc
[modify] https://crrev.com/d3c04350e194839ab4b708f8f906467dba4ecb8f/third_party/blink/renderer/platform/network/http_parsers.h
[modify] https://crrev.com/d3c04350e194839ab4b708f8f906467dba4ecb8f/third_party/blink/renderer/platform/network/http_parsers_fuzzer.cc
[modify] https://crrev.com/d3c04350e194839ab4b708f8f906467dba4ecb8f/third_party/blink/renderer/platform/network/http_parsers_test.cc
[modify] https://crrev.com/d3c04350e194839ab4b708f8f906467dba4ecb8f/third_party/blink/renderer/platform/network/mime/content_type.cc
[modify] https://crrev.com/d3c04350e194839ab4b708f8f906467dba4ecb8f/third_party/blink/renderer/platform/network/mime/mime_type_from_url.cc
[modify] https://crrev.com/d3c04350e194839ab4b708f8f906467dba4ecb8f/third_party/blink/renderer/platform/network/network_state_notifier.cc
[modify] https://crrev.com/d3c04350e194839ab4b708f8f906467dba4ecb8f/third_party/blink/renderer/platform/network/network_state_notifier.h

Project Member

Comment 36 by bugdroid1@chromium.org, Oct 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/86538ae95c8a83a58b74577954f088934240a579

commit 86538ae95c8a83a58b74577954f088934240a579
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Fri Oct 12 22:41:00 2018

Fix 64 bit truncation errors in core/layout

Use wtf_size_t when dealing with WTF types.

BUG=879657

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I473e021de35dd792a5d9522bad146e38a6a334f9
Reviewed-on: https://chromium-review.googlesource.com/c/1274188
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599387}
[modify] https://crrev.com/86538ae95c8a83a58b74577954f088934240a579/third_party/blink/renderer/core/layout/layout_block_flow.cc
[modify] https://crrev.com/86538ae95c8a83a58b74577954f088934240a579/third_party/blink/renderer/core/layout/layout_flexible_box.cc
[modify] https://crrev.com/86538ae95c8a83a58b74577954f088934240a579/third_party/blink/renderer/core/layout/layout_geometry_map.cc
[modify] https://crrev.com/86538ae95c8a83a58b74577954f088934240a579/third_party/blink/renderer/core/layout/layout_geometry_map.h
[modify] https://crrev.com/86538ae95c8a83a58b74577954f088934240a579/third_party/blink/renderer/core/layout/layout_object.cc
[modify] https://crrev.com/86538ae95c8a83a58b74577954f088934240a579/third_party/blink/renderer/core/layout/layout_table.cc
[modify] https://crrev.com/86538ae95c8a83a58b74577954f088934240a579/third_party/blink/renderer/core/layout/layout_table_section.cc
[modify] https://crrev.com/86538ae95c8a83a58b74577954f088934240a579/third_party/blink/renderer/core/layout/layout_theme_default.cc
[modify] https://crrev.com/86538ae95c8a83a58b74577954f088934240a579/third_party/blink/renderer/core/layout/layout_tree_as_text.cc
[modify] https://crrev.com/86538ae95c8a83a58b74577954f088934240a579/third_party/blink/renderer/core/layout/line/breaking_context_inline_headers.h
[modify] https://crrev.com/86538ae95c8a83a58b74577954f088934240a579/third_party/blink/renderer/core/layout/line/root_inline_box.cc
[modify] https://crrev.com/86538ae95c8a83a58b74577954f088934240a579/third_party/blink/renderer/core/layout/line/trailing_objects.cc
[modify] https://crrev.com/86538ae95c8a83a58b74577954f088934240a579/third_party/blink/renderer/core/layout/multi_column_fragmentainer_group.h
[modify] https://crrev.com/86538ae95c8a83a58b74577954f088934240a579/third_party/blink/renderer/core/layout/ng/exclusions/ng_exclusion_space.cc
[modify] https://crrev.com/86538ae95c8a83a58b74577954f088934240a579/third_party/blink/renderer/core/layout/ng/exclusions/ng_exclusion_space.h
[modify] https://crrev.com/86538ae95c8a83a58b74577954f088934240a579/third_party/blink/renderer/core/layout/ng/inline/ng_inline_items_builder.cc
[modify] https://crrev.com/86538ae95c8a83a58b74577954f088934240a579/third_party/blink/renderer/core/layout/ng/inline/ng_line_box_fragment_builder.cc
[modify] https://crrev.com/86538ae95c8a83a58b74577954f088934240a579/third_party/blink/renderer/core/layout/ng/inline/ng_line_box_fragment_builder.h
[modify] https://crrev.com/86538ae95c8a83a58b74577954f088934240a579/third_party/blink/renderer/core/layout/ng/inline/ng_line_breaker.cc
[modify] https://crrev.com/86538ae95c8a83a58b74577954f088934240a579/third_party/blink/renderer/core/layout/ng/ng_block_child_iterator.h
[modify] https://crrev.com/86538ae95c8a83a58b74577954f088934240a579/third_party/blink/renderer/core/layout/ng/ng_flex_layout_algorithm.cc
[modify] https://crrev.com/86538ae95c8a83a58b74577954f088934240a579/third_party/blink/renderer/core/layout/ng/ng_fragment_builder.cc
[modify] https://crrev.com/86538ae95c8a83a58b74577954f088934240a579/third_party/blink/renderer/core/layout/scroll_anchor.cc
[modify] https://crrev.com/86538ae95c8a83a58b74577954f088934240a579/third_party/blink/renderer/core/layout/shapes/polygon_shape.cc
[modify] https://crrev.com/86538ae95c8a83a58b74577954f088934240a579/third_party/blink/renderer/core/layout/shapes/shape.cc
[modify] https://crrev.com/86538ae95c8a83a58b74577954f088934240a579/third_party/blink/renderer/core/layout/svg/svg_text_layout_attributes_builder.cc
[modify] https://crrev.com/86538ae95c8a83a58b74577954f088934240a579/third_party/blink/renderer/core/layout/svg/svg_text_query.cc
[modify] https://crrev.com/86538ae95c8a83a58b74577954f088934240a579/third_party/blink/renderer/core/layout/table_layout_algorithm_auto.cc
[modify] https://crrev.com/86538ae95c8a83a58b74577954f088934240a579/third_party/blink/renderer/core/layout/traced_layout_object.cc

Project Member

Comment 37 by bugdroid1@chromium.org, Oct 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5efc05f69bb9d2800efd18afa258bcfb3c9f8fde

commit 5efc05f69bb9d2800efd18afa258bcfb3c9f8fde
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Tue Oct 16 16:35:51 2018

Fix 64 bit truncation errors in wtf/typed_arrays

Use appropriate types for handling ArrayBuffer

BUG=879657

Change-Id: I0a46fcd98837a041c76d7b68defc06fc786b024b
Reviewed-on: https://chromium-review.googlesource.com/c/1281689
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600013}
[modify] https://crrev.com/5efc05f69bb9d2800efd18afa258bcfb3c9f8fde/third_party/blink/renderer/platform/wtf/typed_arrays/array_buffer.h
[modify] https://crrev.com/5efc05f69bb9d2800efd18afa258bcfb3c9f8fde/third_party/blink/renderer/platform/wtf/typed_arrays/array_buffer_builder.cc
[modify] https://crrev.com/5efc05f69bb9d2800efd18afa258bcfb3c9f8fde/third_party/blink/renderer/platform/wtf/typed_arrays/array_buffer_builder.h
[modify] https://crrev.com/5efc05f69bb9d2800efd18afa258bcfb3c9f8fde/third_party/blink/renderer/platform/wtf/typed_arrays/array_buffer_builder_test.cc
[modify] https://crrev.com/5efc05f69bb9d2800efd18afa258bcfb3c9f8fde/third_party/blink/renderer/platform/wtf/typed_arrays/array_buffer_contents.cc
[modify] https://crrev.com/5efc05f69bb9d2800efd18afa258bcfb3c9f8fde/third_party/blink/renderer/platform/wtf/typed_arrays/array_buffer_contents.h
[modify] https://crrev.com/5efc05f69bb9d2800efd18afa258bcfb3c9f8fde/third_party/blink/renderer/platform/wtf/typed_arrays/array_buffer_view.h
[modify] https://crrev.com/5efc05f69bb9d2800efd18afa258bcfb3c9f8fde/third_party/blink/renderer/platform/wtf/typed_arrays/array_piece.cc

Project Member

Comment 38 by bugdroid1@chromium.org, Oct 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9f852493a90b03a783298ab4673b7ae5fc5e671d

commit 9f852493a90b03a783298ab4673b7ae5fc5e671d
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Tue Oct 16 16:37:18 2018

Fix 64 bit truncation in css style builder.

Don't use an index it isn't needed.

BUG=879657

Change-Id: I798ee0f1f472515536ffd7bcbb6d4e7b37dcfbfe
Reviewed-on: https://chromium-review.googlesource.com/c/1283258
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600014}
[modify] https://crrev.com/9f852493a90b03a783298ab4673b7ae5fc5e671d/third_party/blink/renderer/build/scripts/core/css/properties/templates/style_builder_functions.tmpl

Project Member

Comment 39 by bugdroid1@chromium.org, Oct 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b276d0570cc816bfe25b431f2ee9bc265a6ad478

commit b276d0570cc816bfe25b431f2ee9bc265a6ad478
Author: Will Harris <wfh@chromium.org>
Date: Tue Oct 16 23:23:06 2018

Fix one implicit 64-bit -> 32-bit implicit conversion in a PPAPI test.

../../ppapi/tests/test_url_loader.cc:877:11: warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'int32_t' (aka 'int') [-Wshorten-64-to-32]
          total_bytes_to_be_received);
          ^~~~~~~~~~~~~~~~~~~~~~~~~~

BUG=879657

Change-Id: I152f456368131fe7a2891ff0c97bf83f26ef0906
Reviewed-on: https://chromium-review.googlesource.com/c/1220173
Commit-Queue: Raymes Khoury <raymes@chromium.org>
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600182}
[modify] https://crrev.com/b276d0570cc816bfe25b431f2ee9bc265a6ad478/ppapi/tests/test_url_loader.cc

Project Member

Comment 40 by bugdroid1@chromium.org, Oct 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/09c630aa002c6f4824df791d166b3984392ff949

commit 09c630aa002c6f4824df791d166b3984392ff949
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Thu Oct 18 17:51:31 2018

Fix 64 bit truncation issues in renderer/modules

Use wtf_size_t where appropriate.

BUG=879657

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I5c7cfc6692919d552cdee6deb681ff046177ccf7
Reviewed-on: https://chromium-review.googlesource.com/c/1287189
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600816}
[modify] https://crrev.com/09c630aa002c6f4824df791d166b3984392ff949/third_party/blink/renderer/modules/permissions/permissions.cc
[modify] https://crrev.com/09c630aa002c6f4824df791d166b3984392ff949/third_party/blink/renderer/modules/picture_in_picture/html_video_element_picture_in_picture.cc
[modify] https://crrev.com/09c630aa002c6f4824df791d166b3984392ff949/third_party/blink/renderer/modules/plugins/dom_mime_type.cc
[modify] https://crrev.com/09c630aa002c6f4824df791d166b3984392ff949/third_party/blink/renderer/modules/plugins/dom_mime_type_array.cc
[modify] https://crrev.com/09c630aa002c6f4824df791d166b3984392ff949/third_party/blink/renderer/modules/plugins/dom_plugin_array.cc
[modify] https://crrev.com/09c630aa002c6f4824df791d166b3984392ff949/third_party/blink/renderer/modules/push_messaging/push_subscription.cc
[modify] https://crrev.com/09c630aa002c6f4824df791d166b3984392ff949/third_party/blink/renderer/modules/push_messaging/push_subscription_options.cc
[modify] https://crrev.com/09c630aa002c6f4824df791d166b3984392ff949/third_party/blink/renderer/modules/remoteplayback/remote_playback.cc
[modify] https://crrev.com/09c630aa002c6f4824df791d166b3984392ff949/third_party/blink/renderer/modules/screen_orientation/screen_orientation_controller_impl.cc
[modify] https://crrev.com/09c630aa002c6f4824df791d166b3984392ff949/third_party/blink/renderer/modules/sensor/sensor_proxy_impl.cc
[modify] https://crrev.com/09c630aa002c6f4824df791d166b3984392ff949/third_party/blink/renderer/modules/service_worker/service_worker_global_scope.cc
[modify] https://crrev.com/09c630aa002c6f4824df791d166b3984392ff949/third_party/blink/renderer/modules/service_worker/service_worker_global_scope_client.cc
[modify] https://crrev.com/09c630aa002c6f4824df791d166b3984392ff949/third_party/blink/renderer/modules/service_worker/service_worker_global_scope_proxy.cc
[modify] https://crrev.com/09c630aa002c6f4824df791d166b3984392ff949/third_party/blink/renderer/modules/service_worker/service_worker_installed_scripts_manager.cc
[modify] https://crrev.com/09c630aa002c6f4824df791d166b3984392ff949/third_party/blink/renderer/modules/storage/cached_storage_area.cc
[modify] https://crrev.com/09c630aa002c6f4824df791d166b3984392ff949/third_party/blink/renderer/modules/vibration/vibration_controller.cc
[modify] https://crrev.com/09c630aa002c6f4824df791d166b3984392ff949/third_party/blink/renderer/modules/vr/vr_eye_parameters.h
[modify] https://crrev.com/09c630aa002c6f4824df791d166b3984392ff949/third_party/blink/renderer/modules/webgl/webgl2_rendering_context_base.cc
[modify] https://crrev.com/09c630aa002c6f4824df791d166b3984392ff949/third_party/blink/renderer/modules/webgl/webgl2_rendering_context_base.h
[modify] https://crrev.com/09c630aa002c6f4824df791d166b3984392ff949/third_party/blink/renderer/modules/webgl/webgl_framebuffer.cc
[modify] https://crrev.com/09c630aa002c6f4824df791d166b3984392ff949/third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.cc
[modify] https://crrev.com/09c630aa002c6f4824df791d166b3984392ff949/third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.h
[modify] https://crrev.com/09c630aa002c6f4824df791d166b3984392ff949/third_party/blink/renderer/modules/webgl/webgl_transform_feedback.cc
[modify] https://crrev.com/09c630aa002c6f4824df791d166b3984392ff949/third_party/blink/renderer/modules/webgl/webgl_vertex_array_object_base.cc
[modify] https://crrev.com/09c630aa002c6f4824df791d166b3984392ff949/third_party/blink/renderer/modules/webgl/webgl_vertex_array_object_base.h
[modify] https://crrev.com/09c630aa002c6f4824df791d166b3984392ff949/third_party/blink/renderer/modules/webmidi/midi_input.cc
[modify] https://crrev.com/09c630aa002c6f4824df791d166b3984392ff949/third_party/blink/renderer/platform/bindings/parkable_string.cc
[modify] https://crrev.com/09c630aa002c6f4824df791d166b3984392ff949/third_party/blink/renderer/platform/bindings/parkable_string.h

Project Member

Comment 41 by bugdroid1@chromium.org, Oct 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/33590bd09ea95ba9715e3d7636249170fd0ea8f8

commit 33590bd09ea95ba9715e3d7636249170fd0ea8f8
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Fri Oct 19 19:48:58 2018

Fix 64 bit truncation errors in platform/scheduler

Use appropriate types in scheduler code.

BUG=879657

Change-Id: I51e83b9fd5e6ec48706110bc4ae832d2075e89ca
Reviewed-on: https://chromium-review.googlesource.com/c/1287956
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601265}
[modify] https://crrev.com/33590bd09ea95ba9715e3d7636249170fd0ea8f8/third_party/blink/renderer/platform/scheduler/common/scheduler_helper.cc
[modify] https://crrev.com/33590bd09ea95ba9715e3d7636249170fd0ea8f8/third_party/blink/renderer/platform/scheduler/common/scheduler_helper.h
[modify] https://crrev.com/33590bd09ea95ba9715e3d7636249170fd0ea8f8/third_party/blink/renderer/platform/scheduler/common/throttling/task_queue_throttler.cc
[modify] https://crrev.com/33590bd09ea95ba9715e3d7636249170fd0ea8f8/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.cc
[modify] https://crrev.com/33590bd09ea95ba9715e3d7636249170fd0ea8f8/third_party/blink/renderer/platform/scheduler/main_thread/prioritize_compositing_after_input_experiment.cc
[modify] https://crrev.com/33590bd09ea95ba9715e3d7636249170fd0ea8f8/third_party/blink/renderer/platform/scheduler/main_thread/queueing_time_estimator.cc
[modify] https://crrev.com/33590bd09ea95ba9715e3d7636249170fd0ea8f8/third_party/blink/renderer/platform/scheduler/renderer/webthread_impl_for_renderer_scheduler_unittest.cc

Project Member

Comment 42 by bugdroid1@chromium.org, Oct 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/855ec4bc913cc66d84d94dfc00cdef282ae13b66

commit 855ec4bc913cc66d84d94dfc00cdef282ae13b66
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Fri Oct 26 15:35:41 2018

Fix 64 bit truncation issues in renderer/modules

Use wtf_size_t where appropriate.

BUG=879657

Change-Id: I26f766e7f6f29c6beaf0d396d665f1eba1235d83
Reviewed-on: https://chromium-review.googlesource.com/c/1298246
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603101}
[modify] https://crrev.com/855ec4bc913cc66d84d94dfc00cdef282ae13b66/third_party/blink/renderer/core/layout/custom/layout_worklet.h
[modify] https://crrev.com/855ec4bc913cc66d84d94dfc00cdef282ae13b66/third_party/blink/renderer/core/workers/experimental/task_worklet.cc
[modify] https://crrev.com/855ec4bc913cc66d84d94dfc00cdef282ae13b66/third_party/blink/renderer/core/workers/experimental/task_worklet.h
[modify] https://crrev.com/855ec4bc913cc66d84d94dfc00cdef282ae13b66/third_party/blink/renderer/core/workers/worklet.cc
[modify] https://crrev.com/855ec4bc913cc66d84d94dfc00cdef282ae13b66/third_party/blink/renderer/core/workers/worklet.h
[modify] https://crrev.com/855ec4bc913cc66d84d94dfc00cdef282ae13b66/third_party/blink/renderer/modules/canvas/htmlcanvas/html_canvas_element_module.cc
[modify] https://crrev.com/855ec4bc913cc66d84d94dfc00cdef282ae13b66/third_party/blink/renderer/modules/csspaint/paint_worklet.cc
[modify] https://crrev.com/855ec4bc913cc66d84d94dfc00cdef282ae13b66/third_party/blink/renderer/modules/csspaint/paint_worklet.h
[modify] https://crrev.com/855ec4bc913cc66d84d94dfc00cdef282ae13b66/third_party/blink/renderer/modules/csspaint/paint_worklet_test.cc
[modify] https://crrev.com/855ec4bc913cc66d84d94dfc00cdef282ae13b66/third_party/blink/renderer/modules/document_metadata/copyless_paste_extractor.cc
[modify] https://crrev.com/855ec4bc913cc66d84d94dfc00cdef282ae13b66/third_party/blink/renderer/modules/encoding/text_decoder.cc
[modify] https://crrev.com/855ec4bc913cc66d84d94dfc00cdef282ae13b66/third_party/blink/renderer/modules/encoding/text_decoder.h
[modify] https://crrev.com/855ec4bc913cc66d84d94dfc00cdef282ae13b66/third_party/blink/renderer/modules/encoding/text_decoder_stream.cc
[modify] https://crrev.com/855ec4bc913cc66d84d94dfc00cdef282ae13b66/third_party/blink/renderer/modules/encoding/text_encoder_stream.cc
[modify] https://crrev.com/855ec4bc913cc66d84d94dfc00cdef282ae13b66/third_party/blink/renderer/modules/encryptedmedia/media_key_session.cc
[modify] https://crrev.com/855ec4bc913cc66d84d94dfc00cdef282ae13b66/third_party/blink/renderer/modules/encryptedmedia/media_key_status_map.cc
[modify] https://crrev.com/855ec4bc913cc66d84d94dfc00cdef282ae13b66/third_party/blink/renderer/modules/encryptedmedia/media_key_status_map.h
[modify] https://crrev.com/855ec4bc913cc66d84d94dfc00cdef282ae13b66/third_party/blink/renderer/modules/encryptedmedia/media_key_system_access.cc
[modify] https://crrev.com/855ec4bc913cc66d84d94dfc00cdef282ae13b66/third_party/blink/renderer/modules/encryptedmedia/navigator_request_media_key_system_access.cc
[modify] https://crrev.com/855ec4bc913cc66d84d94dfc00cdef282ae13b66/third_party/blink/renderer/modules/mediarecorder/media_recorder.h
[modify] https://crrev.com/855ec4bc913cc66d84d94dfc00cdef282ae13b66/third_party/blink/renderer/modules/mediasource/source_buffer.h
[modify] https://crrev.com/855ec4bc913cc66d84d94dfc00cdef282ae13b66/third_party/blink/renderer/modules/mediasource/source_buffer_list.cc
[modify] https://crrev.com/855ec4bc913cc66d84d94dfc00cdef282ae13b66/third_party/blink/renderer/modules/mediasource/source_buffer_list.h
[modify] https://crrev.com/855ec4bc913cc66d84d94dfc00cdef282ae13b66/third_party/blink/renderer/modules/mediastream/media_devices.cc
[modify] https://crrev.com/855ec4bc913cc66d84d94dfc00cdef282ae13b66/third_party/blink/renderer/modules/mediastream/media_devices_test.cc
[modify] https://crrev.com/855ec4bc913cc66d84d94dfc00cdef282ae13b66/third_party/blink/renderer/modules/mediastream/media_stream.cc
[modify] https://crrev.com/855ec4bc913cc66d84d94dfc00cdef282ae13b66/third_party/blink/renderer/modules/notifications/notification_image_loader.cc
[modify] https://crrev.com/855ec4bc913cc66d84d94dfc00cdef282ae13b66/third_party/blink/renderer/modules/notifications/notification_manager.cc
[modify] https://crrev.com/855ec4bc913cc66d84d94dfc00cdef282ae13b66/third_party/blink/renderer/modules/notifications/notification_resources_loader.cc
[modify] https://crrev.com/855ec4bc913cc66d84d94dfc00cdef282ae13b66/third_party/blink/renderer/modules/notifications/notification_resources_loader.h
[modify] https://crrev.com/855ec4bc913cc66d84d94dfc00cdef282ae13b66/third_party/blink/renderer/modules/peerconnection/rtc_data_channel.cc
[modify] https://crrev.com/855ec4bc913cc66d84d94dfc00cdef282ae13b66/third_party/blink/renderer/modules/peerconnection/rtc_data_channel_test.cc
[modify] https://crrev.com/855ec4bc913cc66d84d94dfc00cdef282ae13b66/third_party/blink/renderer/modules/peerconnection/rtc_peer_connection.cc
[modify] https://crrev.com/855ec4bc913cc66d84d94dfc00cdef282ae13b66/third_party/blink/renderer/modules/peerconnection/rtc_rtp_receiver.cc
[modify] https://crrev.com/855ec4bc913cc66d84d94dfc00cdef282ae13b66/third_party/blink/renderer/modules/peerconnection/rtc_rtp_sender.cc
[modify] https://crrev.com/855ec4bc913cc66d84d94dfc00cdef282ae13b66/third_party/blink/renderer/modules/peerconnection/rtc_stats_report.cc
[modify] https://crrev.com/855ec4bc913cc66d84d94dfc00cdef282ae13b66/third_party/blink/renderer/modules/peerconnection/rtc_stats_report.h

Project Member

Comment 43 by bugdroid1@chromium.org, Nov 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/406c50b3ee296966dd8ebf88634436aa1717e7e4

commit 406c50b3ee296966dd8ebf88634436aa1717e7e4
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Tue Nov 06 15:37:24 2018

Fix 64 bit truncation warnings in renderer/core/fetch.

Use appropriate types in fetch code.

BUG=879657

Change-Id: I7f26d8a6651abafbb185193cc2670bcdb5eff05e
Reviewed-on: https://chromium-review.googlesource.com/c/1298329
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605685}
[modify] https://crrev.com/406c50b3ee296966dd8ebf88634436aa1717e7e4/third_party/blink/renderer/core/fetch/body_stream_buffer.cc
[modify] https://crrev.com/406c50b3ee296966dd8ebf88634436aa1717e7e4/third_party/blink/renderer/core/fetch/bytes_consumer.cc
[modify] https://crrev.com/406c50b3ee296966dd8ebf88634436aa1717e7e4/third_party/blink/renderer/core/fetch/bytes_consumer_test_util.cc
[modify] https://crrev.com/406c50b3ee296966dd8ebf88634436aa1717e7e4/third_party/blink/renderer/core/fetch/bytes_consumer_test_util.h
[modify] https://crrev.com/406c50b3ee296966dd8ebf88634436aa1717e7e4/third_party/blink/renderer/core/fetch/data_consumer_handle_test_util.h
[modify] https://crrev.com/406c50b3ee296966dd8ebf88634436aa1717e7e4/third_party/blink/renderer/core/fetch/fetch_data_loader.cc
[modify] https://crrev.com/406c50b3ee296966dd8ebf88634436aa1717e7e4/third_party/blink/renderer/core/fetch/fetch_manager.cc
[modify] https://crrev.com/406c50b3ee296966dd8ebf88634436aa1717e7e4/third_party/blink/renderer/core/fetch/fetch_response_data.cc
[modify] https://crrev.com/406c50b3ee296966dd8ebf88634436aa1717e7e4/third_party/blink/renderer/core/fetch/form_data_bytes_consumer.cc
[modify] https://crrev.com/406c50b3ee296966dd8ebf88634436aa1717e7e4/third_party/blink/renderer/core/fetch/form_data_bytes_consumer.h
[modify] https://crrev.com/406c50b3ee296966dd8ebf88634436aa1717e7e4/third_party/blink/renderer/core/fetch/headers.cc
[modify] https://crrev.com/406c50b3ee296966dd8ebf88634436aa1717e7e4/third_party/blink/renderer/core/fetch/multipart_parser.cc
[modify] https://crrev.com/406c50b3ee296966dd8ebf88634436aa1717e7e4/third_party/blink/renderer/core/fetch/multipart_parser_test.cc

Project Member

Comment 44 by bugdroid1@chromium.org, Nov 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a97710c54719affd2bb84e406c6fa8e1904585a9

commit a97710c54719affd2bb84e406c6fa8e1904585a9
Author: Dmitry Titov <dimich@chromium.org>
Date: Tue Nov 06 22:33:24 2018

Revert "Fix 64 bit truncation warnings in renderer/core/fetch."

This reverts commit 406c50b3ee296966dd8ebf88634436aa1717e7e4.

Reason for revert: Speculative revert to fix the test external/wpt/workers/semantics/structured-clone/shared.html

first started to fail in build: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20%28dbg%29%281%29/75530

If this won't fix the test, I'll reland the patch.

Original change's description:
> Fix 64 bit truncation warnings in renderer/core/fetch.
> 
> Use appropriate types in fetch code.
> 
> BUG=879657
> 
> Change-Id: I7f26d8a6651abafbb185193cc2670bcdb5eff05e
> Reviewed-on: https://chromium-review.googlesource.com/c/1298329
> Reviewed-by: David Bokan <bokan@chromium.org>
> Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#605685}

TBR=bokan@chromium.org,dtapuska@chromium.org

Change-Id: I36f8751112daf958ef849549b2c94a57c297ab8f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 879657
Reviewed-on: https://chromium-review.googlesource.com/c/1321251
Reviewed-by: Dmitry Titov <dimich@chromium.org>
Commit-Queue: Dmitry Titov <dimich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605855}
[modify] https://crrev.com/a97710c54719affd2bb84e406c6fa8e1904585a9/third_party/blink/renderer/core/fetch/body_stream_buffer.cc
[modify] https://crrev.com/a97710c54719affd2bb84e406c6fa8e1904585a9/third_party/blink/renderer/core/fetch/bytes_consumer.cc
[modify] https://crrev.com/a97710c54719affd2bb84e406c6fa8e1904585a9/third_party/blink/renderer/core/fetch/bytes_consumer_test_util.cc
[modify] https://crrev.com/a97710c54719affd2bb84e406c6fa8e1904585a9/third_party/blink/renderer/core/fetch/bytes_consumer_test_util.h
[modify] https://crrev.com/a97710c54719affd2bb84e406c6fa8e1904585a9/third_party/blink/renderer/core/fetch/data_consumer_handle_test_util.h
[modify] https://crrev.com/a97710c54719affd2bb84e406c6fa8e1904585a9/third_party/blink/renderer/core/fetch/fetch_data_loader.cc
[modify] https://crrev.com/a97710c54719affd2bb84e406c6fa8e1904585a9/third_party/blink/renderer/core/fetch/fetch_manager.cc
[modify] https://crrev.com/a97710c54719affd2bb84e406c6fa8e1904585a9/third_party/blink/renderer/core/fetch/fetch_response_data.cc
[modify] https://crrev.com/a97710c54719affd2bb84e406c6fa8e1904585a9/third_party/blink/renderer/core/fetch/form_data_bytes_consumer.cc
[modify] https://crrev.com/a97710c54719affd2bb84e406c6fa8e1904585a9/third_party/blink/renderer/core/fetch/form_data_bytes_consumer.h
[modify] https://crrev.com/a97710c54719affd2bb84e406c6fa8e1904585a9/third_party/blink/renderer/core/fetch/headers.cc
[modify] https://crrev.com/a97710c54719affd2bb84e406c6fa8e1904585a9/third_party/blink/renderer/core/fetch/multipart_parser.cc
[modify] https://crrev.com/a97710c54719affd2bb84e406c6fa8e1904585a9/third_party/blink/renderer/core/fetch/multipart_parser_test.cc

Project Member

Comment 45 by bugdroid1@chromium.org, Nov 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/24ffcf2eca9a1428d575643aae0f236a022429f8

commit 24ffcf2eca9a1428d575643aae0f236a022429f8
Author: Dmitry Titov <dimich@chromium.org>
Date: Wed Nov 07 01:04:17 2018

Reland "Fix 64 bit truncation warnings in renderer/core/fetch."

This reverts commit a97710c54719affd2bb84e406c6fa8e1904585a9.

Reason for revert: Reland the original change, since speculative revert did not fix the failing test. 

Original change's description:
> Revert "Fix 64 bit truncation warnings in renderer/core/fetch."
> 
> This reverts commit 406c50b3ee296966dd8ebf88634436aa1717e7e4.
> 
> Reason for revert: Speculative revert to fix the test external/wpt/workers/semantics/structured-clone/shared.html
> 
> first started to fail in build: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20%28dbg%29%281%29/75530
> 
> If this won't fix the test, I'll reland the patch.
> 
> Original change's description:
> > Fix 64 bit truncation warnings in renderer/core/fetch.
> > 
> > Use appropriate types in fetch code.
> > 
> > BUG=879657
> > 
> > Change-Id: I7f26d8a6651abafbb185193cc2670bcdb5eff05e
> > Reviewed-on: https://chromium-review.googlesource.com/c/1298329
> > Reviewed-by: David Bokan <bokan@chromium.org>
> > Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#605685}
> 
> TBR=bokan@chromium.org,dtapuska@chromium.org
> 
> Change-Id: I36f8751112daf958ef849549b2c94a57c297ab8f
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 879657
> Reviewed-on: https://chromium-review.googlesource.com/c/1321251
> Reviewed-by: Dmitry Titov <dimich@chromium.org>
> Commit-Queue: Dmitry Titov <dimich@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#605855}

TBR=bokan@chromium.org,dimich@chromium.org,dtapuska@chromium.org

Change-Id: I30b8ce404b5abb5450d0762598a5332d761c3c62
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 879657
Reviewed-on: https://chromium-review.googlesource.com/c/1321855
Reviewed-by: Dmitry Titov <dimich@chromium.org>
Commit-Queue: Dmitry Titov <dimich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605904}
[modify] https://crrev.com/24ffcf2eca9a1428d575643aae0f236a022429f8/third_party/blink/renderer/core/fetch/body_stream_buffer.cc
[modify] https://crrev.com/24ffcf2eca9a1428d575643aae0f236a022429f8/third_party/blink/renderer/core/fetch/bytes_consumer.cc
[modify] https://crrev.com/24ffcf2eca9a1428d575643aae0f236a022429f8/third_party/blink/renderer/core/fetch/bytes_consumer_test_util.cc
[modify] https://crrev.com/24ffcf2eca9a1428d575643aae0f236a022429f8/third_party/blink/renderer/core/fetch/bytes_consumer_test_util.h
[modify] https://crrev.com/24ffcf2eca9a1428d575643aae0f236a022429f8/third_party/blink/renderer/core/fetch/data_consumer_handle_test_util.h
[modify] https://crrev.com/24ffcf2eca9a1428d575643aae0f236a022429f8/third_party/blink/renderer/core/fetch/fetch_data_loader.cc
[modify] https://crrev.com/24ffcf2eca9a1428d575643aae0f236a022429f8/third_party/blink/renderer/core/fetch/fetch_manager.cc
[modify] https://crrev.com/24ffcf2eca9a1428d575643aae0f236a022429f8/third_party/blink/renderer/core/fetch/fetch_response_data.cc
[modify] https://crrev.com/24ffcf2eca9a1428d575643aae0f236a022429f8/third_party/blink/renderer/core/fetch/form_data_bytes_consumer.cc
[modify] https://crrev.com/24ffcf2eca9a1428d575643aae0f236a022429f8/third_party/blink/renderer/core/fetch/form_data_bytes_consumer.h
[modify] https://crrev.com/24ffcf2eca9a1428d575643aae0f236a022429f8/third_party/blink/renderer/core/fetch/headers.cc
[modify] https://crrev.com/24ffcf2eca9a1428d575643aae0f236a022429f8/third_party/blink/renderer/core/fetch/multipart_parser.cc
[modify] https://crrev.com/24ffcf2eca9a1428d575643aae0f236a022429f8/third_party/blink/renderer/core/fetch/multipart_parser_test.cc

Project Member

Comment 46 by bugdroid1@chromium.org, Nov 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e7eed439e2a52806e9cbaf2408d776ff48be19b6

commit e7eed439e2a52806e9cbaf2408d776ff48be19b6
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Wed Nov 14 18:08:50 2018

Fix 64 bit truncations in core/loader

Use appropriate types in loader code.

BUG=879657

Change-Id: I3d94d7a6d6b3dce98792f4bf055a871f49d5a2da
Reviewed-on: https://chromium-review.googlesource.com/c/1332507
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608032}
[modify] https://crrev.com/e7eed439e2a52806e9cbaf2408d776ff48be19b6/third_party/blink/renderer/core/loader/document_loader.cc
[modify] https://crrev.com/e7eed439e2a52806e9cbaf2408d776ff48be19b6/third_party/blink/renderer/core/loader/modulescript/module_tree_linker.cc
[modify] https://crrev.com/e7eed439e2a52806e9cbaf2408d776ff48be19b6/third_party/blink/renderer/core/loader/resource/image_resource.cc
[modify] https://crrev.com/e7eed439e2a52806e9cbaf2408d776ff48be19b6/third_party/blink/renderer/core/loader/resource/image_resource_content.cc
[modify] https://crrev.com/e7eed439e2a52806e9cbaf2408d776ff48be19b6/third_party/blink/renderer/core/loader/resource/image_resource_test.cc
[modify] https://crrev.com/e7eed439e2a52806e9cbaf2408d776ff48be19b6/third_party/blink/renderer/core/loader/resource/multipart_image_resource_parser.cc
[modify] https://crrev.com/e7eed439e2a52806e9cbaf2408d776ff48be19b6/third_party/blink/renderer/core/loader/resource/multipart_image_resource_parser.h
[modify] https://crrev.com/e7eed439e2a52806e9cbaf2408d776ff48be19b6/third_party/blink/renderer/core/loader/resource/multipart_image_resource_parser_test.cc
[modify] https://crrev.com/e7eed439e2a52806e9cbaf2408d776ff48be19b6/third_party/blink/renderer/core/loader/threadable_loader.cc

Project Member

Comment 47 by bugdroid1@chromium.org, Nov 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/16ca82fc1c31330e9cc73bb35b7e9bd711c6684f

commit 16ca82fc1c31330e9cc73bb35b7e9bd711c6684f
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Thu Nov 22 15:54:59 2018

Fix 64 bit narrowing issues on string16_mojom_traits

Ensure that we don't truncate a size_t to a uint32_t without checking
ranges.

BUG=879657

Change-Id: I52d06db4f87d88de367992fe7af7ed1feff08b93
Reviewed-on: https://chromium-review.googlesource.com/c/1347066
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610426}
[modify] https://crrev.com/16ca82fc1c31330e9cc73bb35b7e9bd711c6684f/third_party/blink/renderer/platform/mojo/string16_mojom_traits.cc

Project Member

Comment 48 by bugdroid1@chromium.org, Nov 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a283e03fd54d1030e6a9bf9e4b951e3a8fabdabb

commit a283e03fd54d1030e6a9bf9e4b951e3a8fabdabb
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Thu Nov 22 17:37:06 2018

Fix 64 bit truncation errors in platform/loader

Use appropriate types in loader code.

BUG=879657

Change-Id: I43da64c50b4dcdb2cd47a4b6ed45ecd7d87d15fb
Reviewed-on: https://chromium-review.googlesource.com/c/1330352
Reviewed-by: Nate Chapin <japhet@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610454}
[modify] https://crrev.com/a283e03fd54d1030e6a9bf9e4b951e3a8fabdabb/third_party/blink/renderer/core/loader/frame_fetch_context.cc
[modify] https://crrev.com/a283e03fd54d1030e6a9bf9e4b951e3a8fabdabb/third_party/blink/renderer/core/loader/frame_fetch_context.h
[modify] https://crrev.com/a283e03fd54d1030e6a9bf9e4b951e3a8fabdabb/third_party/blink/renderer/core/loader/worker_fetch_context.cc
[modify] https://crrev.com/a283e03fd54d1030e6a9bf9e4b951e3a8fabdabb/third_party/blink/renderer/core/loader/worker_fetch_context.h
[modify] https://crrev.com/a283e03fd54d1030e6a9bf9e4b951e3a8fabdabb/third_party/blink/renderer/platform/loader/cors/cors_error_string.cc
[modify] https://crrev.com/a283e03fd54d1030e6a9bf9e4b951e3a8fabdabb/third_party/blink/renderer/platform/loader/fetch/buffering_data_pipe_writer.h
[modify] https://crrev.com/a283e03fd54d1030e6a9bf9e4b951e3a8fabdabb/third_party/blink/renderer/platform/loader/fetch/buffering_data_pipe_writer_test.cc
[modify] https://crrev.com/a283e03fd54d1030e6a9bf9e4b951e3a8fabdabb/third_party/blink/renderer/platform/loader/fetch/cached_metadata.cc
[modify] https://crrev.com/a283e03fd54d1030e6a9bf9e4b951e3a8fabdabb/third_party/blink/renderer/platform/loader/fetch/cached_metadata.h
[modify] https://crrev.com/a283e03fd54d1030e6a9bf9e4b951e3a8fabdabb/third_party/blink/renderer/platform/loader/fetch/fetch_context.cc
[modify] https://crrev.com/a283e03fd54d1030e6a9bf9e4b951e3a8fabdabb/third_party/blink/renderer/platform/loader/fetch/fetch_context.h
[modify] https://crrev.com/a283e03fd54d1030e6a9bf9e4b951e3a8fabdabb/third_party/blink/renderer/platform/loader/fetch/raw_resource.cc
[modify] https://crrev.com/a283e03fd54d1030e6a9bf9e4b951e3a8fabdabb/third_party/blink/renderer/platform/loader/fetch/raw_resource_test.cc
[modify] https://crrev.com/a283e03fd54d1030e6a9bf9e4b951e3a8fabdabb/third_party/blink/renderer/platform/loader/fetch/resource.cc
[modify] https://crrev.com/a283e03fd54d1030e6a9bf9e4b951e3a8fabdabb/third_party/blink/renderer/platform/loader/fetch/resource.h
[modify] https://crrev.com/a283e03fd54d1030e6a9bf9e4b951e3a8fabdabb/third_party/blink/renderer/platform/loader/fetch/resource_client_walker.h
[modify] https://crrev.com/a283e03fd54d1030e6a9bf9e4b951e3a8fabdabb/third_party/blink/renderer/platform/loader/fetch/resource_fetcher.cc
[modify] https://crrev.com/a283e03fd54d1030e6a9bf9e4b951e3a8fabdabb/third_party/blink/renderer/platform/loader/fetch/resource_load_scheduler.cc
[modify] https://crrev.com/a283e03fd54d1030e6a9bf9e4b951e3a8fabdabb/third_party/blink/renderer/platform/loader/fetch/resource_loader.cc
[modify] https://crrev.com/a283e03fd54d1030e6a9bf9e4b951e3a8fabdabb/third_party/blink/renderer/platform/loader/fetch/resource_response.cc
[modify] https://crrev.com/a283e03fd54d1030e6a9bf9e4b951e3a8fabdabb/third_party/blink/renderer/platform/loader/fetch/resource_response.h
[modify] https://crrev.com/a283e03fd54d1030e6a9bf9e4b951e3a8fabdabb/third_party/blink/renderer/platform/loader/fetch/source_keyed_cached_metadata_handler.cc
[modify] https://crrev.com/a283e03fd54d1030e6a9bf9e4b951e3a8fabdabb/third_party/blink/renderer/platform/loader/fetch/source_keyed_cached_metadata_handler_test.cc
[modify] https://crrev.com/a283e03fd54d1030e6a9bf9e4b951e3a8fabdabb/third_party/blink/renderer/platform/loader/link_header.h
[modify] https://crrev.com/a283e03fd54d1030e6a9bf9e4b951e3a8fabdabb/third_party/blink/renderer/platform/loader/subresource_integrity.cc
[modify] https://crrev.com/a283e03fd54d1030e6a9bf9e4b951e3a8fabdabb/third_party/blink/renderer/platform/loader/testing/mock_resource.cc

Project Member

Comment 49 by bugdroid1@chromium.org, Nov 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c9b870ccd060cd4c869a4251bfc81cbea2ad160f

commit c9b870ccd060cd4c869a4251bfc81cbea2ad160f
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Thu Nov 22 18:11:23 2018

Fix 64 bit narrowing issues in mediastream.

Use appropriate types instead of size_t.

BUG=879657

Change-Id: I5372e622570dbfed1628e6a1c70882ed85a17b51
Reviewed-on: https://chromium-review.googlesource.com/c/1347431
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610464}
[modify] https://crrev.com/c9b870ccd060cd4c869a4251bfc81cbea2ad160f/third_party/blink/renderer/platform/mediastream/media_stream_center.cc
[modify] https://crrev.com/c9b870ccd060cd4c869a4251bfc81cbea2ad160f/third_party/blink/renderer/platform/mediastream/media_stream_component.cc
[modify] https://crrev.com/c9b870ccd060cd4c869a4251bfc81cbea2ad160f/third_party/blink/renderer/platform/mediastream/media_stream_descriptor.cc
[modify] https://crrev.com/c9b870ccd060cd4c869a4251bfc81cbea2ad160f/third_party/blink/renderer/platform/mediastream/media_stream_source.cc
[modify] https://crrev.com/c9b870ccd060cd4c869a4251bfc81cbea2ad160f/third_party/blink/renderer/platform/mediastream/media_stream_web_audio_source.cc

Project Member

Comment 50 by bugdroid1@chromium.org, Nov 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ae471b4b1a28dd96154ff1f6476c5a0007aa717c

commit ae471b4b1a28dd96154ff1f6476c5a0007aa717c
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Fri Nov 23 14:14:10 2018

Fix 64 bit truncation in notifications module.

maxActions is defined in the IDL as a 32 bit integer, return it as such.

BUG=879657

Change-Id: If389a010dc5b098095b95674ef017742e787da52
Reviewed-on: https://chromium-review.googlesource.com/c/1348867
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610597}
[modify] https://crrev.com/ae471b4b1a28dd96154ff1f6476c5a0007aa717c/third_party/blink/renderer/modules/notifications/notification.cc
[modify] https://crrev.com/ae471b4b1a28dd96154ff1f6476c5a0007aa717c/third_party/blink/renderer/modules/notifications/notification.h

Project Member

Comment 51 by bugdroid1@chromium.org, Nov 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb2e15dbbc6aee53bbbfcb86b9f44dd30f659b53

commit fb2e15dbbc6aee53bbbfcb86b9f44dd30f659b53
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Fri Nov 23 15:49:01 2018

Avoid 64 bit truncation errors from the compiler for hash

While not possible the compiler still generates errors without
casts.

BUG=879657

Change-Id: I1975197135c8ab2bd0723360180d851b8be17e93
Reviewed-on: https://chromium-review.googlesource.com/c/1348954
Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610615}
[modify] https://crrev.com/fb2e15dbbc6aee53bbbfcb86b9f44dd30f659b53/base/hash.h

Project Member

Comment 52 by bugdroid1@chromium.org, Nov 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/652678d2ba31cc07668502004841d604870d69ff

commit 652678d2ba31cc07668502004841d604870d69ff
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Fri Nov 23 16:53:23 2018

Change insertId to be int64_t to match the sqlite API.

This avoids a possible truncation warning.

BUG=879657

Change-Id: I533c053523c8ade81bb54b55071d4d509e834cbb
Reviewed-on: https://chromium-review.googlesource.com/c/1348970
Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610636}
[modify] https://crrev.com/652678d2ba31cc07668502004841d604870d69ff/third_party/blink/renderer/modules/webdatabase/sql_result_set.idl

Project Member

Comment 53 by bugdroid1@chromium.org, Nov 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fab1525987527e98b1f5d1aceba9dcd38a4cc535

commit fab1525987527e98b1f5d1aceba9dcd38a4cc535
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Fri Nov 23 18:01:33 2018

Fix 64 bit truncation errors in modules

Use wtf_size_t as opposed to size_t

BUG=879657

Change-Id: If00143969f0c18bbfb54b6b602e5b915e756dd3b
Reviewed-on: https://chromium-review.googlesource.com/c/1349750
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610647}
[modify] https://crrev.com/fab1525987527e98b1f5d1aceba9dcd38a4cc535/third_party/blink/renderer/modules/accessibility/ax_object.cc
[modify] https://crrev.com/fab1525987527e98b1f5d1aceba9dcd38a4cc535/third_party/blink/renderer/modules/animationworklet/worklet_animation.cc
[modify] https://crrev.com/fab1525987527e98b1f5d1aceba9dcd38a4cc535/third_party/blink/renderer/modules/indexeddb/web_idb_database_impl.cc
[modify] https://crrev.com/fab1525987527e98b1f5d1aceba9dcd38a4cc535/third_party/blink/renderer/modules/speech/speech_synthesis.cc
[modify] https://crrev.com/fab1525987527e98b1f5d1aceba9dcd38a4cc535/third_party/blink/renderer/modules/speech/speech_synthesis.h
[modify] https://crrev.com/fab1525987527e98b1f5d1aceba9dcd38a4cc535/third_party/blink/renderer/modules/webaudio/deferred_task_handler.cc
[modify] https://crrev.com/fab1525987527e98b1f5d1aceba9dcd38a4cc535/third_party/blink/renderer/modules/webaudio/iir_filter_node.cc
[modify] https://crrev.com/fab1525987527e98b1f5d1aceba9dcd38a4cc535/third_party/blink/renderer/modules/webaudio/wave_shaper_processor.cc
[modify] https://crrev.com/fab1525987527e98b1f5d1aceba9dcd38a4cc535/third_party/blink/renderer/modules/webaudio/wave_shaper_processor.h
[modify] https://crrev.com/fab1525987527e98b1f5d1aceba9dcd38a4cc535/third_party/blink/renderer/modules/webdatabase/inspector_database_agent.cc

Project Member

Comment 54 by bugdroid1@chromium.org, Nov 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/864591fc8376e5aa0b2bd71c7e7e23b062a23530

commit 864591fc8376e5aa0b2bd71c7e7e23b062a23530
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Mon Nov 26 02:33:12 2018

Fix 64 bit truncations in blink

Use appropriate types where necessary.

BUG=879657

Change-Id: Ib20ac7132628cfaac37a57059be3c894f3fc41c2
Reviewed-on: https://chromium-review.googlesource.com/c/1349467
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610751}
[modify] https://crrev.com/864591fc8376e5aa0b2bd71c7e7e23b062a23530/third_party/blink/renderer/core/imagebitmap/image_bitmap.cc
[modify] https://crrev.com/864591fc8376e5aa0b2bd71c7e7e23b062a23530/third_party/blink/renderer/core/imagebitmap/image_bitmap.h
[modify] https://crrev.com/864591fc8376e5aa0b2bd71c7e7e23b062a23530/third_party/blink/renderer/core/loader/resource/image_resource_content.cc
[modify] https://crrev.com/864591fc8376e5aa0b2bd71c7e7e23b062a23530/third_party/blink/renderer/core/xmlhttprequest/xml_http_request.h
[modify] https://crrev.com/864591fc8376e5aa0b2bd71c7e7e23b062a23530/third_party/blink/renderer/modules/peerconnection/rtc_stats_report.cc
[modify] https://crrev.com/864591fc8376e5aa0b2bd71c7e7e23b062a23530/third_party/blink/renderer/modules/webdatabase/database.h
[modify] https://crrev.com/864591fc8376e5aa0b2bd71c7e7e23b062a23530/third_party/blink/renderer/modules/webusb/usb_device.cc

Project Member

Comment 55 by bugdroid1@chromium.org, Nov 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9bddb3ff9713b9eb960ec7cf294be2f8ba485d55

commit 9bddb3ff9713b9eb960ec7cf294be2f8ba485d55
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Mon Nov 26 17:39:17 2018

Fix 64 bit truncation errors in mojo WTF traits.

Cast or use appropriate type where applicable.

BUG=879657

Change-Id: I94f2a425e14281978bce8bfaf256f69b90af7bda
Reviewed-on: https://chromium-review.googlesource.com/c/1347047
Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610874}
[modify] https://crrev.com/9bddb3ff9713b9eb960ec7cf294be2f8ba485d55/mojo/public/cpp/bindings/array_traits_wtf_vector.h
[modify] https://crrev.com/9bddb3ff9713b9eb960ec7cf294be2f8ba485d55/mojo/public/cpp/bindings/lib/wtf_clone_equals_util.h
[modify] https://crrev.com/9bddb3ff9713b9eb960ec7cf294be2f8ba485d55/mojo/public/cpp/bindings/lib/wtf_hash_util.h

Project Member

Comment 56 by bugdroid1@chromium.org, Nov 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc49bd8897e3ee42de837d2f556544f32cae908f

commit bc49bd8897e3ee42de837d2f556544f32cae908f
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Mon Nov 26 18:17:03 2018

Fix 64 bit truncations in indexdb

Cursor advance IDL didn't match the C++ code for types. Make them match.

BUG=879657

Change-Id: I5248e1e40aa35ef471e62d818eafe9c335d82b3f
Reviewed-on: https://chromium-review.googlesource.com/c/1348866
Reviewed-by: Chris Mumford <cmumford@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610891}
[modify] https://crrev.com/bc49bd8897e3ee42de837d2f556544f32cae908f/third_party/blink/renderer/modules/indexeddb/indexed_db_blink_mojom_traits.cc
[modify] https://crrev.com/bc49bd8897e3ee42de837d2f556544f32cae908f/third_party/blink/renderer/modules/indexeddb/web_idb_cursor.h
[modify] https://crrev.com/bc49bd8897e3ee42de837d2f556544f32cae908f/third_party/blink/renderer/modules/indexeddb/web_idb_cursor_impl.cc
[modify] https://crrev.com/bc49bd8897e3ee42de837d2f556544f32cae908f/third_party/blink/renderer/modules/indexeddb/web_idb_cursor_impl.h

Project Member

Comment 57 by bugdroid1@chromium.org, Nov 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/684226f4279b2ea79f72f43994878af4086bbdfc

commit 684226f4279b2ea79f72f43994878af4086bbdfc
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Tue Nov 27 18:06:25 2018

Adjust Paint Chunks to use wtf_size_t

API was using 64 bit integers which caused narrowing to access the arrays.
Adjust the paint chunk API to use the correct type.

BUG=879657

Change-Id: Ibbe16bd43937788fe3a706773826570e0626eb80
Reviewed-on: https://chromium-review.googlesource.com/c/1348989
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611186}
[modify] https://crrev.com/684226f4279b2ea79f72f43994878af4086bbdfc/third_party/blink/renderer/platform/graphics/compositing/paint_artifact_compositor.cc
[modify] https://crrev.com/684226f4279b2ea79f72f43994878af4086bbdfc/third_party/blink/renderer/platform/graphics/compositing/paint_artifact_compositor.h
[modify] https://crrev.com/684226f4279b2ea79f72f43994878af4086bbdfc/third_party/blink/renderer/platform/graphics/compositing/paint_artifact_compositor_test.cc
[modify] https://crrev.com/684226f4279b2ea79f72f43994878af4086bbdfc/third_party/blink/renderer/platform/graphics/paint/paint_artifact.h
[modify] https://crrev.com/684226f4279b2ea79f72f43994878af4086bbdfc/third_party/blink/renderer/platform/graphics/paint/paint_chunk_subset.h
[modify] https://crrev.com/684226f4279b2ea79f72f43994878af4086bbdfc/third_party/blink/renderer/platform/graphics/paint/paint_chunker.h

Project Member

Comment 58 by bugdroid1@chromium.org, Nov 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef6017ef566426cee5f6d7e6a3d8256a35594c1c

commit ef6017ef566426cee5f6d7e6a3d8256a35594c1c
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Tue Nov 27 22:22:06 2018

Fix some 64 bit truncations in webaudio.

Channel count in the IDL is a 32 bit integer. Ensure we use that
and not a 64 bit integer in C++.

BUG=879657

Change-Id: I6415d2d0965f8b4dbd2aa79d831ef8dfc1f49038
Reviewed-on: https://chromium-review.googlesource.com/c/1348969
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611370}
[modify] https://crrev.com/ef6017ef566426cee5f6d7e6a3d8256a35594c1c/third_party/blink/renderer/modules/webaudio/audio_destination_node.cc
[modify] https://crrev.com/ef6017ef566426cee5f6d7e6a3d8256a35594c1c/third_party/blink/renderer/modules/webaudio/audio_destination_node.h
[modify] https://crrev.com/ef6017ef566426cee5f6d7e6a3d8256a35594c1c/third_party/blink/renderer/modules/webaudio/audio_node.cc
[modify] https://crrev.com/ef6017ef566426cee5f6d7e6a3d8256a35594c1c/third_party/blink/renderer/modules/webaudio/audio_node.h
[modify] https://crrev.com/ef6017ef566426cee5f6d7e6a3d8256a35594c1c/third_party/blink/renderer/modules/webaudio/audio_param_map.h
[modify] https://crrev.com/ef6017ef566426cee5f6d7e6a3d8256a35594c1c/third_party/blink/renderer/modules/webaudio/channel_merger_node.cc
[modify] https://crrev.com/ef6017ef566426cee5f6d7e6a3d8256a35594c1c/third_party/blink/renderer/modules/webaudio/channel_merger_node.h
[modify] https://crrev.com/ef6017ef566426cee5f6d7e6a3d8256a35594c1c/third_party/blink/renderer/modules/webaudio/channel_splitter_node.cc
[modify] https://crrev.com/ef6017ef566426cee5f6d7e6a3d8256a35594c1c/third_party/blink/renderer/modules/webaudio/channel_splitter_node.h
[modify] https://crrev.com/ef6017ef566426cee5f6d7e6a3d8256a35594c1c/third_party/blink/renderer/modules/webaudio/convolver_node.cc
[modify] https://crrev.com/ef6017ef566426cee5f6d7e6a3d8256a35594c1c/third_party/blink/renderer/modules/webaudio/convolver_node.h
[modify] https://crrev.com/ef6017ef566426cee5f6d7e6a3d8256a35594c1c/third_party/blink/renderer/modules/webaudio/default_audio_destination_node.cc
[modify] https://crrev.com/ef6017ef566426cee5f6d7e6a3d8256a35594c1c/third_party/blink/renderer/modules/webaudio/default_audio_destination_node.h
[modify] https://crrev.com/ef6017ef566426cee5f6d7e6a3d8256a35594c1c/third_party/blink/renderer/modules/webaudio/dynamics_compressor_node.cc
[modify] https://crrev.com/ef6017ef566426cee5f6d7e6a3d8256a35594c1c/third_party/blink/renderer/modules/webaudio/dynamics_compressor_node.h
[modify] https://crrev.com/ef6017ef566426cee5f6d7e6a3d8256a35594c1c/third_party/blink/renderer/modules/webaudio/media_stream_audio_destination_node.cc
[modify] https://crrev.com/ef6017ef566426cee5f6d7e6a3d8256a35594c1c/third_party/blink/renderer/modules/webaudio/media_stream_audio_destination_node.h
[modify] https://crrev.com/ef6017ef566426cee5f6d7e6a3d8256a35594c1c/third_party/blink/renderer/modules/webaudio/offline_audio_context.cc
[modify] https://crrev.com/ef6017ef566426cee5f6d7e6a3d8256a35594c1c/third_party/blink/renderer/modules/webaudio/offline_audio_context.h
[modify] https://crrev.com/ef6017ef566426cee5f6d7e6a3d8256a35594c1c/third_party/blink/renderer/modules/webaudio/offline_audio_destination_node.cc
[modify] https://crrev.com/ef6017ef566426cee5f6d7e6a3d8256a35594c1c/third_party/blink/renderer/modules/webaudio/offline_audio_destination_node.h
[modify] https://crrev.com/ef6017ef566426cee5f6d7e6a3d8256a35594c1c/third_party/blink/renderer/modules/webaudio/panner_node.cc
[modify] https://crrev.com/ef6017ef566426cee5f6d7e6a3d8256a35594c1c/third_party/blink/renderer/modules/webaudio/panner_node.h
[modify] https://crrev.com/ef6017ef566426cee5f6d7e6a3d8256a35594c1c/third_party/blink/renderer/modules/webaudio/script_processor_node.cc
[modify] https://crrev.com/ef6017ef566426cee5f6d7e6a3d8256a35594c1c/third_party/blink/renderer/modules/webaudio/script_processor_node.h
[modify] https://crrev.com/ef6017ef566426cee5f6d7e6a3d8256a35594c1c/third_party/blink/renderer/modules/webaudio/stereo_panner_node.cc
[modify] https://crrev.com/ef6017ef566426cee5f6d7e6a3d8256a35594c1c/third_party/blink/renderer/modules/webaudio/stereo_panner_node.h

Project Member

Comment 59 by bugdroid1@chromium.org, Nov 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c03896d17d5940370022cf73bf21b887635ca6e

commit 2c03896d17d5940370022cf73bf21b887635ca6e
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Tue Nov 27 22:30:37 2018

Fix 64 bit truncation on display_item.h

Assign the derived size after the SECURITY_DCHECKS to make it clear
we never expect this to exceed the size reserved.

BUG=879657

Change-Id: I1bb9f8724b9605499286935002a45508e58f2b04
Reviewed-on: https://chromium-review.googlesource.com/c/1347577
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611381}
[modify] https://crrev.com/2c03896d17d5940370022cf73bf21b887635ca6e/third_party/blink/renderer/platform/graphics/paint/display_item.h

Project Member

Comment 60 by bugdroid1@chromium.org, Nov 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ab3cf25a23f0309984a32bc9ba4804e108aea7f

commit 3ab3cf25a23f0309984a32bc9ba4804e108aea7f
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Wed Nov 28 15:16:09 2018

Fix 64 bit truncations in webaudio related to channels.

Channels are uint32_t in the javascript API there is no need for them
to be index as 64 bit integers.

BUG=879657

Change-Id: I21d2d0568a7cffe3cb275df11f642b9222f29c1d
Reviewed-on: https://chromium-review.googlesource.com/c/1349463
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611696}
[modify] https://crrev.com/3ab3cf25a23f0309984a32bc9ba4804e108aea7f/media/blink/webaudiosourceprovider_impl_unittest.cc
[modify] https://crrev.com/3ab3cf25a23f0309984a32bc9ba4804e108aea7f/third_party/blink/public/platform/web_audio_source_provider_client.h
[modify] https://crrev.com/3ab3cf25a23f0309984a32bc9ba4804e108aea7f/third_party/blink/renderer/core/html/media/html_media_element.cc
[modify] https://crrev.com/3ab3cf25a23f0309984a32bc9ba4804e108aea7f/third_party/blink/renderer/core/html/media/html_media_element.h
[modify] https://crrev.com/3ab3cf25a23f0309984a32bc9ba4804e108aea7f/third_party/blink/renderer/modules/webaudio/audio_buffer.cc
[modify] https://crrev.com/3ab3cf25a23f0309984a32bc9ba4804e108aea7f/third_party/blink/renderer/modules/webaudio/audio_buffer.h
[modify] https://crrev.com/3ab3cf25a23f0309984a32bc9ba4804e108aea7f/third_party/blink/renderer/modules/webaudio/audio_param_timeline.cc
[modify] https://crrev.com/3ab3cf25a23f0309984a32bc9ba4804e108aea7f/third_party/blink/renderer/modules/webaudio/audio_param_timeline.h
[modify] https://crrev.com/3ab3cf25a23f0309984a32bc9ba4804e108aea7f/third_party/blink/renderer/modules/webaudio/audio_worklet_node.cc
[modify] https://crrev.com/3ab3cf25a23f0309984a32bc9ba4804e108aea7f/third_party/blink/renderer/modules/webaudio/biquad_processor.cc
[modify] https://crrev.com/3ab3cf25a23f0309984a32bc9ba4804e108aea7f/third_party/blink/renderer/modules/webaudio/biquad_processor.h
[modify] https://crrev.com/3ab3cf25a23f0309984a32bc9ba4804e108aea7f/third_party/blink/renderer/modules/webaudio/iir_processor.cc
[modify] https://crrev.com/3ab3cf25a23f0309984a32bc9ba4804e108aea7f/third_party/blink/renderer/modules/webaudio/iir_processor.h
[modify] https://crrev.com/3ab3cf25a23f0309984a32bc9ba4804e108aea7f/third_party/blink/renderer/modules/webaudio/media_element_audio_source_node.cc
[modify] https://crrev.com/3ab3cf25a23f0309984a32bc9ba4804e108aea7f/third_party/blink/renderer/modules/webaudio/media_element_audio_source_node.h
[modify] https://crrev.com/3ab3cf25a23f0309984a32bc9ba4804e108aea7f/third_party/blink/renderer/modules/webaudio/media_stream_audio_destination_node.cc
[modify] https://crrev.com/3ab3cf25a23f0309984a32bc9ba4804e108aea7f/third_party/blink/renderer/modules/webaudio/media_stream_audio_destination_node.h
[modify] https://crrev.com/3ab3cf25a23f0309984a32bc9ba4804e108aea7f/third_party/blink/renderer/modules/webaudio/media_stream_audio_source_node.cc
[modify] https://crrev.com/3ab3cf25a23f0309984a32bc9ba4804e108aea7f/third_party/blink/renderer/modules/webaudio/media_stream_audio_source_node.h
[modify] https://crrev.com/3ab3cf25a23f0309984a32bc9ba4804e108aea7f/third_party/blink/renderer/modules/webaudio/offline_audio_context.cc
[modify] https://crrev.com/3ab3cf25a23f0309984a32bc9ba4804e108aea7f/third_party/blink/renderer/modules/webaudio/offline_audio_context.h
[modify] https://crrev.com/3ab3cf25a23f0309984a32bc9ba4804e108aea7f/third_party/blink/renderer/platform/audio/audio_destination.cc
[modify] https://crrev.com/3ab3cf25a23f0309984a32bc9ba4804e108aea7f/third_party/blink/renderer/platform/audio/audio_destination.h
[modify] https://crrev.com/3ab3cf25a23f0309984a32bc9ba4804e108aea7f/third_party/blink/renderer/platform/audio/audio_source_provider_client.h

Project Member

Comment 61 by bugdroid1@chromium.org, Nov 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4ce140dc9113c9f39b74ee1d4202967a35c5b824

commit 4ce140dc9113c9f39b74ee1d4202967a35c5b824
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Wed Nov 28 16:25:01 2018

Fix 64 bit truncation in tracing

BuitinCategories::Size() returned size_t but the ::At(..) method took
an int. Make these consistent to avoid a 64 bit truncation.

BUG=879657

Change-Id: I7e27f17b709f7070a5234ac53b96438efad0eaf3
Reviewed-on: https://chromium-review.googlesource.com/c/1347570
Reviewed-by: Primiano Tucci <primiano@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611724}
[modify] https://crrev.com/4ce140dc9113c9f39b74ee1d4202967a35c5b824/base/trace_event/builtin_categories.h

Project Member

Comment 62 by bugdroid1@chromium.org, Nov 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d34b361678c2113b17716eee84e1b0835c265b5

commit 9d34b361678c2113b17716eee84e1b0835c265b5
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Wed Nov 28 17:57:07 2018

Adjust some network interface APIs to avoid truncation errors.

Some blink public interfaces used size_t then truncated on the calls
internally to int. Use size_t throughout call graph.

BUG=879657

Change-Id: I3c124524c2e969b65e662a30d0c8898d9d4e01a5
Reviewed-on: https://chromium-review.googlesource.com/c/1354061
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611767}
[modify] https://crrev.com/9d34b361678c2113b17716eee84e1b0835c265b5/content/renderer/appcache/web_application_cache_host_impl.cc
[modify] https://crrev.com/9d34b361678c2113b17716eee84e1b0835c265b5/content/renderer/appcache/web_application_cache_host_impl.h
[modify] https://crrev.com/9d34b361678c2113b17716eee84e1b0835c265b5/content/renderer/shared_worker/embedded_shared_worker_stub.cc
[modify] https://crrev.com/9d34b361678c2113b17716eee84e1b0835c265b5/third_party/blink/public/platform/web_application_cache_host.h
[modify] https://crrev.com/9d34b361678c2113b17716eee84e1b0835c265b5/third_party/blink/renderer/core/inspector/inspector_network_agent.cc
[modify] https://crrev.com/9d34b361678c2113b17716eee84e1b0835c265b5/third_party/blink/renderer/core/inspector/inspector_network_agent.h
[modify] https://crrev.com/9d34b361678c2113b17716eee84e1b0835c265b5/third_party/blink/renderer/core/inspector/network_resources_data.cc
[modify] https://crrev.com/9d34b361678c2113b17716eee84e1b0835c265b5/third_party/blink/renderer/core/inspector/network_resources_data.h
[modify] https://crrev.com/9d34b361678c2113b17716eee84e1b0835c265b5/third_party/blink/renderer/core/loader/progress_tracker.cc
[modify] https://crrev.com/9d34b361678c2113b17716eee84e1b0835c265b5/third_party/blink/renderer/core/loader/progress_tracker.h
[modify] https://crrev.com/9d34b361678c2113b17716eee84e1b0835c265b5/third_party/blink/renderer/core/probe/core_probes.pidl

Project Member

Comment 63 by bugdroid1@chromium.org, Nov 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/56eb0cdb04b4b44ad388fba48adf7e35160c8c1a

commit 56eb0cdb04b4b44ad388fba48adf7e35160c8c1a
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Wed Nov 28 19:23:11 2018

Fix 64 bit truncations in platform

SafeCast a sequence to int in bindings.
Add explicit cast in heap_page.h

BUG=879657

Change-Id: I1c6cf9b1748b84795ed81d903e3e19684bd6d0e3
Reviewed-on: https://chromium-review.googlesource.com/c/1354062
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611814}
[modify] https://crrev.com/56eb0cdb04b4b44ad388fba48adf7e35160c8c1a/third_party/blink/renderer/platform/bindings/to_v8.h
[modify] https://crrev.com/56eb0cdb04b4b44ad388fba48adf7e35160c8c1a/third_party/blink/renderer/platform/heap/heap_page.h

Project Member

Comment 64 by bugdroid1@chromium.org, Nov 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7

commit 9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Wed Nov 28 19:48:42 2018

Replace size_t frames_to_process with uint32_t frames_to_process.

Underlying data structures don't handle more than 4GB frames to process so
stick with using an unsigned value to avoid 64 bit truncation errors.

BUG=879657
TBR=haraken@chromium.org

Change-Id: I353a187cde9885b3642d1d2aaa4019afce40867e
Reviewed-on: https://chromium-review.googlesource.com/c/1354124
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611829}
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/core/html/media/html_media_element.cc
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/core/html/media/html_media_element.h
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/modules/webaudio/analyser_node.cc
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/modules/webaudio/analyser_node.h
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/modules/webaudio/audio_basic_inspector_node.cc
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/modules/webaudio/audio_basic_inspector_node.h
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/modules/webaudio/audio_basic_processor_handler.cc
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/modules/webaudio/audio_basic_processor_handler.h
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/modules/webaudio/audio_basic_processor_handler_test.cc
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/modules/webaudio/audio_buffer.cc
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/modules/webaudio/audio_buffer.h
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/modules/webaudio/audio_buffer_source_node.cc
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/modules/webaudio/audio_buffer_source_node.h
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/modules/webaudio/audio_destination_node.h
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/modules/webaudio/audio_listener.cc
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/modules/webaudio/audio_listener.h
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/modules/webaudio/audio_node.cc
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/modules/webaudio/audio_node.h
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/modules/webaudio/audio_node_input.cc
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/modules/webaudio/audio_node_input.h
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/modules/webaudio/audio_node_output.cc
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/modules/webaudio/audio_node_output.h
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/modules/webaudio/audio_param_timeline.cc
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/modules/webaudio/audio_param_timeline.h
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/modules/webaudio/audio_worklet_node.cc
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/modules/webaudio/audio_worklet_node.h
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/modules/webaudio/base_audio_context.cc
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/modules/webaudio/base_audio_context.h
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/modules/webaudio/biquad_dsp_kernel.cc
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/modules/webaudio/biquad_dsp_kernel.h
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/modules/webaudio/biquad_processor.cc
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/modules/webaudio/biquad_processor.h
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/modules/webaudio/channel_merger_node.cc
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/modules/webaudio/channel_merger_node.h
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/modules/webaudio/channel_splitter_node.cc
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/modules/webaudio/channel_splitter_node.h
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/modules/webaudio/constant_source_node.cc
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/modules/webaudio/constant_source_node.h
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/modules/webaudio/convolver_node.cc
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/modules/webaudio/convolver_node.h
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/modules/webaudio/default_audio_destination_node.cc
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/modules/webaudio/default_audio_destination_node.h
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/modules/webaudio/deferred_task_handler.cc
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/modules/webaudio/deferred_task_handler.h
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/modules/webaudio/delay_dsp_kernel.cc
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/modules/webaudio/delay_dsp_kernel.h
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/modules/webaudio/delay_processor.cc
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/modules/webaudio/delay_processor.h
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/modules/webaudio/dynamics_compressor_node.cc
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/modules/webaudio/dynamics_compressor_node.h
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/modules/webaudio/gain_node.cc
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/modules/webaudio/gain_node.h
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/modules/webaudio/iir_processor.cc
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/modules/webaudio/iir_processor.h
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/modules/webaudio/iirdsp_kernel.cc
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/modules/webaudio/iirdsp_kernel.h
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/modules/webaudio/media_element_audio_source_node.cc
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/modules/webaudio/media_element_audio_source_node.h
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/modules/webaudio/media_stream_audio_destination_node.cc
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/modules/webaudio/media_stream_audio_destination_node.h
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/modules/webaudio/media_stream_audio_source_node.cc
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/modules/webaudio/media_stream_audio_source_node.h
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/modules/webaudio/offline_audio_destination_node.cc
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/modules/webaudio/offline_audio_destination_node.h
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/modules/webaudio/oscillator_node.cc
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/modules/webaudio/oscillator_node.h
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/modules/webaudio/panner_node.cc
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/modules/webaudio/panner_node.h
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/modules/webaudio/realtime_analyser.cc
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/modules/webaudio/realtime_analyser.h
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/modules/webaudio/script_processor_node.cc
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/modules/webaudio/script_processor_node.h
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/modules/webaudio/stereo_panner_node.cc
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/modules/webaudio/stereo_panner_node.h
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/modules/webaudio/wave_shaper_dsp_kernel.cc
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/modules/webaudio/wave_shaper_dsp_kernel.h
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/modules/webaudio/wave_shaper_processor.cc
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/modules/webaudio/wave_shaper_processor.h
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/platform/audio/audio_array.h
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/platform/audio/audio_delay_dsp_kernel.cc
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/platform/audio/audio_delay_dsp_kernel.h
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/platform/audio/audio_dsp_kernel.h
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/platform/audio/audio_dsp_kernel_processor.cc
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/platform/audio/audio_dsp_kernel_processor.h
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/platform/audio/audio_io_callback.h
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/platform/audio/audio_processor.h
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/platform/audio/audio_resampler.cc
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/platform/audio/audio_resampler.h
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/platform/audio/audio_resampler_kernel.cc
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/platform/audio/audio_resampler_kernel.h
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/platform/audio/audio_source_provider.h
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/platform/audio/biquad.cc
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/platform/audio/biquad.h
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/platform/audio/cpu/arm/vector_math_neon.h
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/platform/audio/cpu/mips/vector_math_msa.h
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/platform/audio/cpu/x86/vector_math_avx.h
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/platform/audio/cpu/x86/vector_math_impl.h
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/platform/audio/cpu/x86/vector_math_sse.h
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/platform/audio/cpu/x86/vector_math_x86.h
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/platform/audio/direct_convolver.cc
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/platform/audio/direct_convolver.h
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/platform/audio/equal_power_panner.cc
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/platform/audio/equal_power_panner.h
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/platform/audio/fft_convolver.cc
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/platform/audio/fft_convolver.h
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/platform/audio/hrtf_panner.cc
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/platform/audio/hrtf_panner.h
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/platform/audio/iir_filter.cc
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/platform/audio/iir_filter.h
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/platform/audio/mac/vector_math_mac.h
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/platform/audio/multi_channel_resampler.cc
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/platform/audio/multi_channel_resampler.h
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/platform/audio/panner.h
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/platform/audio/reverb.cc
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/platform/audio/reverb.h
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/platform/audio/reverb_convolver.cc
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/platform/audio/reverb_convolver.h
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/platform/audio/reverb_convolver_stage.cc
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/platform/audio/reverb_convolver_stage.h
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/platform/audio/simple_fft_convolver.cc
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/platform/audio/simple_fft_convolver.h
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/platform/audio/sinc_resampler.cc
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/platform/audio/sinc_resampler.h
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/platform/audio/stereo_panner.cc
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/platform/audio/stereo_panner.h
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/platform/audio/vector_math.cc
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/platform/audio/vector_math.h
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/platform/audio/vector_math_scalar.h
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/platform/audio/vector_math_test.cc
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/platform/mediastream/media_stream_component.cc
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/platform/mediastream/media_stream_component.h
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/platform/mediastream/media_stream_web_audio_source.cc
[modify] https://crrev.com/9d0b6c88252b5e1ab002bb6ed5db81d37851e2c7/third_party/blink/renderer/platform/mediastream/media_stream_web_audio_source.h

Project Member

Comment 65 by bugdroid1@chromium.org, Nov 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7a56a3bbf831cc832aee68b3d93df8b7a3956533

commit 7a56a3bbf831cc832aee68b3d93df8b7a3956533
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Thu Nov 29 22:36:30 2018

Use wtf_size_t for frame index accessing frame buffer cache.

BUG=879657

Change-Id: Ifc3ba15e517c79286158e77a8bb83c3c30ea1a75
Reviewed-on: https://chromium-review.googlesource.com/c/1355881
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612413}
[modify] https://crrev.com/7a56a3bbf831cc832aee68b3d93df8b7a3956533/third_party/blink/renderer/platform/image-decoders/image_decoder.h
[modify] https://crrev.com/7a56a3bbf831cc832aee68b3d93df8b7a3956533/third_party/blink/renderer/platform/image-decoders/webp/webp_image_decoder.h

Project Member

Comment 66 by bugdroid1@chromium.org, Nov 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/610ae98baca8030c1879387ae55bc5ca7de2d1fa

commit 610ae98baca8030c1879387ae55bc5ca7de2d1fa
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Fri Nov 30 00:18:07 2018

Fix 64 bit truncations in renderer/modules.

Fix a few last truncation errors.

BUG=879657

Change-Id: I75339fe7a46efa336bdaa91c73c21a5c673b32f3
Reviewed-on: https://chromium-review.googlesource.com/c/1355856
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612462}
[modify] https://crrev.com/610ae98baca8030c1879387ae55bc5ca7de2d1fa/third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_stream_impl.cc
[modify] https://crrev.com/610ae98baca8030c1879387ae55bc5ca7de2d1fa/third_party/blink/renderer/modules/peerconnection/byte_buffer_queue.cc
[modify] https://crrev.com/610ae98baca8030c1879387ae55bc5ca7de2d1fa/third_party/blink/renderer/modules/webdatabase/sqlite/sqlite_statement.cc

Project Member

Comment 67 by bugdroid1@chromium.org, Nov 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/44fcad8b7cc8a2d6994f13d1aa471889b0fd7941

commit 44fcad8b7cc8a2d6994f13d1aa471889b0fd7941
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Fri Nov 30 15:49:08 2018

Fix Shared Buffer 64 bit truncations

Segments are always 4k and indexed by a WTF::Vector

BUG=879657

Change-Id: Ibe922cc6736fed0ba04e99aee0f04eb470f7fecf
Reviewed-on: https://chromium-review.googlesource.com/c/1355884
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612659}
[modify] https://crrev.com/44fcad8b7cc8a2d6994f13d1aa471889b0fd7941/third_party/blink/renderer/platform/shared_buffer.cc
[modify] https://crrev.com/44fcad8b7cc8a2d6994f13d1aa471889b0fd7941/third_party/blink/renderer/platform/shared_buffer.h
[modify] https://crrev.com/44fcad8b7cc8a2d6994f13d1aa471889b0fd7941/third_party/blink/renderer/platform/shared_buffer_chunk_reader.cc
[modify] https://crrev.com/44fcad8b7cc8a2d6994f13d1aa471889b0fd7941/third_party/blink/renderer/platform/shared_buffer_chunk_reader.h

Project Member

Comment 68 by bugdroid1@chromium.org, Nov 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8b80e0d5a4d34245195f9d9091d04772c2c1213d

commit 8b80e0d5a4d34245195f9d9091d04772c2c1213d
Author: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Date: Fri Nov 30 16:42:33 2018

Revert "Fix Shared Buffer 64 bit truncations"

This reverts commit 44fcad8b7cc8a2d6994f13d1aa471889b0fd7941.

Reason for revert: Possibly causing Linux x64 tree closing issue
https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20Linux%20x64/38102

Original change's description:
> Fix Shared Buffer 64 bit truncations
> 
> Segments are always 4k and indexed by a WTF::Vector
> 
> BUG=879657
> 
> Change-Id: Ibe922cc6736fed0ba04e99aee0f04eb470f7fecf
> Reviewed-on: https://chromium-review.googlesource.com/c/1355884
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#612659}

TBR=haraken@chromium.org,dtapuska@chromium.org

Change-Id: Id069b9258d53267ec504fabe3adbd4b28148345e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 879657
Reviewed-on: https://chromium-review.googlesource.com/c/1356883
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612672}
[modify] https://crrev.com/8b80e0d5a4d34245195f9d9091d04772c2c1213d/third_party/blink/renderer/platform/shared_buffer.cc
[modify] https://crrev.com/8b80e0d5a4d34245195f9d9091d04772c2c1213d/third_party/blink/renderer/platform/shared_buffer.h
[modify] https://crrev.com/8b80e0d5a4d34245195f9d9091d04772c2c1213d/third_party/blink/renderer/platform/shared_buffer_chunk_reader.cc
[modify] https://crrev.com/8b80e0d5a4d34245195f9d9091d04772c2c1213d/third_party/blink/renderer/platform/shared_buffer_chunk_reader.h

Project Member

Comment 69 by bugdroid1@chromium.org, Nov 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b11c0ade1fd091320dbe311390aafb14469d3017

commit b11c0ade1fd091320dbe311390aafb14469d3017
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Fri Nov 30 17:23:18 2018

Fix a few more 64 bit truncation warnings.

Apply casts where necessary. These are all safe.

BUG=879657

Change-Id: Ia0a79b09796ed065a06e60ef880248cadcef3490
Reviewed-on: https://chromium-review.googlesource.com/c/1355775
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612682}
[modify] https://crrev.com/b11c0ade1fd091320dbe311390aafb14469d3017/third_party/blink/renderer/bindings/core/v8/v8_binding_for_core.cc
[modify] https://crrev.com/b11c0ade1fd091320dbe311390aafb14469d3017/third_party/blink/renderer/core/fetch/data_pipe_bytes_consumer.cc
[modify] https://crrev.com/b11c0ade1fd091320dbe311390aafb14469d3017/third_party/blink/renderer/core/style/grid_area.h
[modify] https://crrev.com/b11c0ade1fd091320dbe311390aafb14469d3017/third_party/blink/renderer/core/typed_arrays/flexible_array_buffer_view.h
[modify] https://crrev.com/b11c0ade1fd091320dbe311390aafb14469d3017/third_party/blink/renderer/platform/bindings/v8_binding.h
[modify] https://crrev.com/b11c0ade1fd091320dbe311390aafb14469d3017/third_party/blink/renderer/platform/wtf/typed_arrays/array_buffer.h

Project Member

Comment 70 by bugdroid1@chromium.org, Nov 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6891b000e4f8262f9010048bf8b7de4630913ef1

commit 6891b000e4f8262f9010048bf8b7de4630913ef1
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Fri Nov 30 19:37:03 2018

Reland "Fix Shared Buffer 64 bit truncations"

This is a reland of 44fcad8b7cc8a2d6994f13d1aa471889b0fd7941

It was speculatively reverted for a build failure which turned out
to be something else.

Original change's description:
> Fix Shared Buffer 64 bit truncations
>
> Segments are always 4k and indexed by a WTF::Vector
>
> BUG=879657
>
> Change-Id: Ibe922cc6736fed0ba04e99aee0f04eb470f7fecf
> Reviewed-on: https://chromium-review.googlesource.com/c/1355884
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#612659}

TBR=haraken@chromium.org

Bug: 879657
Change-Id: I60299fc856a6dc987c8f4460b2bf3a339bcb5837
Reviewed-on: https://chromium-review.googlesource.com/c/1357302
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612727}
[modify] https://crrev.com/6891b000e4f8262f9010048bf8b7de4630913ef1/third_party/blink/renderer/platform/shared_buffer.cc
[modify] https://crrev.com/6891b000e4f8262f9010048bf8b7de4630913ef1/third_party/blink/renderer/platform/shared_buffer.h
[modify] https://crrev.com/6891b000e4f8262f9010048bf8b7de4630913ef1/third_party/blink/renderer/platform/shared_buffer_chunk_reader.cc
[modify] https://crrev.com/6891b000e4f8262f9010048bf8b7de4630913ef1/third_party/blink/renderer/platform/shared_buffer_chunk_reader.h

Project Member

Comment 71 by bugdroid1@chromium.org, Nov 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/589d63a301a85940aa9bace2dab4ef5004a151e4

commit 589d63a301a85940aa9bace2dab4ef5004a151e4
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Fri Nov 30 20:26:11 2018

Fix 64 bit truncations in webaudio.

BUG=879657

Change-Id: I522fa35be26873436ed090990cbae1897acef6f7
Reviewed-on: https://chromium-review.googlesource.com/c/1355841
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612759}
[modify] https://crrev.com/589d63a301a85940aa9bace2dab4ef5004a151e4/third_party/blink/renderer/modules/webaudio/audio_buffer_source_node.cc
[modify] https://crrev.com/589d63a301a85940aa9bace2dab4ef5004a151e4/third_party/blink/renderer/modules/webaudio/base_audio_context.cc
[modify] https://crrev.com/589d63a301a85940aa9bace2dab4ef5004a151e4/third_party/blink/renderer/modules/webaudio/base_audio_context.h
[modify] https://crrev.com/589d63a301a85940aa9bace2dab4ef5004a151e4/third_party/blink/renderer/modules/webaudio/convolver_node.cc
[modify] https://crrev.com/589d63a301a85940aa9bace2dab4ef5004a151e4/third_party/blink/renderer/modules/webaudio/default_audio_destination_node.cc
[modify] https://crrev.com/589d63a301a85940aa9bace2dab4ef5004a151e4/third_party/blink/renderer/modules/webaudio/default_audio_destination_node.h
[modify] https://crrev.com/589d63a301a85940aa9bace2dab4ef5004a151e4/third_party/blink/renderer/modules/webaudio/periodic_wave.cc
[modify] https://crrev.com/589d63a301a85940aa9bace2dab4ef5004a151e4/third_party/blink/renderer/modules/webaudio/periodic_wave.h
[modify] https://crrev.com/589d63a301a85940aa9bace2dab4ef5004a151e4/third_party/blink/renderer/modules/webaudio/script_processor_node.cc
[modify] https://crrev.com/589d63a301a85940aa9bace2dab4ef5004a151e4/third_party/blink/renderer/modules/webaudio/script_processor_node.h
[modify] https://crrev.com/589d63a301a85940aa9bace2dab4ef5004a151e4/third_party/blink/renderer/platform/audio/audio_bus.cc
[modify] https://crrev.com/589d63a301a85940aa9bace2dab4ef5004a151e4/third_party/blink/renderer/platform/audio/audio_bus.h
[modify] https://crrev.com/589d63a301a85940aa9bace2dab4ef5004a151e4/third_party/blink/renderer/platform/audio/audio_destination.cc
[modify] https://crrev.com/589d63a301a85940aa9bace2dab4ef5004a151e4/third_party/blink/renderer/platform/audio/audio_destination.h

Project Member

Comment 72 by bugdroid1@chromium.org, Dec 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0f5865b881341c863ceb7dd5ffb6bef5e5e775a1

commit 0f5865b881341c863ceb7dd5ffb6bef5e5e775a1
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Tue Dec 04 21:59:36 2018

Fix 64 bit truncation in AudioParamTimeline.

The relative frame indicies don't exceed 32 bits. Use unsigned instead
of size_t so we don't get truncation errors. The begin/end frame remain
as size_t since they are cumulative counters.

BUG=879657

Change-Id: I22dddfd254e81ca7a9d7fcab57edabd04b87e3c3
Reviewed-on: https://chromium-review.googlesource.com/c/1358792
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613714}
[modify] https://crrev.com/0f5865b881341c863ceb7dd5ffb6bef5e5e775a1/third_party/blink/renderer/modules/webaudio/audio_param_timeline.cc
[modify] https://crrev.com/0f5865b881341c863ceb7dd5ffb6bef5e5e775a1/third_party/blink/renderer/modules/webaudio/audio_param_timeline.h

Project Member

Comment 73 by bugdroid1@chromium.org, Dec 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f5a0dbd125a32f29a0f8ec434db13555ae74314f

commit f5a0dbd125a32f29a0f8ec434db13555ae74314f
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Wed Dec 05 17:23:14 2018

Fix recently added 64 bit truncations in indexdb/cache_storage

BUG=879657

Change-Id: I91c4c332753112331af5c37fcaa8bbd4fc9c7527
Reviewed-on: https://chromium-review.googlesource.com/c/1362205
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614005}
[modify] https://crrev.com/f5a0dbd125a32f29a0f8ec434db13555ae74314f/third_party/blink/renderer/modules/cache_storage/inspector_cache_storage_agent.cc
[modify] https://crrev.com/f5a0dbd125a32f29a0f8ec434db13555ae74314f/third_party/blink/renderer/modules/indexeddb/indexed_db_blink_mojom_traits.cc

Project Member

Comment 74 by bugdroid1@chromium.org, Dec 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/51ec797de0abe70411f513cdf151c4867835f729

commit 51ec797de0abe70411f513cdf151c4867835f729
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Tue Dec 18 01:31:56 2018

Fix a few more 64 bit truncation errors in blink

These truncations are another set that I hadn't fixed yet. They are errors
when building ARM 32 bit.

BUG=879657

Change-Id: Ia5024fcea17341b7cc3e4d0944eb55a345d234fd
Reviewed-on: https://chromium-review.googlesource.com/c/1381136
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617329}
[modify] https://crrev.com/51ec797de0abe70411f513cdf151c4867835f729/third_party/blink/public/web/web_pepper_socket_client.h
[modify] https://crrev.com/51ec797de0abe70411f513cdf151c4867835f729/third_party/blink/renderer/bindings/core/v8/dictionary_helper_for_core.cc
[modify] https://crrev.com/51ec797de0abe70411f513cdf151c4867835f729/third_party/blink/renderer/controller/oom_intervention_impl.cc
[modify] https://crrev.com/51ec797de0abe70411f513cdf151c4867835f729/third_party/blink/renderer/core/inspector/inspector_dom_agent.cc
[modify] https://crrev.com/51ec797de0abe70411f513cdf151c4867835f729/third_party/blink/renderer/core/inspector/network_resources_data.cc
[modify] https://crrev.com/51ec797de0abe70411f513cdf151c4867835f729/third_party/blink/renderer/core/inspector/network_resources_data.h
[modify] https://crrev.com/51ec797de0abe70411f513cdf151c4867835f729/third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_transport_test.cc
[modify] https://crrev.com/51ec797de0abe70411f513cdf151c4867835f729/third_party/blink/renderer/modules/websockets/web_pepper_socket_impl.cc
[modify] https://crrev.com/51ec797de0abe70411f513cdf151c4867835f729/third_party/blink/renderer/modules/websockets/web_pepper_socket_impl.h
[modify] https://crrev.com/51ec797de0abe70411f513cdf151c4867835f729/third_party/blink/renderer/modules/websockets/websocket_channel_impl_test.cc
[modify] https://crrev.com/51ec797de0abe70411f513cdf151c4867835f729/third_party/blink/renderer/platform/blob/blob_bytes_provider_test.cc
[modify] https://crrev.com/51ec797de0abe70411f513cdf151c4867835f729/third_party/blink/renderer/platform/blob/blob_data_test.cc
[modify] https://crrev.com/51ec797de0abe70411f513cdf151c4867835f729/third_party/blink/renderer/platform/fonts/shaping/shape_cache.cc
[modify] https://crrev.com/51ec797de0abe70411f513cdf151c4867835f729/third_party/blink/renderer/platform/graphics/bitmap_image_metrics.cc
[modify] https://crrev.com/51ec797de0abe70411f513cdf151c4867835f729/third_party/blink/renderer/platform/graphics/static_bitmap_image.cc
[modify] https://crrev.com/51ec797de0abe70411f513cdf151c4867835f729/third_party/blink/renderer/platform/loader/fetch/resource_load_scheduler.cc
[modify] https://crrev.com/51ec797de0abe70411f513cdf151c4867835f729/third_party/blink/renderer/platform/network/network_state_notifier.cc
[modify] https://crrev.com/51ec797de0abe70411f513cdf151c4867835f729/third_party/blink/renderer/platform/network/network_state_notifier.h

Project Member

Comment 75 by bugdroid1@chromium.org, Dec 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ba6fc41854a07f0aa5fc3e5e65f7875c3a26746a

commit ba6fc41854a07f0aa5fc3e5e65f7875c3a26746a
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Fri Dec 21 01:49:14 2018

Fix 64 truncation errors in webmidi

Newly introduced methods in webmidi have truncation errors related
to the size of data passed around. Use wtf_size_t because the data
is retrieved and stored into backing WTF vectors.

BUG=879657

Change-Id: Icc260425fe01d358186556293a1ce4337565372e
Reviewed-on: https://chromium-review.googlesource.com/c/1387650
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618429}
[modify] https://crrev.com/ba6fc41854a07f0aa5fc3e5e65f7875c3a26746a/third_party/blink/renderer/modules/webmidi/midi_access.cc
[modify] https://crrev.com/ba6fc41854a07f0aa5fc3e5e65f7875c3a26746a/third_party/blink/renderer/modules/webmidi/midi_access.h
[modify] https://crrev.com/ba6fc41854a07f0aa5fc3e5e65f7875c3a26746a/third_party/blink/renderer/modules/webmidi/midi_access_initializer.h
[modify] https://crrev.com/ba6fc41854a07f0aa5fc3e5e65f7875c3a26746a/third_party/blink/renderer/modules/webmidi/midi_accessor.cc
[modify] https://crrev.com/ba6fc41854a07f0aa5fc3e5e65f7875c3a26746a/third_party/blink/renderer/modules/webmidi/midi_accessor.h
[modify] https://crrev.com/ba6fc41854a07f0aa5fc3e5e65f7875c3a26746a/third_party/blink/renderer/modules/webmidi/midi_accessor_client.h
[modify] https://crrev.com/ba6fc41854a07f0aa5fc3e5e65f7875c3a26746a/third_party/blink/renderer/modules/webmidi/midi_dispatcher.cc
[modify] https://crrev.com/ba6fc41854a07f0aa5fc3e5e65f7875c3a26746a/third_party/blink/renderer/modules/webmidi/midi_dispatcher.h

Project Member

Comment 76 by bugdroid1@chromium.org, Dec 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b78ef3abef17d45b968b5e0a2ac692a69d8aa87

commit 2b78ef3abef17d45b968b5e0a2ac692a69d8aa87
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Fri Dec 21 22:25:15 2018

Fix 64 bit truncation in new IDB code.

Use a range iterator to avoid 64 bit truncation with size_t.

BUG=879657

Change-Id: Ic776d3aae635b47d24a0d548c0a260840e8c5656
Reviewed-on: https://chromium-review.googlesource.com/c/1387652
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618633}
[modify] https://crrev.com/2b78ef3abef17d45b968b5e0a2ac692a69d8aa87/third_party/blink/renderer/modules/indexeddb/idb_factory.cc

Project Member

Comment 77 by bugdroid1@chromium.org, Dec 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f1e233b3fb8afdcd0cff83be8c20d891ba1d8271

commit f1e233b3fb8afdcd0cff83be8c20d891ba1d8271
Author: Tom Sepez <tsepez@chromium.org>
Date: Fri Dec 21 22:27:07 2018

Avoid instantiating SaturateFastAsmOp<> for types that do not use it.

Currently, this path is avoided via an |if (false) { ... }| in
the code above it when SaturateFastAsmOp is not supported for a
given pair of types. However, instantiating the template for 64-bit
sources will give a truncation warning for arm (at the line where
we do |int32_t src = value;|) under strict compiler modes (even
though the path can't be reached).

Avoid the error by conditionalizing its instatiation for cases where
it is actually usable.

BUG=879657

Change-Id: I40bee5a4686b89c1d35c7b93804b215afe25dd68
Reviewed-on: https://chromium-review.googlesource.com/c/1387958
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618634}
[modify] https://crrev.com/f1e233b3fb8afdcd0cff83be8c20d891ba1d8271/base/numerics/safe_conversions.h
[modify] https://crrev.com/f1e233b3fb8afdcd0cff83be8c20d891ba1d8271/base/numerics/safe_conversions_arm_impl.h

Project Member

Comment 78 by bugdroid1@chromium.org, Dec 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9a38e3472884f6049d7c050324c0f42e7c60f289

commit 9a38e3472884f6049d7c050324c0f42e7c60f289
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Fri Dec 21 22:43:50 2018

Fix 64 bit truncation error in paint_image header.

Use size_t for hash value which matches the function definition
requirement and the type.

BUG=879657

Change-Id: I486cfd3adde1880c03b1657d9cb803c5d50f16f4
Reviewed-on: https://chromium-review.googlesource.com/c/1387827
Reviewed-by: vmpstr <vmpstr@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618647}
[modify] https://crrev.com/9a38e3472884f6049d7c050324c0f42e7c60f289/cc/paint/paint_image.h

Comment 79 by r...@tambre.ee, Jan 5

From https://chromium-review.googlesource.com/c/chromium/src/+/1396124/1/ui/gfx/font_fallback_win.cc#180:
> I think logging the size of a collection is a relatively common pattern with histograms.
> If the plan is to do this conversion on all of Chrome, then it would be unfortunate to have all such call sites become more convoluted like this. Perhaps we can make a version of the macro that allows passing a size_t?

Thoughts?

Project Member

Comment 80 by bugdroid1@chromium.org, Jan 7

The following revision refers to this bug:
  https://boringssl.googlesource.com/boringssl/+/35771ff8afc2201b5cf5b884db5b3889edde06bc

commit 35771ff8afc2201b5cf5b884db5b3889edde06bc
Author: Raul Tambre <raul@tambre.ee>
Date: Mon Jan 07 18:14:42 2019

Fix protos_len size in SSL_set_alpn_protos and SSL_CTX_set_alpn_protos

MakeConstSpan() takes size_t as the second argument, so protos_len ought to also be size_t.

Bug: chromium:879657
Change-Id: I93089ea20ce4b9c2b9d4d954dce807feb5341482
Reviewed-on: https://boringssl-review.googlesource.com/c/34164
Reviewed-by: Adam Langley <agl@google.com>
Commit-Queue: David Benjamin <davidben@google.com>

[modify] https://crrev.com/35771ff8afc2201b5cf5b884db5b3889edde06bc/ssl/ssl_lib.cc
[modify] https://crrev.com/35771ff8afc2201b5cf5b884db5b3889edde06bc/include/openssl/ssl.h

Project Member

Comment 81 by bugdroid1@chromium.org, Jan 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9f4c1cd43578260f25f0737e8f10c1f09f0b51a5

commit 9f4c1cd43578260f25f0737e8f10c1f09f0b51a5
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Mon Jan 07 20:36:29 2019

Fix bad cast introduced in https://crrev.com/246d85666a1

Variable type was not the same as the cast type. Fix that.

BUG=879657

Change-Id: I75c84da09131bf9e1c15966c8c7f48c262987acd
Reviewed-on: https://chromium-review.googlesource.com/c/1398395
Reviewed-by: Ehsan Karamad <ekaramad@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620454}
[modify] https://crrev.com/9f4c1cd43578260f25f0737e8f10c1f09f0b51a5/third_party/blink/renderer/core/dom/document.cc

Project Member

Comment 82 by bugdroid1@chromium.org, Jan 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8af086054d74d1a5cf3d0c60f9af78d0b7d6039d

commit 8af086054d74d1a5cf3d0c60f9af78d0b7d6039d
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Tue Jan 08 14:17:22 2019

Fix 64 bit truncation errors in platform/loader

This fixes a SafeCast that was a TODO by using the appropriate
values on the interfaces.

BUG=879657

Change-Id: Ia5d04bd72100a5099c21d747ed2dc47d8eb68b7e
Reviewed-on: https://chromium-review.googlesource.com/c/1399288
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620706}
[modify] https://crrev.com/8af086054d74d1a5cf3d0c60f9af78d0b7d6039d/content/renderer/pepper/pepper_url_loader_host.cc
[modify] https://crrev.com/8af086054d74d1a5cf3d0c60f9af78d0b7d6039d/content/renderer/pepper/pepper_url_loader_host.h
[modify] https://crrev.com/8af086054d74d1a5cf3d0c60f9af78d0b7d6039d/media/blink/resource_multibuffer_data_provider.cc
[modify] https://crrev.com/8af086054d74d1a5cf3d0c60f9af78d0b7d6039d/media/blink/resource_multibuffer_data_provider.h
[modify] https://crrev.com/8af086054d74d1a5cf3d0c60f9af78d0b7d6039d/third_party/blink/public/web/web_associated_url_loader_client.h
[modify] https://crrev.com/8af086054d74d1a5cf3d0c60f9af78d0b7d6039d/third_party/blink/renderer/core/exported/web_associated_url_loader_impl.cc
[modify] https://crrev.com/8af086054d74d1a5cf3d0c60f9af78d0b7d6039d/third_party/blink/renderer/core/exported/web_associated_url_loader_impl_test.cc
[modify] https://crrev.com/8af086054d74d1a5cf3d0c60f9af78d0b7d6039d/third_party/blink/renderer/core/loader/frame_fetch_context.cc
[modify] https://crrev.com/8af086054d74d1a5cf3d0c60f9af78d0b7d6039d/third_party/blink/renderer/core/loader/frame_fetch_context.h
[modify] https://crrev.com/8af086054d74d1a5cf3d0c60f9af78d0b7d6039d/third_party/blink/renderer/core/loader/threadable_loader.cc
[modify] https://crrev.com/8af086054d74d1a5cf3d0c60f9af78d0b7d6039d/third_party/blink/renderer/core/loader/threadable_loader.h
[modify] https://crrev.com/8af086054d74d1a5cf3d0c60f9af78d0b7d6039d/third_party/blink/renderer/core/loader/threadable_loader_client.h
[modify] https://crrev.com/8af086054d74d1a5cf3d0c60f9af78d0b7d6039d/third_party/blink/renderer/core/loader/threadable_loader_test.cc
[modify] https://crrev.com/8af086054d74d1a5cf3d0c60f9af78d0b7d6039d/third_party/blink/renderer/core/loader/worker_fetch_context.cc
[modify] https://crrev.com/8af086054d74d1a5cf3d0c60f9af78d0b7d6039d/third_party/blink/renderer/core/loader/worker_fetch_context.h
[modify] https://crrev.com/8af086054d74d1a5cf3d0c60f9af78d0b7d6039d/third_party/blink/renderer/core/probe/core_probes.pidl
[modify] https://crrev.com/8af086054d74d1a5cf3d0c60f9af78d0b7d6039d/third_party/blink/renderer/core/xmlhttprequest/xml_http_request.cc
[modify] https://crrev.com/8af086054d74d1a5cf3d0c60f9af78d0b7d6039d/third_party/blink/renderer/core/xmlhttprequest/xml_http_request.h
[modify] https://crrev.com/8af086054d74d1a5cf3d0c60f9af78d0b7d6039d/third_party/blink/renderer/platform/loader/fetch/fetch_context.cc
[modify] https://crrev.com/8af086054d74d1a5cf3d0c60f9af78d0b7d6039d/third_party/blink/renderer/platform/loader/fetch/fetch_context.h
[modify] https://crrev.com/8af086054d74d1a5cf3d0c60f9af78d0b7d6039d/third_party/blink/renderer/platform/loader/fetch/raw_resource.cc
[modify] https://crrev.com/8af086054d74d1a5cf3d0c60f9af78d0b7d6039d/third_party/blink/renderer/platform/loader/fetch/raw_resource.h
[modify] https://crrev.com/8af086054d74d1a5cf3d0c60f9af78d0b7d6039d/third_party/blink/renderer/platform/loader/fetch/resource.h
[modify] https://crrev.com/8af086054d74d1a5cf3d0c60f9af78d0b7d6039d/third_party/blink/renderer/platform/loader/fetch/resource_fetcher_test.cc
[modify] https://crrev.com/8af086054d74d1a5cf3d0c60f9af78d0b7d6039d/third_party/blink/renderer/platform/loader/fetch/resource_loader.cc

Project Member

Comment 83 by bugdroid1@chromium.org, Jan 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d654008e8641fbfb471ec16b38c1ef2c90ee3d5

commit 9d654008e8641fbfb471ec16b38c1ef2c90ee3d5
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Tue Jan 08 15:56:14 2019

64 bit truncations in blink

Fix a few more remaining issues on 32 bit builds.

BUG=879657

Change-Id: I9e1689275ed8a82722bce18a44514a7655aca2fc
Reviewed-on: https://chromium-review.googlesource.com/c/1398785
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620738}
[modify] https://crrev.com/9d654008e8641fbfb471ec16b38c1ef2c90ee3d5/third_party/blink/renderer/core/inspector/inspector_network_agent.cc
[modify] https://crrev.com/9d654008e8641fbfb471ec16b38c1ef2c90ee3d5/third_party/blink/renderer/core/messaging/blink_transferable_message.cc
[modify] https://crrev.com/9d654008e8641fbfb471ec16b38c1ef2c90ee3d5/third_party/blink/renderer/core/paint/compositing/composited_layer_mapping.cc
[modify] https://crrev.com/9d654008e8641fbfb471ec16b38c1ef2c90ee3d5/third_party/blink/renderer/core/paint/image_paint_timing_detector.cc
[modify] https://crrev.com/9d654008e8641fbfb471ec16b38c1ef2c90ee3d5/third_party/blink/renderer/core/paint/text_paint_timing_detector.cc
[modify] https://crrev.com/9d654008e8641fbfb471ec16b38c1ef2c90ee3d5/third_party/blink/renderer/modules/indexeddb/idb_key.cc

Comment 84 by kbr@chromium.org, Jan 8

Blocking: 919981

Project Member

Comment 85 by bugdroid1@chromium.org, Jan 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c9a0917b5793645d3a4601f6c4e6f52d0fd85226

commit c9a0917b5793645d3a4601f6c4e6f52d0fd85226
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Tue Jan 08 23:22:33 2019

Fix 64 bit truncation errors in webgl2 rendering context.

Bindings definition of GLintptr is a 64 bit signed integer (long long).
C++ definition of GLintptr is a signed long int. On 32 bit platforms
they don't match. This avoids an implicit truncation that was happening
on those platforms.

BUG=879657

Change-Id: I737c3a5ecb938f526f181ffdc06033c0a7ec0149
Reviewed-on: https://chromium-review.googlesource.com/c/1398786
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620927}
[modify] https://crrev.com/c9a0917b5793645d3a4601f6c4e6f52d0fd85226/third_party/blink/renderer/modules/webgl/webgl2_rendering_context_base.cc
[modify] https://crrev.com/c9a0917b5793645d3a4601f6c4e6f52d0fd85226/third_party/blink/renderer/modules/webgl/webgl2_rendering_context_base.h

Project Member

Comment 86 by bugdroid1@chromium.org, Jan 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9ff86072f4a7880e380e4e4f8770588ff5705a8f

commit 9ff86072f4a7880e380e4e4f8770588ff5705a8f
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Wed Jan 09 17:03:15 2019

Fix 64 bit truncation with inspector interfaces

Received data size is uint64_t. Propagate this through the interfaces.

BUG=879657

Change-Id: Ia43b03df934a2c9c8896250530f1533efddd8e45
Reviewed-on: https://chromium-review.googlesource.com/c/1401513
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621185}
[modify] https://crrev.com/9ff86072f4a7880e380e4e4f8770588ff5705a8f/third_party/blink/renderer/core/inspector/inspector_network_agent.cc
[modify] https://crrev.com/9ff86072f4a7880e380e4e4f8770588ff5705a8f/third_party/blink/renderer/core/inspector/inspector_network_agent.h
[modify] https://crrev.com/9ff86072f4a7880e380e4e4f8770588ff5705a8f/third_party/blink/renderer/core/inspector/inspector_trace_events.cc
[modify] https://crrev.com/9ff86072f4a7880e380e4e4f8770588ff5705a8f/third_party/blink/renderer/core/inspector/inspector_trace_events.h
[modify] https://crrev.com/9ff86072f4a7880e380e4e4f8770588ff5705a8f/third_party/blink/renderer/core/inspector/network_resources_data.cc
[modify] https://crrev.com/9ff86072f4a7880e380e4e4f8770588ff5705a8f/third_party/blink/renderer/core/inspector/network_resources_data.h
[modify] https://crrev.com/9ff86072f4a7880e380e4e4f8770588ff5705a8f/third_party/blink/renderer/core/loader/progress_tracker.cc
[modify] https://crrev.com/9ff86072f4a7880e380e4e4f8770588ff5705a8f/third_party/blink/renderer/core/loader/progress_tracker.h

Project Member

Comment 87 by bugdroid1@chromium.org, Jan 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7de40a92cf2ae3c4ed5350774fe688d9e8507a57

commit 7de40a92cf2ae3c4ed5350774fe688d9e8507a57
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Wed Jan 09 17:08:56 2019

Fix a few more 64 bit truncation errors

static_cast down the grid_layout code which is fine because it is
always divided by a larger number than it was multiplied with.

BUG=879657

Change-Id: Icc0aaeb27f2050f31cd3c0f73b0c32b8d74a4150
Reviewed-on: https://chromium-review.googlesource.com/c/1401512
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621189}
[modify] https://crrev.com/7de40a92cf2ae3c4ed5350774fe688d9e8507a57/third_party/blink/renderer/core/layout/layout_frame_set.cc

Project Member

Comment 88 by bugdroid1@chromium.org, Jan 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e0b3253a56d67b05f888d8e22e7d1843da85e12e

commit e0b3253a56d67b05f888d8e22e7d1843da85e12e
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Wed Jan 09 17:44:30 2019

Fix image conversion truncation issues

Ensure operations are done under checked_math appropriately.

BUG=879657

Change-Id: Ice4cadead84b32fd5501f68bcf082e65eab1e113
Reviewed-on: https://chromium-review.googlesource.com/c/1401623
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621210}
[modify] https://crrev.com/e0b3253a56d67b05f888d8e22e7d1843da85e12e/third_party/blink/renderer/core/html/canvas/image_data.cc
[modify] https://crrev.com/e0b3253a56d67b05f888d8e22e7d1843da85e12e/third_party/blink/renderer/core/imagebitmap/image_bitmap.cc
[modify] https://crrev.com/e0b3253a56d67b05f888d8e22e7d1843da85e12e/third_party/blink/renderer/modules/canvas/canvas2d/base_rendering_context_2d.cc
[modify] https://crrev.com/e0b3253a56d67b05f888d8e22e7d1843da85e12e/third_party/blink/renderer/platform/graphics/bitmap_image.cc
[modify] https://crrev.com/e0b3253a56d67b05f888d8e22e7d1843da85e12e/third_party/blink/renderer/platform/graphics/bitmap_image_metrics.cc
[modify] https://crrev.com/e0b3253a56d67b05f888d8e22e7d1843da85e12e/third_party/blink/renderer/platform/graphics/bitmap_image_metrics.h
[modify] https://crrev.com/e0b3253a56d67b05f888d8e22e7d1843da85e12e/third_party/blink/renderer/platform/graphics/gpu/webgl_image_conversion.cc
[modify] https://crrev.com/e0b3253a56d67b05f888d8e22e7d1843da85e12e/third_party/blink/renderer/platform/image-decoders/image_decoder.cc
[modify] https://crrev.com/e0b3253a56d67b05f888d8e22e7d1843da85e12e/third_party/blink/renderer/platform/image-decoders/png/png_image_decoder.cc

Project Member

Comment 89 by bugdroid1@chromium.org, Jan 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ad6eac16ce9483edf2b027b406272f9c9e72e907

commit ad6eac16ce9483edf2b027b406272f9c9e72e907
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Thu Jan 10 16:32:13 2019

Fix 64 bit truncation error on Android

strlen(...) didn't get rolled into a constant for android with bionic
which caused a size_t->wtf_size_t conversion implicitly.

Instead use base::CharTraits to determine length.

BUG=879657

Change-Id: Icce7e505001d77a4034baf376488404334237fbe
Reviewed-on: https://chromium-review.googlesource.com/c/1404068
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621598}
[modify] https://crrev.com/ad6eac16ce9483edf2b027b406272f9c9e72e907/third_party/blink/renderer/modules/DEPS
[modify] https://crrev.com/ad6eac16ce9483edf2b027b406272f9c9e72e907/third_party/blink/renderer/modules/crypto/normalize_algorithm.cc
[modify] https://crrev.com/ad6eac16ce9483edf2b027b406272f9c9e72e907/third_party/blink/tools/blinkpy/presubmit/audit_non_blink_usage.py

Project Member

Comment 90 by bugdroid1@chromium.org, Jan 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b71814852be2ec0a4b8ee29130118655c76c5dfd

commit b71814852be2ec0a4b8ee29130118655c76c5dfd
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Thu Jan 10 19:21:00 2019

Enable 64 bit truncation warnings in blink

BUG=879657

Change-Id: I80f12446a4a7507436fa85db4b454705b841a91b
Reviewed-on: https://chromium-review.googlesource.com/c/1362207
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621694}
[modify] https://crrev.com/b71814852be2ec0a4b8ee29130118655c76c5dfd/third_party/blink/renderer/BUILD.gn

Project Member

Comment 91 by bugdroid1@chromium.org, Jan 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/84212018af795fb981327d7bebd61a417b0b43fe

commit 84212018af795fb981327d7bebd61a417b0b43fe
Author: Thomas Anderson <thomasanderson@chromium.org>
Date: Thu Jan 10 19:46:22 2019

Revert "Enable 64 bit truncation warnings in blink"

This reverts commit b71814852be2ec0a4b8ee29130118655c76c5dfd.

Reason for revert: Build failure on Linux Build (dbg)(32):
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Builder%20%28dbg%29%2832%29/97088

Original change's description:
> Enable 64 bit truncation warnings in blink
> 
> BUG=879657
> 
> Change-Id: I80f12446a4a7507436fa85db4b454705b841a91b
> Reviewed-on: https://chromium-review.googlesource.com/c/1362207
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#621694}

TBR=thakis@chromium.org,haraken@chromium.org,dtapuska@chromium.org

Change-Id: Ic4622e4193bae5fb283396f7431637ef5910be68
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 879657
Reviewed-on: https://chromium-review.googlesource.com/c/1405969
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621713}
[modify] https://crrev.com/84212018af795fb981327d7bebd61a417b0b43fe/third_party/blink/renderer/BUILD.gn

Project Member

Comment 92 by bugdroid1@chromium.org, Jan 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/471c29d68c826278f9e4444e7118bd30c22e7dbe

commit 471c29d68c826278f9e4444e7118bd30c22e7dbe
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Thu Jan 10 21:58:11 2019

Add safe cast on web_font_decoder.

Tell is returning off_t which is a 64 bit integer on 32 bit linux.

BUG=879657

Change-Id: Ic5ad29918880e268010b0921c0709910086560d4
Reviewed-on: https://chromium-review.googlesource.com/c/1405974
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621765}
[modify] https://crrev.com/471c29d68c826278f9e4444e7118bd30c22e7dbe/third_party/blink/renderer/platform/fonts/web_font_decoder.cc

Project Member

Comment 93 by bugdroid1@chromium.org, Jan 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff1adeb574ec302aec2c7e48e3fe3c68b2ca8ed6

commit ff1adeb574ec302aec2c7e48e3fe3c68b2ca8ed6
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Fri Jan 11 16:13:55 2019

Fix 64 bit truncation in BufferingBytesConsumer class

SafeCast a 64 bit integer down to a wtf_size_t

BUG=879657

Change-Id: I6d8b62a5d18f9ac11ee631f52cdbaf911c2cf597
Reviewed-on: https://chromium-review.googlesource.com/c/1406934
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622021}
[modify] https://crrev.com/ff1adeb574ec302aec2c7e48e3fe3c68b2ca8ed6/third_party/blink/renderer/core/fetch/buffering_bytes_consumer.cc

Project Member

Comment 94 by bugdroid1@chromium.org, Jan 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6eb051d141c5c893db87118941a092e16dc2cdd2

commit 6eb051d141c5c893db87118941a092e16dc2cdd2
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Fri Jan 11 17:10:02 2019

Reland "Enable 64 bit truncation warnings in blink"

This is a reland of b71814852be2ec0a4b8ee29130118655c76c5dfd

Original change's description:
> Enable 64 bit truncation warnings in blink
>
> BUG=879657
>
> Change-Id: I80f12446a4a7507436fa85db4b454705b841a91b
> Reviewed-on: https://chromium-review.googlesource.com/c/1362207
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#621694}

Bug: 879657
Change-Id: I2635dc3f93f93dbe05f059a91740d0d4305e39ae
Reviewed-on: https://chromium-review.googlesource.com/c/1406130
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622036}
[modify] https://crrev.com/6eb051d141c5c893db87118941a092e16dc2cdd2/third_party/blink/renderer/BUILD.gn

Project Member

Comment 95 by bugdroid1@chromium.org, Jan 16 (6 days ago)

The following revision refers to this bug:
  https://boringssl.googlesource.com/boringssl/+/823effe97507d036f660c6c65203f7551d5f0a99

commit 823effe97507d036f660c6c65203f7551d5f0a99
Author: Adam Langley <alangley@gmail.com>
Date: Wed Jan 16 20:02:16 2019

Revert "Fix protos_len size in SSL_set_alpn_protos and SSL_CTX_set_alpn_protos"

This reverts commit 35771ff8afc2201b5cf5b884db5b3889edde06bc. It breaks
tcnetty, which is tcnetty's fault but we have a large backlog from
Christmas to break with at the moment.

Bug: chromium:879657
Change-Id: Iafe93b335d88722170ec2689a25e145969e19e73
Reviewed-on: https://boringssl-review.googlesource.com/c/34324
Commit-Queue: David Benjamin <davidben@google.com>
Reviewed-by: David Benjamin <davidben@google.com>

[modify] https://crrev.com/823effe97507d036f660c6c65203f7551d5f0a99/ssl/ssl_lib.cc
[modify] https://crrev.com/823effe97507d036f660c6c65203f7551d5f0a99/include/openssl/ssl.h

Project Member

Comment 96 by bugdroid1@chromium.org, Jan 18 (4 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/28f870bb1f2407e086d9311eaa102675a801a4d5

commit 28f870bb1f2407e086d9311eaa102675a801a4d5
Author: Raul Tambre <raul@tambre.ee>
Date: Fri Jan 18 20:25:51 2019

Fix some 64-bit truncation issues in //ui/gfx

Bug: 879657
Change-Id: I05080f0c3fdeb5b4ca3df3536a36d16c2b90a5df
Reviewed-on: https://chromium-review.googlesource.com/c/1396124
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Raul Tambre <raul@tambre.ee>
Cr-Commit-Position: refs/heads/master@{#624259}
[modify] https://crrev.com/28f870bb1f2407e086d9311eaa102675a801a4d5/ui/gfx/harfbuzz_font_skia.cc
[modify] https://crrev.com/28f870bb1f2407e086d9311eaa102675a801a4d5/ui/gfx/icon_util.cc
[modify] https://crrev.com/28f870bb1f2407e086d9311eaa102675a801a4d5/ui/gfx/icon_util.h
[modify] https://crrev.com/28f870bb1f2407e086d9311eaa102675a801a4d5/ui/gfx/paint_vector_icon.cc
[modify] https://crrev.com/28f870bb1f2407e086d9311eaa102675a801a4d5/ui/gfx/render_text.cc
[modify] https://crrev.com/28f870bb1f2407e086d9311eaa102675a801a4d5/ui/gfx/render_text_harfbuzz.cc
[modify] https://crrev.com/28f870bb1f2407e086d9311eaa102675a801a4d5/ui/gfx/text_elider.cc

Project Member

Comment 97 by bugdroid1@chromium.org, Yesterday (33 hours ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f191b595fb58d9e29ba46fd70628bc9cd36b98d0

commit f191b595fb58d9e29ba46fd70628bc9cd36b98d0
Author: Raul Tambre <raul@tambre.ee>
Date: Mon Jan 21 23:56:29 2019

Fix various 64-bit truncation issues in //base

TBR=palmer per https://chromium-review.googlesource.com/c/chromium/src/+/812216/5#message-5576928821c2a59b57af3563fef0ae4b8d49a2ce

Bug: 879657
Change-Id: I21bc35ee1ba5cb88d60092b6b129e933ac522eb4
Reviewed-on: https://chromium-review.googlesource.com/c/1422446
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624696}
[modify] https://crrev.com/f191b595fb58d9e29ba46fd70628bc9cd36b98d0/base/big_endian.h
[modify] https://crrev.com/f191b595fb58d9e29ba46fd70628bc9cd36b98d0/base/big_endian_unittest.cc
[modify] https://crrev.com/f191b595fb58d9e29ba46fd70628bc9cd36b98d0/base/files/file_util_unittest.cc
[modify] https://crrev.com/f191b595fb58d9e29ba46fd70628bc9cd36b98d0/base/i18n/time_formatting.cc
[modify] https://crrev.com/f191b595fb58d9e29ba46fd70628bc9cd36b98d0/base/json/json_parser.cc
[modify] https://crrev.com/f191b595fb58d9e29ba46fd70628bc9cd36b98d0/base/json/json_parser.h
[modify] https://crrev.com/f191b595fb58d9e29ba46fd70628bc9cd36b98d0/base/memory/discardable_shared_memory_unittest.cc
[modify] https://crrev.com/f191b595fb58d9e29ba46fd70628bc9cd36b98d0/base/memory/shared_memory_unittest.cc
[modify] https://crrev.com/f191b595fb58d9e29ba46fd70628bc9cd36b98d0/base/pickle.cc
[modify] https://crrev.com/f191b595fb58d9e29ba46fd70628bc9cd36b98d0/base/pickle.h
[modify] https://crrev.com/f191b595fb58d9e29ba46fd70628bc9cd36b98d0/base/task/task_scheduler/scheduler_single_thread_task_runner_manager.cc
[modify] https://crrev.com/f191b595fb58d9e29ba46fd70628bc9cd36b98d0/base/task/task_scheduler/scheduler_worker_pool_impl.cc
[modify] https://crrev.com/f191b595fb58d9e29ba46fd70628bc9cd36b98d0/base/task/task_scheduler/scheduler_worker_pool_impl.h
[modify] https://crrev.com/f191b595fb58d9e29ba46fd70628bc9cd36b98d0/base/task/task_scheduler/task_tracker.cc
[modify] https://crrev.com/f191b595fb58d9e29ba46fd70628bc9cd36b98d0/base/task/task_scheduler/task_tracker.h
[modify] https://crrev.com/f191b595fb58d9e29ba46fd70628bc9cd36b98d0/base/task/task_scheduler/task_tracker_unittest.cc
[modify] https://crrev.com/f191b595fb58d9e29ba46fd70628bc9cd36b98d0/base/trace_event/trace_config.cc
[modify] https://crrev.com/f191b595fb58d9e29ba46fd70628bc9cd36b98d0/base/win/registry.cc
[modify] https://crrev.com/f191b595fb58d9e29ba46fd70628bc9cd36b98d0/base/win/scoped_bstr.cc
[modify] https://crrev.com/f191b595fb58d9e29ba46fd70628bc9cd36b98d0/base/win/scoped_hstring.cc
[modify] https://crrev.com/f191b595fb58d9e29ba46fd70628bc9cd36b98d0/media/remoting/proto_utils.cc

►

Issue 879657 link

Issue metadata

enable -Wshorten-64-to-32 for 64-bit builds

Issue description

Comment 1 by bugdroid1@chromium.org, Aug 31

Comment 1 Deleted

Comment 2 by bugdroid1@chromium.org, Sep 1

Comment 2 Deleted

Comment 3 by dtapu...@chromium.org, Sep 4

Comment 3 Deleted

Comment 4 by wfh@chromium.org, Sep 4

Comment 4 Deleted

Comment 5 by wfh@chromium.org, Sep 5

Comment 5 Deleted

Comment 6 by wfh@chromium.org, Sep 7

Comment 6 Deleted

Comment 7 by bugdroid1@chromium.org, Sep 8

Comment 7 Deleted

Comment 8 by bugdroid1@chromium.org, Sep 10

Comment 8 Deleted

Comment 9 by bugdroid1@chromium.org, Sep 11

Comment 9 Deleted

Comment 10 by bugdroid1@chromium.org, Sep 11

Comment 10 Deleted

Comment 11 by bugdroid1@chromium.org, Sep 11

Comment 11 Deleted

Comment 12 by bugdroid1@chromium.org, Sep 11

Comment 12 Deleted

Comment 13 by bugdroid1@chromium.org, Sep 11

Comment 13 Deleted

Comment 14 by bugdroid1@chromium.org, Sep 11

Comment 14 Deleted

Comment 15 by wfh@chromium.org, Sep 11

Comment 15 Deleted

Comment 16 by bugdroid1@chromium.org, Sep 17

Comment 16 Deleted

Comment 17 by bugdroid1@chromium.org, Sep 18

Comment 17 Deleted

Comment 18 by bugdroid1@chromium.org, Sep 18

Comment 18 Deleted

Comment 19 by bugdroid1@chromium.org, Sep 18

Comment 19 Deleted

Comment 20 by bugdroid1@chromium.org, Sep 19

Comment 20 Deleted

Comment 21 by bugdroid1@chromium.org, Sep 20

Comment 21 Deleted

Comment 22 by bugdroid1@chromium.org, Sep 20

Comment 22 Deleted

Comment 23 by bugdroid1@chromium.org, Sep 20

Comment 23 Deleted

Comment 24 by bugdroid1@chromium.org, Sep 24

Comment 24 Deleted

Comment 25 by bugdroid1@chromium.org, Sep 25

Comment 25 Deleted

Comment 26 by bugdroid1@chromium.org, Oct 3

Comment 26 Deleted

Comment 27 by bugdroid1@chromium.org, Oct 3

Comment 27 Deleted

Comment 28 by bugdroid1@chromium.org, Oct 3

Comment 28 Deleted

Comment 29 by bugdroid1@chromium.org, Oct 4

Comment 29 Deleted

Comment 30 by bugdroid1@chromium.org, Oct 4

Comment 30 Deleted

Comment 31 by bugdroid1@chromium.org, Oct 9

Comment 31 Deleted

Comment 32 by bugdroid1@chromium.org, Oct 9

Comment 32 Deleted

Comment 33 by bugdroid1@chromium.org, Oct 10

Comment 33 Deleted

Comment 34 by bugdroid1@chromium.org, Oct 10

Comment 34 Deleted

Comment 35 by bugdroid1@chromium.org, Oct 12

Comment 35 Deleted

Comment 36 by bugdroid1@chromium.org, Oct 12

Comment 36 Deleted

Comment 37 by bugdroid1@chromium.org, Oct 16

Comment 37 Deleted

Comment 38 by bugdroid1@chromium.org, Oct 16

Comment 38 Deleted