New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 879644 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows , Mac
Pri: 1
Type: Bug



Sign in to add a comment

ChromeContentRendererClientMetricsTest.RewriteEmbedSuccessRewrite Disabled

Project Member Reported by oksamyt@google.com, Aug 31

Issue description

This test is reported as flaky:  https://crbug.com/879624 









 
Components: Internals>Metrics
Labels: OS-Mac OS-Windows
Owner: mlamouri@chromium.org
It was not obvious to me which component and owner to assign, please advise if I got it wrong.
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/05130b79fdee61ca98f66c3a6973f7451fed26ad

commit 05130b79fdee61ca98f66c3a6973f7451fed26ad
Author: Oksana Zhuravlova <oksamyt@chromium.org>
Date: Fri Aug 31 19:27:51 2018

Disable flaky ChromeContentRendererClientMetricsTest.RewriteEmbedSuccessRewrite

Bug:  879644 

Change-Id: I8090ee6d00d59887a1161332cc6f85143f46b3ac

TBR=sky@chromium.org

Change-Id: I8090ee6d00d59887a1161332cc6f85143f46b3ac
Reviewed-on: https://chromium-review.googlesource.com/1200104
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588112}
[modify] https://crrev.com/05130b79fdee61ca98f66c3a6973f7451fed26ad/chrome/renderer/chrome_content_renderer_client_unittest.cc

Status: Assigned (was: Unconfirmed)
Cc: mlamouri@chromium.org
 Issue 879624  has been merged into this issue.
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/42eb495a6580674a67f934111eb6ce1b9d898afd

commit 42eb495a6580674a67f934111eb6ce1b9d898afd
Author: Mounir Lamouri <mlamouri@chromium.org>
Date: Wed Jan 02 15:53:32 2019

Flash Embed Rewrite: re-enable tests that were disabled on Mac/Windows.

Looking at the stack from the tests, it's unclear how it was related to
the code it's testing. Re-enabling the tests may help figure out if it
was a temporary issue.

Bug:  879644 
Change-Id: I2ea2d95e7f24f71f86e2c147017bb7d01a563323
Reviewed-on: https://chromium-review.googlesource.com/c/1382477
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619408}
[modify] https://crrev.com/42eb495a6580674a67f934111eb6ce1b9d898afd/chrome/renderer/media/flash_embed_rewrite_unittest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment