New issue
Advanced search Search tips

Issue 879630 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 6
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 754101


Participants' hotlists:
Harmony-Cast-Dialog


Sign in to add a comment

[Harmony Cast Dialog] Make the "no devices found" view match the mocks

Project Member Reported by taku...@chromium.org, Aug 31

Issue description

The position of the throbber and help icon and their padding must be adjusted to match the mocks here:
go/presentation/d/1q2scOvS_tGbl8H0MMbfJ3jNTIuH4ZDMI9FhOyZgs634/edit#slide=id.g4028094dfd_3_160
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fd82957ce10daaff873fc0dbd97330f82e154327

commit fd82957ce10daaff873fc0dbd97330f82e154327
Author: Takumi Fujimoto <takumif@chromium.org>
Date: Thu Sep 06 17:36:37 2018

[Harmony Cast Dialog] Update the "no devices found" view to match the mocks

Per the mocks, move the throbber and the info icon to the left of the view.
Also factor out constants and throbber creating code into a helper file.
Screencap: https://drive.google.com/open?id=1UF1uamxoR0oG-3aEHwdJkoHU_7pJW_CB

Bug:  879630 
Change-Id: I42ee54d063df0f9af74cad10a4a21a9a8f78a869
Reviewed-on: https://chromium-review.googlesource.com/1199945
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589206}
[modify] https://crrev.com/fd82957ce10daaff873fc0dbd97330f82e154327/chrome/browser/ui/BUILD.gn
[add] https://crrev.com/fd82957ce10daaff873fc0dbd97330f82e154327/chrome/browser/ui/views/media_router/cast_dialog_helper.cc
[add] https://crrev.com/fd82957ce10daaff873fc0dbd97330f82e154327/chrome/browser/ui/views/media_router/cast_dialog_helper.h
[modify] https://crrev.com/fd82957ce10daaff873fc0dbd97330f82e154327/chrome/browser/ui/views/media_router/cast_dialog_no_sinks_view.cc
[modify] https://crrev.com/fd82957ce10daaff873fc0dbd97330f82e154327/chrome/browser/ui/views/media_router/cast_dialog_sink_button.cc
[modify] https://crrev.com/fd82957ce10daaff873fc0dbd97330f82e154327/chrome/browser/ui/views/media_router/cast_dialog_sink_button.h

Status: Fixed (was: Assigned)

Sign in to add a comment