Info msg icon temporarily replaces stop casting icon for active session. |
||
Issue descriptionPlatform: Mac Chrome: M70 with Harmony UI. What steps will reproduce the problem? (1) Change the source to "Cast desktop". (2) Select a device. (3) Click "Share" in the OS's system dialog. (4) Casting desktop will start. (5) Open the Media Router dialog, and observe the UI regarding this cast session and device. What is the expected result? I expected to see a stop icon next to the active session/device. This might not be a bug. The UI does match the mocks for issue msgs. But, there isn't a specific mock for the types of issue messages that appear after successful connections. So I'm not sure if it was considered. What happens instead? In place of the blue stop icon is a grey info icon. The issue icon does automatically disappear after some timeout, then the stop icon appears. I'm not sure what the logic is or the exact timeout, but it felt like ~ 30 seconds. During that time the dialog can be closed and re-opened and the issue icon persists.
,
Sep 6
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/03c59d8902e82924e48e05fc951c591907e6e8ea commit 03c59d8902e82924e48e05fc951c591907e6e8ea Author: Takumi Fujimoto <takumif@chromium.org> Date: Thu Sep 06 19:12:09 2018 [Harmony Cast Dialog] Show stop button even if there is an issue The stop button and the issue icon share the same space in sink item UI, so when both are present (i.e. when a sink has both a route and an issue) we must ensure that the stop button is shown, so that the user can stop the route. Bug: 879627 Change-Id: I73751190dec2cde98b9568e7ebb4b2cea8516dea Reviewed-on: https://chromium-review.googlesource.com/1208818 Reviewed-by: mark a. foltz <mfoltz@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#589232} [modify] https://crrev.com/03c59d8902e82924e48e05fc951c591907e6e8ea/chrome/browser/ui/views/media_router/cast_dialog_sink_button.cc
,
Sep 6
|
||
►
Sign in to add a comment |
||
Comment 1 by taku...@chromium.org
, Aug 31Labels: -Pri-3 Target-71 Pri-1
Status: Assigned (was: Untriaged)
Summary: Info msg icon temporarily replaces stop casting icon for active session. (was: Info msg temporarily replaces stop casting icon for active session. )