New issue
Advanced search Search tips

Issue 879605 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 16
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 836886



Sign in to add a comment

[BlinkGenPropertyTrees] compositing/overflow-trumps-transform-style.html is failing

Project Member Reported by pdr@chromium.org, Aug 31

Issue description

This test has what looks like an ordering issue.
 
Status: Available (was: Untriaged)
Labels: -Pri-3 Pri-2
Owner: wangxianzhu@chromium.org
Status: Assigned (was: Available)
A reduced test case:

<!DOCTYPE html>
<div style="transform-style: preserve-3d">
  <div style="transform: translate3d(0, 0, 30px)">
    <div style="width: 100px; height: 100px; background: green; will-change: transform"></div>
  </div>
  <div style="width: 100px; height: 100px; background: red; transform: translate3d(0, -100px, 20px)"></div>
</div>

Expected: green square; Actual: red square.

"transform-style: preserve-3d" on the top-level div seems mistakenly ignored.
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1dedda961f7fbde6f069fe0a3b0d82193c2bfa5a

commit 1dedda961f7fbde6f069fe0a3b0d82193c2bfa5a
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Sun Sep 16 00:08:43 2018

[BGPT] Force render surface for 3d object flattening its subtree

For non-BGPT, this is done in PropertyTreeBuilder
(https://cs.chromium.org/chromium/src/cc/trees/property_tree_builder.cc?rcl=929c1eea7c58e4d656a57837e6161c88d79cbec8&l=809)
by forcing render surface via a cc effect node.

Now do the same for BGPT.

Bug:  879605 
Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ia1f61f27a04c0d0feaf67911767c7d1ea06cb9c5
Reviewed-on: https://chromium-review.googlesource.com/1224598
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591596}
[modify] https://crrev.com/1dedda961f7fbde6f069fe0a3b0d82193c2bfa5a/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-gen-property-trees
[modify] https://crrev.com/1dedda961f7fbde6f069fe0a3b0d82193c2bfa5a/third_party/blink/renderer/core/paint/paint_property_tree_builder.cc
[modify] https://crrev.com/1dedda961f7fbde6f069fe0a3b0d82193c2bfa5a/third_party/blink/renderer/core/paint/paint_property_tree_builder_test.cc
[modify] https://crrev.com/1dedda961f7fbde6f069fe0a3b0d82193c2bfa5a/third_party/blink/renderer/platform/graphics/compositing/paint_artifact_compositor.cc
[modify] https://crrev.com/1dedda961f7fbde6f069fe0a3b0d82193c2bfa5a/third_party/blink/renderer/platform/graphics/compositing/property_tree_manager.cc
[modify] https://crrev.com/1dedda961f7fbde6f069fe0a3b0d82193c2bfa5a/third_party/blink/renderer/platform/graphics/paint/transform_paint_property_node.h

Status: Fixed (was: Assigned)

Sign in to add a comment