New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 879604 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Yesterday
Cc:
Components:
EstimatedDays: ----
NextAction: 2019-01-21
OS: ----
Pri: 2
Type: Bug-Regression

Blocking:
issue 843945



Sign in to add a comment

wpt/cookies/samesite/ layout tests fail on V8 downstream bots

Project Member Reported by machenb...@chromium.org, Aug 31

Issue description

Started here:
https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8-Blink%20Linux%2064/25965

Several different tests fail flakily. Suspecting https://crrev.com/c/1196547 ?

These seem to not fail on Chromium side. Maybe it's because V8's bots are not on swarming? I.e. some test order problem?
 
The suspect CL deletes the expectations files from the tests that now started failing. What's the expected behavior when the expectations files are deleted but the tests not?
I'll disable those tests on V8-side until this is clarified.
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 31

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/bc1872d9f6801c0e0e32582d793412a158f59e28

commit bc1872d9f6801c0e0e32582d793412a158f59e28
Author: Michael Achenbach <machenbach@chromium.org>
Date: Fri Aug 31 16:17:14 2018

[test] Skip some layout tests on V8 side

TBR=mslekova@chromium.org
NOTRY=true

Bug:  chromium:879604 
Change-Id: I051837bae866f391ec5f1555b845cd66cc9f777a
Reviewed-on: https://chromium-review.googlesource.com/1199285
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55560}
[modify] https://crrev.com/bc1872d9f6801c0e0e32582d793412a158f59e28/tools/blink_tests/TestExpectations

Owner: mkwst@chromium.org
Status: Assigned (was: Untriaged)
Mike could you take a look please?
How are y'all running the tests on the v8 bot? The patch in question changed some behavior in `content_shell` running in layout test mode. Are y'all using the same infrastructure?
I think we run the tests the same way Chromium does, except we're not using swarming. So our test order is different, but nothing else I think.
Cc: chlily@chromium.org mef@chromium.org mmenke@chromium.org morlovich@chromium.org
Labels: Hotlist-Cookies
Owner: ----
Status: Untriaged (was: Assigned)
(Unassigning myself, marking untriaged in preparation to retriage with folks who will do a better job taking care of cookies than I've been able to)

Comment 8 by machenbach@google.com, Jan 18 (4 days ago)

NextAction: 2019-01-21
We've migrated V8 testing to swarming, which also solved https://crbug.com/920545. I unskipped these tests now here for the V8 builders:
https://crrev.com/c/1421318

Will check back if everything stays green and then closed this.

Comment 9 by machenbach@google.com, Jan 18 (4 days ago)

Owner: machenb...@chromium.org
Status: Assigned (was: Untriaged)

Comment 10 by monor...@bugs.chromium.org, Yesterday (45 hours ago)

The NextAction date has arrived: 2019-01-21

Comment 11 by machenb...@chromium.org, Yesterday (45 hours ago)

Status: Verified (was: Assigned)
Doesn't fail anymore.

Sign in to add a comment