Issue metadata
Sign in to add a comment
|
wpt/cookies/samesite/ layout tests fail on V8 downstream bots |
||||||||||||||||||||||
Issue descriptionStarted here: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8-Blink%20Linux%2064/25965 Several different tests fail flakily. Suspecting https://crrev.com/c/1196547 ? These seem to not fail on Chromium side. Maybe it's because V8's bots are not on swarming? I.e. some test order problem?
,
Aug 31
I'll disable those tests on V8-side until this is clarified.
,
Aug 31
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/bc1872d9f6801c0e0e32582d793412a158f59e28 commit bc1872d9f6801c0e0e32582d793412a158f59e28 Author: Michael Achenbach <machenbach@chromium.org> Date: Fri Aug 31 16:17:14 2018 [test] Skip some layout tests on V8 side TBR=mslekova@chromium.org NOTRY=true Bug: chromium:879604 Change-Id: I051837bae866f391ec5f1555b845cd66cc9f777a Reviewed-on: https://chromium-review.googlesource.com/1199285 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#55560} [modify] https://crrev.com/bc1872d9f6801c0e0e32582d793412a158f59e28/tools/blink_tests/TestExpectations
,
Sep 7
Mike could you take a look please?
,
Sep 7
How are y'all running the tests on the v8 bot? The patch in question changed some behavior in `content_shell` running in layout test mode. Are y'all using the same infrastructure?
,
Sep 7
I think we run the tests the same way Chromium does, except we're not using swarming. So our test order is different, but nothing else I think.
,
Oct 4
(Unassigning myself, marking untriaged in preparation to retriage with folks who will do a better job taking care of cookies than I've been able to)
,
Jan 18
(4 days ago)
We've migrated V8 testing to swarming, which also solved https://crbug.com/920545. I unskipped these tests now here for the V8 builders: https://crrev.com/c/1421318 Will check back if everything stays green and then closed this.
,
Jan 18
(4 days ago)
,
Yesterday
(45 hours ago)
The NextAction date has arrived: 2019-01-21
,
Yesterday
(45 hours ago)
Doesn't fail anymore. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by machenb...@chromium.org
, Aug 31