It2Me Native Message Host crash |
|||||
Issue descriptionThis morning I noticed that I could not use It2Me on any platform using the latest M70 build. This is because of a recent change to migrate to SimpleURLLoader: https://chromium-review.googlesource.com/1194042 The fix is to add the missing Mojo dependency to the binary. I missed this in CL as I had thought we already added this dependency to our exes but the NMH binary must have been missed in that work. The fix is simple and will need to be merged to M70.
,
Aug 31
This CL does not affect the browser (only used by Chrome Remote Desktop).
,
Aug 31
Requesting merge for M70.
,
Sep 1
Your change meets the bar and is auto-approved for M70. Please go ahead and merge the CL to branch 3538 manually. Please contact milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/347a697a80e033f209d251ba3824dbe1fe6f8721 commit 347a697a80e033f209d251ba3824dbe1fe6f8721 Author: Joe Downing <joedow@chromium.org> Date: Tue Sep 04 16:11:31 2018 It2Me Native Messaging Host crash This is a regression caused by the recent migration to SimpleUrlLoader: https://chromium-review.googlesource.com/1194042 I had thought all of our binaries now had the correct Mojo dependencies added but it looks like the NMH binary was missed. Bug: 879593 Change-Id: I2858524d1d78abce45e7a6a34a8739ad47320a5e Reviewed-on: https://chromium-review.googlesource.com/1199705 Reviewed-by: Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#588068}(cherry picked from commit 82548bb487484b95a1b6d2f5031dee6e31d860e8) Reviewed-on: https://chromium-review.googlesource.com/1204431 Reviewed-by: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#25} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/347a697a80e033f209d251ba3824dbe1fe6f8721/remoting/host/it2me/BUILD.gn [modify] https://crrev.com/347a697a80e033f209d251ba3824dbe1fe6f8721/remoting/host/it2me/it2me_native_messaging_host_main.cc
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/347a697a80e033f209d251ba3824dbe1fe6f8721 commit 347a697a80e033f209d251ba3824dbe1fe6f8721 Author: Joe Downing <joedow@chromium.org> Date: Tue Sep 04 16:11:31 2018 It2Me Native Messaging Host crash This is a regression caused by the recent migration to SimpleUrlLoader: https://chromium-review.googlesource.com/1194042 I had thought all of our binaries now had the correct Mojo dependencies added but it looks like the NMH binary was missed. Bug: 879593 Change-Id: I2858524d1d78abce45e7a6a34a8739ad47320a5e Reviewed-on: https://chromium-review.googlesource.com/1199705 Reviewed-by: Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#588068}(cherry picked from commit 82548bb487484b95a1b6d2f5031dee6e31d860e8) Reviewed-on: https://chromium-review.googlesource.com/1204431 Reviewed-by: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#25} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/347a697a80e033f209d251ba3824dbe1fe6f8721/remoting/host/it2me/BUILD.gn [modify] https://crrev.com/347a697a80e033f209d251ba3824dbe1fe6f8721/remoting/host/it2me/it2me_native_messaging_host_main.cc
,
Sep 4
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/347a697a80e033f209d251ba3824dbe1fe6f8721 commit 347a697a80e033f209d251ba3824dbe1fe6f8721 Author: Joe Downing <joedow@chromium.org> Date: Tue Sep 04 16:11:31 2018 It2Me Native Messaging Host crash This is a regression caused by the recent migration to SimpleUrlLoader: https://chromium-review.googlesource.com/1194042 I had thought all of our binaries now had the correct Mojo dependencies added but it looks like the NMH binary was missed. Bug: 879593 Change-Id: I2858524d1d78abce45e7a6a34a8739ad47320a5e Reviewed-on: https://chromium-review.googlesource.com/1199705 Reviewed-by: Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#588068}(cherry picked from commit 82548bb487484b95a1b6d2f5031dee6e31d860e8) Reviewed-on: https://chromium-review.googlesource.com/1204431 Reviewed-by: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#25} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/347a697a80e033f209d251ba3824dbe1fe6f8721/remoting/host/it2me/BUILD.gn [modify] https://crrev.com/347a697a80e033f209d251ba3824dbe1fe6f8721/remoting/host/it2me/it2me_native_messaging_host_main.cc |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, Aug 31