Issue metadata
Sign in to add a comment
|
Picture-in-Picture: DCHECK crash when starting video after reload |
||||||||||||||||||||||
Issue descriptionChrome Version : trunk OS Version: Linux URLs (if applicable) : https://www.w3.org/2010/05/video/mediaevents.html What steps will reproduce the problem? 1. Play video 2. Send to PIP 3. Close PIP window 5. Reload Page 6. Play video What is the expected result? Video plays What happens instead of that? Browser crash :( Worth checking if it's also an issue on Canary as we may need to merge something.
,
Aug 31
,
Aug 31
Oh, I should have mentioned: this is hitting a DCHECK. I did not try if it was actually crashing on a release build. Did you try with DCHECK enable?
,
Aug 31
Issue 877685 has been merged into this issue.
,
Aug 31
Ok, running into it here with is_debug=true [209696:209696:0831/140412.715623:FATAL:picture_in_picture_window_controller_impl.cc(167)] Check failed: media_player_id_.has_value(). #0 0x7fccb9c3d3ed base::debug::StackTrace::StackTrace() #1 0x7fccb9948b1c base::debug::StackTrace::StackTrace() #2 0x7fccb99b850a logging::LogMessage::~LogMessage() #3 0x7fccb5024524 content::PictureInPictureWindowControllerImpl::UpdatePlaybackState() #4 0x7fccb4f3fb57 content::MediaWebContentsObserver::OnMediaPaused() #5 0x7fccb4f4422c _ZN3IPC20DispatchToMethodImplIN7content24MediaWebContentsObserverEMS2_FvPNS1_15RenderFrameHostEibES3_NSt3__15tupleIJibEEEJLm0ELm1EEEEvPT_T0_PT1_OT2_NS7_16integer_sequenceImJXspT3_EEEE #6 0x7fccb4f44130 _ZN3IPC16DispatchToMethodIN7content24MediaWebContentsObserverENS1_15RenderFrameHostEJibENSt3__15tupleIJibEEEEENS4_9enable_ifIXeqsZT1_sr3std10tuple_sizeINS4_5decayIT2_E4typeEEE5valueEvE4typeEPT_MSE_FvPT0_DpT1_ESH_OS9_ #7 0x7fccb4f41fe0 _ZN3IPC8MessageTI45MediaPlayerDelegateHostMsg_OnMediaPaused_MetaNSt3__15tupleIJibEEEvE8DispatchIN7content24MediaWebContentsObserverES8_NS7_15RenderFrameHostEMS8_FvPS9_ibEEEbPKNS_7MessageEPT_PT0_PT1_T2_ #8 0x7fccb4f3f725 content::MediaWebContentsObserver::OnMessageReceived() #9 0x7fccb5530bb3 content::WebContentsImpl::OnMessageReceived() #10 0x7fccb4bd15cc content::RenderFrameHostImpl::OnMessageReceived() #11 0x7fccb51c90b3 content::RenderProcessHostImpl::OnMessageReceived() #12 0x7fccb7c9e645 IPC::ChannelProxy::Context::OnDispatchMessage() #13 0x7fccb7ca478f _ZN4base8internal13FunctorTraitsIMN3IPC12ChannelProxy7ContextEFvRKNS2_7MessageEEvE6InvokeIS9_RK13scoped_refptrIS4_EJS7_EEEvT_OT0_DpOT1_ #14 0x7fccb7ca46ef _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIRKMN3IPC12ChannelProxy7ContextEFvRKNS4_7MessageEEJRK13scoped_refptrIS6_ES9_EEEvOT_DpOT0_ #15 0x7fccb7ca467d _ZN4base8internal7InvokerINS0_9BindStateIMN3IPC12ChannelProxy7ContextEFvRKNS3_7MessageEEJ13scoped_refptrIS5_ES6_EEEFvvEE7RunImplIRKSA_RKNSt3__15tupleIJSC_S6_EEEJLm0ELm1EEEEvOT_OT0_NSJ_16integer_sequenceImJXspT1_EEEE #16 0x7fccb7ca457c _ZN4base8internal7InvokerINS0_9BindStateIMN3IPC12ChannelProxy7ContextEFvRKNS3_7MessageEEJ13scoped_refptrIS5_ES6_EEEFvvEE3RunEPNS0_13BindStateBaseE #17 0x7fccb98f73fe _ZNO4base12OnceCallbackIFvvEE3RunEv #18 0x7fccb9949fe2 base::debug::TaskAnnotator::RunTask() #19 0x7fccb99dbf66 base::MessageLoop::RunTask() #20 0x7fccb99dc2ee base::MessageLoop::DeferOrRunPendingTask() #21 0x7fccb99dc779 base::MessageLoop::DoWork() #22 0x7fccb99e3b86 base::MessagePumpGlib::Run() #23 0x7fccb99db65b base::MessageLoop::Run() #24 0x7fccb9a83cfd base::RunLoop::Run() #25 0x559d3282be33 ChromeBrowserMainParts::MainMessageLoopRun() #26 0x7fccb46af641 content::BrowserMainLoop::RunMainMessageLoopParts() #27 0x7fccb46b7710 content::BrowserMainRunnerImpl::Run() #28 0x7fccb46a27c0 content::BrowserMain() #29 0x7fccb6601e44 content::RunBrowserProcessMain() #30 0x7fccb660472b content::ContentMainRunnerImpl::Run() #31 0x7fccb65f962c content::ContentServiceManagerMainDelegate::RunEmbedderProcess() #32 0x7fccb9ee480a service_manager::Main() #33 0x7fccb65ff883 content::ContentMain() #34 0x559d30917246 ChromeMain #35 0x559d30917152 main #36 0x7fcc8f3072b1 __libc_start_main #37 0x559d3091702a _start
,
Sep 20
,
Sep 20
,
Sep 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/831a1ec9ca49586b323d13d4e9b11c355deff761 commit 831a1ec9ca49586b323d13d4e9b11c355deff761 Author: François Beaufort <beaufort.francois@gmail.com> Date: Wed Sep 26 19:52:10 2018 [Picture-in-Picture] Reset MediaPlayerId when user closes PiP window. This makes sure the MediaPlayerId of the Picture-in-Picture video is reset when user closes Picture-in-Picture window manually or when user requests Picture-in-Picture several times. Bug: 879592 , 889011 Change-Id: I3ceea8de7fc5ee0e2c81268154daaa065b29b92b Reviewed-on: https://chromium-review.googlesource.com/1236276 Reviewed-by: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#594441} [modify] https://crrev.com/831a1ec9ca49586b323d13d4e9b11c355deff761/chrome/browser/picture_in_picture/picture_in_picture_window_controller_browsertest.cc [modify] https://crrev.com/831a1ec9ca49586b323d13d4e9b11c355deff761/content/browser/media/media_web_contents_observer.cc [modify] https://crrev.com/831a1ec9ca49586b323d13d4e9b11c355deff761/content/browser/media/media_web_contents_observer.h [modify] https://crrev.com/831a1ec9ca49586b323d13d4e9b11c355deff761/content/browser/picture_in_picture/picture_in_picture_window_controller_impl.cc
,
Sep 26
,
Oct 3
,
Oct 3
This bug requires manual review: We are only 12 days from stable. Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 3
,
Oct 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/09b2b7de767653f017ac4dfecbc133e830e276d1 commit 09b2b7de767653f017ac4dfecbc133e830e276d1 Author: François Beaufort <beaufort.francois@gmail.com> Date: Thu Oct 04 07:37:11 2018 [Picture-in-Picture] Reset MediaPlayerId when user closes PiP window. This makes sure the MediaPlayerId of the Picture-in-Picture video is reset when user closes Picture-in-Picture window manually or when user requests Picture-in-Picture several times. Bug: 879592 , 889011 Change-Id: I3ceea8de7fc5ee0e2c81268154daaa065b29b92b Reviewed-on: https://chromium-review.googlesource.com/1236276 Reviewed-by: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Original-Commit-Position: refs/heads/master@{#594441}(cherry picked from commit 831a1ec9ca49586b323d13d4e9b11c355deff761) Reviewed-on: https://chromium-review.googlesource.com/c/1260129 Reviewed-by: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/branch-heads/3538@{#848} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/09b2b7de767653f017ac4dfecbc133e830e276d1/chrome/browser/picture_in_picture/picture_in_picture_window_controller_browsertest.cc [modify] https://crrev.com/09b2b7de767653f017ac4dfecbc133e830e276d1/content/browser/media/media_web_contents_observer.cc [modify] https://crrev.com/09b2b7de767653f017ac4dfecbc133e830e276d1/content/browser/media/media_web_contents_observer.h [modify] https://crrev.com/09b2b7de767653f017ac4dfecbc133e830e276d1/content/browser/picture_in_picture/picture_in_picture_window_controller_impl.cc
,
Oct 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/09b2b7de767653f017ac4dfecbc133e830e276d1 Commit: 09b2b7de767653f017ac4dfecbc133e830e276d1 Author: beaufort.francois@gmail.com Commiter: beaufort.francois@gmail.com Date: 2018-10-04 07:37:11 +0000 UTC [Picture-in-Picture] Reset MediaPlayerId when user closes PiP window. This makes sure the MediaPlayerId of the Picture-in-Picture video is reset when user closes Picture-in-Picture window manually or when user requests Picture-in-Picture several times. Bug: 879592 , 889011 Change-Id: I3ceea8de7fc5ee0e2c81268154daaa065b29b92b Reviewed-on: https://chromium-review.googlesource.com/1236276 Reviewed-by: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Original-Commit-Position: refs/heads/master@{#594441}(cherry picked from commit 831a1ec9ca49586b323d13d4e9b11c355deff761) Reviewed-on: https://chromium-review.googlesource.com/c/1260129 Reviewed-by: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/branch-heads/3538@{#848} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by apaci...@chromium.org
, Aug 31