New issue
Advanced search Search tips

Issue 879570 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Sep 14
Cc:
Components:
EstimatedDays: 5
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

[ios] Add Bookmark Search

Project Member Reported by djean@chromium.org, Aug 31

Issue description

Chrome Version: (copy from chrome://version)
OS: iOS

What steps will reproduce the problem?
(1) Bookmarks

What is the expected result?
No search bar.
What happens instead?
Search bar.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1dba3ee80a85c1ddb0d0151a579a36e31548aed7

commit 1dba3ee80a85c1ddb0d0151a579a36e31548aed7
Author: David Jean <djean@google.com>
Date: Mon Sep 10 08:52:10 2018

[ios] Added bookmark search

When opening:
https://drive.google.com/file/d/1z4iyQgQOL9jUFNfIf9Qg1SmFz9INxN88/view?usp=sharing
When searching:
https://drive.google.com/file/d/1wdMrOC9GDzh7e97HY-1ObHergJH0rnoC/view?usp=sharing

In action:
https://drive.google.com/file/d/14NMZ4mkCUZM8QNyopWHQ6MyDX939bcni/view?usp=sharing

Bug:  879570 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I51f88361a79703c55f03e2befb745ca3701ce577
Reviewed-on: https://chromium-review.googlesource.com/1193932
Commit-Queue: David Jean <djean@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589861}
[modify] https://crrev.com/1dba3ee80a85c1ddb0d0151a579a36e31548aed7/ios/chrome/browser/ui/bookmarks/bookmark_home_mediator.h
[modify] https://crrev.com/1dba3ee80a85c1ddb0d0151a579a36e31548aed7/ios/chrome/browser/ui/bookmarks/bookmark_home_mediator.mm
[modify] https://crrev.com/1dba3ee80a85c1ddb0d0151a579a36e31548aed7/ios/chrome/browser/ui/bookmarks/bookmark_home_shared_state.h
[modify] https://crrev.com/1dba3ee80a85c1ddb0d0151a579a36e31548aed7/ios/chrome/browser/ui/bookmarks/bookmark_home_shared_state.mm
[modify] https://crrev.com/1dba3ee80a85c1ddb0d0151a579a36e31548aed7/ios/chrome/browser/ui/bookmarks/bookmark_home_view_controller.mm
[modify] https://crrev.com/1dba3ee80a85c1ddb0d0151a579a36e31548aed7/ios/chrome/browser/ui/bookmarks/bookmark_home_view_controller_unittest.mm
[modify] https://crrev.com/1dba3ee80a85c1ddb0d0151a579a36e31548aed7/ios/chrome/browser/ui/bookmarks/bookmark_interaction_controller.mm
[modify] https://crrev.com/1dba3ee80a85c1ddb0d0151a579a36e31548aed7/ios/chrome/browser/ui/bookmarks/bookmark_ui_constants.h
[modify] https://crrev.com/1dba3ee80a85c1ddb0d0151a579a36e31548aed7/ios/chrome/browser/ui/bookmarks/bookmark_ui_constants.mm
[modify] https://crrev.com/1dba3ee80a85c1ddb0d0151a579a36e31548aed7/ios/chrome/browser/ui/bookmarks/bookmarks_egtest.mm

Doing a speculative revert due to failures. See https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/ios-uirefresh-simulator/2536

BookmarksTestCaseSearch&#x2f;testSearchTapOnScrimCancelsSearchController
BookmarksTestCaseSearch&#x2f;testSearchScrimShownWhenSearchBoxEnabled
BookmarksTestCaseSearch&#x2f;testSearchHidesNavigationBar
BookmarksTestCaseSearch&#x2f;testSearchBarShownOnRoot
BookmarksTestCaseSearch&#x2f;testSearchResults
BookmarksTestCaseSearch&#x2f;testSearchItemsCanBeSwipedToDelete
BookmarksTestCaseSearch&#x2f;testDisablesSearchOnEditMode
BookmarksTestCaseSearch&#x2f;testSearchWithNoResults
BookmarksTestCaseSearch&#x2f;testSearchCancelRestoresNodeBookmarks
BookmarksTestCaseSearch&#x2f;testSearchBarShownOnMobileBookmarks
BookmarksTestCaseSearch&#x2f;testSearchLongPressEditOnURL

E.g.

BookmarksTestCaseSearch/testSearchTapOnScrimCancelsSearchController:
2018-09-10 02:38:13.760 ios_chrome_bookmarks_egtests[37783:647966] Warning attempt to a attach <_UINavigationControllerManagedSearchPalette: 0x7f9cf6475bf0; frame = (-187.5 0; 0 52); layer = <CALayer: 0x60000377a160>> to a navigation controller whose navigation bar is not in the view hierarchy!
2018-09-10 02:38:16.071 ios_chrome_bookmarks_egtests[37783:647966] Warning attempt to a attach <_UINavigationControllerManagedSearchPalette: 0x7f9cf3369360; frame = (-187.5 0; 0 52); layer = <CALayer: 0x60000304ca60>> to a navigation controller whose navigation bar is not in the view hierarchy!
../../ios/chrome/browser/ui/bookmarks/bookmarks_egtest.mm:4324: error: -[BookmarksTestCaseSearch testSearchTapOnScrimCancelsSearchController] : Exception: NoMatchingElementException
Exception Name: NoMatchingElementException
Exception Reason: Cannot find UI element.
Exception with Action: {
  "Action Name":  "Tap",
  "Element Matcher":  "(respondsToSelector(accessibilityIdentifier) && accessibilityID('kBookmarkHomeSearchBarIdentifier'))",
  "Recovery Suggestion":  "Check if the element exists in the UI hierarchy printed below. If it exists, adjust the matcher so that it accurately matches element."
}
Exception Details: Error Trace: [
  {
    "Description":  "Interaction cannot continue because the desired element was not found.",
    "Error Domain":  "com.google.earlgrey.ElementInteractionErrorDomain",
    "Error Code":  "0",
    "File Name":  "GREYElementInteraction.m",
    "Function Name":  "-[GREYElementInteraction matchedElementsWithTimeout:error:]",
    "Line":  "124",
    "TestCase Class":  "BookmarksTestCaseSearch",
    "TestCase Method":  "testSearchTapOnScrimCancelsSearchController"
  }
]
Bundle ID: org.chromium.gtest.generic-unit-test
Stack Trace: (
	0   EarlGrey                            0x000000011e124119 -[GREYDefaultFailureHandler handleException:details:] + 1305
	1   EarlGrey                            0x000000011e115689 -[GREYElementInteraction grey_handleFailureOfAction:actionError:userProvidedOutError:] + 4201
	2   EarlGrey                            0x000000011e11254a __46-[GREYElementInteraction performAction:error:]_block_invoke + 1626
	3   EarlGrey                            0x000000011e13d2c4 __59-[GREYUIThreadExecutor executeSyncWithTimeout:block:error:]_block_invoke + 68
	4   EarlGrey                            0x000000011e13a20a __77-[GREYRunLoopSpinner grey_drainRunLoopInActiveModeAndCheckCondition:forTime:]_block_invoke + 314
	5   EarlGrey                            0x000000011e13abef __89-[GREYRunLoopSpinner grey_setupObserverInMode:withBeforeSourcesBlock:beforeWaitingBlock:]_block_invoke + 175
	6   CoreFoundation                      0x000000011c03d037 __CFRUNLOOP_IS_CALLING_OUT_TO_AN_OBSERVER_CALLBACK_FUNCTION__ + 23
	7   CoreFoundation                      0x000000011c0374ce __CFRunLoopDoObservers + 430
	8   CoreFoundation                      0x000000011c037a33 __CFRunLoopRun + 1235
	9   CoreFoundation                      0x000000011c037221 CFRunLoopRunSpecific + 625
	10  EarlGrey                            0x000000011e139e35 -[GREYRunLoopSpinner grey_drainRunLoopInActiveModeAndCheckCondition:forTime:] + 597
	11  EarlGrey                            0x000000011e1398b3 -[GREYRunLoopSpinner spinWithStopConditionBlock:] + 419
	12  EarlGrey                            0x000000011e13cd2c -[GREYUIThreadExecutor executeSyncWithTimeout:block:error:] + 1004
	13  EarlGrey                            0x000000011e11154d -[GREYElementInteraction performAction:error:] + 1789
	14  EarlGrey                            0x000000011e110e1f -[GREYElementInteraction performAction:] + 79
	15  ios_chrome_bookmarks_egtests        0x000000010e0577e4 -[BookmarksTestCaseSearch testSearchTapOnScrimCancelsSearchController] + 436
	16  CoreFoundation                      0x000000011c0e111c __invoking___ + 140
	17  CoreFoundation                      0x000000011c0de5b5 -[NSInvocation invoke] + 325
	18  EarlGrey                            0x000000011e1070c8 -[GREYTestCaseInvocation invoke] + 104
	19  XCTest                              0x000000011d558b6e __24-[XCTestCase invokeTest]_block_invoke.192 + 78
	20  XCTest                              0x000000011d5b02e8 -[XCTestCase(Failures) performFailableBlock:testCaseRun:shouldInterruptTest:] + 57
	21  XCTest                              0x000000011d5b0205 -[XCTestCase(Failures) _performTurningExceptionsIntoFailuresInterruptAfterHandling:block:] + 96
	22  XCTest                              0x000000011d55882f __24-[XCTestCase invokeTest]_block_invoke + 848
	23  XCTest                              0x000000011d5b61ee -[XCUITestContext performInScope:] + 248
	24  XCTest                              0x000000011d558424 -[XCTestCase testContextPerformInScope:] + 98
	25  XCTest                              0x000000011d5584d2 -[XCTestCase invokeTest] + 137
	26  EarlGrey                            0x000000011e0f7c67 -[XCTestCase(GREYAdditions) grey_invokeTest] + 1079
	27  XCTest                              0x000000011d55a00d __26-[XCTestCase performTest:]_block_invoke_2 + 43
	28  XCTest                              0x000000011d5b02e8 -[XCTestCase(Failures) performFailableBlock:testCaseRun:shouldInterruptTest:] + 57
	29  XCTest                              0x000000011d5b0205 -[XCTestCase(Failures) _performTurningExceptionsIntoFailuresInterruptAfterHandling:block:] + 96
	30  XCTest                              0x000000011d559f24 __26-[XCTestCase performTest:]_block_invoke.326 + 88
	31  XCTest                              0x000000011d5c0a3b +[XCTContext runInContextForTestCase:block:] + 225
	32  XCTest                              0x000000011d559653 -[XCTestCase performTest:] + 675
	33  XCTest                              0x000000011d59c802 -[XCTest runTest] + 57
	34  XCTest                              0x000000011d55485b __27-[XCTestSuite performTest:]_block_invoke + 365
	35  XCTest                              0x000000011d554033 -[XCTestSuite _performProtectedSectionForTest:testSection:] + 55
	36  XCTest                              0x000000011d5542f6 -[XCTestSuite performTest:] + 296
	37  XCTest                              0x000000011d59c802 -[XCTest runTest] + 57
	38  XCTest                              0x000000011d55485b __27-[XCTestSuite performTest:]_block_invoke + 365
	39  XCTest                              0x000000011d554033 -[XCTestSuite _performProtectedSectionForTest:testSection:] + 55
	40  XCTest                              0x000000011d5542f6 -[XCTestSuite performTest:] + 296
	41  XCTest                              0x000000011d59c802 -[XCTest runTest] + 57
	42  XCTest                              0x000000011d55485b __27-[XCTestSuite performTest:]_block_invoke + 365
	43  XCTest                              0x000000011d554033 -[XCTestSuite _performProtectedSectionForTest:testSection:] + 55
	44  XCTest                              0x000000011d5542f6 -[XCTestSuite performTest:] + 296
	45  XCTest                              0x000000011d59c802 -[XCTest runTest] + 57
	46  XCTest                              0x000000011d5caea6 __44-[XCTTestRunSession runTestsAndReturnError:]_block_invoke + 171
	47  XCTest                              0x000000011d5cafc7 __44-[XCTTestRunSession runTestsAndReturnError:]_block_invoke.80 + 68
	48  XCTest                              0x000000011d56c86a -[XCTestObservationCenter _observeTestExecutionForBlock:] + 594
	49  XCTest                              0x000000011d5cac1a -[XCTTestRunSession runTestsAndReturnError:] + 623
	50  XCTest                              0x000000011d53925a -[XCTestDriver runTestsAndReturnError:] + 422
	51  XCTest                              0x000000011d5bcfbd _XCTestMain + 1478
	52  libXCTestBundleInject.dylib         0x000000011bfa0bb8 __copy_helper_block_ + 0
	53  CoreFoundation                      0x000000011c03da3c __CFRUNLOOP_IS_CALLING_OUT_TO_A_BLOCK__ + 12
	54  CoreFoundation                      0x000000011c03d1f0 __CFRunLoopDoBlocks + 336
	55  CoreFoundation                      0x000000011c037a64 __CFRunLoopRun + 1284
	56  CoreFoundation                      0x000000011c037221 CFRunLoopRunSpecific + 625
	57  GraphicsServices                    0x00000001269441dd GSEventRunModal + 62
	58  UIKitCore                           0x00000001220242f1 UIApplicationMain + 140
	59  ios_chrome_bookmarks_egtests        0x000000010dfe9073 _ZN12_GLOBAL__N_120RunUIApplicationMainEiPPc + 355
	60  ios_chrome_bookmarks_egtests        0x000000010dfe8b41 main + 417
	61  libdyld.dylib                       0x0000000124ad55cd start + 1
	62  ???                                 0x0000000000000006 0x0 + 6
)
Screenshots: {
  "Screenshot At Failure":  "/Users/chrome-bot/Library/Developer/CoreSimulator/Devices/44FF576E-1A4A-4FEB-9DF6-5304CB3CFBDB/data/Containers/Data/Application/A342BC1F-8ED9-476E-9FDA-0F52B17A9F82/Documents/BookmarksTestCaseSearch_testSearchTapOnScrimCancelsSearchController-NoMatchingElementException-AC436957-6912-4DA2-9AAE-9D89F751B6F5/BookmarksTestCaseSearch_testSearchTapOnScrimCancelsSearchController.png",
  "Visibility Checker Most Recent Before Image":  "/Users/chrome-bot/Library/Developer/CoreSimulator/Devices/44FF576E-1A4A-4FEB-9DF6-5304CB3CFBDB/data/Containers/Data/Application/A342BC1F-8ED9-476E-9FDA-0F52B17A9F82/Documents/BookmarksTestCaseSearch_testSearchTapOnScrimCancelsSearchController-NoMatchingElementException-AC436957-6912-4DA2-9AAE-9D89F751B6F5/BookmarksTestCaseSearch_testSearchTapOnScrimCancelsSearchController_before.png",
  "Visibility Checker Most Recent Expected After Image":  "/Users/chrome-bot/Library/Developer/CoreSimulator/Devices/44FF576E-1A4A-4FEB-9DF6-5304CB3CFBDB/data/Containers/Data/Application/A342BC1F-8ED9-476E-9FDA-0F52B17A9F82/Documents/BookmarksTestCaseSearch_testSearchTapOnScrimCancelsSearchController-NoMatchingElementException-AC436957-6912-4DA2-9AAE-9D89F751B6F5/BookmarksTestCaseSearch_testSearchTapOnScrimCancelsSearchController_after_expected.png",
  "Visibility Checker Most Recent Actual After Image":  "/Users/chrome-bot/Library/Developer/CoreSimulator/Devices/44FF576E-1A4A-4FEB-9DF6-5304CB3CFBDB/data/Containers/Data/Application/A342BC1F-8ED9-476E-9FDA-0F52B17A9F82/Documents/BookmarksTestCaseSearch_testSearchTapOnScrimCancelsSearchController-NoMatchingElementException-AC436957-6912-4DA2-9AAE-9D89F751B6F5/BookmarksTestCaseSearch_testSearchTapOnScrimCancelsSearchController_after_actual.png"
}
UI hierarchy (ordered by window level, front to back as rendered):
Legend: {
  "[AX]":  "Accessibility",
  "[UIE]":  "User Interaction Enabled",
  "[Window 1]":  "Frontmost Window"
}
========== Window 1 ==========
<UITextEffectsWindow:0x7f9cf120a800; AX=N; AX.frame={{0, 0}, {375, 812}}; AX.activationPoint={187.5, 406}; AX.traits='UIAccessibilityTraitNone'; AX.focused='N'; frame={{0, 0}, {375, 812}}; opaque; hidden; alpha=1>
========== Window 2 ==========
<UITextEffectsWindow:0x7f9cf5082200; AX=N; AX.frame={{0, 0}, {375, 812}}; AX.activationPoint={187.5, 406}; AX.traits='UIAccessibilityTraitNone'; AX.focused='N'; frame={{0, 0}, {375, 812}}; alpha=1>
  |--<UIInputSetContainerView:0x7f9cf3263a40; AX=N; AX.frame={{0, 0}, {375, 812}}; AX.activationPoint={187.5, 406}; AX.traits='UIAccessibilityTraitNone'; AX.focused='N'; frame={{0, 0}, {375, 812}}; opaque; alpha=1>
  |  |--<UIInputSetHostView:0x7f9cf3265dd0; AX=N; AX.frame={{0, 812}, {375, 233}}; AX.activationPoint={187.5, 928.5}; AX.traits='UIAccessibilityTraitNone'; AX.focused='N'; frame={{0, 812}, {375, 233}}; opaque; alpha=1>
  |  |  |--<UIKeyboardDockView:0x7f9cf0e76390; AX=Y; AX.frame={{0, 812}, {108, 54}}; AX.activationPoint={54, 839}; AX.traits='UIAccessibilityTraitNone'; AX.focused='N'; frame={{0, 0}, {108, 54}}; opaque; hidden; alpha=1>
  |  |  |  |--<UIKeyboardDockItemButton:0x7f9cf0e77010; AX=N; AX.id='dictation'; AX.label='Dictate'; AX.hint='Double-tap to start dictation. Double-tap with two fingers when finished.'; AX.frame={{42, 799}, {66, 66}}; AX.activationPoint={75, 832}; AX.traits='UIAccessibilityTraitButton'; AX.focused='N'; frame={{42, -13}, {66, 66}}; hidden; alpha=1>
  |  |  |  |  |--<UIButtonLabel:0x7f9cf0e82670; AX=N; AX.frame={{42, 799}, {0, 0}}; AX.activationPoint={42, 799}; AX.traits='UIAccessibilityTraitStaticText'; AX.focused='N'; frame={{0, 0}, {0, 0}}; hidden; alpha=1; UIE=N; text=''>
  |  |  |  |  |--<UIImageView:0x7f9cf0e77350; AX=N; AX.id='dictation_dockitem-portrait'; AX.frame={{67, 815}, {15, 25}}; AX.activationPoint={74.5, 827.5}; AX.traits='UIAccessibilityTraitImage'; AX.focused='N'; frame={{25, 16}, {15, 25}}; alpha=1; UIE=N>
  |  |  |  |--<UIKeyboardDockItemButton:0x7f9cf0e767a0; AX=N; AX.label='Next keyboard'; AX.hint='Double-tap and hold, then drag up to select another keyboard'; AX.value='Emoji'; AX.frame={{0, 799}, {66, 66}}; AX.activationPoint={33, 832}; AX.traits='UIAccessibilityTraitButton'; AX.focused='N'; frame={{0, -13}, {66, 66}}; alpha=1>
  |  |  |  |  |--<UIButtonLabel:0x7f9cf0e76d10; AX=N; AX.frame={{0, 799}, {0, 0}}; AX.activationPoint={0, 799}; AX.traits='UIAccessibilityTraitStaticText'; AX.focused='N'; frame={{0, 0}, {0, 0}}; hidden; alpha=1; UIE=N; text=''>
  |  |  |  |  |--<UIImageView:0x7f9cf0e76ae0; AX=N; AX.id='emoji_dockitem-portrait'; AX.frame={{26, 813}, {27, 27}}; AX.activationPoint={39.5, 826.5}; AX.traits='UIAccessibilityTraitImage'; AX.focused='N'; frame={{26, 14}, {27, 27}}; alpha=1; UIE=N>
========== Window 3 ==========
<ChromeOverlayWindow:0x7f9cf3208b80; AX=N; AX.frame={{0, 0}, {375, 812}}; AX.activationPoint={187.5, 406}; AX.traits='UIAccessibilityTraitNone'; AX.focused='N'; frame={{0, 0}, {375, 812}}; opaque; alpha=1>
  |--<MDCOverlayWindowContainerView:0x7f9cf300a0e0; AX=N; AX.frame={{0, 0}, {375, 812}}; AX.activationPoint={187.5, 406}; AX.traits='UIAccessibilityTraitNone'; AX.focused='N'; frame={{0, 0}, {375, 812}}; opaque; hidden; alpha=1>
  |--<UITransitionView:0x7f9cf64667d0; AX=N; AX.frame={{0, 0}, {375, 812}}; AX.activationPoint={187.5, 406}; AX.traits='UIAccessibilityTraitNone'; AX.focused='N'; frame={{0, 0}, {375, 812}}; opaque; alpha=1>
  |  |--<UILayoutContainerView:0x7f9cf665c260; AX=N; AX.frame={{0, 0}, {375, 812}}; AX.activationPoint={187.5, 406}; AX.traits='UIAccessibilityTraitNone'; AX.focused='N'; frame={{0, 0}, {375, 812}}; opaque; alpha=1>
  |  |  |--<UIToolbar:0x7f9cf64b7990; AX=N; AX.id='kBookmarkHomeUIToolbarIdentifier'; AX.frame={{0, 729}, {375, 49}}; AX.activationPoint={187.5, 753.5}; AX.traits='UIAccessibilityTraitNone'; AX.focused='N'; frame={{0, 729}, {375, 49}}; opaque; alpha=1>
  |  |  |  |--<_UIToolbarContentView:0x7f9cf665d6f0; AX=N; AX.frame={{0, 729}, {375, 49}}; AX.activationPoint={187.5, 753.5}; AX.traits='UIAccessibilityTraitNone'; AX.focused='N'; frame={{0, 0}, {375, 49}}; opaque; alpha=1>
  |  |  |  |  |--<_UIButtonBarStackView:0x7f9cf663be00; AX=N; AX.frame={{0, 729}, {375, 49}}; AX.activationPoint={187.5, 753.5}; AX.traits='UIAccessibilityTraitNone'; AX.focused='N'; frame={{0, 0}, {375, 49}}; opaque; alpha=1>
  |  |  |  |  |  |--<_UIButtonBarButton:0x7f9cf0c7fb30; AX=Y; AX.id='kBookmarkHomeTrailingButtonIdentifier'; AX.label='Edit'; AX.frame={{321.33333333333331, 734}, {53.666666666666686, 44}}; AX.activationPoint={348.16666666666663, 756}; AX.traits='UIAccessibilityTraitButton'; AX.focused='N'; frame={{321.33333333333331, 5}, {53.666666666666664, 44}}; opaque; alpha=1>
  |  |  |  |  |  |  |--<_UIModernBarButton:0x7f9cf0cd9a70; AX=Y; AX.label='Edit'; AX.frame={{329.33333333333331, 742.66666666666663}, {29.666666666666686, 23.333333333333371}}; AX.activationPoint={344.16666666666663, 754.33333333333326}; AX.traits='UIAccessibilityTraitButton,UIAccessibilityTraitNotEnabled'; AX.focused='N'; frame={{8.0000000000000018, 8.6666666666666661}, {29.666666666666668, 23.333333333333332}}; alpha=1; UIE=N>
  |  |  |  |  |  |  |  |--<UIButtonLabel:0x7f9cf0c7cbd0; AX=Y; AX.label='Edit'; AX.frame={{329.33333333333331, 745.66666666666663}, {29.666666666666686, 20.333333333333371}}; AX.activationPoint={344.16666666666663, 755.83333333333326}; AX.traits='UIAccessibilityTraitStaticText'; AX.focused='N'; frame={{0, 3.0000000000000018}, {29.666666666666668, 20.333333333333332}}; alpha=1; UIE=N; text='Edit'>
  |  |  |  |  |  |--<UIView:0x7f9cf0cd35a0; AX=N; AX.frame={{114.33333333333331, 756}, {207, 0}}; AX.activationPoint={217.83333333333331, 756}; AX.traits='UIAccessibilityTraitNone'; AX.focused='N'; frame={{114.33333333333331, 27}, {207, 0}}; opaque; alpha=1>
  |  |  |  |  |  |--<_UIButtonBarButton:0x7f9cf0cd6530; AX=Y; AX.id='kBookmarkHomeLeadingButtonIdentifier'; AX.label='New Folder'; AX.frame={{0, 734}, {114.33333333333333, 44}}; AX.activationPoint={57.166666666666664, 756}; AX.traits='UIAccessibilityTraitButton'; AX.focused='N'; frame={{0, 5}, {114.33333333333333, 44}}; opaque; alpha=1>
  |  |  |  |  |  |  |--<_UIModernBarButton:0x7f9cf0cd53b0; AX=Y; AX.label='New Folder'; AX.frame={{16, 742.66666666666663}, {90.333333333333329, 23.333333333333371}}; AX.activationPoint={61.166666666666664, 754.33333333333326}; AX.traits='UIAccessibilityTraitButton,UIAccessibilityTraitNotEnabled'; AX.focused='N'; frame={{16, 8.6666666666666661}, {90.333333333333329, 23.333333333333332}}; alpha=1; UIE=N>
  |  |  |  |  |  |  |  |--<UIButtonLabel:0x7f9cf0c2f750; AX=Y; AX.label='New Folder'; AX.frame={{16, 745.66666666666663}, {87.333333333333329, 20.333333333333371}}; AX.activationPoint={59.666666666666664, 755.83333333333326}; AX.traits='UIAccessibilityTraitStaticText'; AX.focused='N'; frame={{0, 3.0000000000000018}, {87.333333333333329, 20.333333333333332}}; alpha=1; UIE=N; text='New Folder'>
  |  |  |  |--<_UIBarBackground:0x7f9cf663e540; AX=N; AX.frame={{0, 729}, {375, 83}}; AX.activationPoint={187.5, 770.5}; AX.traits='UIAccessibilityTraitNone'; AX.focused='N'; frame={{0, 0}, {375, 83}}; opaque; alpha=1; UIE=N>
  |  |  |  |  |--<UIImageView:0x7f9cf663e9d0; AX=N; AX.frame={{0, 728.66666666666663}, {375, 0.33333333333337123}}; AX.activationPoint={187.5, 728.83333333333326}; AX.traits='UIAccessibilityTraitImage'; AX.focused='N'; frame={{0, -0.33333333333333331}, {375, 0.33333333333333331}}; opaque; alpha=1; UIE=N>
  |  |  |--<UINavigationTransitionView:0x7f9cf66356b0; AX=N; AX.frame={{0, 0}, {375, 812}}; AX.activationPoint={187.5, 406}; AX.traits='UIAccessibilityTraitNone'; AX.focused='N'; frame={{0, 0}, {375, 812}}; opaque; alpha=1>
  |  |  |  |--<UIViewControllerWrapperView:0x7f9cf6455f40; AX=N; AX.frame={{0, 0}, {375, 812}}; AX.activationPoint={187.5, 406}; AX.traits='UIAccessibilityTraitNone'; AX.focused='N'; frame={{0, 0}, {375, 812}}; opaque; alpha=1>
  |  |  |  |  |--<UITableView:0x7f9cf4067000; AX=N; AX.id='bookmarksTableView'; AX.frame={{0, 0}, {375, 729}}; AX.activationPoint={187.5, 364.5}; AX.traits='UIAccessibilityTraitNone'; AX.focused='N'; frame={{0, 0}, {375, 729}}; opaque; alpha=1>
  |  |  |  |  |  |--<MDCFlexibleHeaderView:0x7f9cf33a9600; AX=N; AX.frame={{0, 0}, {375, 100}}; AX.activationPoint={187.5, 50}; AX.traits='UIAccessibilityTraitNone'; AX.focused='N'; frame={{0, -100}, {375, 100}}; opaque; alpha=1>
  |  |  |  |  |  |  |--<MDCHeaderStackView:0x7f9cf336b5f0; AX=N; AX.frame={{0, 44}, {375, 56}}; AX.activationPoint={187.5, 72}; AX.traits='UIAccessibilityTraitNone'; AX.focused='N'; frame={{0, 44}, {375, 56}}; opaque; alpha=1>
  |  |  |  |  |  |  |  |--<MDCNavigationBar:0x7f9cf336bb20; AX=N; AX.frame={{0, 44}, {375, 56}}; AX.activationPoint={187.5, 72}; AX.traits='UIAccessibilityTraitNone'; AX.focused='N'; frame={{0, 0}, {375, 56}}; opaque; alpha=1>
  |  |  |  |  |  |  |  |  |--<MDCButtonBar:0x7f9cf336e820; AX=N; AX.frame={{306, 44}, {69, 56}}; AX.activationPoint={340.5, 72}; AX.traits='UIAccessibilityTraitNone'; AX.focused='N'; frame={{306, 0}, {69, 56}}; opaque; alpha=1>
  |  |  |  |  |  |  |  |  |  |--<MDCButtonBarButton:0x7f9cf33bd910; AX=Y; AX.id='kBookmarkHomeNavigationBarDoneButtonIdentifier'; AX.label='Done'; AX.frame={{306, 44}, {69, 56}}; AX.activationPoint={340.5, 72}; AX.traits='UIAccessibilityTraitButton'; AX.focused='N'; frame={{0, 0}, {69, 56}}; alpha=1>
  |  |  |  |  |  |  |  |  |  |  |--<UIButtonLabel:0x7f9cf33bdcf0; AX=Y; AX.label='DONE'; AX.frame={{322, 65.666666666666671}, {37, 17}}; AX.activationPoint={340.5, 74.166666666666671}; AX.traits='UIAccessibilityTraitStaticText'; AX.focused='N'; frame={{16, 21.666666666666668}, {37, 17}}; alpha=1; UIE=N; text='DONE'>
  |  |  |  |  |  |  |  |  |  |  |--<UIImageView:0x7f9cf33be210; AX=N; AX.frame={{306, 44}, {0, 0}}; AX.activationPoint={306, 44}; AX.traits='UIAccessibilityTraitImage'; AX.focused='N'; frame={{0, 0}, {0, 0}}; hidden; alpha=1; UIE=N>
  |  |  |  |  |  |  |  |  |  |  |--<MDCInkView:0x7f9cf33bdff0; AX=N; AX.frame={{306, 44}, {69, 56}}; AX.activationPoint={340.5, 72}; AX.traits='UIAccessibilityTraitNone'; AX.focused='N'; frame={{0, 0}, {69, 56}}; opaque; alpha=1; UIE=N>
  |  |  |  |  |  |  |  |  |--<MDCButtonBar:0x7f9cf33d9450; AX=N; AX.frame={{0, 44}, {56, 56}}; AX.activationPoint={28, 72}; AX.traits='UIAccessibilityTraitNone'; AX.focused='N'; frame={{0, 0}, {56, 56}}; opaque; alpha=1>
  |  |  |  |  |  |  |  |  |  |--<MDCButtonBarButton:0x7f9cf339b060; AX=Y; AX.id='ic_arrow_back'; AX.label='Back'; AX.frame={{0, 44}, {56, 56}}; AX.activationPoint={28, 72}; AX.traits='UIAccessibilityTraitButton'; AX.focused='N'; frame={{0, 0}, {56, 56}}; alpha=1>
  |  |  |  |  |  |  |  |  |  |  |--<UIButtonLabel:0x7f9cf339b440; AX=N; AX.frame={{0, 44}, {0, 0}}; AX.activationPoint={0, 44}; AX.traits='UIAccessibilityTraitStaticText'; AX.focused='N'; frame={{0, 0}, {0, 0}}; hidden; alpha=1; UIE=N; text=''>
  |  |  |  |  |  |  |  |  |  |  |--<UIImageView:0x7f9cf339b960; AX=N; AX.frame={{16, 60}, {24, 24}}; AX.activationPoint={28, 72}; AX.traits='UIAccessibilityTraitImage'; AX.focused='N'; frame={{16, 16}, {24, 24}}; alpha=1; UIE=N>
  |  |  |  |  |  |  |  |  |  |  |--<MDCInkView:0x7f9cf339b740; AX=N; AX.frame={{0, 44}, {56, 56}}; AX.activationPoint={28, 72}; AX.traits='UIAccessibilityTraitNone'; AX.focused='N'; frame={{0, 0}, {56, 56}}; opaque; alpha=1; UIE=N>
  |  |  |  |  |  |  |  |  |--<UILabel:0x7f9cf3379c10; AX=Y; AX.label='Mobile Bookmarks'; AX.frame={{72, 60}, {168, 24}}; AX.activationPoint={156, 72}; AX.traits='UIAccessibilityTraitHeader,UIAccessibilityTraitStaticText'; AX.focused='N'; frame={{72, 16}, {168, 24}}; opaque; alpha=1; UIE=N; text='Mobile Bookmarks'>
  |  |  |  |  |  |  |--<UIView:0x7f9cf3332050; AX=N; AX.frame={{0, 0}, {375, 100}}; AX.activationPoint={187.5, 50}; AX.traits='UIAccessibilityTraitNone'; AX.focused='N'; frame={{0, 0}, {375, 100}}; opaque; alpha=1>
  |  |  |  |  |  |  |--<UIView:0x7f9cf3360590; AX=N; AX.frame={{0, 0}, {0, 44}}; AX.activationPoint={0, 22}; AX.traits='UIAccessibilityTraitNone'; AX.focused='N'; frame={{0, 0}, {0, 44}}; opaque; alpha=1>
  |  |  |  |  |  |--<UIImageView:0x7f9cf0ca6050; AX=N; AX.frame={{369.66666666666669, 405}, {2.3333333333333144, 321}}; AX.activationPoint={370.83333333333337, 565.5}; AX.traits='UIAccessibilityTraitImage'; AX.focused='N'; frame={{369.66666666666669, 305}, {2.3333333333333335, 321}}; alpha=0; UIE=N>
  |  |  |  |  |  |--<UIView:0x7f9cf651d0c0; AX=N; AX.frame={{0, 426}, {375, 1}}; AX.activationPoint={187.5, 426.5}; AX.traits='UIAccessibilityTraitNone'; AX.focused='N'; frame={{0, 326}, {375, 1}}; opaque; alpha=1>
  |  |  |  |  |  |--<UIView:0x7f9cf651baf0; AX=N; AX.frame={{0, 425}, {375, 1}}; AX.activationPoint={187.5, 425.5}; AX.traits='UIAccessibilityTraitNone'; AX.focused='N'; frame={{0, 325}, {375, 1}}; opaque; alpha=1>
  |  |  |  |  |  |--<UIImageView:0x7f9cf0c84b00; AX=N; AX.frame={{3, 723.66666666666663}, {369, 2.3333333333333712}}; AX.activationPoint={187.5, 724.83333333333326}; AX.traits='UIAccessibilityTraitImage'; AX.focused='N'; frame={{3, 623.66666666666663}, {369, 2.3333333333333335}}; alpha=0; UIE=N>
  |  |  |  |  |  |--<BookmarkTableCell:0x7f9cf103ce00; AX=N; AX.frame={{0, 100}, {375, 65}}; AX.activationPoint={187.5, 132.5}; AX.traits='UIAccessibilityTraitButton'; AX.focused='N'; frame={{0, 0}, {375, 65}}; opaque; alpha=1; text=''>
  |  |  |  |  |  |  |--<UIButton:0x7f9cf0cb1c80; AX=Y; AX.label='More Info'; AX.frame={{351, 126}, {8, 13}}; AX.activationPoint={355, 132.5}; AX.traits='UIAccessibilityTraitButton,UIAccessibilityTraitNotEnabled'; AX.focused='N'; frame={{351, 26}, {8, 13}}; alpha=1; UIE=N>
  |  |  |  |  |  |  |  |--<UIImageView:0x7f9cf65337d0; AX=N; AX.frame={{351, 126}, {8, 13}}; AX.activationPoint={355, 132.5}; AX.traits='UIAccessibilityTraitImage'; AX.focused='N'; frame={{0, 0}, {8, 13}}; alpha=1; UIE=N>
  |  |  |  |  |  |  |--<UITableViewCellContentView:0x7f9cf0c5c260; AX=Y; AX.id='Folder 1.1'; AX.label='Folder 1.1'; AX.frame={{0, 100}, {341, 65}}; AX.activationPoint={170.5, 132.5}; AX.traits='UIAccessibilityTraitButton'; AX.focused='N'; frame={{0, 0}, {341, 65}}; opaque; alpha=1>
  |  |  |  |  |  |  |  |--<UIView:0x7f9cf65146a0; AX=N; AX.frame={{48, 164.66666666666669}, {327, 0.33333333333334281}}; AX.activationPoint={211.5, 164.83333333333337}; AX.traits='UIAccessibilityTraitNone'; AX.focused='N'; frame={{48, 64.666666666666671}, {327, 0.33333333333333331}}; opaque; alpha=1>
  |  |  |  |  |  |  |  |--<UIStackView:0x7f9cf0c7e550; AX=N; AX.frame={{16, 100}, {309, 65}}; AX.activationPoint={170.5, 132.5}; AX.traits='UIAccessibilityTraitNone'; AX.focused='N'; frame={{16, 0}, {309, 65}}; opaque; alpha=1>
  |  |  |  |  |  |  |  |  |--<UITextField:0x7f9cf123b400; AX=N; AX.value='Folder 1.1'; AX.frame={{48, 123}, {277, 19}}; AX.activationPoint={186.5, 132.5}; AX.traits='UIAccessibilityTraitNone'; AX.focused='N'; frame={{32, 23}, {277, 19}}; alpha=1; UIE=N; text='Folder 1.1'>
  |  |  |  |  |  |  |  |  |  |--<_UITextFieldContentView:0x7f9cf0cac800; AX=N; AX.frame={{48, 123}, {277, 19}}; AX.activationPoint={186.5, 132.5}; AX.traits='UIAccessibilityTraitNone'; AX.focused='N'; frame={{0, 0}, {277, 19}}; alpha=1; UIE=N>
  |  |  |  |  |  |  |  |  |  |--<UIAccessibilityTextFieldElement:0x600003dd65e0; AX=Y; AX.value='Folder 1.1'; AX.frame={{48, 123}, {277, 19}}; AX.activationPoint={186.5, 132.5}; AX.traits='UIAccessibilityTraitNone'; AX.focused='N'>
  |  |  |  |  |  |  |  |  |--<UILabel:0x7f9cf0c7a030; AX=N; AX.frame={{40, 124.66666666666667}, {16, 16.000000000000014}}; AX.activationPoint={48, 132.66666666666669}; AX.traits='UIAccessibilityTraitStaticText'; AX.focused='N'; frame={{24, 24.666666666666671}, {16, 16}}; opaque; hidden; alpha=1; UIE=N; text=''>
  |  |  |  |  |  |  |  |  |--<UIImageView:0x7f9cf0c79e00; AX=N; AX.id='bookmark_gray_folder_new'; AX.frame={{16, 124.66666666666667}, {16, 16.000000000000014}}; AX.activationPoint={24, 132.66666666666669}; AX.traits='UIAccessibilityTraitImage'; AX.focused='N'; frame={{0, 24.666666666666671}, {16, 16}}; alpha=1; UIE=N>
  |  |  |  |  |  |--<BookmarkTableCell:0x7f9cf1122e00; AX=N; AX.frame={{0, 165}, {375, 65}}; AX.activationPoint={187.5, 197.5}; AX.traits='UIAccessibilityTraitButton'; AX.focused='N'; frame={{0, 65}, {375, 65}}; opaque; alpha=1; text=''>
  |  |  |  |  |  |  |--<UIButton:0x7f9cf6506f30; AX=Y; AX.label='More Info'; AX.frame={{351, 191}, {8, 13}}; AX.activationPoint={355, 197.5}; AX.traits='UIAccessibilityTraitButton,UIAccessibilityTraitNotEnabled'; AX.focused='N'; frame={{351, 26}, {8, 13}}; alpha=1; UIE=N>
  |  |  |  |  |  |  |  |--<UIImageView:0x7f9cf650d9b0; AX=N; AX.frame={{351, 191}, {8, 13}}; AX.activationPoint={355, 197.5}; AX.traits='UIAccessibilityTraitImage'; AX.focused='N'; frame={{0, 0}, {8, 13}}; alpha=1; UIE=N>
  |  |  |  |  |  |  |--<UITableViewCellContentView:0x7f9cf6534700; AX=Y; AX.id='Folder 1'; AX.label='Folder 1'; AX.frame={{0, 165}, {341, 65}}; AX.activationPoint={170.5, 197.5}; AX.traits='UIAccessibilityTraitButton'; AX.focused='N'; frame={{0, 0}, {341, 65}}; opaque; alpha=1>
  |  |  |  |  |  |  |  |--<UIView:0x7f9cf0c8f4a0; AX=N; AX.frame={{48, 229.66666666666669}, {327, 0.33333333333334281}}; AX.activationPoint={211.5, 229.83333333333337}; AX.traits='UIAccessibilityTraitNone'; AX.focused='N'; frame={{48, 64.666666666666671}, {327, 0.33333333333333331}}; opaque; alpha=1>
  |  |  |  |  |  |  |  |--<UIStackView:0x7f9cf65354e0; AX=N; AX.frame={{16, 165}, {309, 65}}; AX.activationPoint={170.5, 197.5}; AX.traits='UIAccessibilityTraitNone'; AX.focused='N'; frame={{16, 0}, {309, 65}}; opaque; alpha=1>
  |  |  |  |  |  |  |  |  |--<UITextField:0x7f9cf11ed800; AX=N; AX.value='Folder 1'; AX.frame={{48, 188}, {277, 19}}; AX.activationPoint={186.5, 197.5}; AX.traits='UIAccessibilityTraitNone'; AX.focused='N'; frame={{32, 23}, {277, 19}}; alpha=1; UIE=N; text='Folder 1'>
  |  |  |  |  |  |  |  |  |  |--<_UITextFieldContentView:0x7f9cf6534ca0; AX=N; AX.frame={{48, 188}, {277, 19}}; AX.activationPoint={186.5, 197.5}; AX.traits='UIAccessibilityTraitNone'; AX.focused='N'; frame={{0, 0}, {277, 19}}; alpha=1; UIE=N>
  |  |  |  |  |  |  |  |  |  |--<UIAccessibilityTextFieldElement:0x600003dd6250; AX=Y; AX.value='Folder 1'; AX.frame={{48, 188}, {277, 19}}; AX.activationPoint={186.5, 197.5}; AX.traits='UIAccessibilityTraitNone'; AX.focused='N'>
  |  |  |  |  |  |  |  |  |--<UILabel:0x7f9cf65351f0; AX=N; AX.frame={{40, 189.66666666666669}, {16, 16}}; AX.activationPoint={48, 197.66666666666669}; AX.traits='UIAccessibilityTraitStaticText'; AX.focused='N'; frame={{24, 24.666666666666671}, {16, 16}}; opaque; hidden; alpha=1; UIE=N; text=''>
  |  |  |  |  |  |  |  |  |--<UIImageView:0x7f9cf6534fc0; AX=N; AX.id='bookmark_gray_folder_new'; AX.frame={{16, 189.66666666666669}, {16, 16}}; AX.activationPoint={24, 197.66666666666669}; AX.traits='UIAccessibilityTraitImage'; AX.focused='N'; frame={{0, 24.666666666666671}, {16, 16}}; alpha=1; UIE=N>
  |  |  |  |  |  |--<BookmarkTableCell:0x7f9cf1055000; AX=N; AX.frame={{0, 230}, {375, 65}}; AX.activationPoint={187.5, 262.5}; AX.traits='UIAccessibilityTraitNone'; AX.focused='N'; frame={{0, 130}, {375, 65}}; opaque; alpha=1; text=''>
  |  |  |  |  |  |  |--<UITableViewCellContentView:0x7f9cf650de30; AX=Y; AX.id='French URL'; AX.label='French URL'; AX.frame={{0, 230}, {375, 65}}; AX.activationPoint={187.5, 262.5}; AX.traits='UIAccessibilityTraitButton'; AX.focused='N'; frame={{0, 0}, {375, 65}}; opaque; alpha=1>
  |  |  |  |  |  |  |  |--<UIView:0x7f9cf650f760; AX=N; AX.frame={{48, 294.66666666666669}, {327, 0.33333333333331439}}; AX.activationPoint={211.5, 294.83333333333337}; AX.traits='UIAccessibilityTraitNone'; AX.focused='N'; frame={{48, 64.666666666666671}, {327, 0.33333333333333331}}; opaque; alpha=1>
  |  |  |  |  |  |  |  |--<UIStackView:0x7f9cf650e8b0; AX=N; AX.frame={{16, 230}, {343, 65}}; AX.activationPoint={187.5, 262.5}; AX.traits='UIAccessibilityTraitNone'; AX.focused='N'; frame={{16, 0}, {343, 65}}; opaque; alpha=1>
  |  |  |  |  |  |  |  |  |--<UITextField:0x7f9cf1153a00; AX=N; AX.value='French URL'; AX.frame={{48, 253}, {311, 19}}; AX.activationPoint={203.5, 262.5}; AX.traits='UIAccessibilityTraitNone'; AX.focused='N'; frame={{32, 23}, {311, 19}}; alpha=1; UIE=N; text='French URL'>
  |  |  |  |  |  |  |  |  |  |--<_UITextFieldContentView:0x7f9cf650e190; AX=N; AX.frame={{48, 253}, {311, 19}}; AX.activationPoint={203.5, 262.5}; AX.traits='UIAccessibilityTraitNone'; AX.focused='N'; frame={{0, 0}, {311, 19}}; alpha=1; UIE=N>
  |  |  |  |  |  |  |  |  |  |--<UIAccessibilityTextFieldElement:0x600003dd4780; AX=Y; AX.value='French URL'; AX.frame={{48, 253}, {311, 19}}; AX.activationPoint={203.5, 262.5}; AX.traits='UIAccessibilityTraitNone'; AX.focused='N'>
  |  |  |  |  |  |  |  |  |--<UILabel:0x7f9cf650e5c0; AX=Y; AX.label='IP'; AX.frame={{16, 254.66666666666669}, {16, 16}}; AX.activationPoint={24, 262.66666666666669}; AX.traits='UIAccessibilityTraitStaticText'; AX.focused='N'; frame={{0, 24.666666666666671}, {16, 16}}; opaque; alpha=1; UIE=N; text='IP'>
  |  |  |  |  |  |  |  |  |--<UIImageView:0x7f9cf650e390; AX=N; AX.frame={{0, 254.66666666666669}, {16, 16}}; AX.activationPoint={8, 262.66666666666669}; AX.traits='UIAccessibilityTraitImage'; AX.focused='N'; frame={{-16, 24.666666666666671}, {16, 16}}; opaque; hidden; alpha=1; UIE=N>
  |  |  |  |  |  |--<BookmarkTableCell:0x7f9cf11f1800; AX=N; AX.frame={{0, 295}, {375, 65}}; AX.activationPoint={187.5, 327.5}; AX.traits='UIAccessibilityTraitNone'; AX.focused='N'; frame={{0, 195}, {375, 65}}; opaque; alpha=1; text=''>
  |  |  |  |  |  |  |--<UITableViewCellContentView:0x7f9cf0c0e910; AX=Y; AX.id='Second URL'; AX.label='Second URL'; AX.frame={{0, 295}, {375, 65}}; AX.activationPoint={187.5, 327.5}; AX.traits='UIAccessibilityTraitButton'; AX.focused='N'; frame={{0, 0}, {375, 65}}; opaque; alpha=1>
  |  |  |  |  |  |  |  |--<UIView:0x7f9cf6523010; AX=N; AX.frame={{48, 359.66666666666669}, {327, 0.33333333333331439}}; AX.activationPoint={211.5, 359.83333333333337}; AX.traits='UIAccessibilityTraitNone'; AX.focused='N'; frame={{48, 64.666666666666671}, {327, 0.33333333333333331}}; opaque; alpha=1>
  |  |  |  |  |  |  |  |--<UIStackView:0x7f9cf6522040; AX=N; AX.frame={{16, 295}, {343, 65}}; AX.activationPoint={187.5, 327.5}; AX.traits='UIAccessibilityTraitNone'; AX.focused='N'; frame={{16, 0}, {343, 65}}; opaque; alpha=1>
  |  |  |  |  |  |  |  |  |--<UITextField:0x7f9cf1259c00; AX=N; AX.value='Second URL'; AX.frame={{48, 318}, {311, 19}}; AX.activationPoint={203.5, 327.5}; AX.traits='UIAccessibilityTraitNone'; AX.focused='N'; frame={{32, 23}, {311, 19}}; alpha=1; UIE=N; text='Second URL'>
  |  |  |  |  |  |  |  |  |  |--<_UITextFieldContentView:0x7f9cf6521920; AX=N; AX.frame={{48, 318}, {311, 19}}; AX.activationPoint={203.5, 327.5}; AX.traits='UIAccessibilityTraitNone'; AX.focused='N'; frame={{0, 0}, {311, 19}}; alpha=1; UIE=N>
  |  |  |  |  |  |  |  |  |  |--<UIAccessibilityTextFieldElement:0x600003df0510; AX=Y; AX.value='Second URL'; AX.frame={{48, 318}, {311, 19}}; AX.activationPoint={203.5, 327.5}; AX.traits='UIAccessibilityTraitNone'; AX.focused='N'>
  |  |  |  |  |  |  |  |  |--<UILabel:0x7f9cf6521d50; AX=Y; AX.label='IP'; AX.frame={{16, 319.66666666666669}, {16, 16}}; AX.activationPoint={24, 327.66666666666669}; AX.traits='UIAccessibilityTraitStaticText'; AX.focused='N'; frame={{0, 24.666666666666671}, {16, 16}}; opaque; alpha=1; UIE=N; text='IP'>
  |  |  |  |  |  |  |  |  |--<UIImageView:0x7f9cf6521b20; AX=N; AX.frame={{0, 319.66666666666669}, {16, 16}}; AX.activationPoint={8, 327.66666666666669}; AX.traits='UIAccessibilityTraitImage'; AX.focused='N'; frame={{-16, 24.666666666666671}, {16, 16}}; opaque; hidden; alpha=1; UIE=N>
  |  |  |  |  |  |--<BookmarkTableCell:0x7f9cf11d0200; AX=N; AX.frame={{0, 360}, {375, 65}}; AX.activationPoint={187.5, 392.5}; AX.traits='UIAccessibilityTraitNone'; AX.focused='N'; frame={{0, 260}, {375, 65}}; opaque; alpha=1; text=''>
  |  |  |  |  |  |  |--<UITableViewCellContentView:0x7f9cf65171c0; AX=Y; AX.id='First URL'; AX.label='First URL'; AX.frame={{0, 360}, {375, 65}}; AX.activationPoint={187.5, 392.5}; AX.traits='UIAccessibilityTraitButton'; AX.focused='N'; frame={{0, 0}, {375, 65}}; opaque; alpha=1>
  |  |  |  |  |  |  |  |--<UIView:0x7f9cf6518980; AX=N; AX.frame={{48, 424.66666666666669}, {327, 0.33333333333331439}}; AX.activationPoint={211.5, 424.83333333333337}; AX.traits='UIAccessibilityTraitNone'; AX.focused='N'; frame={{48, 64.666666666666671}, {327, 0.33333333333333331}}; opaque; alpha=1>
  |  |  |  |  |  |  |  |--<UIStackView:0x7f9cf6517ad0; AX=N; AX.frame={{16, 360}, {343, 65}}; AX.activationPoint={187.5, 392.5}; AX.traits='UIAccessibilityTraitNone'; AX.focused='N'; frame={{16, 0}, {343, 65}}; opaque; alpha=1>
  |  |  |  |  |  |  |  |  |--<UITextField:0x7f9cf1216a00; AX=N; AX.value='First URL'; AX.frame={{48, 383}, {311, 19}}; AX.activationPoint={203.5, 392.5}; AX.traits='UIAccessibilityTraitNone'; AX.focused='N'; frame={{32, 23}, {311, 19}}; alpha=1; UIE=N; text='First URL'>
  |  |  |  |  |  |  |  |  |  |--<_UITextFieldContentView:0x7f9cf65173b0; AX=N; AX.frame={{48, 383}, {311, 19}}; AX.activationPoint={203.5, 392.5}; AX.traits='UIAccessibilityTraitNone'; AX.focused='N'; frame={{0, 0}, {311, 19}}; alpha=1; UIE=N>
  |  |  |  |  |  |  |  |  |  |--<UIAccessibilityTextFieldElement:0x600003df3d50; AX=Y; AX.value='First URL'; AX.frame={{48, 383}, {311, 19}}; AX.activationPoint={203.5, 392.5}; AX.traits='UIAccessibilityTraitNone'; AX.focused='N'>
  |  |  |  |  |  |  |  |  |--<UILabel:0x7f9cf65177e0; AX=Y; AX.label='IP'; AX.frame={{16, 384.66666666666669}, {16, 16}}; AX.activationPoint={24, 392.66666666666669}; AX.traits='UIAccessibilityTraitStaticText'; AX.focused='N'; frame={{0, 24.666666666666671}, {16, 16}}; opaque; alpha=1; UIE=N; text='IP'>
  |  |  |  |  |  |  |  |  |--<UIImageView:0x7f9cf65175b0; AX=N; AX.frame={{0, 384.66666666666669}, {16, 16}}; AX.activationPoint={8, 392.66666666666669}; AX.traits='UIAccessibilityTraitImage'; AX.focused='N'; frame={{-16, 24.666666666666671}, {16, 16}}; opaque; hidden; alpha=1; UIE=N>
  |--<UITransitionView:0x7f9cf304a9c0; AX=N; AX.frame={{0, 0}, {375, 812}}; AX.activationPoint={187.5, 406}; AX.traits='UIAccessibilityTraitNone'; AX.focused='N'; frame={{0, 0}, {375, 812}}; opaque; alpha=1>
<unknown>:0: error: -[BookmarksTestCaseSearch testSearchTapOnScrimCancelsSearchController] : failed: caught "EarlGreyInternalTestInterruptException", "Immediately halt execution of testcase"
(
	0   CoreFoundation                      0x000000011c0da29b __exceptionPreprocess + 331
	1   libobjc.A.dylib                     0x0000000121182735 objc_exception_throw + 48
	2   CoreFoundation                      0x000000011c0d9e09 -[NSException raise] + 9
	3   EarlGrey                            0x000000011e0f76cd -[XCTestCase(GREYAdditions) grey_markAsFailedAtLine:inFile:description:] + 237
	4   EarlGrey                            0x000000011e124277 -[GREYDefaultFailureHandler handleException:details:] + 1655
	5   EarlGrey                            0x000000011e115689 -[GREYElementInteraction grey_handleFailureOfAction:actionError:userProvidedOutError:] + 4201
	6   EarlGrey                            0x000000011e11254a __46-[GREYElementInteraction performAction:error:]_block_invoke + 1626
	7   EarlGrey                            0x000000011e13d2c4 __59-[GREYUIThreadExecutor executeSyncWithTimeout:block:error:]_block_invoke + 68
	8   EarlGrey                            0x000000011e13a20a __77-[GREYRunLoopSpinner grey_drainRunLoopInActiveModeAndCheckCondition:forTime:]_block_invoke + 314
	9   EarlGrey                            0x000000011e13abef __89-[GREYRunLoopSpinner grey_setupObserverInMode:withBeforeSourcesBlock:beforeWaitingBlock:]_block_invoke + 175
	10  CoreFoundation                      0x000000011c03d037 __CFRUNLOOP_IS_CALLING_OUT_TO_AN_OBSERVER_CALLBACK_FUNCTION__ + 23
	11  CoreFoundation                      0x000000011c0374ce __CFRunLoopDoObservers + 430
	12  CoreFoundation                      0x000000011c037a33 __CFRunLoopRun + 1235
	13  CoreFoundation                      0x000000011c037221 CFRunLoopRunSpecific + 625
	14  EarlGrey                            0x000000011e139e35 -[GREYRunLoopSpinner grey_drainRunLoopInActiveModeAndCheckCondition:forTime:] + 597
	15  EarlGrey                            0x000000011e1398b3 -[GREYRunLoopSpinner spinWithStopConditionBlock:] + 419
	16  EarlGrey                            0x000000011e13cd2c -[GREYUIThreadExecutor executeSyncWithTimeout:block:error:] + 1004
	17  EarlGrey                            0x000000011e11154d -[GREYElementInteraction performAction:error:] + 1789
	18  EarlGrey                            0x000000011e110e1f -[GREYElementInteraction performAction:] + 79
	19  ios_chrome_bookmarks_egtests        0x000000010e0577e4 -[BookmarksTestCaseSearch testSearchTapOnScrimCancelsSearchController] + 436
	20  CoreFoundation                      0x000000011c0e111c __invoking___ + 140
	21  CoreFoundation                      0x000000011c0de5b5 -[NSInvocation invoke] + 325
	22  EarlGrey                            0x000000011e1070c8 -[GREYTestCaseInvocation invoke] + 104
	23  XCTest                              0x000000011d558b6e __24-[XCTestCase invokeTest]_block_invoke.192 + 78
	24  XCTest                              0x000000011d5b02e8 -[XCTestCase(Failures) performFailableBlock:testCaseRun:shouldInterruptTest:] + 57
	25  XCTest                              0x000000011d5b0205 -[XCTestCase(Failures) _performTurningExceptionsIntoFailuresInterruptAfterHandling:block:] + 96
	26  XCTest                              0x000000011d55882f __24-[XCTestCase invokeTest]_block_invoke + 848
	27  XCTest                              0x000000011d5b61ee -[XCUITestContext performInScope:] + 248
	28  XCTest                              0x000000011d558424 -[XCTestCase testContextPerformInScope:] + 98
	29  XCTest                              0x000000011d5584d2 -[XCTestCase invokeTest] + 137
	30  EarlGrey                            0x000000011e0f7c67 -[XCTestCase(GREYAdditions) grey_invokeTest] + 1079
	31  XCTest                              0x000000011d55a00d __26-[XCTestCase performTest:]_block_invoke_2 + 43
	32  XCTest                              0x000000011d5b02e8 -[XCTestCase(Failures) performFailableBlock:testCaseRun:shouldInterruptTest:] + 57
	33  XCTest                              0x000000011d5b0205 -[XCTestCase(Failures) _performTurningExceptionsIntoFailuresInterruptAfterHandling:block:] + 96
	34  XCTest                              0x000000011d559f24 __26-[XCTestCase performTest:]_block_invoke.326 + 88
	35  XCTest                              0x000000011d5c0a3b +[XCTContext runInContextForTestCase:block:] + 225
	36  XCTest                              0x000000011d559653 -[XCTestCase performTest:] + 675
	37  XCTest                              0x000000011d59c802 -[XCTest runTest] + 57
	38  XCTest                              0x000000011d55485b __27-[XCTestSuite performTest:]_block_invoke + 365
	39  XCTest                              0x000000011d554033 -[XCTestSuite _performProtectedSectionForTest:testSection:] + 55
	40  XCTest                              0x000000011d5542f6 -[XCTestSuite performTest:] + 296
	41  XCTest                              0x000000011d59c802 -[XCTest runTest] + 57
	42  XCTest                              0x000000011d55485b __27-[XCTestSuite performTest:]_block_invoke + 365
	43  XCTest                              0x000000011d554033 -[XCTestSuite _performProtectedSectionForTest:testSection:] + 55
	44  XCTest                              0x000000011d5542f6 -[XCTestSuite performTest:] + 296
	45  XCTest                              0x000000011d59c802 -[XCTest runTest] + 57
	46  XCTest                              0x000000011d55485b __27-[XCTestSuite performTest:]_block_invoke + 365
	47  XCTest                              0x000000011d554033 -[XCTestSuite _performProtectedSectionForTest:testSection:] + 55
	48  XCTest                              0x000000011d5542f6 -[XCTestSuite performTest:] + 296
	49  XCTest                              0x000000011d59c802 -[XCTest runTest] + 57
	50  XCTest                              0x000000011d5caea6 __44-[XCTTestRunSession runTestsAndReturnError:]_block_invoke + 171
	51  XCTest                              0x000000011d5cafc7 __44-[XCTTestRunSession runTestsAndReturnError:]_block_invoke.80 + 68
	52  XCTest                              0x000000011d56c86a -[XCTestObservationCenter _observeTestExecutionForBlock:] + 594
	53  XCTest                              0x000000011d5cac1a -[XCTTestRunSession runTestsAndReturnError:] + 623
	54  XCTest                              0x000000011d53925a -[XCTestDriver runTestsAndReturnError:] + 422
	55  XCTest                              0x000000011d5bcfbd _XCTestMain + 1478
	56  libXCTestBundleInject.dylib         0x000000011bfa0bb8 __copy_helper_block_ + 0
	57  CoreFoundation                      0x000000011c03da3c __CFRUNLOOP_IS_CALLING_OUT_TO_A_BLOCK__ + 12
	58  CoreFoundation                      0x000000011c03d1f0 __CFRunLoopDoBlocks + 336
	59  CoreFoundation                      0x000000011c037a64 __CFRunLoopRun + 1284
	60  CoreFoundation                      0x000000011c037221 CFRunLoopRunSpecific + 625
	61  GraphicsServices                    0x00000001269441dd GSEventRunModal + 62
	62  UIKitCore                           0x00000001220242f1 UIApplicationMain + 140
	63  ios_chrome_bookmarks_egtests        0x000000010dfe9073 _ZN12_GLOBAL__N_120RunUIApplicationMainEiPPc + 355
	64  ios_chrome_bookmarks_egtests        0x000000010dfe8b41 main + 417
	65  libdyld.dylib                       0x0000000124ad55cd start + 1
	66  ???                                 0x0000000000000006 0x0 + 6
)

Project Member

Comment 3 by bugdroid1@chromium.org, Sep 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/366e10e91e0e8a66cf59cae73a1e1bc7fd1a83db

commit 366e10e91e0e8a66cf59cae73a1e1bc7fd1a83db
Author: Dominic Battré <battre@chromium.org>
Date: Mon Sep 10 12:12:58 2018

Revert "[ios] Added bookmark search"

This reverts commit 1dba3ee80a85c1ddb0d0151a579a36e31548aed7.

Reason for revert: Speculative revert due to Failures on ios_chrome_bookmarks_egtests (iPhone X iOS 12.0)

Original change's description:
> [ios] Added bookmark search
> 
> When opening:
> https://drive.google.com/file/d/1z4iyQgQOL9jUFNfIf9Qg1SmFz9INxN88/view?usp=sharing
> When searching:
> https://drive.google.com/file/d/1wdMrOC9GDzh7e97HY-1ObHergJH0rnoC/view?usp=sharing
> 
> In action:
> https://drive.google.com/file/d/14NMZ4mkCUZM8QNyopWHQ6MyDX939bcni/view?usp=sharing
> 
> Bug:  879570 
> Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
> Change-Id: I51f88361a79703c55f03e2befb745ca3701ce577
> Reviewed-on: https://chromium-review.googlesource.com/1193932
> Commit-Queue: David Jean <djean@chromium.org>
> Reviewed-by: Sergio Collazos <sczs@chromium.org>
> Reviewed-by: Gauthier Ambard <gambard@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#589861}

TBR=sczs@chromium.org,gambard@chromium.org,djean@chromium.org

Change-Id: Ia9b723b9a69cb7aa4cf00f339f380a15a7e64109
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  879570 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Reviewed-on: https://chromium-review.googlesource.com/1215866
Reviewed-by: Dominic Battré <battre@chromium.org>
Commit-Queue: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589890}
[modify] https://crrev.com/366e10e91e0e8a66cf59cae73a1e1bc7fd1a83db/ios/chrome/browser/ui/bookmarks/bookmark_home_mediator.h
[modify] https://crrev.com/366e10e91e0e8a66cf59cae73a1e1bc7fd1a83db/ios/chrome/browser/ui/bookmarks/bookmark_home_mediator.mm
[modify] https://crrev.com/366e10e91e0e8a66cf59cae73a1e1bc7fd1a83db/ios/chrome/browser/ui/bookmarks/bookmark_home_shared_state.h
[modify] https://crrev.com/366e10e91e0e8a66cf59cae73a1e1bc7fd1a83db/ios/chrome/browser/ui/bookmarks/bookmark_home_shared_state.mm
[modify] https://crrev.com/366e10e91e0e8a66cf59cae73a1e1bc7fd1a83db/ios/chrome/browser/ui/bookmarks/bookmark_home_view_controller.mm
[modify] https://crrev.com/366e10e91e0e8a66cf59cae73a1e1bc7fd1a83db/ios/chrome/browser/ui/bookmarks/bookmark_home_view_controller_unittest.mm
[modify] https://crrev.com/366e10e91e0e8a66cf59cae73a1e1bc7fd1a83db/ios/chrome/browser/ui/bookmarks/bookmark_interaction_controller.mm
[modify] https://crrev.com/366e10e91e0e8a66cf59cae73a1e1bc7fd1a83db/ios/chrome/browser/ui/bookmarks/bookmark_ui_constants.h
[modify] https://crrev.com/366e10e91e0e8a66cf59cae73a1e1bc7fd1a83db/ios/chrome/browser/ui/bookmarks/bookmark_ui_constants.mm
[modify] https://crrev.com/366e10e91e0e8a66cf59cae73a1e1bc7fd1a83db/ios/chrome/browser/ui/bookmarks/bookmarks_egtest.mm

Project Member

Comment 4 by bugdroid1@chromium.org, Sep 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d8f11dd4ae180dc8bf9aa5271168e6102cd943aa

commit d8f11dd4ae180dc8bf9aa5271168e6102cd943aa
Author: David Jean <djean@google.com>
Date: Thu Sep 13 07:38:47 2018

[ios] Reland (of 1193932) Added bookmark search

When opening:
https://drive.google.com/file/d/1z4iyQgQOL9jUFNfIf9Qg1SmFz9INxN88/view?usp=sharing
When searching:
https://drive.google.com/file/d/1wdMrOC9GDzh7e97HY-1ObHergJH0rnoC/view?usp=sharing

In action:
https://drive.google.com/file/d/14NMZ4mkCUZM8QNyopWHQ6MyDX939bcni/view?usp=sharing

Bug:  879570 
Change-Id: Id472f13d269884eb1202920526b7776ce6468754
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Reviewed-on: https://chromium-review.googlesource.com/1193932
Commit-Queue: David Jean <djean@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#589861}
Reviewed-on: https://chromium-review.googlesource.com/1216042
Cr-Commit-Position: refs/heads/master@{#590942}
[modify] https://crrev.com/d8f11dd4ae180dc8bf9aa5271168e6102cd943aa/ios/chrome/browser/ui/bookmarks/bookmark_home_mediator.h
[modify] https://crrev.com/d8f11dd4ae180dc8bf9aa5271168e6102cd943aa/ios/chrome/browser/ui/bookmarks/bookmark_home_mediator.mm
[modify] https://crrev.com/d8f11dd4ae180dc8bf9aa5271168e6102cd943aa/ios/chrome/browser/ui/bookmarks/bookmark_home_shared_state.h
[modify] https://crrev.com/d8f11dd4ae180dc8bf9aa5271168e6102cd943aa/ios/chrome/browser/ui/bookmarks/bookmark_home_shared_state.mm
[modify] https://crrev.com/d8f11dd4ae180dc8bf9aa5271168e6102cd943aa/ios/chrome/browser/ui/bookmarks/bookmark_home_view_controller.mm
[modify] https://crrev.com/d8f11dd4ae180dc8bf9aa5271168e6102cd943aa/ios/chrome/browser/ui/bookmarks/bookmark_home_view_controller_unittest.mm
[modify] https://crrev.com/d8f11dd4ae180dc8bf9aa5271168e6102cd943aa/ios/chrome/browser/ui/bookmarks/bookmark_interaction_controller.mm
[modify] https://crrev.com/d8f11dd4ae180dc8bf9aa5271168e6102cd943aa/ios/chrome/browser/ui/bookmarks/bookmark_ui_constants.h
[modify] https://crrev.com/d8f11dd4ae180dc8bf9aa5271168e6102cd943aa/ios/chrome/browser/ui/bookmarks/bookmark_ui_constants.mm
[modify] https://crrev.com/d8f11dd4ae180dc8bf9aa5271168e6102cd943aa/ios/chrome/browser/ui/bookmarks/bookmarks_egtest.mm

Project Member

Comment 5 by bugdroid1@chromium.org, Sep 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/78ec22b9935e102b470727ec543451a3565bb21e

commit 78ec22b9935e102b470727ec543451a3565bb21e
Author: David Jean <djean@google.com>
Date: Fri Sep 14 09:03:46 2018

[ios] Added edit mode to bookmark search

Added handling of multiple edits by showing navigation bar when results are
visible and handling any operation that would use the original root_node.

Bug:  879570 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I451006aa456bcc494583aed58820e405d04852c0
Reviewed-on: https://chromium-review.googlesource.com/1213174
Commit-Queue: David Jean <djean@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591307}
[modify] https://crrev.com/78ec22b9935e102b470727ec543451a3565bb21e/ios/chrome/browser/ui/bookmarks/bookmark_home_view_controller.mm
[modify] https://crrev.com/78ec22b9935e102b470727ec543451a3565bb21e/ios/chrome/browser/ui/bookmarks/bookmarks_egtest.mm

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
Verified in 71.0.3555.0 Canary in iPhone 6s plus(iOS 12), iPhone 7plus(iOS 10.3.3), iPad Air(iOS 10.3.3) and iPad Air(iOS 12)

Bookmark search is now displayed

Link to screenshot:
https://drive.google.com/file/d/1-GYqr7BlvBp5-ZfN1-gcuChXNCOgF-XB/view?usp=sharing
Cc: linds...@chromium.org

Sign in to add a comment