New issue
Advanced search Search tips

Issue 879569 link

Starred by 1 user
Status: Verified
Owner:
djean@chromium.org
Closed: Sep 5
Cc:
ios-bugs@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: 1
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

[ios] visually show search password field as disabled

Project Member Reported by djean@chromium.org, Aug 31 
Chrome Version: (copy from chrome://version)
OS: iOS

What steps will reproduce the problem?
(1) Settings
(2) Passwords
(3) Edit

What is the expected result?
Search Bar should dim
What happens instead?
Search bar stays same color, even though it is disabled.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/45976032e2616915935a4d3a19c2a8f951de3424

commit 45976032e2616915935a4d3a19c2a8f951de3424
Author: David Jean <djean@google.com>
Date: Tue Sep 04 07:57:15 2018

[ios] Added visual disabled state to pwd search

Also Added some missing eg tests.

Bug:  879569 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I99084b2fc3d32797bcb4e12135b1d950d9befa1d
Reviewed-on: https://chromium-review.googlesource.com/1199363
Commit-Queue: David Jean <djean@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588467}
[modify] https://crrev.com/45976032e2616915935a4d3a19c2a8f951de3424/ios/chrome/browser/ui/settings/cells/settings_search_item.h
[modify] https://crrev.com/45976032e2616915935a4d3a19c2a8f951de3424/ios/chrome/browser/ui/settings/cells/settings_search_item.mm
[modify] https://crrev.com/45976032e2616915935a4d3a19c2a8f951de3424/ios/chrome/browser/ui/settings/passwords_settings_egtest.mm
[modify] https://crrev.com/45976032e2616915935a4d3a19c2a8f951de3424/ios/chrome/browser/ui/settings/save_passwords_collection_view_controller.mm
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/45976032e2616915935a4d3a19c2a8f951de3424

commit 45976032e2616915935a4d3a19c2a8f951de3424
Author: David Jean <djean@google.com>
Date: Tue Sep 04 07:57:15 2018

[ios] Added visual disabled state to pwd search

Also Added some missing eg tests.

Bug:  879569 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I99084b2fc3d32797bcb4e12135b1d950d9befa1d
Reviewed-on: https://chromium-review.googlesource.com/1199363
Commit-Queue: David Jean <djean@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588467}
[modify] https://crrev.com/45976032e2616915935a4d3a19c2a8f951de3424/ios/chrome/browser/ui/settings/cells/settings_search_item.h
[modify] https://crrev.com/45976032e2616915935a4d3a19c2a8f951de3424/ios/chrome/browser/ui/settings/cells/settings_search_item.mm
[modify] https://crrev.com/45976032e2616915935a4d3a19c2a8f951de3424/ios/chrome/browser/ui/settings/passwords_settings_egtest.mm
[modify] https://crrev.com/45976032e2616915935a4d3a19c2a8f951de3424/ios/chrome/browser/ui/settings/save_passwords_collection_view_controller.mm
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/45976032e2616915935a4d3a19c2a8f951de3424

commit 45976032e2616915935a4d3a19c2a8f951de3424
Author: David Jean <djean@google.com>
Date: Tue Sep 04 07:57:15 2018

[ios] Added visual disabled state to pwd search

Also Added some missing eg tests.

Bug:  879569 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I99084b2fc3d32797bcb4e12135b1d950d9befa1d
Reviewed-on: https://chromium-review.googlesource.com/1199363
Commit-Queue: David Jean <djean@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588467}
[modify] https://crrev.com/45976032e2616915935a4d3a19c2a8f951de3424/ios/chrome/browser/ui/settings/cells/settings_search_item.h
[modify] https://crrev.com/45976032e2616915935a4d3a19c2a8f951de3424/ios/chrome/browser/ui/settings/cells/settings_search_item.mm
[modify] https://crrev.com/45976032e2616915935a4d3a19c2a8f951de3424/ios/chrome/browser/ui/settings/passwords_settings_egtest.mm
[modify] https://crrev.com/45976032e2616915935a4d3a19c2a8f951de3424/ios/chrome/browser/ui/settings/save_passwords_collection_view_controller.mm

Comment 4 by djean@chromium.org, Sep 5

Status: Fixed (was: Assigned)

Comment 5 by pmadalla@chromium.org, Sep 11

Status: Verified (was: Fixed)
Verified the issue on the build 71.0.3549.0 canary tested on iPhone7+(11.4.1). 
Password bar is dim, looks good. 

Image:
https://drive.google.com/file/d/11pegTHpU_exqErIK6R5xOA44WmREK0p8/view?usp=sharing
►

Sign in to add a comment