Its functionality is now largely in chrome/install_static and other bits of chrome/installer/util. It should be removed for the sake of code clarity and maintainability.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9f352c1e2d1a18381783f10ddf876c0de59e2847 commit 9f352c1e2d1a18381783f10ddf876c0de59e2847 Author: Greg Thompson <grt@chromium.org> Date: Fri Aug 31 15:50:00 2018 Modernize InstallUtil::GetCriticalUpdateVersion. - Migrate from BrowserDistribution to install_static. - Treat base::Version as a value type. BUG= 879568 R=huangs@chromium.org Change-Id: I4bf2cf5558945d09d3f73acaf015ace3ce7f1c68 Reviewed-on: https://chromium-review.googlesource.com/1195094 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#588035} [modify] https://crrev.com/9f352c1e2d1a18381783f10ddf876c0de59e2847/chrome/browser/upgrade_detector/upgrade_detector_impl.cc [modify] https://crrev.com/9f352c1e2d1a18381783f10ddf876c0de59e2847/chrome/installer/util/install_util.cc [modify] https://crrev.com/9f352c1e2d1a18381783f10ddf876c0de59e2847/chrome/installer/util/install_util.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5f3eea5fa32b5d42f962fcf69c57c469043fe88c commit 5f3eea5fa32b5d42f962fcf69c57c469043fe88c Author: Greg Thompson <grt@chromium.org> Date: Fri Aug 31 18:13:23 2018 Move AddDefaultShortcutProperties from Product to ShellUtil. It no longer needs BrowserDistribution or Product. There are no functional changes. BUG= 879568 Change-Id: Idda9357d8de97d7e08989b46fd4461fba2929965 Reviewed-on: https://chromium-review.googlesource.com/1196224 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by: Greg Thompson <grt@chromium.org> Reviewed-by: Bernhard Bauer <bauerb@chromium.org> Reviewed-by: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#588091} [modify] https://crrev.com/5f3eea5fa32b5d42f962fcf69c57c469043fe88c/chrome/browser/profiles/profile_shortcut_manager_unittest_win.cc [modify] https://crrev.com/5f3eea5fa32b5d42f962fcf69c57c469043fe88c/chrome/browser/profiles/profile_shortcut_manager_win.cc [modify] https://crrev.com/5f3eea5fa32b5d42f962fcf69c57c469043fe88c/chrome/installer/setup/install.cc [modify] https://crrev.com/5f3eea5fa32b5d42f962fcf69c57c469043fe88c/chrome/installer/setup/install_unittest.cc [modify] https://crrev.com/5f3eea5fa32b5d42f962fcf69c57c469043fe88c/chrome/installer/setup/setup_main.cc [modify] https://crrev.com/5f3eea5fa32b5d42f962fcf69c57c469043fe88c/chrome/installer/setup/setup_util.cc [modify] https://crrev.com/5f3eea5fa32b5d42f962fcf69c57c469043fe88c/chrome/installer/util/chrome_browser_operations.cc [modify] https://crrev.com/5f3eea5fa32b5d42f962fcf69c57c469043fe88c/chrome/installer/util/chrome_browser_operations.h [modify] https://crrev.com/5f3eea5fa32b5d42f962fcf69c57c469043fe88c/chrome/installer/util/google_update_settings.cc [modify] https://crrev.com/5f3eea5fa32b5d42f962fcf69c57c469043fe88c/chrome/installer/util/product.cc [modify] https://crrev.com/5f3eea5fa32b5d42f962fcf69c57c469043fe88c/chrome/installer/util/product.h [modify] https://crrev.com/5f3eea5fa32b5d42f962fcf69c57c469043fe88c/chrome/installer/util/product_operations.h [modify] https://crrev.com/5f3eea5fa32b5d42f962fcf69c57c469043fe88c/chrome/installer/util/shell_util.cc [modify] https://crrev.com/5f3eea5fa32b5d42f962fcf69c57c469043fe88c/chrome/installer/util/shell_util.h [modify] https://crrev.com/5f3eea5fa32b5d42f962fcf69c57c469043fe88c/chrome/installer/util/shell_util_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fff082afafc63bac9b6cfe24858b9cf2b683777e commit fff082afafc63bac9b6cfe24858b9cf2b683777e Author: Greg Thompson <grt@chromium.org> Date: Fri Aug 31 18:18:14 2018 Remove dead code in installer/util. Product::AddKeyFiles has been unused since r165493. BUG= 879568 R=robertshield@chromium.org Change-Id: Iddecb99e6a877891848e66fb08d5fe46267e276a Reviewed-on: https://chromium-review.googlesource.com/1196231 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by: Robert Shield <robertshield@chromium.org> Cr-Commit-Position: refs/heads/master@{#588093} [modify] https://crrev.com/fff082afafc63bac9b6cfe24858b9cf2b683777e/chrome/installer/util/BUILD.gn [delete] https://crrev.com/a886f31ed796f5e053765a53be5403b1518aa157/chrome/installer/util/chrome_browser_operations.cc [delete] https://crrev.com/a886f31ed796f5e053765a53be5403b1518aa157/chrome/installer/util/chrome_browser_operations.h [modify] https://crrev.com/fff082afafc63bac9b6cfe24858b9cf2b683777e/chrome/installer/util/product.cc [modify] https://crrev.com/fff082afafc63bac9b6cfe24858b9cf2b683777e/chrome/installer/util/product.h [delete] https://crrev.com/a886f31ed796f5e053765a53be5403b1518aa157/chrome/installer/util/product_operations.h
The following CLs were also a part of this cleanup: - https://crrev.com/586920: GetChromeVersion cleanup - https://crrev.com/587023: SwapNewChromeExeIfPresent cleanup - https://crrev.com/587311: safe browsing client name cleanup - https://crrev.com/587327: IWYU fixes for browser_distribution.h - https://crrev.com/587345: fix jumbo build break - https://crrev.com/587598: Modernize GetDowngradeVersion and AddUpdateDowngradeVersionItem - https://crrev.com/587604: Replace Product::SetMsiMarker with DeleteRegistryValue - https://crrev.com/587666: Replace BrowserDistribution::GetAppDescription with InstallUtil::GetAppDescription
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5ce9d462c98d28e7866015350570518cc60c0cef commit 5ce9d462c98d28e7866015350570518cc60c0cef Author: Greg Thompson <grt@chromium.org> Date: Sat Sep 01 18:38:40 2018 Move launch functions from installer_util into setup.exe. These functions are only used by the installer, so they belong there. BUG= 879568 Change-Id: I6f934c86bd1f9f94ff3f02ae7e8b465c4070be66 Reviewed-on: https://chromium-review.googlesource.com/1199575 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#588289} [modify] https://crrev.com/5ce9d462c98d28e7866015350570518cc60c0cef/chrome/installer/setup/BUILD.gn [add] https://crrev.com/5ce9d462c98d28e7866015350570518cc60c0cef/chrome/installer/setup/launch_chrome.cc [add] https://crrev.com/5ce9d462c98d28e7866015350570518cc60c0cef/chrome/installer/setup/launch_chrome.h [modify] https://crrev.com/5ce9d462c98d28e7866015350570518cc60c0cef/chrome/installer/setup/setup_main.cc [modify] https://crrev.com/5ce9d462c98d28e7866015350570518cc60c0cef/chrome/installer/setup/uninstall.cc [modify] https://crrev.com/5ce9d462c98d28e7866015350570518cc60c0cef/chrome/installer/util/product.cc [modify] https://crrev.com/5ce9d462c98d28e7866015350570518cc60c0cef/chrome/installer/util/product.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ea06ab2f566abeef6a195863601f8a25194671e4 commit ea06ab2f566abeef6a195863601f8a25194671e4 Author: Greg Thompson <grt@chromium.org> Date: Tue Sep 04 16:31:29 2018 Move DoPostUninstallOperations from BrowserDistribution into setup. Showing the uninstall survey is a brand-specific behavior. This CL introduces a new setup/brand_behaviors.h file that declares various operations that vary by brand. DoPostUninstallOperations and GetDistributionData (its helper function) both reside in brand-specific implementation files that are selected at build time. This also allowed moving the uninstall metrics code from installer/util into installer/setup where it really belongs. I have also taken the liberty to gently modernize some of the moved code. BUG= 879568 Change-Id: I25d9c205d46ffb14454193fcc28ae5803502bf29 Reviewed-on: https://chromium-review.googlesource.com/1200862 Reviewed-by: Robert Sesek <rsesek@chromium.org> Reviewed-by: Brian White <bcwhite@chromium.org> Reviewed-by: Samuel Huang <huangs@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#588537} [modify] https://crrev.com/ea06ab2f566abeef6a195863601f8a25194671e4/chrome/installer/setup/BUILD.gn [modify] https://crrev.com/ea06ab2f566abeef6a195863601f8a25194671e4/chrome/installer/setup/DEPS [add] https://crrev.com/ea06ab2f566abeef6a195863601f8a25194671e4/chrome/installer/setup/brand_behaviors.h [add] https://crrev.com/ea06ab2f566abeef6a195863601f8a25194671e4/chrome/installer/setup/chromium_behaviors.cc [add] https://crrev.com/ea06ab2f566abeef6a195863601f8a25194671e4/chrome/installer/setup/google_chrome_behaviors.cc [modify] https://crrev.com/ea06ab2f566abeef6a195863601f8a25194671e4/chrome/installer/setup/setup_constants.cc [modify] https://crrev.com/ea06ab2f566abeef6a195863601f8a25194671e4/chrome/installer/setup/setup_constants.h [modify] https://crrev.com/ea06ab2f566abeef6a195863601f8a25194671e4/chrome/installer/setup/uninstall.cc [add] https://crrev.com/ea06ab2f566abeef6a195863601f8a25194671e4/chrome/installer/setup/uninstall_metrics.cc [rename] https://crrev.com/ea06ab2f566abeef6a195863601f8a25194671e4/chrome/installer/setup/uninstall_metrics.h [rename] https://crrev.com/ea06ab2f566abeef6a195863601f8a25194671e4/chrome/installer/setup/uninstall_metrics_unittest.cc [modify] https://crrev.com/ea06ab2f566abeef6a195863601f8a25194671e4/chrome/installer/util/BUILD.gn [modify] https://crrev.com/ea06ab2f566abeef6a195863601f8a25194671e4/chrome/installer/util/DEPS [modify] https://crrev.com/ea06ab2f566abeef6a195863601f8a25194671e4/chrome/installer/util/browser_distribution.cc [modify] https://crrev.com/ea06ab2f566abeef6a195863601f8a25194671e4/chrome/installer/util/browser_distribution.h [modify] https://crrev.com/ea06ab2f566abeef6a195863601f8a25194671e4/chrome/installer/util/google_chrome_distribution.cc [modify] https://crrev.com/ea06ab2f566abeef6a195863601f8a25194671e4/chrome/installer/util/google_chrome_distribution.h [delete] https://crrev.com/a01f12fb384baa9e668c8b78d54cf832947e2576/chrome/installer/util/uninstall_metrics.cc [modify] https://crrev.com/ea06ab2f566abeef6a195863601f8a25194671e4/chrome/installer/util/util_constants.cc [modify] https://crrev.com/ea06ab2f566abeef6a195863601f8a25194671e4/chrome/installer/util/util_constants.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f82f3089ca14042a57ceac2fd0fb65022273addf commit f82f3089ca14042a57ceac2fd0fb65022273addf Author: Greg Thompson <grt@chromium.org> Date: Tue Sep 04 17:37:39 2018 Move UpdateInstallStatus from BrowserDistribution into setup. This is brand-specific behavior for the installer. BUG= 879568 R=chengx@chromium.org Change-Id: Ifac2d4842482c58bf6ce23809217f15632d606ff Reviewed-on: https://chromium-review.googlesource.com/1200942 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#588576} [modify] https://crrev.com/f82f3089ca14042a57ceac2fd0fb65022273addf/chrome/installer/setup/brand_behaviors.h [modify] https://crrev.com/f82f3089ca14042a57ceac2fd0fb65022273addf/chrome/installer/setup/chromium_behaviors.cc [modify] https://crrev.com/f82f3089ca14042a57ceac2fd0fb65022273addf/chrome/installer/setup/google_chrome_behaviors.cc [modify] https://crrev.com/f82f3089ca14042a57ceac2fd0fb65022273addf/chrome/installer/setup/setup_main.cc [modify] https://crrev.com/f82f3089ca14042a57ceac2fd0fb65022273addf/chrome/installer/util/browser_distribution.cc [modify] https://crrev.com/f82f3089ca14042a57ceac2fd0fb65022273addf/chrome/installer/util/browser_distribution.h [modify] https://crrev.com/f82f3089ca14042a57ceac2fd0fb65022273addf/chrome/installer/util/google_chrome_distribution.cc [modify] https://crrev.com/f82f3089ca14042a57ceac2fd0fb65022273addf/chrome/installer/util/google_chrome_distribution.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4c360d34931a7bc4c153adc53ba938d9cee5869f commit 4c360d34931a7bc4c153adc53ba938d9cee5869f Author: Samuel Huang <huangs@chromium.org> Date: Tue Sep 04 19:28:02 2018 Revert "Move UpdateInstallStatus from BrowserDistribution into setup." This reverts commit f82f3089ca14042a57ceac2fd0fb65022273addf. Reason for revert: http://crbug.com/880484 Original change's description: > Move UpdateInstallStatus from BrowserDistribution into setup. > > This is brand-specific behavior for the installer. > > BUG= 879568 > R=chengx@chromium.org > > Change-Id: Ifac2d4842482c58bf6ce23809217f15632d606ff > Reviewed-on: https://chromium-review.googlesource.com/1200942 > Commit-Queue: Greg Thompson <grt@chromium.org> > Reviewed-by: Xi Cheng <chengx@chromium.org> > Cr-Commit-Position: refs/heads/master@{#588576} TBR=grt@chromium.org,chengx@chromium.org Change-Id: Ib0acfabd42ba741d957fa3dd578a87ecb198042d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 879568 Reviewed-on: https://chromium-review.googlesource.com/1204723 Reviewed-by: Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#588612} [modify] https://crrev.com/4c360d34931a7bc4c153adc53ba938d9cee5869f/chrome/installer/setup/brand_behaviors.h [modify] https://crrev.com/4c360d34931a7bc4c153adc53ba938d9cee5869f/chrome/installer/setup/chromium_behaviors.cc [modify] https://crrev.com/4c360d34931a7bc4c153adc53ba938d9cee5869f/chrome/installer/setup/google_chrome_behaviors.cc [modify] https://crrev.com/4c360d34931a7bc4c153adc53ba938d9cee5869f/chrome/installer/setup/setup_main.cc [modify] https://crrev.com/4c360d34931a7bc4c153adc53ba938d9cee5869f/chrome/installer/util/browser_distribution.cc [modify] https://crrev.com/4c360d34931a7bc4c153adc53ba938d9cee5869f/chrome/installer/util/browser_distribution.h [modify] https://crrev.com/4c360d34931a7bc4c153adc53ba938d9cee5869f/chrome/installer/util/google_chrome_distribution.cc [modify] https://crrev.com/4c360d34931a7bc4c153adc53ba938d9cee5869f/chrome/installer/util/google_chrome_distribution.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/898c03378ce34174d58f4b1ef1490cc65c008664 commit 898c03378ce34174d58f4b1ef1490cc65c008664 Author: Samuel Huang <huangs@chromium.org> Date: Tue Sep 04 19:33:11 2018 Revert "Move DoPostUninstallOperations from BrowserDistribution into setup." This reverts commit ea06ab2f566abeef6a195863601f8a25194671e4. Reason for revert: http://crbug.com/880484 Original change's description: > Move DoPostUninstallOperations from BrowserDistribution into setup. > > Showing the uninstall survey is a brand-specific behavior. This CL > introduces a new setup/brand_behaviors.h file that declares various > operations that vary by brand. DoPostUninstallOperations and > GetDistributionData (its helper function) both reside in brand-specific > implementation files that are selected at build time. > > This also allowed moving the uninstall metrics code from installer/util > into installer/setup where it really belongs. > > I have also taken the liberty to gently modernize some of the moved > code. > > BUG= 879568 > > Change-Id: I25d9c205d46ffb14454193fcc28ae5803502bf29 > Reviewed-on: https://chromium-review.googlesource.com/1200862 > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Brian White <bcwhite@chromium.org> > Reviewed-by: Samuel Huang <huangs@chromium.org> > Commit-Queue: Greg Thompson <grt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#588537} TBR=huangs@chromium.org,bcwhite@chromium.org,rsesek@chromium.org,grt@chromium.org Change-Id: I7f5efa7c536e8b2c8c18445ff0d3f6b869ffa7b9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 879568 Reviewed-on: https://chromium-review.googlesource.com/1204725 Reviewed-by: Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#588613} [modify] https://crrev.com/898c03378ce34174d58f4b1ef1490cc65c008664/chrome/installer/setup/BUILD.gn [modify] https://crrev.com/898c03378ce34174d58f4b1ef1490cc65c008664/chrome/installer/setup/DEPS [delete] https://crrev.com/4c360d34931a7bc4c153adc53ba938d9cee5869f/chrome/installer/setup/brand_behaviors.h [delete] https://crrev.com/4c360d34931a7bc4c153adc53ba938d9cee5869f/chrome/installer/setup/chromium_behaviors.cc [delete] https://crrev.com/4c360d34931a7bc4c153adc53ba938d9cee5869f/chrome/installer/setup/google_chrome_behaviors.cc [modify] https://crrev.com/898c03378ce34174d58f4b1ef1490cc65c008664/chrome/installer/setup/setup_constants.cc [modify] https://crrev.com/898c03378ce34174d58f4b1ef1490cc65c008664/chrome/installer/setup/setup_constants.h [modify] https://crrev.com/898c03378ce34174d58f4b1ef1490cc65c008664/chrome/installer/setup/uninstall.cc [delete] https://crrev.com/4c360d34931a7bc4c153adc53ba938d9cee5869f/chrome/installer/setup/uninstall_metrics.cc [modify] https://crrev.com/898c03378ce34174d58f4b1ef1490cc65c008664/chrome/installer/util/BUILD.gn [modify] https://crrev.com/898c03378ce34174d58f4b1ef1490cc65c008664/chrome/installer/util/DEPS [modify] https://crrev.com/898c03378ce34174d58f4b1ef1490cc65c008664/chrome/installer/util/browser_distribution.cc [modify] https://crrev.com/898c03378ce34174d58f4b1ef1490cc65c008664/chrome/installer/util/browser_distribution.h [modify] https://crrev.com/898c03378ce34174d58f4b1ef1490cc65c008664/chrome/installer/util/google_chrome_distribution.cc [modify] https://crrev.com/898c03378ce34174d58f4b1ef1490cc65c008664/chrome/installer/util/google_chrome_distribution.h [add] https://crrev.com/898c03378ce34174d58f4b1ef1490cc65c008664/chrome/installer/util/uninstall_metrics.cc [rename] https://crrev.com/898c03378ce34174d58f4b1ef1490cc65c008664/chrome/installer/util/uninstall_metrics.h [rename] https://crrev.com/898c03378ce34174d58f4b1ef1490cc65c008664/chrome/installer/util/uninstall_metrics_unittest.cc [modify] https://crrev.com/898c03378ce34174d58f4b1ef1490cc65c008664/chrome/installer/util/util_constants.cc [modify] https://crrev.com/898c03378ce34174d58f4b1ef1490cc65c008664/chrome/installer/util/util_constants.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/00d80f6b236436b5d7d57c69f9b23527aaa9e52f commit 00d80f6b236436b5d7d57c69f9b23527aaa9e52f Author: Greg Thompson <grt@chromium.org> Date: Wed Sep 05 10:21:50 2018 Reland "Move DoPostUninstallOperations from BrowserDistribution into setup." This is a reland of ea06ab2f566abeef6a195863601f8a25194671e4. Original CL: > Showing the uninstall survey is a brand-specific behavior. This CL > introduces a new setup/brand_behaviors.h file that declares various > operations that vary by brand. DoPostUninstallOperations and > GetDistributionData (its helper function) both reside in brand-specific > implementation files that are selected at build time. > > This also allowed moving the uninstall metrics code from installer/util > into installer/setup where it really belongs. > > I have also taken the liberty to gently modernize some of the moved > code. > > BUG= 879568 > > Change-Id: I25d9c205d46ffb14454193fcc28ae5803502bf29 > Reviewed-on: https://chromium-review.googlesource.com/1200862 > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Brian White <bcwhite@chromium.org> > Reviewed-by: Samuel Huang <huangs@chromium.org> > Commit-Queue: Greg Thompson <grt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#588537} > (cherry picked from commit ea06ab2f566abeef6a195863601f8a25194671e4) BUG= 879568 TBR=rsesek@chromium.org,bcwhite@chromium.org,huangs@chromium.org Change-Id: I089f50e1a24d447936bb034bddc9cba5ee0afa7f Reviewed-on: https://chromium-review.googlesource.com/1206431 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#588817} [modify] https://crrev.com/00d80f6b236436b5d7d57c69f9b23527aaa9e52f/chrome/installer/setup/BUILD.gn [modify] https://crrev.com/00d80f6b236436b5d7d57c69f9b23527aaa9e52f/chrome/installer/setup/DEPS [add] https://crrev.com/00d80f6b236436b5d7d57c69f9b23527aaa9e52f/chrome/installer/setup/brand_behaviors.h [add] https://crrev.com/00d80f6b236436b5d7d57c69f9b23527aaa9e52f/chrome/installer/setup/chromium_behaviors.cc [add] https://crrev.com/00d80f6b236436b5d7d57c69f9b23527aaa9e52f/chrome/installer/setup/google_chrome_behaviors.cc [modify] https://crrev.com/00d80f6b236436b5d7d57c69f9b23527aaa9e52f/chrome/installer/setup/setup_constants.cc [modify] https://crrev.com/00d80f6b236436b5d7d57c69f9b23527aaa9e52f/chrome/installer/setup/setup_constants.h [modify] https://crrev.com/00d80f6b236436b5d7d57c69f9b23527aaa9e52f/chrome/installer/setup/uninstall.cc [add] https://crrev.com/00d80f6b236436b5d7d57c69f9b23527aaa9e52f/chrome/installer/setup/uninstall_metrics.cc [rename] https://crrev.com/00d80f6b236436b5d7d57c69f9b23527aaa9e52f/chrome/installer/setup/uninstall_metrics.h [rename] https://crrev.com/00d80f6b236436b5d7d57c69f9b23527aaa9e52f/chrome/installer/setup/uninstall_metrics_unittest.cc [modify] https://crrev.com/00d80f6b236436b5d7d57c69f9b23527aaa9e52f/chrome/installer/util/BUILD.gn [modify] https://crrev.com/00d80f6b236436b5d7d57c69f9b23527aaa9e52f/chrome/installer/util/DEPS [modify] https://crrev.com/00d80f6b236436b5d7d57c69f9b23527aaa9e52f/chrome/installer/util/browser_distribution.cc [modify] https://crrev.com/00d80f6b236436b5d7d57c69f9b23527aaa9e52f/chrome/installer/util/browser_distribution.h [modify] https://crrev.com/00d80f6b236436b5d7d57c69f9b23527aaa9e52f/chrome/installer/util/google_chrome_distribution.cc [modify] https://crrev.com/00d80f6b236436b5d7d57c69f9b23527aaa9e52f/chrome/installer/util/google_chrome_distribution.h [delete] https://crrev.com/83fe18057de72b9b5c6771975c043a722b658cd2/chrome/installer/util/uninstall_metrics.cc [modify] https://crrev.com/00d80f6b236436b5d7d57c69f9b23527aaa9e52f/chrome/installer/util/util_constants.cc [modify] https://crrev.com/00d80f6b236436b5d7d57c69f9b23527aaa9e52f/chrome/installer/util/util_constants.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f837b80e3b0322bb573ce1f3cad296b1cab07b4a commit f837b80e3b0322bb573ce1f3cad296b1cab07b4a Author: Greg Thompson <grt@chromium.org> Date: Wed Sep 05 10:56:25 2018 Reland "Move UpdateInstallStatus from BrowserDistribution into setup." This reverts commit 4c360d34931a7bc4c153adc53ba938d9cee5869f. Reason for revert: http://crbug.com/880484 has been resolved so this is clear to land now. Original change's description: > Revert "Move UpdateInstallStatus from BrowserDistribution into setup." > > This reverts commit f82f3089ca14042a57ceac2fd0fb65022273addf. > > Reason for revert: http://crbug.com/880484 > > Original change's description: > > Move UpdateInstallStatus from BrowserDistribution into setup. > > > > This is brand-specific behavior for the installer. > > > > BUG= 879568 > > R=chengx@chromium.org > > > > Change-Id: Ifac2d4842482c58bf6ce23809217f15632d606ff > > Reviewed-on: https://chromium-review.googlesource.com/1200942 > > Commit-Queue: Greg Thompson <grt@chromium.org> > > Reviewed-by: Xi Cheng <chengx@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#588576} > > TBR=grt@chromium.org,chengx@chromium.org > > Change-Id: Ib0acfabd42ba741d957fa3dd578a87ecb198042d > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 879568 > Reviewed-on: https://chromium-review.googlesource.com/1204723 > Reviewed-by: Samuel Huang <huangs@chromium.org> > Commit-Queue: Samuel Huang <huangs@chromium.org> > Cr-Commit-Position: refs/heads/master@{#588612} TBR=huangs@chromium.org,grt@chromium.org,chengx@chromium.org Change-Id: Icb571cc1c7932c0162dde5bfce5fbc900ed8ba5e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 879568 Reviewed-on: https://chromium-review.googlesource.com/1206472 Reviewed-by: Greg Thompson <grt@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#588826} [modify] https://crrev.com/f837b80e3b0322bb573ce1f3cad296b1cab07b4a/chrome/installer/setup/brand_behaviors.h [modify] https://crrev.com/f837b80e3b0322bb573ce1f3cad296b1cab07b4a/chrome/installer/setup/chromium_behaviors.cc [modify] https://crrev.com/f837b80e3b0322bb573ce1f3cad296b1cab07b4a/chrome/installer/setup/google_chrome_behaviors.cc [modify] https://crrev.com/f837b80e3b0322bb573ce1f3cad296b1cab07b4a/chrome/installer/setup/setup_main.cc [modify] https://crrev.com/f837b80e3b0322bb573ce1f3cad296b1cab07b4a/chrome/installer/util/browser_distribution.cc [modify] https://crrev.com/f837b80e3b0322bb573ce1f3cad296b1cab07b4a/chrome/installer/util/browser_distribution.h [modify] https://crrev.com/f837b80e3b0322bb573ce1f3cad296b1cab07b4a/chrome/installer/util/google_chrome_distribution.cc [modify] https://crrev.com/f837b80e3b0322bb573ce1f3cad296b1cab07b4a/chrome/installer/util/google_chrome_distribution.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/31e1a2dbccc34a129ce779fea8d793b53f3ed945 commit 31e1a2dbccc34a129ce779fea8d793b53f3ed945 Author: Greg Thompson <grt@chromium.org> Date: Wed Sep 05 11:15:44 2018 Move GetPublisherName from BrowserDistribution into InstallUtil. Chromium will now report "The Chromium Authors" rather than "Chromium" as its publisher name (as it should have all along). BUG= 879568 Change-Id: I05b6989b015e8fa9f91a1d1803fb82630598d60d Reviewed-on: https://chromium-review.googlesource.com/1200864 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#588828} [modify] https://crrev.com/31e1a2dbccc34a129ce779fea8d793b53f3ed945/chrome/installer/setup/install_worker.cc [modify] https://crrev.com/31e1a2dbccc34a129ce779fea8d793b53f3ed945/chrome/installer/util/browser_distribution.cc [modify] https://crrev.com/31e1a2dbccc34a129ce779fea8d793b53f3ed945/chrome/installer/util/browser_distribution.h [modify] https://crrev.com/31e1a2dbccc34a129ce779fea8d793b53f3ed945/chrome/installer/util/google_chrome_distribution.cc [modify] https://crrev.com/31e1a2dbccc34a129ce779fea8d793b53f3ed945/chrome/installer/util/google_chrome_distribution.h [modify] https://crrev.com/31e1a2dbccc34a129ce779fea8d793b53f3ed945/chrome/installer/util/install_util.cc [modify] https://crrev.com/31e1a2dbccc34a129ce779fea8d793b53f3ed945/chrome/installer/util/install_util.h [modify] https://crrev.com/31e1a2dbccc34a129ce779fea8d793b53f3ed945/chrome/installer/util/shell_util.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/528d0966b3cfe8df72b9373392e2ded2a61f64b8 commit 528d0966b3cfe8df72b9373392e2ded2a61f64b8 Author: Greg Thompson <grt@chromium.org> Date: Thu Sep 06 06:01:38 2018 Move some more functions from BrowserDistribution to InstallUtil. In particular: GetShortcutName, GetStartMenuShortcutSubfolder, and GetLongAppDescription are now in InstallUtil. BUG= 879568 TBR=bauerb@chromium.org,sky@chromium.org Change-Id: I42fb4e44fa5d315ee60d051f3410f3dc92e16d9e Reviewed-on: https://chromium-review.googlesource.com/1200865 Reviewed-by: Bernhard Bauer <bauerb@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: François Doray <fdoray@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#589105} [modify] https://crrev.com/528d0966b3cfe8df72b9373392e2ded2a61f64b8/chrome/browser/profiles/profile_shortcut_manager_unittest_win.cc [modify] https://crrev.com/528d0966b3cfe8df72b9373392e2ded2a61f64b8/chrome/browser/profiles/profile_shortcut_manager_win.cc [modify] https://crrev.com/528d0966b3cfe8df72b9373392e2ded2a61f64b8/chrome/browser/profiles/profile_shortcut_manager_win.h [modify] https://crrev.com/528d0966b3cfe8df72b9373392e2ded2a61f64b8/chrome/browser/shell_integration.h [modify] https://crrev.com/528d0966b3cfe8df72b9373392e2ded2a61f64b8/chrome/browser/ui/views/frame/browser_window_property_manager_browsertest_win.cc [modify] https://crrev.com/528d0966b3cfe8df72b9373392e2ded2a61f64b8/chrome/installer/setup/install.cc [modify] https://crrev.com/528d0966b3cfe8df72b9373392e2ded2a61f64b8/chrome/installer/setup/install_unittest.cc [modify] https://crrev.com/528d0966b3cfe8df72b9373392e2ded2a61f64b8/chrome/installer/util/browser_distribution.cc [modify] https://crrev.com/528d0966b3cfe8df72b9373392e2ded2a61f64b8/chrome/installer/util/browser_distribution.h [modify] https://crrev.com/528d0966b3cfe8df72b9373392e2ded2a61f64b8/chrome/installer/util/google_chrome_distribution_dummy.cc [modify] https://crrev.com/528d0966b3cfe8df72b9373392e2ded2a61f64b8/chrome/installer/util/install_util.cc [modify] https://crrev.com/528d0966b3cfe8df72b9373392e2ded2a61f64b8/chrome/installer/util/install_util.h [modify] https://crrev.com/528d0966b3cfe8df72b9373392e2ded2a61f64b8/chrome/installer/util/shell_util.cc [modify] https://crrev.com/528d0966b3cfe8df72b9373392e2ded2a61f64b8/chrome/installer/util/shell_util.h [modify] https://crrev.com/528d0966b3cfe8df72b9373392e2ded2a61f64b8/chrome/installer/util/shell_util_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/005a710c3b3c515ec0fa91bd70482bd4339ce586 commit 005a710c3b3c515ec0fa91bd70482bd4339ce586 Author: Greg Thompson <grt@chromium.org> Date: Thu Sep 06 06:54:38 2018 Move GetDisplayName from BrowserDistribution to InstallUtil. BUG= 879568 Change-Id: Ia3247e32ad072b014561990a9e0da87b7be3edc0 Reviewed-on: https://chromium-review.googlesource.com/1200866 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#589108} [modify] https://crrev.com/005a710c3b3c515ec0fa91bd70482bd4339ce586/chrome/browser/chrome_browser_main_win.cc [modify] https://crrev.com/005a710c3b3c515ec0fa91bd70482bd4339ce586/chrome/browser/local_discovery/service_discovery_shared_client.cc [modify] https://crrev.com/005a710c3b3c515ec0fa91bd70482bd4339ce586/chrome/browser/media/router/mojo/media_route_provider_util_win.cc [modify] https://crrev.com/005a710c3b3c515ec0fa91bd70482bd4339ce586/chrome/browser/profile_resetter/profile_resetter.cc [modify] https://crrev.com/005a710c3b3c515ec0fa91bd70482bd4339ce586/chrome/browser/profiles/profile_shortcut_manager_unittest_win.cc [modify] https://crrev.com/005a710c3b3c515ec0fa91bd70482bd4339ce586/chrome/browser/profiles/profile_shortcut_manager_win.cc [modify] https://crrev.com/005a710c3b3c515ec0fa91bd70482bd4339ce586/chrome/browser/shell_integration_win.cc [modify] https://crrev.com/005a710c3b3c515ec0fa91bd70482bd4339ce586/chrome/browser/web_applications/components/web_app_shortcut_win.cc [modify] https://crrev.com/005a710c3b3c515ec0fa91bd70482bd4339ce586/chrome/installer/setup/install.cc [modify] https://crrev.com/005a710c3b3c515ec0fa91bd70482bd4339ce586/chrome/installer/setup/install_worker.cc [modify] https://crrev.com/005a710c3b3c515ec0fa91bd70482bd4339ce586/chrome/installer/setup/installer_state.cc [modify] https://crrev.com/005a710c3b3c515ec0fa91bd70482bd4339ce586/chrome/installer/setup/setup_main.cc [modify] https://crrev.com/005a710c3b3c515ec0fa91bd70482bd4339ce586/chrome/installer/setup/uninstall.cc [modify] https://crrev.com/005a710c3b3c515ec0fa91bd70482bd4339ce586/chrome/installer/util/browser_distribution.cc [modify] https://crrev.com/005a710c3b3c515ec0fa91bd70482bd4339ce586/chrome/installer/util/browser_distribution.h [modify] https://crrev.com/005a710c3b3c515ec0fa91bd70482bd4339ce586/chrome/installer/util/firewall_manager_win.cc [modify] https://crrev.com/005a710c3b3c515ec0fa91bd70482bd4339ce586/chrome/installer/util/firewall_manager_win.h [modify] https://crrev.com/005a710c3b3c515ec0fa91bd70482bd4339ce586/chrome/installer/util/install_util.cc [modify] https://crrev.com/005a710c3b3c515ec0fa91bd70482bd4339ce586/chrome/installer/util/install_util.h [modify] https://crrev.com/005a710c3b3c515ec0fa91bd70482bd4339ce586/chrome/installer/util/shell_util.cc [modify] https://crrev.com/005a710c3b3c515ec0fa91bd70482bd4339ce586/chrome/installer/util/shell_util.h [modify] https://crrev.com/005a710c3b3c515ec0fa91bd70482bd4339ce586/chrome/installer/util/shell_util_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/26007adf7cb9f10760c0177613154317f5a6b32f commit 26007adf7cb9f10760c0177613154317f5a6b32f Author: Greg Thompson <grt@chromium.org> Date: Thu Sep 06 07:09:06 2018 Replace GetVersionKey() with GetClientsKeyPath. BUG= 879568 Change-Id: I3edeb811f2c892b6162f21648c7644b387007e25 Reviewed-on: https://chromium-review.googlesource.com/1200868 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#589110} [modify] https://crrev.com/26007adf7cb9f10760c0177613154317f5a6b32f/chrome/installer/setup/install_worker.cc [modify] https://crrev.com/26007adf7cb9f10760c0177613154317f5a6b32f/chrome/installer/setup/installer_state_unittest.cc [modify] https://crrev.com/26007adf7cb9f10760c0177613154317f5a6b32f/chrome/installer/setup/setup_main.cc [modify] https://crrev.com/26007adf7cb9f10760c0177613154317f5a6b32f/chrome/installer/setup/setup_util.cc [modify] https://crrev.com/26007adf7cb9f10760c0177613154317f5a6b32f/chrome/installer/setup/setup_util.h [modify] https://crrev.com/26007adf7cb9f10760c0177613154317f5a6b32f/chrome/installer/setup/setup_util_unittest.cc [modify] https://crrev.com/26007adf7cb9f10760c0177613154317f5a6b32f/chrome/installer/setup/uninstall.cc [modify] https://crrev.com/26007adf7cb9f10760c0177613154317f5a6b32f/chrome/installer/util/app_command.cc [modify] https://crrev.com/26007adf7cb9f10760c0177613154317f5a6b32f/chrome/installer/util/app_registration_data.h [modify] https://crrev.com/26007adf7cb9f10760c0177613154317f5a6b32f/chrome/installer/util/browser_distribution.cc [modify] https://crrev.com/26007adf7cb9f10760c0177613154317f5a6b32f/chrome/installer/util/browser_distribution.h [modify] https://crrev.com/26007adf7cb9f10760c0177613154317f5a6b32f/chrome/installer/util/installation_state.cc [modify] https://crrev.com/26007adf7cb9f10760c0177613154317f5a6b32f/chrome/installer/util/non_updating_app_registration_data.cc [modify] https://crrev.com/26007adf7cb9f10760c0177613154317f5a6b32f/chrome/installer/util/non_updating_app_registration_data.h [modify] https://crrev.com/26007adf7cb9f10760c0177613154317f5a6b32f/chrome/installer/util/product_state_unittest.cc [modify] https://crrev.com/26007adf7cb9f10760c0177613154317f5a6b32f/chrome/installer/util/product_unittest.cc [modify] https://crrev.com/26007adf7cb9f10760c0177613154317f5a6b32f/chrome/installer/util/test_app_registration_data.cc [modify] https://crrev.com/26007adf7cb9f10760c0177613154317f5a6b32f/chrome/installer/util/test_app_registration_data.h [modify] https://crrev.com/26007adf7cb9f10760c0177613154317f5a6b32f/chrome/installer/util/updating_app_registration_data.cc [modify] https://crrev.com/26007adf7cb9f10760c0177613154317f5a6b32f/chrome/installer/util/updating_app_registration_data.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aab3f4809612d631935a4e35fd2856b82d21ab40 commit aab3f4809612d631935a4e35fd2856b82d21ab40 Author: Greg Thompson <grt@chromium.org> Date: Sun Sep 09 11:12:37 2018 Replace GetStateMediumKey() with GetClientStateMediumKeyPath. Also moves some consumes of InstallDetails to the new convenience functions in install_static. BUG= 879568 Change-Id: I01c5c05f10a57407b3981ab64c6d4da2bb8de088 Reviewed-on: https://chromium-review.googlesource.com/1213145 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#589800} [modify] https://crrev.com/aab3f4809612d631935a4e35fd2856b82d21ab40/chrome/install_static/install_util.cc [modify] https://crrev.com/aab3f4809612d631935a4e35fd2856b82d21ab40/chrome/install_static/install_util.h [modify] https://crrev.com/aab3f4809612d631935a4e35fd2856b82d21ab40/chrome/installer/setup/install_worker.cc [modify] https://crrev.com/aab3f4809612d631935a4e35fd2856b82d21ab40/chrome/installer/setup/user_experiment_unittest.cc [modify] https://crrev.com/aab3f4809612d631935a4e35fd2856b82d21ab40/chrome/installer/util/app_registration_data.h [modify] https://crrev.com/aab3f4809612d631935a4e35fd2856b82d21ab40/chrome/installer/util/browser_distribution.cc [modify] https://crrev.com/aab3f4809612d631935a4e35fd2856b82d21ab40/chrome/installer/util/browser_distribution.h [modify] https://crrev.com/aab3f4809612d631935a4e35fd2856b82d21ab40/chrome/installer/util/experiment_storage_unittest.cc [modify] https://crrev.com/aab3f4809612d631935a4e35fd2856b82d21ab40/chrome/installer/util/google_update_settings.cc [modify] https://crrev.com/aab3f4809612d631935a4e35fd2856b82d21ab40/chrome/installer/util/google_update_settings_unittest.cc [modify] https://crrev.com/aab3f4809612d631935a4e35fd2856b82d21ab40/chrome/installer/util/installation_state.cc [modify] https://crrev.com/aab3f4809612d631935a4e35fd2856b82d21ab40/chrome/installer/util/non_updating_app_registration_data.cc [modify] https://crrev.com/aab3f4809612d631935a4e35fd2856b82d21ab40/chrome/installer/util/non_updating_app_registration_data.h [modify] https://crrev.com/aab3f4809612d631935a4e35fd2856b82d21ab40/chrome/installer/util/test_app_registration_data.cc [modify] https://crrev.com/aab3f4809612d631935a4e35fd2856b82d21ab40/chrome/installer/util/test_app_registration_data.h [modify] https://crrev.com/aab3f4809612d631935a4e35fd2856b82d21ab40/chrome/installer/util/updating_app_registration_data.cc [modify] https://crrev.com/aab3f4809612d631935a4e35fd2856b82d21ab40/chrome/installer/util/updating_app_registration_data.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8fc94ef249e1ee92af9f188ba3653f1f5a279433 commit 8fc94ef249e1ee92af9f188ba3653f1f5a279433 Author: Greg Thompson <grt@chromium.org> Date: Mon Sep 10 16:53:12 2018 Switch to install_static::GetClientStateKeyPath() in ElevateAndRegisterChrome. This removes the last use of BrowserDistribution in ShellUtil. BUG= 879568 Change-Id: Ib6ec1ab03913f16f17495ce67f603c7f1eb7ba1a Reviewed-on: https://chromium-review.googlesource.com/1215282 Reviewed-by: Owen Min <zmin@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#589947} [modify] https://crrev.com/8fc94ef249e1ee92af9f188ba3653f1f5a279433/chrome/browser/shell_integration_win.cc [modify] https://crrev.com/8fc94ef249e1ee92af9f188ba3653f1f5a279433/chrome/installer/setup/install.cc [modify] https://crrev.com/8fc94ef249e1ee92af9f188ba3653f1f5a279433/chrome/installer/setup/setup_main.cc [modify] https://crrev.com/8fc94ef249e1ee92af9f188ba3653f1f5a279433/chrome/installer/util/shell_util.cc [modify] https://crrev.com/8fc94ef249e1ee92af9f188ba3653f1f5a279433/chrome/installer/util/shell_util.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c7731a29958a476c0cc4d5dc9b4c4f9508ce449b commit c7731a29958a476c0cc4d5dc9b4c4f9508ce449b Author: Greg Thompson <grt@chromium.org> Date: Tue Sep 11 08:44:50 2018 Modernize more GoogleUpdateSettings functions. use install_static in InitChannelInfo, SetEULAConsent, and {Get,Set}ExperimentLables. Also: - changed EULA -> Eula in symbol names in chrome/installer. - added support for testing both per-user and per-machine installs in GCAPIOmahaExperimentTest. BUG= 879568 Change-Id: I7676c7b75a9cb4cd3a85d1ba609d66a71581f05e Reviewed-on: https://chromium-review.googlesource.com/1215024 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#590238} [modify] https://crrev.com/c7731a29958a476c0cc4d5dc9b4c4f9508ce449b/chrome/browser/first_run/first_run_internal_win.cc [modify] https://crrev.com/c7731a29958a476c0cc4d5dc9b4c4f9508ce449b/chrome/installer/gcapi/BUILD.gn [modify] https://crrev.com/c7731a29958a476c0cc4d5dc9b4c4f9508ce449b/chrome/installer/gcapi/DEPS [modify] https://crrev.com/c7731a29958a476c0cc4d5dc9b4c4f9508ce449b/chrome/installer/gcapi/gcapi_omaha_experiment_test.cc [modify] https://crrev.com/c7731a29958a476c0cc4d5dc9b4c4f9508ce449b/chrome/installer/gcapi/gcapi_test.cc [modify] https://crrev.com/c7731a29958a476c0cc4d5dc9b4c4f9508ce449b/chrome/installer/setup/setup_main.cc [modify] https://crrev.com/c7731a29958a476c0cc4d5dc9b4c4f9508ce449b/chrome/installer/util/experiment_storage.cc [modify] https://crrev.com/c7731a29958a476c0cc4d5dc9b4c4f9508ce449b/chrome/installer/util/google_update_constants.cc [modify] https://crrev.com/c7731a29958a476c0cc4d5dc9b4c4f9508ce449b/chrome/installer/util/google_update_constants.h [modify] https://crrev.com/c7731a29958a476c0cc4d5dc9b4c4f9508ce449b/chrome/installer/util/google_update_settings.cc [modify] https://crrev.com/c7731a29958a476c0cc4d5dc9b4c4f9508ce449b/chrome/installer/util/google_update_settings.h [modify] https://crrev.com/c7731a29958a476c0cc4d5dc9b4c4f9508ce449b/chrome/installer/util/google_update_settings_unittest.cc [modify] https://crrev.com/c7731a29958a476c0cc4d5dc9b4c4f9508ce449b/chrome/installer/util/install_util.cc [modify] https://crrev.com/c7731a29958a476c0cc4d5dc9b4c4f9508ce449b/chrome/installer/util/install_util.h [modify] https://crrev.com/c7731a29958a476c0cc4d5dc9b4c4f9508ce449b/chrome/installer/util/installation_state.cc [modify] https://crrev.com/c7731a29958a476c0cc4d5dc9b4c4f9508ce449b/chrome/installer/util/util_constants.cc [modify] https://crrev.com/c7731a29958a476c0cc4d5dc9b4c4f9508ce449b/chrome/installer/util/util_constants.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7796df611d973615b5fb61d884331bfb389d2b58 commit 7796df611d973615b5fb61d884331bfb389d2b58 Author: Greg Thompson <grt@chromium.org> Date: Wed Sep 12 21:13:32 2018 Switch to install_static in {Get,Set}CollectStatsConsent. This removes yet another use of BrowserDistribution and AppRegistrationData from installer/util. BUG= 879568 Change-Id: I7f5ead0b52598b0c5491938817c018a771c90405 Reviewed-on: https://chromium-review.googlesource.com/1215204 Reviewed-by: Patrick Monette <pmonette@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#590822} [modify] https://crrev.com/7796df611d973615b5fb61d884331bfb389d2b58/chrome/install_static/install_util.cc [modify] https://crrev.com/7796df611d973615b5fb61d884331bfb389d2b58/chrome/install_static/install_util.h [modify] https://crrev.com/7796df611d973615b5fb61d884331bfb389d2b58/chrome/installer/setup/install_worker.cc [modify] https://crrev.com/7796df611d973615b5fb61d884331bfb389d2b58/chrome/installer/setup/installer_crash_reporter_client.cc [modify] https://crrev.com/7796df611d973615b5fb61d884331bfb389d2b58/chrome/installer/util/google_update_settings.cc [modify] https://crrev.com/7796df611d973615b5fb61d884331bfb389d2b58/chrome/installer/util/google_update_settings.h [modify] https://crrev.com/7796df611d973615b5fb61d884331bfb389d2b58/chrome/installer/util/google_update_settings_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f2dff379a2e4e1307630894317b1fc3d08c1e605 commit f2dff379a2e4e1307630894317b1fc3d08c1e605 Author: Greg Thompson <grt@chromium.org> Date: Wed Sep 12 21:32:08 2018 Remove uses of BrowserDistribution outside of c/installer/setup. This CL switches the straggles outside of setup to using install_static. Also: - inline what's left of Product and remove product.cc. - remove TestAppRegistrationData (no longer unused). - remove google_chrome_distribution_dummy.cc (unused). BUG= 879568 Change-Id: Iff359b7fff346486fb4ec132d5b00e88dc6dc0e9 Reviewed-on: https://chromium-review.googlesource.com/1221267 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#590830} [modify] https://crrev.com/f2dff379a2e4e1307630894317b1fc3d08c1e605/chrome/browser/downgrade/user_data_downgrade_browsertest.cc [modify] https://crrev.com/f2dff379a2e4e1307630894317b1fc3d08c1e605/chrome/installer/util/BUILD.gn [modify] https://crrev.com/f2dff379a2e4e1307630894317b1fc3d08c1e605/chrome/installer/util/app_commands.h [modify] https://crrev.com/f2dff379a2e4e1307630894317b1fc3d08c1e605/chrome/installer/util/experiment_storage_unittest.cc [delete] https://crrev.com/36be926f766fe3f0cb231123e4b9e6b087aa27e0/chrome/installer/util/google_chrome_distribution_dummy.cc [modify] https://crrev.com/f2dff379a2e4e1307630894317b1fc3d08c1e605/chrome/installer/util/google_update_settings_unittest.cc [modify] https://crrev.com/f2dff379a2e4e1307630894317b1fc3d08c1e605/chrome/installer/util/install_util_unittest.cc [modify] https://crrev.com/f2dff379a2e4e1307630894317b1fc3d08c1e605/chrome/installer/util/installation_state.cc [delete] https://crrev.com/36be926f766fe3f0cb231123e4b9e6b087aa27e0/chrome/installer/util/product.cc [modify] https://crrev.com/f2dff379a2e4e1307630894317b1fc3d08c1e605/chrome/installer/util/product.h [modify] https://crrev.com/f2dff379a2e4e1307630894317b1fc3d08c1e605/chrome/installer/util/product_state_unittest.cc [delete] https://crrev.com/36be926f766fe3f0cb231123e4b9e6b087aa27e0/chrome/installer/util/test_app_registration_data.cc [delete] https://crrev.com/36be926f766fe3f0cb231123e4b9e6b087aa27e0/chrome/installer/util/test_app_registration_data.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e6d27382134b3e97288db99e11aa46f11d1e5765 commit e6d27382134b3e97288db99e11aa46f11d1e5765 Author: Greg Thompson <grt@chromium.org> Date: Wed Sep 19 11:19:27 2018 Remove BrowserDistribution. This CL migrates the final callers of BrowserDistribution::GetStateKey to install_static::GetClientStateKeyPath. As a result, BrowserDistribution and AppRegistrationData no longer have any consumers. This allows for removal of them and related classes (including Product). Additionally, this CL contains a few small cleanups such as removing the dead IsChromeActivelyUsed function and gently massaging some function parameters. BUG= 879568 Change-Id: Id4957b9e269706678c84ea2fac8c24c490a99b0f Reviewed-on: https://chromium-review.googlesource.com/1230016 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#592364} [modify] https://crrev.com/e6d27382134b3e97288db99e11aa46f11d1e5765/chrome/installer/gcapi/DEPS [modify] https://crrev.com/e6d27382134b3e97288db99e11aa46f11d1e5765/chrome/installer/setup/install.cc [modify] https://crrev.com/e6d27382134b3e97288db99e11aa46f11d1e5765/chrome/installer/setup/install.h [modify] https://crrev.com/e6d27382134b3e97288db99e11aa46f11d1e5765/chrome/installer/setup/install_unittest.cc [modify] https://crrev.com/e6d27382134b3e97288db99e11aa46f11d1e5765/chrome/installer/setup/install_worker.cc [modify] https://crrev.com/e6d27382134b3e97288db99e11aa46f11d1e5765/chrome/installer/setup/install_worker.h [modify] https://crrev.com/e6d27382134b3e97288db99e11aa46f11d1e5765/chrome/installer/setup/install_worker_unittest.cc [modify] https://crrev.com/e6d27382134b3e97288db99e11aa46f11d1e5765/chrome/installer/setup/installer_state.cc [modify] https://crrev.com/e6d27382134b3e97288db99e11aa46f11d1e5765/chrome/installer/setup/installer_state.h [modify] https://crrev.com/e6d27382134b3e97288db99e11aa46f11d1e5765/chrome/installer/setup/installer_state_unittest.cc [modify] https://crrev.com/e6d27382134b3e97288db99e11aa46f11d1e5765/chrome/installer/setup/setup_main.cc [modify] https://crrev.com/e6d27382134b3e97288db99e11aa46f11d1e5765/chrome/installer/setup/setup_util.cc [modify] https://crrev.com/e6d27382134b3e97288db99e11aa46f11d1e5765/chrome/installer/setup/setup_util.h [modify] https://crrev.com/e6d27382134b3e97288db99e11aa46f11d1e5765/chrome/installer/setup/setup_util_unittest.cc [modify] https://crrev.com/e6d27382134b3e97288db99e11aa46f11d1e5765/chrome/installer/setup/uninstall.cc [modify] https://crrev.com/e6d27382134b3e97288db99e11aa46f11d1e5765/chrome/installer/setup/uninstall.h [modify] https://crrev.com/e6d27382134b3e97288db99e11aa46f11d1e5765/chrome/installer/util/BUILD.gn [delete] https://crrev.com/398ba6bd4e98ca437d05274df6bd6ac5deb87276/chrome/installer/util/app_registration_data.h [delete] https://crrev.com/398ba6bd4e98ca437d05274df6bd6ac5deb87276/chrome/installer/util/browser_distribution.cc [delete] https://crrev.com/398ba6bd4e98ca437d05274df6bd6ac5deb87276/chrome/installer/util/browser_distribution.h [delete] https://crrev.com/398ba6bd4e98ca437d05274df6bd6ac5deb87276/chrome/installer/util/google_chrome_distribution.cc [delete] https://crrev.com/398ba6bd4e98ca437d05274df6bd6ac5deb87276/chrome/installer/util/google_chrome_distribution.h [delete] https://crrev.com/398ba6bd4e98ca437d05274df6bd6ac5deb87276/chrome/installer/util/non_updating_app_registration_data.cc [delete] https://crrev.com/398ba6bd4e98ca437d05274df6bd6ac5deb87276/chrome/installer/util/non_updating_app_registration_data.h [delete] https://crrev.com/398ba6bd4e98ca437d05274df6bd6ac5deb87276/chrome/installer/util/product.h [modify] https://crrev.com/e6d27382134b3e97288db99e11aa46f11d1e5765/chrome/installer/util/product_unittest.cc [delete] https://crrev.com/398ba6bd4e98ca437d05274df6bd6ac5deb87276/chrome/installer/util/updating_app_registration_data.cc [delete] https://crrev.com/398ba6bd4e98ca437d05274df6bd6ac5deb87276/chrome/installer/util/updating_app_registration_data.h
FYI, y'all. :-)
\o/!!!
Comment 1 by bugdroid1@chromium.org
, Aug 31