USS Wallet crashes the Sync internals node browser |
|||||||||
Issue descriptionWhen enabling the USS wallet experiment, and then going to about:sync-internals and clicking the "node browser" tab, crashes Chrome. This is a blocker for go/project-butter, and will need to be merged into M70.
,
Sep 6
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b18743347f2fa3a84e29c119c6a8cd1e071de8aa commit b18743347f2fa3a84e29c119c6a8cd1e071de8aa Author: sebsg <sebsg@chromium.org> Date: Thu Sep 06 20:34:33 2018 [Sync] Fix an encoding issue that caused sync-internals to crash. Some of the ids comming from payments needed to be converted before they could be displayed. This should only affect the sync internals page, no feature code. Bug: 879556 Change-Id: I423580564574ea5f883044d4a4e08bf0e8c9b1e7 Reviewed-on: https://chromium-review.googlesource.com/1205192 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#589279} [modify] https://crrev.com/b18743347f2fa3a84e29c119c6a8cd1e071de8aa/components/autofill/core/browser/webdata/autofill_sync_bridge_util.cc [modify] https://crrev.com/b18743347f2fa3a84e29c119c6a8cd1e071de8aa/components/autofill/core/browser/webdata/autofill_sync_bridge_util.h [modify] https://crrev.com/b18743347f2fa3a84e29c119c6a8cd1e071de8aa/components/autofill/core/browser/webdata/autofill_wallet_sync_bridge.cc [modify] https://crrev.com/b18743347f2fa3a84e29c119c6a8cd1e071de8aa/components/autofill/core/browser/webdata/autofill_wallet_sync_bridge.h [modify] https://crrev.com/b18743347f2fa3a84e29c119c6a8cd1e071de8aa/components/autofill/core/browser/webdata/autofill_wallet_sync_bridge_unittest.cc
,
Sep 6
,
Sep 7
,
Sep 7
,
Sep 7
Keeping it open until it is merged to M70 :)
,
Sep 7
Your change meets the bar and is auto-approved for M70. Please go ahead and merge the CL to branch 3538 manually. Please contact milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/222cc5c57e4d79a3a29c125dd7905f7bae4c349a commit 222cc5c57e4d79a3a29c125dd7905f7bae4c349a Author: sebsg <sebsg@chromium.org> Date: Mon Sep 10 14:20:18 2018 Merge70 [Sync] Fix encoding issue that caused sync-internals to crash. Some of the ids comming from payments needed to be converted before they could be displayed. This should only affect the sync internals page, no feature code. Bug: 879556 Change-Id: I423580564574ea5f883044d4a4e08bf0e8c9b1e7 Reviewed-on: https://chromium-review.googlesource.com/1205192 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: Jan Krcal <jkrcal@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#589279}(cherry picked from commit b18743347f2fa3a84e29c119c6a8cd1e071de8aa) Reviewed-on: https://chromium-review.googlesource.com/1216030 Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#207} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/222cc5c57e4d79a3a29c125dd7905f7bae4c349a/components/autofill/core/browser/webdata/autofill_sync_bridge_util.cc [modify] https://crrev.com/222cc5c57e4d79a3a29c125dd7905f7bae4c349a/components/autofill/core/browser/webdata/autofill_sync_bridge_util.h [modify] https://crrev.com/222cc5c57e4d79a3a29c125dd7905f7bae4c349a/components/autofill/core/browser/webdata/autofill_wallet_sync_bridge.cc [modify] https://crrev.com/222cc5c57e4d79a3a29c125dd7905f7bae4c349a/components/autofill/core/browser/webdata/autofill_wallet_sync_bridge.h [modify] https://crrev.com/222cc5c57e4d79a3a29c125dd7905f7bae4c349a/components/autofill/core/browser/webdata/autofill_wallet_sync_bridge_unittest.cc
,
Sep 10
,
Sep 12
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by se...@chromium.org
, Sep 5