New issue
Advanced search Search tips

Issue 879551 link

Starred by 1 user
Status: Fixed
Owner:
ioanap@chromium.org
Closed: Sep 4
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Task



Sign in to add a comment

[Android] Remove entry point for password generation popup

Project Member Reported by ioanap@chromium.org, Aug 31 
The existing entry point leads to an old implementation. As password generation should only be offered via the password accessory, the code leading to the password generation popup needs to be removed.

The password generation popup code itself is kept for now, as it is used 
for the editing popup, even when a password is generated via the accessory.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a9eaa0595998a868b5e5fa0e4abf5479dbcb35a8

commit a9eaa0595998a868b5e5fa0e4abf5479dbcb35a8
Author: Ioana Pandele <ioanap@chromium.org>
Date: Mon Sep 03 08:52:06 2018

[Android] Remove entry point for password generation popup

Password generation should only be offered via the keyboard accessory,
so the code path leading to the generation poup needs to be removed.

Bug:  879551 
Change-Id: Iedea26b6e25d250d7d0d72168aa9ee7402e5aeea
Reviewed-on: https://chromium-review.googlesource.com/1199382
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588352}
[modify] https://crrev.com/a9eaa0595998a868b5e5fa0e4abf5479dbcb35a8/chrome/browser/password_manager/chrome_password_manager_client.cc

Comment 2 by ioanap@chromium.org, Sep 4

Labels: Merge-Request-70
Status: Fixed (was: Started)
This change makes sure that password generation can only be offered via the keyboard accessory on Android and not via the password generation popup.
Project Member

Comment 3 by sheriffbot@chromium.org, Sep 5

Labels: -Merge-Request-70 Hotlist-Merge-Approved Merge-Approved-70
Your change meets the bar and is auto-approved for M70. Please go ahead and merge the CL to branch 3538 manually. Please contact milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 5

Labels: -merge-approved-70 merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/267dc47f8199eb180e001895a7253e7e611825ac

commit 267dc47f8199eb180e001895a7253e7e611825ac
Author: Ioana Pandele <ioanap@chromium.org>
Date: Wed Sep 05 11:00:05 2018

[M70][Android] Remove entry point for password generation popup

Password generation should only be offered via the keyboard accessory,
so the code path leading to the generation poup needs to be removed.

Bug:  879551 
Change-Id: Iedea26b6e25d250d7d0d72168aa9ee7402e5aeea
Reviewed-on: https://chromium-review.googlesource.com/1199382
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#588352}(cherry picked from commit a9eaa0595998a868b5e5fa0e4abf5479dbcb35a8)
Reviewed-on: https://chromium-review.googlesource.com/1206592
Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#44}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/267dc47f8199eb180e001895a7253e7e611825ac/chrome/browser/password_manager/chrome_password_manager_client.cc
►

Sign in to add a comment