Issue metadata
Sign in to add a comment
|
Flaky V8 scanner dcheck failure in layout tests |
||||||||||||||||||||||
Issue descriptionCurrently visible on V8's layout debug bot, e.g.: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8-Blink%20Linux%2064%20%28dbg%29/13428 See in stdout of layout tests: 13:59:41.871 2624 worker/0 http/tests/devtools/search/sources-search-scope-many-projects.js output stderr lines: 13:59:41.871 2624 13:59:41.871 2624 13:59:41.871 2624 # 13:59:41.871 2624 # Fatal error in ../../v8/src/parsing/scanner.cc, line 452 13:59:41.871 2624 # Debug check failed: pos >= current_pos. 13:59:41.871 2624 # 13:59:41.871 2624 # 13:59:41.871 2624 # 13:59:41.871 2624 #FailureMessage Object: 0x7fff98740570#0 0x000003442a0c base::debug::StackTrace::StackTrace() 13:59:41.871 2624 #1 0x000004a2ddfb gin::(anonymous namespace)::PrintStackTrace() 13:59:41.871 2624 #2 0x000004a24768 V8_Fatal() 13:59:41.871 2624 #3 0x000004a244c5 v8::base::(anonymous namespace)::DefaultDcheckHandler() 13:59:41.871 2624 #4 0x0000024c8642 v8::internal::Scanner::SeekForward() 13:59:41.871 2624 #5 0x00000212d834 v8::internal::Debug::ProcessCompileEvent() 13:59:41.871 2624 #6 0x0000024d2bd7 v8::internal::PendingCompilationErrorHandler::ThrowPendingError() 13:59:41.871 2624 #7 0x0000024a4f7e v8::internal::parsing::ParseProgram() 13:59:41.871 2624 #8 0x000001ec8fa7 v8::internal::(anonymous namespace)::CompileToplevel() 13:59:41.871 2624 #9 0x000001ecaf1a v8::internal::Compiler::GetSharedFunctionInfoForScript() 13:59:41.871 2624 #10 0x00000211182b v8::internal::DebugEvaluate::Global()
,
Aug 31
There is fix: https://chromium-review.googlesource.com/c/v8/v8/+/1196686 I tbred Toon, since he is OOO until September 17th.
,
Aug 31
,
Aug 31
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/3fd1f8a7b4b9a1381f46f724973f14f11126765f commit 3fd1f8a7b4b9a1381f46f724973f14f11126765f Author: Alexey Kozyatinskiy <kozyatinskiy@chromium.org> Date: Fri Aug 31 14:24:39 2018 inspector: do not use SeekForward to move backward We can use Seek + Advance instead on source stream. TBR=verwaest@chromium.org Bug: chromium:879550 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ic6ad12a86105ce68ea404e313b74d11417928cf0 Reviewed-on: https://chromium-review.googlesource.com/1196686 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by: Maya Lekova <mslekova@chromium.org> Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#55552} [modify] https://crrev.com/3fd1f8a7b4b9a1381f46f724973f14f11126765f/src/debug/debug.cc [modify] https://crrev.com/3fd1f8a7b4b9a1381f46f724973f14f11126765f/test/inspector/debugger/script-on-after-compile-expected.txt [modify] https://crrev.com/3fd1f8a7b4b9a1381f46f724973f14f11126765f/test/inspector/debugger/script-on-after-compile.js
,
Sep 21
Scanner related part of my CL was reverted, so I mark it was Fixed. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by sigurds@chromium.org
, Aug 31