New issue
Advanced search Search tips

Issue 879548 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

Browser data deletion dialog sub label missing reference to Touch ID credentials

Project Member Reported by martinkr@google.com, Aug 31

Issue description

The "Passwords and other sign-in data" item in the browser data deletion dialog erases Touch ID WebAuthn credentials; however the sub label indicating the number of items only references passwords. This needs to be updated with a separate (or combined?) count for Touch ID credentials.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/62e723e2f1a1a361404770cc922a1c3cf6dde25e

commit 62e723e2f1a1a361404770cc922a1c3cf6dde25e
Author: Martin Kreichgauer <martinkr@google.com>
Date: Tue Sep 25 00:54:52 2018

fido/mac: Add |CountWebAuthnCredentials| method.

CountWebAuthnCredentials counts the number of Touch ID WebAuthn
credentials stored in the keychain for a given profile with a creation
date in a given interval. This will be used to implement a counter label
for these credentials in the browsing data deletion dialog.

Bug:  879548 
Change-Id: Iacac0ee3c13f69a0b7f9ea1c1f2e1b10f0ce949e
Reviewed-on: https://chromium-review.googlesource.com/1239537
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593785}
[modify] https://crrev.com/62e723e2f1a1a361404770cc922a1c3cf6dde25e/device/fido/mac/browsing_data_deletion.h
[modify] https://crrev.com/62e723e2f1a1a361404770cc922a1c3cf6dde25e/device/fido/mac/browsing_data_deletion.mm
[modify] https://crrev.com/62e723e2f1a1a361404770cc922a1c3cf6dde25e/device/fido/mac/browsing_data_deletion_unittest.mm

Project Member

Comment 2 by bugdroid1@chromium.org, Sep 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cee4630e2774ec4dd4a7a529c35cbe53b1d6aaa8

commit cee4630e2774ec4dd4a7a529c35cbe53b1d6aaa8
Author: Martin Kreichgauer <martinkr@google.com>
Date: Thu Sep 27 19:49:21 2018

add browsing data strings for WebAuthn credential counter labels

Splitting this off from the implementation so we can submit strings
earlier.

Bug:  879548 
Change-Id: I180391d203f1fcd98a04f42a89373eb42b33341f
Reviewed-on: https://chromium-review.googlesource.com/1246821
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594822}
[modify] https://crrev.com/cee4630e2774ec4dd4a7a529c35cbe53b1d6aaa8/components/browsing_data_strings.grdp

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0c05f13e3dabcb67ceac6b8cc45f80024fca50dd

commit 0c05f13e3dabcb67ceac6b8cc45f80024fca50dd
Author: Martin Kreichgauer <martinkr@google.com>
Date: Tue Oct 02 20:13:40 2018

Update counter for "passwords and other sign-in data" in browsing data deletion

This changes the counter sublabel for the "passwords and other sign-in
data" item in the browsing data deletion dialog to include the number of
WebAuthn credentials stored by authenticators built into Chrome
(currently this is only the Touch ID authenticator on macOS).

The format is:
- "None" if neither passwords nor WebAuthn credentials are present
- the counter label for passwords or WebAuthn credentials if only one of
them is present. E.g., "1 password" or "sign-in data for 3 accounts".
- both counter labels separated by "; " if both are present. E.g., "2
passwords (synced); sign-in data for 1 account".

Note that while passwords can be synced, WebAuthn credentials cannot.

Bug:  879548 
Change-Id: I4ea5035841192fce6e185fa4fa4b077986bed041
Reviewed-on: https://chromium-review.googlesource.com/1246822
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#595960}
[modify] https://crrev.com/0c05f13e3dabcb67ceac6b8cc45f80024fca50dd/chrome/browser/BUILD.gn
[modify] https://crrev.com/0c05f13e3dabcb67ceac6b8cc45f80024fca50dd/chrome/browser/browsing_data/counters/browsing_data_counter_factory.cc
[modify] https://crrev.com/0c05f13e3dabcb67ceac6b8cc45f80024fca50dd/chrome/browser/browsing_data/counters/browsing_data_counter_utils.cc
[modify] https://crrev.com/0c05f13e3dabcb67ceac6b8cc45f80024fca50dd/chrome/browser/browsing_data/counters/browsing_data_counter_utils_unittest.cc
[add] https://crrev.com/0c05f13e3dabcb67ceac6b8cc45f80024fca50dd/chrome/browser/browsing_data/counters/signin_data_counter.cc
[add] https://crrev.com/0c05f13e3dabcb67ceac6b8cc45f80024fca50dd/chrome/browser/browsing_data/counters/signin_data_counter.h
[modify] https://crrev.com/0c05f13e3dabcb67ceac6b8cc45f80024fca50dd/components/browsing_data/core/counters/passwords_counter.cc
[modify] https://crrev.com/0c05f13e3dabcb67ceac6b8cc45f80024fca50dd/components/browsing_data/core/counters/passwords_counter.h

Status: Fixed (was: Assigned)

Sign in to add a comment