Browser data deletion dialog sub label missing reference to Touch ID credentials |
||
Issue descriptionThe "Passwords and other sign-in data" item in the browser data deletion dialog erases Touch ID WebAuthn credentials; however the sub label indicating the number of items only references passwords. This needs to be updated with a separate (or combined?) count for Touch ID credentials.
,
Sep 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cee4630e2774ec4dd4a7a529c35cbe53b1d6aaa8 commit cee4630e2774ec4dd4a7a529c35cbe53b1d6aaa8 Author: Martin Kreichgauer <martinkr@google.com> Date: Thu Sep 27 19:49:21 2018 add browsing data strings for WebAuthn credential counter labels Splitting this off from the implementation so we can submit strings earlier. Bug: 879548 Change-Id: I180391d203f1fcd98a04f42a89373eb42b33341f Reviewed-on: https://chromium-review.googlesource.com/1246821 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#594822} [modify] https://crrev.com/cee4630e2774ec4dd4a7a529c35cbe53b1d6aaa8/components/browsing_data_strings.grdp
,
Oct 2
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0c05f13e3dabcb67ceac6b8cc45f80024fca50dd commit 0c05f13e3dabcb67ceac6b8cc45f80024fca50dd Author: Martin Kreichgauer <martinkr@google.com> Date: Tue Oct 02 20:13:40 2018 Update counter for "passwords and other sign-in data" in browsing data deletion This changes the counter sublabel for the "passwords and other sign-in data" item in the browsing data deletion dialog to include the number of WebAuthn credentials stored by authenticators built into Chrome (currently this is only the Touch ID authenticator on macOS). The format is: - "None" if neither passwords nor WebAuthn credentials are present - the counter label for passwords or WebAuthn credentials if only one of them is present. E.g., "1 password" or "sign-in data for 3 accounts". - both counter labels separated by "; " if both are present. E.g., "2 passwords (synced); sign-in data for 1 account". Note that while passwords can be synced, WebAuthn credentials cannot. Bug: 879548 Change-Id: I4ea5035841192fce6e185fa4fa4b077986bed041 Reviewed-on: https://chromium-review.googlesource.com/1246822 Reviewed-by: Christian Dullweber <dullweber@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#595960} [modify] https://crrev.com/0c05f13e3dabcb67ceac6b8cc45f80024fca50dd/chrome/browser/BUILD.gn [modify] https://crrev.com/0c05f13e3dabcb67ceac6b8cc45f80024fca50dd/chrome/browser/browsing_data/counters/browsing_data_counter_factory.cc [modify] https://crrev.com/0c05f13e3dabcb67ceac6b8cc45f80024fca50dd/chrome/browser/browsing_data/counters/browsing_data_counter_utils.cc [modify] https://crrev.com/0c05f13e3dabcb67ceac6b8cc45f80024fca50dd/chrome/browser/browsing_data/counters/browsing_data_counter_utils_unittest.cc [add] https://crrev.com/0c05f13e3dabcb67ceac6b8cc45f80024fca50dd/chrome/browser/browsing_data/counters/signin_data_counter.cc [add] https://crrev.com/0c05f13e3dabcb67ceac6b8cc45f80024fca50dd/chrome/browser/browsing_data/counters/signin_data_counter.h [modify] https://crrev.com/0c05f13e3dabcb67ceac6b8cc45f80024fca50dd/components/browsing_data/core/counters/passwords_counter.cc [modify] https://crrev.com/0c05f13e3dabcb67ceac6b8cc45f80024fca50dd/components/browsing_data/core/counters/passwords_counter.h
,
Oct 2
|
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Sep 25