New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 879543 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Sep 17
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Security

Blocking:
issue 880786



Sign in to add a comment

CrOS: Vulnerability reported in sys-apps/busybox

Project Member Reported by vomit.go...@appspot.gserviceaccount.com, Aug 31

Issue description

Automated analysis has detected that the following third party packages have had vulnerabilities publicly reported. 

NOTE: There may be several bugs listed below - in almost all cases, all bugs can be quickly addressed by upgrading to the latest version of the package.

Package Name: sys-apps/busybox
Package Version: [cpe:/a:busybox:busybox:1.27.2]

Advisory: CVE-2018-1000517
  Details: https://vomit.googleplex.com/advisory?id=CVE/CVE-2018-1000517
  CVSS severity score: 7.5/10.0
  Confidence: high
  Description:

BusyBox project BusyBox wget version prior to commit 8e2174e9bd836e53c8b9c6e00d1bc6e2a718686e contains a Buffer Overflow vulnerability in Busybox wget that can result in heap buffer overflow. This attack appear to be exploitable via network connectivity. This vulnerability appears to have been fixed in after commit 8e2174e9bd836e53c8b9c6e00d1bc6e2a718686e.


 
Owner: zsm@chromium.org
Status: Assigned (was: Untriaged)
Assigning per similar reports.
Labels: Security_Severity-High
Punting to mnissler@, jorgelo@

mnissler@, jorgelo@: Should userspace security bugs be added to a hotlist / assigned to security sherriff in the future? What's the usual process?
Cc: groeck@chromium.org jorgelo@chromium.org
Owner: mnissler@chromium.org
Components: OS>Packages
Labels: -ComponentOSKernel
Owner: ----
Status: Untriaged (was: Assigned)
We do have a Chrome OS security rotation so while Tom very generously triaged this for us, he didn't have to. In the future, feel free to remove yourself from the owner field. The sheriff will get to the bug.

I don't even think we use busybox wget.
Cc: mortonm@chromium.org
Cc: yunlian@chromium.org jclinton@chromium.org
yunlian@/jclinton@: is busybox just something we use in our lab/test infra or is it used somehow on consumer devices?
Not used in lab/test infra per say and not really my area but: I do happen to know that Busybox is used extensively in the recovery flow and the factory flows. So, yes, it's used on consumer devices, all the time.
Indeed:

$ equery-kevin d busybox
 * These packages depend on busybox:
chromeos-base/factory-deps-1-r7 (sys-apps/busybox) <====
virtual/editor-0 (sys-apps/busybox)
virtual/logger-0 (sys-apps/busybox[syslog])

while it is used on recovery, we don't do any networking things there by design.  it isn't installed on the rootfs at all, although we do provide it on dev images.  that leaves factory, and those are a bit limited in what they actually fetch.

so yes, we should upgrade to fix, but i don't think it's a big deal.  plus we push everyone to only use `curl` in verified code.
Labels: -Security_Severity-High Security_Severity-Medium Security_Impact-Stable
Owner: yunlian@chromium.org
Status: Assigned (was: Untriaged)
Downgrading the severity since it doesn't affect most users directly. Assigning to yunlian@
Project Member

Comment 12 by sheriffbot@chromium.org, Sep 5

Labels: M-69 Target-69
Blocking: 880786
Project Member

Comment 14 by sheriffbot@chromium.org, Sep 14

yunlian: Uh oh! This issue still open and hasn't been updated in the last 14 days. This is a serious vulnerability, and we want to ensure that there's progress. Could you please leave an update with the current status and any potential blockers?

If you're not the right owner for this issue, could you please remove yourself as soon as possible or help us find the right one?

If the issue is fixed or you can't reproduce it, please close the bug. If you've started working on a fix, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 15 by bugdroid1@chromium.org, Sep 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/portage-stable/+/112a816d832d82a1ebaa9b31babe92e31741b031

commit 112a816d832d82a1ebaa9b31babe92e31741b031
Author: Yunlian Jiang <yunlian@google.com>
Date: Sun Sep 16 11:04:33 2018

busybox: upgrade to upstream 1.29.3

This pulls Gentoo upstream busybox 1.29.3 to get some security
fixes.

BUG= chromium:879543 
TEST=create a recover image for samus and it works.

Change-Id: I674e7b99f4bb4330deb0e39b9f3155ef8e76acf3
Reviewed-on: https://chromium-review.googlesource.com/1226085
Commit-Ready: Yunlian Jiang <yunlian@chromium.org>
Tested-by: Yunlian Jiang <yunlian@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[delete] https://crrev.com/26d294a1be387513099e75d1fd55d60feddeaa97/sys-apps/busybox/files/busybox-1.27.2-clang.patch
[rename] https://crrev.com/112a816d832d82a1ebaa9b31babe92e31741b031/sys-apps/busybox/busybox-1.29.3.ebuild
[modify] https://crrev.com/112a816d832d82a1ebaa9b31babe92e31741b031/sys-apps/busybox/Manifest

Status: Verified (was: Assigned)
The patch is included in busybox 1.29.3
Project Member

Comment 17 by sheriffbot@chromium.org, Sep 17

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Project Member

Comment 18 by sheriffbot@chromium.org, Dec 24

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment