Issue metadata
Sign in to add a comment
|
Regression: Unnecessary tooltip is seen near ubertray while dragging apps into the extended shelf. |
||||||||||||||||||||||
Issue descriptionChrome Version: 70.0.3532.8/1105.1.0 dev-channel Candy,Peppy and Paine OS: Chrome OS What steps will reproduce the problem? (1) Sign-in to user>> Drag an app from shelf and drop inside the extended shelf and observe unnecessary tooltip near ubertray (Refer video) Actual: Unnecessary tooltip is seen near ubertray while dragging apps into the extended shelf. Expected: No such issue should be seen This is a Regression issue as same is working fine in M68 NOTE: Issue is also seen in M69
,
Aug 31
Thank you Kejia! It seems to me like any tooltip like this (even correctly place) is annoying and unnecessary during a drag operation. So I would be tempted to just not show any tooltips during a drag. What do you think?
,
Aug 31
Yep makes sense to me! Thanks Manu!
,
Aug 31
Just checked offline with Kejia that it does make sense to disable tooltips during a drag.
,
Sep 1
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cdb7b4b3090f3aa141100b2b03db1e53732f47d6 commit cdb7b4b3090f3aa141100b2b03db1e53732f47d6 Author: Manu Cornet <manucornet@chromium.org> Date: Sat Sep 01 21:11:19 2018 CrOS Shelf: Don't show tooltips during a drag (After chatting with kejiashao@ offline, we agreed that showing tooltips during a drag operation is distracting and not useful.) Bug: 879535 Change-Id: I2c092380560372ec568d25e55d984828b93d6839 Reviewed-on: https://chromium-review.googlesource.com/1199496 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Alex Newcomer <newcomer@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#588294} [modify] https://crrev.com/cdb7b4b3090f3aa141100b2b03db1e53732f47d6/ash/shelf/shelf_view.cc
,
Sep 1
,
Sep 4
,
Sep 5
Your change meets the bar and is auto-approved for M70. Please go ahead and merge the CL to branch 3538 manually. Please contact milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/33ca3e6b6261ef38f62553112db30f280bca8daf commit 33ca3e6b6261ef38f62553112db30f280bca8daf Author: Alex Newcomer <newcomer@chromium.org> Date: Fri Sep 07 21:06:53 2018 CrOS Shelf: Don't show tooltips during a drag (After chatting with kejiashao@ offline, we agreed that showing tooltips during a drag operation is distracting and not useful.) TBR=manucornet@chromium.org (cherry picked from commit cdb7b4b3090f3aa141100b2b03db1e53732f47d6) Bug: 879535 Change-Id: I2c092380560372ec568d25e55d984828b93d6839 Reviewed-on: https://chromium-review.googlesource.com/1199496 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Alex Newcomer <newcomer@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#588294} Reviewed-on: https://chromium-review.googlesource.com/1214070 Cr-Commit-Position: refs/branch-heads/3538@{#164} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/33ca3e6b6261ef38f62553112db30f280bca8daf/ash/shelf/shelf_view.cc |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by newcomer@chromium.org
, Aug 31Owner: manucornet@chromium.org