Regression:Blue focus ring around the play/pause button stays even when the button is not seen in PIP window
Reported by
vineetha...@etouch.net,
Aug 31
|
||||||||||
Issue descriptionChrome Version : 70.0.3538.0 (Official Build) Revision a20f097fb0047bcf58b3ec9a44be7fab7ba4cbc4-refs/branch-heads/3538@{#1} (32/64 bit) OS : Windows (7, 8, 8.1, 10), Linux(14.04 LTS), Mac(10.12.6, 10.13.1, 10.13.6, 10.14) Test URL : https://googlechrome.github.io/samples/picture-in-picture/ What steps will reproduce the problem? 1. Launch chrome, navigate to above test URL and play the video present on the page in 'Picture-in-Picture' mode. 2. Now tab to take focus over play/pause button on the PiP window. 2. Wait until video gets finished and observe the blue focus ring in PiP window. Actual Result : Blue focus ring around the play/pause button stays even when the button is not seen after the video is finished. Expected Result : Play/pause button as well as its blue focus ring should not be seen after the video is finished. This is a regression issue broken in ‘M-70’ and below is the per-revision bisect information: Good Build : 70.0.3523.0 (Revision : 583084) Bad Build : 70.0.3524.0 (Revision : 583420) You are probably looking for a change made after 583269 (known good), but no later than 583270 (first known bad). CHANGE-LOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/7667868daafdd56a86507d2f3d433f30db5083a3..9d6f39a010b60dfa489615b80379f502421ea231 Suspecting: https://chromium.googlesource.com/chromium/src/+/9d6f39a010b60dfa489615b80379f502421ea231 sawtelle@ : Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Thank you
,
Sep 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/25a467533b00c6a6e686f6a22ad3c994d5cdfb7c commit 25a467533b00c6a6e686f6a22ad3c994d5cdfb7c Author: François Beaufort <beaufort.francois@gmail.com> Date: Mon Sep 24 12:59:43 2018 [Picture-in-Picture] Hide controls layer when no video. This CL makes sure we never show play/pause and scrim controls when there is no video in Picture-in-Picture window. Bug: 879529 Change-Id: I8d9ee5dcde24e9dc1b3e89af091c3385d338b046 Reviewed-on: https://chromium-review.googlesource.com/1235580 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by: apacible <apacible@chromium.org> Cr-Commit-Position: refs/heads/master@{#593513} [modify] https://crrev.com/25a467533b00c6a6e686f6a22ad3c994d5cdfb7c/chrome/browser/ui/views/overlay/overlay_window_views.cc [modify] https://crrev.com/25a467533b00c6a6e686f6a22ad3c994d5cdfb7c/chrome/browser/ui/views/overlay/overlay_window_views.h
,
Sep 24
,
Sep 25
Update : Rechecked the above issue on Win(7,8,8.1,10) ,Mac(10.12.6 , 10.13.1 , 10.13.6, 10.14) and Linux(14.04 LTS)OS with Canary version #71.0.3561.0 and the issue is fixed. Kindly refer the attached screen cast.
,
Sep 25
,
Oct 3
,
Oct 3
This bug requires manual review: We are only 12 days from stable. Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 3
,
Oct 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b4bd8438d4f8815e6949b7cfe78ea5e89262e5dd commit b4bd8438d4f8815e6949b7cfe78ea5e89262e5dd Author: François Beaufort <beaufort.francois@gmail.com> Date: Thu Oct 04 07:38:24 2018 [Picture-in-Picture] Hide controls layer when no video. This CL makes sure we never show play/pause and scrim controls when there is no video in Picture-in-Picture window. Bug: 879529 Change-Id: I8d9ee5dcde24e9dc1b3e89af091c3385d338b046 Reviewed-on: https://chromium-review.googlesource.com/1235580 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by: apacible <apacible@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#593513}(cherry picked from commit 25a467533b00c6a6e686f6a22ad3c994d5cdfb7c) Reviewed-on: https://chromium-review.googlesource.com/c/1260130 Reviewed-by: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/branch-heads/3538@{#849} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/b4bd8438d4f8815e6949b7cfe78ea5e89262e5dd/chrome/browser/ui/views/overlay/overlay_window_views.cc [modify] https://crrev.com/b4bd8438d4f8815e6949b7cfe78ea5e89262e5dd/chrome/browser/ui/views/overlay/overlay_window_views.h
,
Oct 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b4bd8438d4f8815e6949b7cfe78ea5e89262e5dd Commit: b4bd8438d4f8815e6949b7cfe78ea5e89262e5dd Author: beaufort.francois@gmail.com Commiter: beaufort.francois@gmail.com Date: 2018-10-04 07:38:24 +0000 UTC [Picture-in-Picture] Hide controls layer when no video. This CL makes sure we never show play/pause and scrim controls when there is no video in Picture-in-Picture window. Bug: 879529 Change-Id: I8d9ee5dcde24e9dc1b3e89af091c3385d338b046 Reviewed-on: https://chromium-review.googlesource.com/1235580 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by: apacible <apacible@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#593513}(cherry picked from commit 25a467533b00c6a6e686f6a22ad3c994d5cdfb7c) Reviewed-on: https://chromium-review.googlesource.com/c/1260130 Reviewed-by: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/branch-heads/3538@{#849} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
,
Oct 10
Update : Rechecked the above issue on Win(7,8,8.1,10) ,Mac(10.12.6 , 10.13.1 , 10.13.6, 10.14.1) and Linux(14.04 LTS)OS with Beta version #70.0.3538.54 and the issue is fixed. Kindly refer the attached screen cast. |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by fbeaufort@chromium.org
, Sep 20Status: Started (was: Assigned)