New issue
Advanced search Search tips

Issue 879513 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: ----



Sign in to add a comment

ChromeContentRendererClientMetricsTests failing on multiple builders

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Aug 31

Issue description

Example Log Output:

[ RUN      ] ChromeContentRendererClientMetricsTest.RewriteEmbedJSAPI
[8196:2716:0831/002347.988:35796921:FATAL:scoped_refptr.h(219)] Check failed: ptr_.
Backtrace:
	base::debug::StackTrace::StackTrace [0x00007FF8868F1915+101]
	base::debug::StackTrace::StackTrace [0x00007FF8868F094F+31]
	logging::LogMessage::~LogMessage [0x00007FF8869591C6+134]
	scoped_refptr<base::internal::BindStateBase>::operator-> [0x00007FF886885526+166]
	base::internal::CallbackBase::polymorphic_invoke [0x00007FF886885473+19]
	base::RepeatingCallback<void __cdecl(base::TimeTicks,metrics::SampledProfile)>::Run [0x00007FF6F6235675+53]
	metrics::CallStackProfileBuilder::PassProfilesToMetricsProvider [0x00007FF6F62355BB+139]
	metrics::CallStackProfileBuilder::OnProfileCompleted [0x00007FF6F6234BA8+712]
	base::StackSamplingProfiler::SamplingThread::FinishCollection [0x00007FF886A6653F+639]
	base::StackSamplingProfiler::SamplingThread::RemoveCollectionTask [0x00007FF886A660A4+692]
	base::internal::FunctorTraits<void (__cdecl base::StackSamplingProfiler::SamplingThread::*)(int) __ptr64,void>::Invoke<void (__cdecl base::StackSamplingProfiler::SamplingThread::*)(int) __ptr64,base::StackSamplingProfiler::SamplingThread * __ptr64,int> [0x00007FF886A6C7C5+69]
	base::internal::InvokeHelper<0,void>::MakeItSo<void (__cdecl base::StackSamplingProfiler::SamplingThread::*)(int) __ptr64,base::StackSamplingProfiler::SamplingThread * __ptr64,int> [0x00007FF886A6C71D+77]
	base::internal::Invoker<base::internal::BindState<void (__cdecl base::StackSamplingProfiler::SamplingThread::*)(int) __ptr64,base::internal::UnretainedWrapper<base::StackSamplingProfiler::SamplingThread>,int>,void __cdecl(void)>::RunImpl<void (__cdecl bas [0x00007FF886A6C68C+124]
	base::internal::Invoker<base::internal::BindState<void (__cdecl base::StackSamplingProfiler::SamplingThread::*)(int) __ptr64,base::internal::UnretainedWrapper<base::StackSamplingProfiler::SamplingThread>,int>,void __cdecl(void)>::RunOnce [0x00007FF886A6C556+70]
	base::OnceCallback<void __cdecl(void)>::Run [0x00007FF88688D891+97]
	base::debug::TaskAnnotator::RunTask [0x00007FF8868F5EF3+915]
	base::MessageLoop::RunTask [0x00007FF886992FB3+979]
	base::MessageLoop::DeferOrRunPendingTask [0x00007FF886993503+83]
	base::MessageLoop::DoWork [0x00007FF8869939F4+484]
	base::MessagePumpDefault::Run [0x00007FF88699F547+119]
	base::MessageLoop::Run [0x00007FF88699282C+524]
	base::RunLoop::Run [0x00007FF886A706DA+506]
	base::Thread::Run [0x00007FF886B9E3EE+366]
	base::Thread::ThreadMain [0x00007FF886B9ECE9+1449]
	logging::CheckEQImpl<enum base::win::Version,enum base::win::Version> [0x00007FF886B90413+595]
	BaseThreadInitThunk [0x00007FF8AA262774+20]
	RtlUserThreadStart [0x00007FF8AC4C0D51+33]
r587726 is the likely culprit, will revert.
Cc: isherman@chromium.org sky@chromium.org
Components: Internals>Network>Library
Labels: -Sheriff-Chromium
Owner: wittman@chromium.org
Reverted r587726 as r587978. Assigning to original CL author, wittman@, please investigate.
Status: Assigned (was: Available)
 Issue 879538  has been merged into this issue.
 Issue 879537  has been merged into this issue.
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2943c9c7082865f62153731e4d34414a286e6f4b

commit 2943c9c7082865f62153731e4d34414a286e6f4b
Author: Mike Wittman <wittman@chromium.org>
Date: Fri Aug 31 19:28:57 2018

Reland "Rationalize call stacks targets in //components/metrics/BUILD.gn"

Relanding with fix for ChromeContentRendererClientMetricsTest.

Renames targets to better reflect what they provide. Removes the
:metrics dep from the target for child processes to avoid including
unnecessary browser-process-only code in those processes. Breaks the
direct dependency of CallStackProfileBuilder on :metrics by introducing
a receiver callback abstraction.

TBR=sky

Bug:  878509 ,  879513 ,  804942 
Change-Id: Ib83ad55a31b98022531a8dad740c7d5516db8caf
Reviewed-on: https://chromium-review.googlesource.com/1199764
Reviewed-by: Mike Wittman <wittman@chromium.org>
Commit-Queue: Mike Wittman <wittman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588114}
[modify] https://crrev.com/2943c9c7082865f62153731e4d34414a286e6f4b/chrome/browser/BUILD.gn
[modify] https://crrev.com/2943c9c7082865f62153731e4d34414a286e6f4b/chrome/browser/chrome_browser_main.cc
[modify] https://crrev.com/2943c9c7082865f62153731e4d34414a286e6f4b/chrome/common/BUILD.gn
[modify] https://crrev.com/2943c9c7082865f62153731e4d34414a286e6f4b/chrome/common/thread_profiler.cc
[modify] https://crrev.com/2943c9c7082865f62153731e4d34414a286e6f4b/chrome/common/thread_profiler.h
[modify] https://crrev.com/2943c9c7082865f62153731e4d34414a286e6f4b/chrome/gpu/BUILD.gn
[modify] https://crrev.com/2943c9c7082865f62153731e4d34414a286e6f4b/chrome/renderer/chrome_content_renderer_client_unittest.cc
[modify] https://crrev.com/2943c9c7082865f62153731e4d34414a286e6f4b/components/metrics/BUILD.gn
[modify] https://crrev.com/2943c9c7082865f62153731e4d34414a286e6f4b/components/metrics/call_stack_profile_builder.cc
[modify] https://crrev.com/2943c9c7082865f62153731e4d34414a286e6f4b/components/metrics/call_stack_profile_builder.h
[modify] https://crrev.com/2943c9c7082865f62153731e4d34414a286e6f4b/components/startup_metric_utils/browser/BUILD.gn

Status: Fixed (was: Assigned)

Sign in to add a comment