Regression: Spacing between 'Cancel' & 'Done' buttons is not proper on Add Shortcut overlay using RTL.
Reported by
sanyam.g...@etouch.net,
Aug 31
|
||||||
Issue descriptionChrome Version: 70.0.3538.0 (Official Build) Revision a20f097fb0047bcf58b3ec9a44be7fab7ba4cbc4-refs/branch-heads/3538@{#1} (64-bit) OS: Windows(7,8,8.1,10), Mac(10.12.6 , 10.13.1 , 10.13.6, 10.14) & Linux(14.04 LTS) Pre-condition: Enable "Enable using the Google local NTP" , "New Tab Page Custom Links" and "set Force UI direction to 'Right to Left" flags under chrome://flags. What steps will reproduce the problem? 1. Launch Chrome and navigate to NTP . 2. Click on 'Add Shortcut' thumbnail and observe. Actual Result : Spacing between 'Cancel' & 'Done' buttons is not proper on Add Shortcut overlay. Expected Result: Spacing between 'Cancel' & 'Done' buttons should be proper. This is a regression issue, broken in 'M-70', below is per-revision bisect info: Good Build: 70.0.3503.0 (Revision: 578160) Bad Build : 70.0.3504.0 (Revision: 578510) You are probably looking for a change made after 578403 (known good), but no later than 578404 (first known bad). CHANGE-LOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/cc26ae0530e932f65dbab9bccbf5f590a9d37c94..c7c6a230da8a075b37f7306f4f8902e7a3f3b490 Suspect: https://chromium.googlesource.com/chromium/src/+/c7c6a230da8a075b37f7306f4f8902e7a3f3b490 @kristipark: Could you please help to reassign if your change is not the cause for this change. Kindly review the attached screen-cast for reference. Thank You..!!
,
Sep 6
Noting that this is not a regression; the expected behavior video shows LTR.
,
Sep 6
,
Sep 28
,
Oct 1
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/57fb5ba9ff8e4849536faa1406c5cce5c2537431 commit 57fb5ba9ff8e4849536faa1406c5cce5c2537431 Author: Kristi Park <kristipark@chromium.org> Date: Mon Oct 01 22:20:47 2018 [NTP] Fix spacing between cancel and done in edit shortcut dialog for RTL Before: https://screenshot.googleplex.com/VTEZEnvP8Ac.png After: https://screenshot.googleplex.com/QpJWqkymMe8.png Bug: 879502 Change-Id: I4a37757b19297c3507b55d8506446dd1f58ecbc5 Reviewed-on: https://chromium-review.googlesource.com/1252854 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#595584} [modify] https://crrev.com/57fb5ba9ff8e4849536faa1406c5cce5c2537431/chrome/browser/resources/local_ntp/custom_links_edit.css
,
Oct 1
,
Oct 3
Update : Rechecked the above issue on Win(7,8,8.1,10) ,Mac(10.12.6 , 10.13.1 , 10.13.6, 10.14) and Linux(14.04 LTS) OS with Canary version #71.0.3569.0 and the issue is fixed. Kindly refer the attached screen cast. Thank you..!!! |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by twelling...@chromium.org
, Sep 4