New issue
Advanced search Search tips

Issue 879486 link

Starred by 1 user
Status: Fixed
Owner:
ioanap@chromium.org
Closed: Sep 3
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Add metrics for password generation on Android

Project Member Reported by ioanap@chromium.org, Aug 31 
Add UMA metrics for password generation user-triggered events such as password accepted, edited, deleted, rejected. 

The histogram is only used for Android at the moment, but it is suitable for other platforms as well.

Comment 1 by ioanap@chromium.org, Aug 31

Description: Show this description
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 31 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b0bb4724bbbad1e69d993c09849787319eee3620

commit b0bb4724bbbad1e69d993c09849787319eee3620
Author: Ioana Pandele <ioanap@chromium.org>
Date: Fri Aug 31 08:04:30 2018

Add metrics for password generation on Android

Bug:  879486 , 835234
Change-Id: Ife5ece610ec7f3173caf368681e3f3338c96354b
Reviewed-on: https://chromium-review.googlesource.com/1195483
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587963}
[modify] https://crrev.com/b0bb4724bbbad1e69d993c09849787319eee3620/chrome/browser/android/password_manager/password_generation_dialog_view_android.cc
[modify] https://crrev.com/b0bb4724bbbad1e69d993c09849787319eee3620/chrome/browser/password_manager/chrome_password_manager_client.cc
[modify] https://crrev.com/b0bb4724bbbad1e69d993c09849787319eee3620/chrome/browser/password_manager/password_accessory_controller.cc
[modify] https://crrev.com/b0bb4724bbbad1e69d993c09849787319eee3620/chrome/browser/password_manager/password_accessory_controller.h
[modify] https://crrev.com/b0bb4724bbbad1e69d993c09849787319eee3620/components/autofill/core/common/password_generation_util.cc
[modify] https://crrev.com/b0bb4724bbbad1e69d993c09849787319eee3620/components/autofill/core/common/password_generation_util.h
[modify] https://crrev.com/b0bb4724bbbad1e69d993c09849787319eee3620/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/b0bb4724bbbad1e69d993c09849787319eee3620/tools/metrics/histograms/histograms.xml

Comment 3 by ioanap@chromium.org, Sep 3

Status: Fixed (was: Started)

Comment 4 by ioanap@chromium.org, Sep 3

Labels: Merge-Request-70
This is a metrics-only change.
Project Member

Comment 5 by sheriffbot@chromium.org, Sep 4

Labels: -Merge-Request-70 Hotlist-Merge-Approved Merge-Approved-70
Your change meets the bar and is auto-approved for M70. Please go ahead and merge the CL to branch 3538 manually. Please contact milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 4

Labels: -merge-approved-70 merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/53fd2dabc42c0a40c8efca6225e1dc83e9189334

commit 53fd2dabc42c0a40c8efca6225e1dc83e9189334
Author: Ioana Pandele <ioanap@chromium.org>
Date: Tue Sep 04 09:36:50 2018

[M70]Add metrics for password generation on Android

Bug:  879486 , 835234
Change-Id: Ife5ece610ec7f3173caf368681e3f3338c96354b
Reviewed-on: https://chromium-review.googlesource.com/1195483
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#587963}(cherry picked from commit b0bb4724bbbad1e69d993c09849787319eee3620)
Reviewed-on: https://chromium-review.googlesource.com/1203970
Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#20}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/53fd2dabc42c0a40c8efca6225e1dc83e9189334/chrome/browser/android/password_manager/password_generation_dialog_view_android.cc
[modify] https://crrev.com/53fd2dabc42c0a40c8efca6225e1dc83e9189334/chrome/browser/password_manager/chrome_password_manager_client.cc
[modify] https://crrev.com/53fd2dabc42c0a40c8efca6225e1dc83e9189334/chrome/browser/password_manager/password_accessory_controller.cc
[modify] https://crrev.com/53fd2dabc42c0a40c8efca6225e1dc83e9189334/chrome/browser/password_manager/password_accessory_controller.h
[modify] https://crrev.com/53fd2dabc42c0a40c8efca6225e1dc83e9189334/components/autofill/core/common/password_generation_util.cc
[modify] https://crrev.com/53fd2dabc42c0a40c8efca6225e1dc83e9189334/components/autofill/core/common/password_generation_util.h
[modify] https://crrev.com/53fd2dabc42c0a40c8efca6225e1dc83e9189334/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/53fd2dabc42c0a40c8efca6225e1dc83e9189334/tools/metrics/histograms/histograms.xml
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/53fd2dabc42c0a40c8efca6225e1dc83e9189334

commit 53fd2dabc42c0a40c8efca6225e1dc83e9189334
Author: Ioana Pandele <ioanap@chromium.org>
Date: Tue Sep 04 09:36:50 2018

[M70]Add metrics for password generation on Android

Bug:  879486 , 835234
Change-Id: Ife5ece610ec7f3173caf368681e3f3338c96354b
Reviewed-on: https://chromium-review.googlesource.com/1195483
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#587963}(cherry picked from commit b0bb4724bbbad1e69d993c09849787319eee3620)
Reviewed-on: https://chromium-review.googlesource.com/1203970
Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#20}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/53fd2dabc42c0a40c8efca6225e1dc83e9189334/chrome/browser/android/password_manager/password_generation_dialog_view_android.cc
[modify] https://crrev.com/53fd2dabc42c0a40c8efca6225e1dc83e9189334/chrome/browser/password_manager/chrome_password_manager_client.cc
[modify] https://crrev.com/53fd2dabc42c0a40c8efca6225e1dc83e9189334/chrome/browser/password_manager/password_accessory_controller.cc
[modify] https://crrev.com/53fd2dabc42c0a40c8efca6225e1dc83e9189334/chrome/browser/password_manager/password_accessory_controller.h
[modify] https://crrev.com/53fd2dabc42c0a40c8efca6225e1dc83e9189334/components/autofill/core/common/password_generation_util.cc
[modify] https://crrev.com/53fd2dabc42c0a40c8efca6225e1dc83e9189334/components/autofill/core/common/password_generation_util.h
[modify] https://crrev.com/53fd2dabc42c0a40c8efca6225e1dc83e9189334/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/53fd2dabc42c0a40c8efca6225e1dc83e9189334/tools/metrics/histograms/histograms.xml
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/53fd2dabc42c0a40c8efca6225e1dc83e9189334

commit 53fd2dabc42c0a40c8efca6225e1dc83e9189334
Author: Ioana Pandele <ioanap@chromium.org>
Date: Tue Sep 04 09:36:50 2018

[M70]Add metrics for password generation on Android

Bug:  879486 , 835234
Change-Id: Ife5ece610ec7f3173caf368681e3f3338c96354b
Reviewed-on: https://chromium-review.googlesource.com/1195483
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#587963}(cherry picked from commit b0bb4724bbbad1e69d993c09849787319eee3620)
Reviewed-on: https://chromium-review.googlesource.com/1203970
Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#20}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/53fd2dabc42c0a40c8efca6225e1dc83e9189334/chrome/browser/android/password_manager/password_generation_dialog_view_android.cc
[modify] https://crrev.com/53fd2dabc42c0a40c8efca6225e1dc83e9189334/chrome/browser/password_manager/chrome_password_manager_client.cc
[modify] https://crrev.com/53fd2dabc42c0a40c8efca6225e1dc83e9189334/chrome/browser/password_manager/password_accessory_controller.cc
[modify] https://crrev.com/53fd2dabc42c0a40c8efca6225e1dc83e9189334/chrome/browser/password_manager/password_accessory_controller.h
[modify] https://crrev.com/53fd2dabc42c0a40c8efca6225e1dc83e9189334/components/autofill/core/common/password_generation_util.cc
[modify] https://crrev.com/53fd2dabc42c0a40c8efca6225e1dc83e9189334/components/autofill/core/common/password_generation_util.h
[modify] https://crrev.com/53fd2dabc42c0a40c8efca6225e1dc83e9189334/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/53fd2dabc42c0a40c8efca6225e1dc83e9189334/tools/metrics/histograms/histograms.xml
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8b6615947b4d820630aba94123792961519f24aa

commit 8b6615947b4d820630aba94123792961519f24aa
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date: Fri Oct 19 14:39:55 2018

Implement PasswordGeneration.UserEvent metrics for desktop.

The CL moves the implementation from Android-specific code to the
cross-platform component. This is a follow-up to
https://chromium-review.googlesource.com/c/chromium/src/+/1195483
https://chromium-review.googlesource.com/c/chromium/src/+/1202204

Bug:  879486 , 835234
Change-Id: I03dfe07c19f215bc914c9d564011e68010a1c11a
Reviewed-on: https://chromium-review.googlesource.com/c/1283133
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601142}
[modify] https://crrev.com/8b6615947b4d820630aba94123792961519f24aa/chrome/browser/password_manager/chrome_password_manager_client.cc
[modify] https://crrev.com/8b6615947b4d820630aba94123792961519f24aa/chrome/browser/password_manager/password_accessory_controller.cc
[modify] https://crrev.com/8b6615947b4d820630aba94123792961519f24aa/chrome/browser/password_manager/password_accessory_controller.h
[modify] https://crrev.com/8b6615947b4d820630aba94123792961519f24aa/chrome/browser/password_manager/password_accessory_controller_unittest.cc
[modify] https://crrev.com/8b6615947b4d820630aba94123792961519f24aa/chrome/browser/password_manager/password_generation_interactive_uitest.cc
[modify] https://crrev.com/8b6615947b4d820630aba94123792961519f24aa/components/autofill/core/common/password_generation_util.cc
[modify] https://crrev.com/8b6615947b4d820630aba94123792961519f24aa/components/autofill/core/common/password_generation_util.h
[modify] https://crrev.com/8b6615947b4d820630aba94123792961519f24aa/components/password_manager/core/browser/new_password_form_manager.cc
[modify] https://crrev.com/8b6615947b4d820630aba94123792961519f24aa/components/password_manager/core/browser/new_password_form_manager.h
[modify] https://crrev.com/8b6615947b4d820630aba94123792961519f24aa/components/password_manager/core/browser/new_password_form_manager_unittest.cc
[modify] https://crrev.com/8b6615947b4d820630aba94123792961519f24aa/components/password_manager/core/browser/password_form_manager.cc
[modify] https://crrev.com/8b6615947b4d820630aba94123792961519f24aa/components/password_manager/core/browser/password_form_manager.h
[modify] https://crrev.com/8b6615947b4d820630aba94123792961519f24aa/components/password_manager/core/browser/password_form_manager_unittest.cc
[modify] https://crrev.com/8b6615947b4d820630aba94123792961519f24aa/components/password_manager/core/browser/password_form_metrics_recorder.cc
[modify] https://crrev.com/8b6615947b4d820630aba94123792961519f24aa/components/password_manager/core/browser/password_form_metrics_recorder.h
[modify] https://crrev.com/8b6615947b4d820630aba94123792961519f24aa/components/password_manager/core/browser/password_form_metrics_recorder_unittest.cc
[modify] https://crrev.com/8b6615947b4d820630aba94123792961519f24aa/components/password_manager/core/browser/password_manager_unittest.cc
[modify] https://crrev.com/8b6615947b4d820630aba94123792961519f24aa/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/8b6615947b4d820630aba94123792961519f24aa/tools/metrics/histograms/histograms.xml
►

Sign in to add a comment