New issue
Advanced search Search tips

Issue 879451 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 31
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

AEC3: Allow controlled usage of the shadow filter output

Project Member Reported by peah@chromium.org, Aug 31

Issue description

Sometimes usage of the shadow filter output causes distortions of the nearend. In such cases, a good way of turning off this feature is needed.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 31

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/240215431ee21e85e415484d1d80f437850f2f8e

commit 240215431ee21e85e415484d1d80f437850f2f8e
Author: Per Åhgren <peah@webrtc.org>
Date: Fri Aug 31 06:51:16 2018

AEC3: Parametrize the shadow filter output usage

This CL introduces the ability to control the usage of the shadow filter
output in the echo canceller output.

Bug:  webrtc:9694 , chromium:879451 
Change-Id: I01f90de60de1799b32892051c176bda5e1a8d33e
Reviewed-on: https://webrtc-review.googlesource.com/97020
Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org>
Commit-Queue: Per Åhgren <peah@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24506}
[modify] https://crrev.com/240215431ee21e85e415484d1d80f437850f2f8e/api/audio/echo_canceller3_config.h
[modify] https://crrev.com/240215431ee21e85e415484d1d80f437850f2f8e/modules/audio_processing/aec3/echo_remover.cc
[modify] https://crrev.com/240215431ee21e85e415484d1d80f437850f2f8e/modules/audio_processing/test/audio_processing_simulator.cc

Status: Assigned (was: Untriaged)
Status: Fixed (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ed774e4540ee3afb2dd4ac22ef3fb7bcc89f7e57

commit ed774e4540ee3afb2dd4ac22ef3fb7bcc89f7e57
Author: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Mon Sep 03 10:54:18 2018

Roll src/third_party/webrtc f18b35284288..689b5874d4fb (50 commits)

https://webrtc.googlesource.com/src.git/+log/f18b35284288..689b5874d4fb


git log f18b35284288..689b5874d4fb --date=short --no-merges --format='%ad %ae %s'
2018-09-03 nisse@webrtc.org Use monotonic clock for PhysicalSocketServer timeouts.
2018-09-01 phoglund@webrtc.org Roll chromium_revision c1d4701..bbc67a1bd5 (585833:587546)
2018-09-01 phoglund@webrtc.org Remove MSVC debug bots from CQ.
2018-08-31 julien.isorce@chromium.org ScreenCapturerMac: destroy the streams and remove the DisplayStreamManager
2018-08-31 steveanton@webrtc.org Use AsyncInvoker in DtmfSender instead of MessageHandler
2018-08-31 steveanton@webrtc.org Use AsyncInvoker in DataChannel instead of MessageHandler
2018-08-31 steveanton@webrtc.org Use AsyncInvoker in JsepTransportController instead of MessageHandler
2018-08-31 steveanton@webrtc.org Use AsyncInvoker in PeerConnection instead of MessageHandler
2018-08-31 srte@webrtc.org Removes redundant starting rate.
2018-08-31 devicentepena@webrtc.org AEC3: option for using the stationarity estimator at render from the beginning of the call
2018-08-31 danilchap@webrtc.org Uninline non-trivial AudioOptions functions
2018-08-31 danilchap@webrtc.org Implement periodic cancelable task for task queue
2018-08-31 phoglund@webrtc.org Bump xcode versions for WebRTC bots.
2018-08-31 alessiob@webrtc.org Moving LappedTransform, Blocker and AudioRingBuffer.
2018-08-31 danilchap@webrtc.org Cleanup RtpPacketizerVP8 tests
2018-08-31 nisse@webrtc.org Reland "Add spatial index to EncodedImage."
2018-08-31 peah@webrtc.org AEC3: Parametrize the shadow filter output usage
2018-08-31 qingsi@google.com Add the multicast DNS message format.
2018-08-30 alessiob@webrtc.org Removing the intelligibility enhancer.
2018-08-30 wfh@chromium.org Add no_size_t_to_int_warning suppression to webrtc.
2018-08-30 brandtr@webrtc.org Revert "Reland "Optimize execution time of RTPSender::UpdateDelayStatistics""
2018-08-30 terelius@webrtc.org Reland "Optimize execution time of RTPSender::UpdateDelayStatistics"
2018-08-30 srte@webrtc.org Adds TaskQueue congestion controller tests in VideoSendStreamTest.
2018-08-30 srte@webrtc.org Adds support for frame rate control in FrameGeneratorCapturer.
2018-08-30 srte@webrtc.org Fixes breaking bug in feedback based GoogCC.
2018-08-30 phoglund@webrtc.org Roll chromium_revision 33a17747bb2..c1d47013a1 (585798:585833)
2018-08-30 nisse@webrtc.org Revert "Refactor TestAudioDeviceModule to not depend on EventTimerWrapper."
2018-08-30 nisse@webrtc.org Use a lock to protect members accessed by RtpVideoStreamReceiver::GetSyncInfo()
2018-08-30 nisse@webrtc.org Delete StreamStatistician::IsRetransmitOfOldPacket
2018-08-30 andersc@webrtc.org Obj-C SDK Cleanup
2018-08-30 nisse@webrtc.org Refactor TestAudioDeviceModule to not depend on EventTimerWrapper.
2018-08-30 danilchap@webrtc.org Cleanup RtpPacketizerVp8
2018-08-30 phoglund@webrtc.org Roll chromium_revision ca3a5e1cbb..33a17747bb (585726:585798)
2018-08-30 benwright@webrtc.org Injects FrameEncryptorInterface into RtpSender.
2018-08-29 benwright@webrtc.org This change integrates the FrameEncryptorInterface and the
2018-08-29 ssilkin@webrtc.org Move VP9 frame rate controller to separate class.
2018-08-29 nisse@webrtc.org Revert "Add spatial index to EncodedImage."
2018-08-29 nisse@webrtc.org Add spatial index to EncodedImage.
2018-08-29 devicentepena@webrtc.org AEC3: Adding a reset of the ERLE estimator after going out from the initial state.
2018-08-29 mbonadei@webrtc.org Remove clang:find_bad_constructs suppression from call:call.
2018-08-29 titovartem@webrtc.org Remove deprecated ctors of DirectTransport and its subclasses and FakeNetworkPipe
2018-08-29 valeriian@webrtc.org Adding CustomAudioAnalyzer interface in APM.
2018-08-29 devicentepena@webrtc.org AEC3: Reset the ERLE estimation after a delay change
2018-08-29 sakal@webrtc.org Use generic video header frame ID as picture ID.
2018-08-29 kthelgason@webrtc.org Add config option to run VideoCodecTest in real time.
2018-08-29 kthelgason@webrtc.org Export constants from RTCAudioSessionConfiguration.
2018-08-29 titovartem@webrtc.org Add support of overriding network simulation in video quality tests.
2018-08-29 kthelgason@webrtc.org Remove kVideoCodecUnknown completely.
2018-08-29 danilchap@webrtc.org Cleanup RtpPacketizer interface
2018-08-29 henrika@webrtc.org Increases max size of webrtc::AudioFrame from 60ms to 120ms @32kHz.


Created with:
  gclient setdep -r src/third_party/webrtc@689b5874d4fb

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG=chromium:None,chromium:851883,chromium:None,chromium:None,chromium:None,chromium:None,chromium:879451,chromium:588506,chromium:None,chromium:878319,chromium:None,chromium:None,chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Ie676e811ca23db391939ff0facf56f6aa46abbcd
Reviewed-on: https://chromium-review.googlesource.com/1201666
Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#588372}
[modify] https://crrev.com/ed774e4540ee3afb2dd4ac22ef3fb7bcc89f7e57/DEPS

Sign in to add a comment