New issue
Advanced search Search tips

Issue 879447 link

Starred by 1 user
Status: Fixed
Owner:
chrishall@chromium.org
Closed: Oct 2
Cc:
aboxhall@chromium.org
dtseng@chromium.org
lpalmaro@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug
Team-Accessibility



Sign in to add a comment

chrome/browser/resources/chromeos/chromevox/chromevox/background/options.html has two opening html tags

Project Member Reported by chrishall@chromium.org, Aug 31 
chromium/src/chrome/browser/resources/chromeos/chromevox/chromevox/background/options.html specifies "<html>" twice

chromium/src/chrome/browser/resources/chromeos/chromevox/chromevox/background$ grep -n 'html' options.html 
4:<html>
17:<html>
438:</html>


Why do we have two opening html tags and one closing?

I suspect the second opening tag is a bug.

Comment 1 by chrishall@chromium.org, Aug 31 

This is also true of the file
chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.html

chrome/browser/resources/chromeos/chromevox/cvox2/background$ git grep -n 'html' panel.html
panel.html:4:<html>
panel.html:20:<html>
panel.html:73:</html>

Comment 2 by chrishall@chromium.org, Aug 31

Cc: aboxhall@chromium.org

Comment 3 by chrishall@chromium.org, Aug 31

Status: Started (was: Assigned)
Removed second occurrence from both files, fixed lang while I was there.

Uploaded to
https://chromium-review.googlesource.com/c/chromium/src/+/1198708
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 5 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/65a69520a3c51069f252013d9912b605a26227d4

commit 65a69520a3c51069f252013d9912b605a26227d4
Author: Chris Hall <chrishall@chromium.org>
Date: Tue Sep 04 18:44:02 2018

[Chrome] fixing 2 occurrences duplicate opening html tag

Bug:  879447 
Change-Id: Iae8fcbc69cbcf8e0bfe3705f334dd062420a232c
Reviewed-on: https://chromium-review.googlesource.com/1198708
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588594}
[modify] https://crrev.com/65a69520a3c51069f252013d9912b605a26227d4/chrome/browser/resources/chromeos/chromevox/chromevox/background/options.html
[modify] https://crrev.com/65a69520a3c51069f252013d9912b605a26227d4/chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.html

Comment 5 by chrishall@chromium.org, Oct 2

Status: Fixed (was: Started)
►

Sign in to add a comment