New issue
Advanced search Search tips

Issue 879446 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 7
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

ImageLoader metrics are missing from histograms.xml

Project Member Reported by tapted@chromium.org, Aug 31

Issue description

Chrome Version       : 70.0.3534.4
OS Version:  Chrome

ImageLoaderClient records a bunch of metrics, but I can't find the histogram metadata for them.

What steps will reproduce the problem?
1. Open Files app or Gallery, do some stuff
2. Go to chrome://histograms
3. See a bunch of stuff like

ImageLoader.Client.Cache.HitMiss
ImageLoader.Client.Cached
ImageLoader.Client.Cache.Usage


What is the expected result?

Also appears at uma.googleplex.com


What happens instead of that?

Doesn't

 
Screenshot from 2018-09-06 16-04-53.png
15.2 KB View Download
Screenshot from 2018-09-06 16-04-41.png
11.2 KB View Download
Screenshot from 2018-09-06 16-04-18.png
10.5 KB View Download
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/74d4a8f41c7131184cc52c249e4fedef8790d557

commit 74d4a8f41c7131184cc52c249e4fedef8790d557
Author: Trent Apted <tapted@chromium.org>
Date: Fri Sep 07 01:36:32 2018

Add UMA metadata for ImageLoaderClient metrics.

Metrics were added 5 years ago in r188357, but they lack metadata.

Bug:  879446 
Change-Id: I42daa58100bd8ed6c7c2d13542913e56d82f6f37
Reviewed-on: https://chromium-review.googlesource.com/1208999
Commit-Queue: Trent Apted <tapted@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589403}
[modify] https://crrev.com/74d4a8f41c7131184cc52c249e4fedef8790d557/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Assigned)

Sign in to add a comment