Add a virtual keyboard browser test |
|||||||
Issue description
Add a test of the virtual keyboard from a FilesApp browser tests. Open the FilesApp, select a file to rename, eg., use
code search: keyboard_operations.js renameNewFolder
as the basis of a new test. Change it to send a JS touch Event to the FilesApp file rename <input> element, then check that the Aura virtual keyboard is displayed [1]
[1] The test JS sends a message from FilesApp to the browser test C++ over the chrome.test.sendMessage channel per usual. In the C++, handle the message and reply to it in:
void FileManagerBrowserTestBase::OnCommand(...)
if (name == "getVirtualKeyboardState") {
keyboard::WaitUntilShown();
base::DictionaryValue dictionary;
dictionary.SetBoolean("visible", keyboard::IsKeyboardVisible());
base::JSONWriter::Write(dictionary, output);
return;
}
Should be easy todo in M69 M70 ... @shend maybe add leo to this bug.
,
Sep 6
> But the browser test framework for simple chrome does not have or show virtual keyboard even when run with --enable-virtual-keyboard (bad). Well that's the necessary first step, make Table mode browser tests enable the virtual keyboard.
,
Sep 6
,
Sep 6
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c480691dbc893c156f0ee9880e1c46fa482a5766 commit c480691dbc893c156f0ee9880e1c46fa482a5766 Author: Noel Gordon <noel@chromium.org> Date: Thu Sep 06 04:40:30 2018 Allow browser test base class to read tablet mode test state Propagate the Table Mode (aka Ash immersive mode) test state into the base class of the Files App test suite. Make Tablet Mode tests enable the Ash Virtual Keyboard flag (as would happen on real chromebook in Table Mode). No change in test behavior: just erecting the scaffold so we can test this aspect of Chrome OS. Bug: 879434, 839243 Change-Id: Idfd4016698214876c991d26d1a3a8fd7dfa84bde Reviewed-on: https://chromium-review.googlesource.com/1207783 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#589100} [modify] https://crrev.com/c480691dbc893c156f0ee9880e1c46fa482a5766/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc [modify] https://crrev.com/c480691dbc893c156f0ee9880e1c46fa482a5766/chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc [modify] https://crrev.com/c480691dbc893c156f0ee9880e1c46fa482a5766/chrome/browser/chromeos/file_manager/file_manager_browsertest_base.h
,
Sep 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fe3ac346a9e30b2bba001db47af1521b417ed92a commit fe3ac346a9e30b2bba001db47af1521b417ed92a Author: Noel Gordon <noel@chromium.org> Date: Mon Sep 10 05:12:57 2018 FilesApp browser test: enable virtual keyboard in tablet mode tests Add an Ash EnableVirtualKeyboard mojo test API, and use it in FilesApp browser test fixtures that run in Ash tablet mode. No change in behavior: this is laying scaffold to allow testing of the Virtual Keyboard and its use in Files App in tablet mode [1]. [1] No tests of the Virtual Keyboard feature from Files App currently, and issue 762664, issue 762694 indicate this gap in test coverage. Test: browser_tests --gtest_filter="*FilesApp*TabletMode" Bug: 879434 Change-Id: I8c0c2ee8ef8e208cb721019c3cdca85f9448c5c8 Reviewed-on: https://chromium-review.googlesource.com/1210422 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by: Sam McNally <sammc@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#589828} [modify] https://crrev.com/fe3ac346a9e30b2bba001db47af1521b417ed92a/ash/public/interfaces/shell_test_api.mojom [modify] https://crrev.com/fe3ac346a9e30b2bba001db47af1521b417ed92a/ash/shell_test_api.cc [modify] https://crrev.com/fe3ac346a9e30b2bba001db47af1521b417ed92a/ash/shell_test_api.h [modify] https://crrev.com/fe3ac346a9e30b2bba001db47af1521b417ed92a/chrome/browser/chromeos/DEPS [modify] https://crrev.com/fe3ac346a9e30b2bba001db47af1521b417ed92a/chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc [modify] https://crrev.com/fe3ac346a9e30b2bba001db47af1521b417ed92a/chrome/browser/chromeos/file_manager/file_manager_browsertest_base.h
,
Sep 12
,
Oct 19
,
Oct 19
With issue 895703 fixed, we can add virtual keyboard & tablet mode tests to the SelectFileDialogExtensionBrowserTest suite too.
,
Oct 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9b8749dabce3505abbac682bb4e60ead7534f1b2 commit 9b8749dabce3505abbac682bb4e60ead7534f1b2 Author: Noel Gordon <noel@chromium.org> Date: Fri Oct 19 08:03:57 2018 Add SelectFileDialogExtensionBrowserTest virtual keyboard test FilesApp provides the innards of the extension file dialog. For tablet mode tests, always enable the Ash virtual keyboard and add a test that clicks dialog filename <input> element and checks that the Ash virtual keyboard appears. The virtual keyboard test and enable-features=SingleProcessMash do not play nice at this time: exclude this test from single process mash. Bug: 879434, 897012 Change-Id: Ia5a72abd3fcdbd12282c36b27cc1213fd7e6672b Reviewed-on: https://chromium-review.googlesource.com/c/1290571 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#601078} [modify] https://crrev.com/9b8749dabce3505abbac682bb4e60ead7534f1b2/chrome/browser/ui/views/select_file_dialog_extension_browsertest.cc [modify] https://crrev.com/9b8749dabce3505abbac682bb4e60ead7534f1b2/testing/buildbot/filters/chromeos.single_process_mash.browser_tests.filter
,
Jan 7
,
Jan 7
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by noel@chromium.org
, Aug 31