New issue
Advanced search Search tips

Issue 879425 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 29
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Show a user-friendly path for team drives in the settings UI

Project Member Reported by sa...@chromium.org, Aug 31

Issue description

Update file_manager::util::GetDownloadLocationText() to rewrite <drive mount path>/team_drives to something like "Team Drives"
 
Owner: sa...@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/88d5f8c4e8721b86308988b7848d667db9ba4952

commit 88d5f8c4e8721b86308988b7848d667db9ba4952
Author: Sam McNally <sammc@chromium.org>
Date: Fri Aug 31 06:25:37 2018

Rewrite <drive root>/team_drives to "Team Drives" for the settings UI.

Bug:  879425 
Change-Id: Ibcb7b71ca7424cd085c26fde7693b48b7473ba74
Reviewed-on: https://chromium-review.googlesource.com/1198703
Commit-Queue: Sam McNally <sammc@chromium.org>
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587956}
[modify] https://crrev.com/88d5f8c4e8721b86308988b7848d667db9ba4952/chrome/browser/chromeos/file_manager/path_util.cc
[modify] https://crrev.com/88d5f8c4e8721b86308988b7848d667db9ba4952/chrome/browser/chromeos/file_manager/path_util.h
[modify] https://crrev.com/88d5f8c4e8721b86308988b7848d667db9ba4952/chrome/browser/chromeos/file_manager/path_util_unittest.cc

Status: Fixed (was: Assigned)
Owner: joelhockey@chromium.org
Status: Assigned (was: Fixed)
Prefix all Google Drive paths with 'Google Drive' and use 'My Drive' for default:
 Google Drive > My Drive > ...
 Google Drive > Team Drives > ...
 Google Drive > Computers > ...
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9f0dcec150d982f68cb16e78b6605c32c13bde40

commit 9f0dcec150d982f68cb16e78b6605c32c13bde40
Author: Joel Hockey <joelhockey@chromium.org>
Date: Mon Oct 29 07:52:18 2018

Fix Google Drive display paths shown in settings page

Currently paths are shown as:
 Google Drive > ...
 Team Drives > ...
 Computers > ...

This change sets all Google Drives paths to prefix with 'Google Drive'
and adds 'My Drive' for paths in /root.  'Google Drive' is not
localized.  The 'My Drive', 'Team Drives' and 'Computers' labels are.

 Google Drive > My Drive > ...
 Google Drive > Team Drives > ...
 Google Drive > Computers > ...

Bug:  879425 
Change-Id: I502dbae82af575a91744abad4a7e98ba15ad8a69
Reviewed-on: https://chromium-review.googlesource.com/c/1304275
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603436}
[modify] https://crrev.com/9f0dcec150d982f68cb16e78b6605c32c13bde40/chrome/browser/chromeos/file_manager/path_util.cc
[modify] https://crrev.com/9f0dcec150d982f68cb16e78b6605c32c13bde40/chrome/browser/chromeos/file_manager/path_util_unittest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment