New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 879418 link

Starred by 2 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature


Participants' hotlists:
Better-Together-Launch-Blockers


Sign in to add a comment

Setup flow should be keyboard-shortcut friendly

Project Member Reported by khorimoto@chromium.org, Aug 31

Issue description

(1) The password field should be focused as soon as the setup flow loads. Currently, you have to press tab to focus the field.
(2) You can press enter in the password field to go to the next page, but you cannot press enter on either of the following two pages.

These improvements help the usability of the page.
 
Labels: -M-70 M-71
 Issue 884262  has been merged into this issue.
Components: -UI>ProximityAuth UI>Multidevice
Owner: hansberry@chromium.org
Status: Started (was: Available)
Grabbing this issue.
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1ba3fb04f3c36246743e369d94d4a11223196ca7

commit 1ba3fb04f3c36246743e369d94d4a11223196ca7
Author: Ryan Hansberry <hansberry@chromium.org>
Date: Thu Oct 11 01:04:37 2018

[CrOS Multidevice] Autofocus the forward buttons in MultiDevice setup flow.

multidevice-setup cannot directly grab the #forward-button because it is
owned by multidevice-setup-post-oobe, so it fires a 'focus-forward-button'
up to multidevice-setup-post-oobe.

Bug: 879418
Change-Id: I5c194a11a5393ea7fd2cffb286920d3a0a17a040
Reviewed-on: https://chromium-review.googlesource.com/c/1265819
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598607}
[modify] https://crrev.com/1ba3fb04f3c36246743e369d94d4a11223196ca7/chrome/browser/resources/chromeos/login/multidevice_setup_first_run.html
[modify] https://crrev.com/1ba3fb04f3c36246743e369d94d4a11223196ca7/chrome/browser/resources/chromeos/login/multidevice_setup_first_run.js
[modify] https://crrev.com/1ba3fb04f3c36246743e369d94d4a11223196ca7/chrome/browser/resources/chromeos/multidevice_setup/multidevice_setup_post_oobe.html
[modify] https://crrev.com/1ba3fb04f3c36246743e369d94d4a11223196ca7/chrome/browser/resources/chromeos/multidevice_setup/multidevice_setup_post_oobe.js
[modify] https://crrev.com/1ba3fb04f3c36246743e369d94d4a11223196ca7/chrome/browser/ui/webui/chromeos/login/multidevice_setup_screen_handler.cc
[modify] https://crrev.com/1ba3fb04f3c36246743e369d94d4a11223196ca7/ui/webui/resources/cr_components/chromeos/multidevice_setup/multidevice_setup.js

Status: Fixed (was: Started)
Status: Assigned (was: Fixed)
This appears to have regressed - when I first open the dialog, I can't hit Enter to move to the next page. Ryan, feel free to re-assign if you can't take this on.
Owner: khorimoto@chromium.org
Sorry, I don't think I have the bandwidth to take on this issue at the moment -- can you take it?
Sure, I'll look into this.
Owner: hsuregan@chromium.org
Actually, Regan will work on this instead :)
Status: Started (was: Assigned)

Sign in to add a comment