push_to_prod test fails, but metrics show success
Reported by
jrbarnette@chromium.org,
Aug 30
|
||||||
Issue description
Push to prod hasn't updated the prod branch since last Monday-ish.
We seem to have multiple problems. The most serious is that viceroy
claims to have seen successes earlier today, but those successes
didn't translate into branch updates:
http://shortn/_ggHmt05pIX
Looking at the run dated 8/30, 13:00, I see that it ends this way:
[chromeos-staging-drone2.hot.corp.google.com] out:
2018-08-30 13:43:08,558 ERRO| Traceback (most recent call last):
File "/usr/local/google/home/chromeos-test/chromiumos/chromeos-admin/venv/server_management_lib/tasks/task.py", line 66, in run
self._run()
File "/usr/local/google/home/chromeos-test/chromiumos/chromeos-admin/venv/server_management_lib/tasks/staging_lab_task.py", line 495, in _run
self.update_prod_next_refs(good_hashes)
File "/usr/local/google/home/chromeos-test/chromiumos/chromeos-admin/venv/server_management_lib/tasks/staging_lab_task.py", line 456, in update_prod_next_refs
self.push_prod_next_branch(repo, commit_map[repo])
File "/usr/local/google/home/chromeos-test/chromiumos/chromeos-admin/venv/server_management_lib/tasks/staging_lab_task.py", line 518, in push_prod_next_branch
print(subprocess.check_output(push_cmd, stderr=subprocess.STDOUT,
NameError: global name 'subprocess' is not defined
Don't know how that happened, but I can't imagine that it's good.
,
Aug 30
,
Aug 30
Wait. I want an explanation for why our dashboard shows success despite the failures. Given that the "push prod branch" command was pretty much the last thing we did, I kind of suspect that the metric report is "testing passed" rather than "we made it all the way to updating the branch".
,
Aug 30
The metric was not moved or renamed when I moved the test push itself into chromeos-admin. On it.
,
Sep 8
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/5776514388916d9866c7ef77dc58b7775c7f0c63 commit 5776514388916d9866c7ef77dc58b7775c7f0c63 Author: Jacob Kopczynski <jkop@google.com> Date: Sat Sep 08 01:36:45 2018 autotest: Remove now-inaccurate test push metric Moved to chromeos_admin BUG= chromium:879394 TEST=None Change-Id: I7d3ee1bb7a1cf2fc56faeb2428ca25b3819262e6 Reviewed-on: https://chromium-review.googlesource.com/1198016 Commit-Ready: Jacob Kopczynski <jkop@chromium.org> Tested-by: Jacob Kopczynski <jkop@chromium.org> Reviewed-by: Jacob Kopczynski <jkop@chromium.org> [modify] https://crrev.com/5776514388916d9866c7ef77dc58b7775c7f0c63/site_utils/test_push.py
,
Sep 8
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/chromeos-admin/+/bd4d51dec4b416059f13919e82024c9d06715ba1 commit bd4d51dec4b416059f13919e82024c9d06715ba1 Author: Jacob Kopczynski <jkop@google.com> Date: Sat Sep 08 01:36:45 2018
,
Sep 12
CLs seem to have not affected staging until 14:45 PST today. But they do seem to be working now.
,
Sep 12
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by jrbarnette@chromium.org
, Aug 30Labels: -Pri-2 Pri-1