New issue
Advanced search Search tips

Issue 879376 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 5
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Task



Sign in to add a comment

chrome: purge subversion usage

Project Member Reported by vapier@chromium.org, Aug 30

Issue description

we still have vestigial svn bits hanging around.  clean it all up.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/d6d937698aaca5bf16a57ee4b17e36a6c1458697

commit d6d937698aaca5bf16a57ee4b17e36a6c1458697
Author: Mike Frysinger <vapier@chromium.org>
Date: Fri Aug 31 18:21:32 2018

subversion.eclass: drop our copy

We don't have anything that syncs svn directly anymore, so drop this.

BUG= chromium:879376 
TEST=precq passes

Change-Id: Ifc50e13f710ccd32b6e506656a0e973e52e4985a
Reviewed-on: https://chromium-review.googlesource.com/1197748
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[delete] https://crrev.com/e4cadb173c257098308252fc0f8b101a82096444/eclass/subversion.eclass

Project Member

Comment 2 by bugdroid1@chromium.org, Sep 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/939205c20aacd0ce4c44322f7bac995b96564041

commit 939205c20aacd0ce4c44322f7bac995b96564041
Author: Mike Frysinger <vapier@chromium.org>
Date: Wed Sep 05 12:11:45 2018

chromeos-chrome: drop references to subversion

We haven't synced or used subversion in years, so scrub the references.

BUG= chromium:879376 
TEST=precq passes

Change-Id: I5e57ab29a16977207e969fe88bce76617e45314d
Reviewed-on: https://chromium-review.googlesource.com/1197747
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>

[modify] https://crrev.com/939205c20aacd0ce4c44322f7bac995b96564041/eclass/chromium-source.eclass
[modify] https://crrev.com/939205c20aacd0ce4c44322f7bac995b96564041/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild

Project Member

Comment 3 by bugdroid1@chromium.org, Sep 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/93ad226712761a0669119501b0d91847d16de62b

commit 93ad226712761a0669119501b0d91847d16de62b
Author: Mike Frysinger <vapier@chromium.org>
Date: Wed Sep 05 12:11:43 2018

cros_mark_chrome_as_stable: stop passing CROS_SVN_COMMIT through

We don't actually write this variable out to the ebuild, and none of
our ebuilds have it hardcoded in them.  The chrome ebuilds themselves
just use $PV to sync to the right --tag.

BUG= chromium:879376 
TEST=unittests pass

Change-Id: Ia0590e484ac021b7970a4509bb7c7eefd16ce737
Reviewed-on: https://chromium-review.googlesource.com/1197686
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>

[modify] https://crrev.com/93ad226712761a0669119501b0d91847d16de62b/scripts/cros_mark_chrome_as_stable_unittest.py
[modify] https://crrev.com/93ad226712761a0669119501b0d91847d16de62b/scripts/cros_mark_chrome_as_stable.py

Status: Fixed (was: Started)

Sign in to add a comment