New issue
Advanced search Search tips

Issue 879364 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 12
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 836886



Sign in to add a comment

[BlinkGenPropertyTrees] backface visibility is incorrect

Project Member Reported by pdr@chromium.org, Aug 30

Issue description

There is some bleeding from the back side of this test into the front side. It's a subtle failure but needs some investigation.
 
compositing/backface-visibility/backface-visibility-hierarchical-transform.html is also failing and, looking at that test, I think this may be a regression in backface visibility.
Summary: [BlinkGenPropertyTrees] backface visibility is incorrect (was: [BlinkGenPropertyTrees] compositing/backface-visibility-transformed.html is failing)
Owner: wangxianzhu@chromium.org
Status: Assigned (was: Available)
A reduced test based on compositing/backface-visibility/backface-visibility-hierarchical-transform.html:
<!DOCTYPE html>
<div style="transform: rotateY(180deg); transform-style: preserve-3d">
  <div style="backface-visibility: hidden; width: 100px; height: 100px; background: red"></div>
</div>
shows the regression.

<!DOCTYPE html>
<div style="transform: rotateY(180deg); transform-style: preserve-3d;
  backface-visibility: hidden; width: 100px; height: 100px; background: red"></div>
succeeds.

Project Member

Comment 5 by bugdroid1@chromium.org, Sep 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d18aae4354456a1d242730c10e21cf73c9356b67

commit d18aae4354456a1d242730c10e21cf73c9356b67
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Wed Sep 12 00:48:51 2018

[BGPT] Create transform paint property node for backface-visibility:hidden

The node is needed for PaintArtifactCompositor to correctly set
backface visibility properties of cc layers.

Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Bug:  879364 
Change-Id: Idc8241988f1582a160f816371e137c4ce03f4aa2
Reviewed-on: https://chromium-review.googlesource.com/1217909
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590555}
[modify] https://crrev.com/d18aae4354456a1d242730c10e21cf73c9356b67/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-gen-property-trees
[add] https://crrev.com/d18aae4354456a1d242730c10e21cf73c9356b67/third_party/WebKit/LayoutTests/flag-specific/enable-blink-gen-property-trees/paint/invalidation/clip/clip-path-constant-repaint-expected.txt
[modify] https://crrev.com/d18aae4354456a1d242730c10e21cf73c9356b67/third_party/blink/renderer/core/paint/paint_property_tree_builder.cc
[modify] https://crrev.com/d18aae4354456a1d242730c10e21cf73c9356b67/third_party/blink/renderer/core/paint/paint_property_tree_builder_test.cc

Status: Fixed (was: Assigned)

Sign in to add a comment