New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 879353 link

Starred by 6 users
Status: Fixed
Owner:
khmel@chromium.org
Closed: Oct 19
Cc:
kinaba@chromium.org
█ erosky@chromium.org
khmel@chromium.org
kroot@chromium.org
elijahtaylor@chromium.org
█ lpique@chromium.org
edcourtney@chromium.org
ricardoq@chromium.org
achuith@chromium.org
█ djacobo@chromium.org
mukai@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

login_GaiaLogin failing in M-70 with websocket error

Project Member Reported by kathrelk...@chromium.org, Aug 30 
"Unhandled WebSocketConnectionClosedException: socket is already closed."

Same error happens on other real gaia tests also.  Reproduced locally.

e.g. https://stainless.corp.google.com/browse/chromeos-autotest-results/232329164-chromeos-test/

Passing R70-11005.0.0
Failing R70-11010.0.0

Comment 1 by achuith@chromium.org, Aug 30 

The full stack:

Traceback (most recent call last):
  File "/usr/local/autotest/common_lib/test.py", line 600, in _exec
    _call_test_function(self.execute, *p_args, **p_dargs)
  File "/usr/local/autotest/common_lib/test.py", line 806, in _call_test_function
    raise error.UnhandledTestFail(e)
UnhandledTestFail: Unhandled WebSocketConnectionClosedException: socket is already closed.
Traceback (most recent call last):
  File "/usr/local/autotest/common_lib/test.py", line 800, in _call_test_function
    return func(*args, **dargs)
  File "/usr/local/autotest/common_lib/test.py", line 464, in execute
    postprocess_profiled_run, args, dargs)
  File "/usr/local/autotest/common_lib/test.py", line 371, in _call_run_once
    self.run_once(*args, **dargs)
  File "/usr/local/autotest/tests/login_GaiaLogin/login_GaiaLogin.py", line 25, in run_once
    password=password) as cr:
  File "/usr/local/autotest/common_lib/cros/chrome.py", line 179, in __init__
    self._browser = self._browser_to_create.Create()
  File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome/cros_browser_finder.py", line 103, in Create
    browser_backend, self._platform_backend, startup_args)
  File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome/cros_browser_with_oobe.py", line 14, in __init__
    backend, platform_backend, startup_args)
  File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/browser/browser.py", line 48, in __init__
    self._browser_backend.Start(startup_args, startup_url=startup_url)
  File "/usr/local/telemetry/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 52, in traced_function
    return func(*args, **kwargs)
  File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome/cros_browser_backend.py", line 97, in Start
    self.oobe.NavigateGaiaLogin(self._username, self._password)
  File "/usr/local/telemetry/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 52, in traced_function
    return func(*args, **kwargs)
  File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome/oobe.py", line 92, in NavigateGaiaLogin
    wait_for_close=not enterprise_enroll)
  File "/usr/local/telemetry/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 52, in traced_function
    return func(*args, **kwargs)
  File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome/oobe.py", line 104, in _NavigateWebviewLogin
    py_utils.WaitFor(lambda: not self._GaiaWebviewContext(), 60)
  File "/usr/local/telemetry/src/third_party/catapult/common/py_utils/py_utils/__init__.py", line 136, in WaitFor
    res = condition()
  File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome/oobe.py", line 104, in <lambda>
    py_utils.WaitFor(lambda: not self._GaiaWebviewContext(), 60)
  File "/usr/local/telemetry/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 52, in traced_function
    return func(*args, **kwargs)
  File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome/oobe.py", line 32, in _GaiaWebviewContext
    py_utils.WaitFor(webview.HasReachedQuiescence, 20)
  File "/usr/local/telemetry/src/third_party/catapult/common/py_utils/py_utils/__init__.py", line 129, in WaitFor
    res = condition()
  File "/usr/local/telemetry/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 52, in traced_function
    return func(*args, **kwargs)
  File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/browser/web_contents.py", line 137, in HasReachedQuiescence
    script=self._quiescence_js)
  File "/usr/local/telemetry/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 52, in traced_function
    return func(*args, **kwargs)
  File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/browser/web_contents.py", line 215, in EvaluateJavaScript
    return self._inspector_backend.EvaluateJavaScript(*args, **kwargs)
  File "/usr/local/telemetry/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 52, in traced_function
    return func(*args, **kwargs)
  File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_backend.py", line 251, in EvaluateJavaScript
    return self._EvaluateJavaScript(expression, context_id, timeout)
  File "/usr/local/telemetry/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 52, in traced_function
    return func(*args, **kwargs)
  File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_backend.py", line 37, in Inner
    return func(inspector_backend, *args, **kwargs)
  File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_backend.py", line 533, in _EvaluateJavaScript
    self._runtime.Crash(context_id, timeout)
  File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_runtime.py", line 81, in Crash
    res = self._inspector_websocket.SyncRequest(request, timeout)
  File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_websocket.py", line 127, in SyncRequest
    self._SendRequest(req)
  File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_websocket.py", line 115, in _SendRequest
    self._socket.send(data)
  File "/usr/local/telemetry/src/third_party/catapult/telemetry/third_party/websocket-client/websocket/_core.py", line 234, in send
    return self.send_frame(frame)
  File "/usr/local/telemetry/src/third_party/catapult/telemetry/third_party/websocket-client/websocket/_core.py", line 259, in send_frame
    l = self._send(data)
  File "/usr/local/telemetry/src/third_party/catapult/telemetry/third_party/websocket-client/websocket/_core.py", line 423, in _send
    return send(self.sock, data)
  File "/usr/local/telemetry/src/third_party/catapult/telemetry/third_party/websocket-client/websocket/_socket.py", line 113, in send
    raise WebSocketConnectionClosedException("socket is already closed.")
WebSocketConnectionClosedException: socket is already closed.

Comment 2 by achuith@chromium.org, Aug 31

Components: -Tests Tests>Telemetry
Owner: achuith@chromium.org
Status: Started (was: Untriaged)
https://chromium-review.googlesource.com/c/catapult/+/1197749
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 31 

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/e0f3ba1f4ce2c24058479e0a870356bdd06aacca

commit e0f3ba1f4ce2c24058479e0a870356bdd06aacca
Author: Achuith Bhandarkar <achuith@chromium.org>
Date: Fri Aug 31 00:59:35 2018

oobe: Catch WebSocketException.

BUG= chromium:879353 
TEST=login_GaiaLogin
TBR=nednguyen@google.com

Change-Id: I91d0bcce7810e58addcd4b911a5b0e9f556bbfd2
Reviewed-on: https://chromium-review.googlesource.com/1197749
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Achuith Bhandarkar <achuith@chromium.org>

[modify] https://crrev.com/e0f3ba1f4ce2c24058479e0a870356bdd06aacca/BUILD.gn
[modify] https://crrev.com/e0f3ba1f4ce2c24058479e0a870356bdd06aacca/telemetry/telemetry/internal/backends/chrome/oobe.py
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 31 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f5ecfadbfbe840879ffd14f32cbd126c9fea6df9

commit f5ecfadbfbe840879ffd14f32cbd126c9fea6df9
Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Fri Aug 31 19:46:30 2018

Roll src/third_party/catapult cd6bcbe53ba7..6fc719e87628 (6 commits)

https://chromium.googlesource.com/catapult.git/+log/cd6bcbe53ba7..6fc719e87628


git log cd6bcbe53ba7..6fc719e87628 --date=short --no-merges --format='%ad %ae %s'
2018-08-31 zmo@chromium.org Remove removed folder from telemetry isolate
2018-08-31 chiniforooshan@chromium.org Tracing: Fix an input latency bug
2018-08-31 pasko@chromium.org devil: refactor perf_control.py for upcoming N5X support
2018-08-31 anthonyalridge@google.com Improve dot stacking algoritm to handle small numbers.
2018-08-31 anthonyalridge@google.com Flip axes for CFG.
2018-08-31 achuith@chromium.org oobe: Catch WebSocketException.


Created with:
  gclient setdep -r src/third_party/catapult@6fc719e87628

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:879523 ,chromium:383566,chromium:866423,chromium:866423, chromium:879353 
TBR=sullivan@chromium.org

Change-Id: Ieb839c3ef97435a3479cfb2b98d5441308e1dd70
Reviewed-on: https://chromium-review.googlesource.com/1199691
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#588128}
[modify] https://crrev.com/f5ecfadbfbe840879ffd14f32cbd126c9fea6df9/DEPS

Comment 6 by djacobo@chromium.org, Sep 5

Cc: djacobo@chromium.org elijahtaylor@chromium.org lpique@chromium.org edcourtney@chromium.org ricardoq@chromium.org khmel@chromium.org kinaba@chromium.org
 Issue 878689  has been merged into this issue.

Comment 7 by djacobo@chromium.org, Sep 5 

Chrome hasn't rolled in a few days, we can only wait for now.

Comment 8 by djacobo@google.com, Sep 17

Cc: erosky@chromium.org kroot@chromium.org
+ arc++ constables. Since this may be blocking a few tests

Comment 9 by chinglinyu@chromium.org, Sep 18 

Issue 884641 has been merged into this issue.

Comment 10 by achuith@chromium.org, Sep 18 

Latest runs of login_GaiaLogin:
https://stainless.corp.google.com/search?test=%5Elogin%5C_GaiaLogin%24&exclude_non_release=false&exclude_cts=true&col=build&row=board_model&view=matrix&first_date=2018-09-12&last_date=2018-09-18

Now there's a: Unhandled TimeoutException:

Stack:
raceback (most recent call last):
  File "/usr/local/autotest/common_lib/test.py", line 800, in _call_test_function
    return func(*args, **dargs)
  File "/usr/local/autotest/common_lib/test.py", line 464, in execute
    postprocess_profiled_run, args, dargs)
  File "/usr/local/autotest/common_lib/test.py", line 371, in _call_run_once
    self.run_once(*args, **dargs)
  File "/usr/local/autotest/tests/login_GaiaLogin/login_GaiaLogin.py", line 25, in run_once
    password=password) as cr:
  File "/usr/local/autotest/common_lib/cros/chrome.py", line 179, in __init__
    self._browser = self._browser_to_create.Create()
  File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome/cros_browser_finder.py", line 103, in Create
    browser_backend, self._platform_backend, startup_args)
  File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome/cros_browser_with_oobe.py", line 14, in __init__
    backend, platform_backend, startup_args)
  File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/browser/browser.py", line 48, in __init__
    self._browser_backend.Start(startup_args, startup_url=startup_url)
  File "/usr/local/telemetry/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 52, in traced_function
    return func(*args, **kwargs)
  File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome/cros_browser_backend.py", line 97, in Start
    self.oobe.NavigateGaiaLogin(self._username, self._password)
  File "/usr/local/telemetry/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 52, in traced_function
    return func(*args, **kwargs)
  File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome/oobe.py", line 94, in NavigateGaiaLogin
    wait_for_close=not enterprise_enroll)
  File "/usr/local/telemetry/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 52, in traced_function
    return func(*args, **kwargs)
  File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome/oobe.py", line 106, in _NavigateWebviewLogin
    py_utils.WaitFor(lambda: not self._GaiaWebviewContext(), 60)
  File "/usr/local/telemetry/src/third_party/catapult/common/py_utils/py_utils/__init__.py", line 136, in WaitFor
    res = condition()
  File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome/oobe.py", line 106, in <lambda>
    py_utils.WaitFor(lambda: not self._GaiaWebviewContext(), 60)
  File "/usr/local/telemetry/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 52, in traced_function
    return func(*args, **kwargs)
  File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome/oobe.py", line 33, in _GaiaWebviewContext
    py_utils.WaitFor(webview.HasReachedQuiescence, 20)
  File "/usr/local/telemetry/src/third_party/catapult/common/py_utils/py_utils/__init__.py", line 129, in WaitFor
    res = condition()
  File "/usr/local/telemetry/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 52, in traced_function
    return func(*args, **kwargs)
  File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/browser/web_contents.py", line 137, in HasReachedQuiescence
    script=self._quiescence_js)
  File "/usr/local/telemetry/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 52, in traced_function
    return func(*args, **kwargs)
  File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/browser/web_contents.py", line 215, in EvaluateJavaScript
    return self._inspector_backend.EvaluateJavaScript(*args, **kwargs)
  File "/usr/local/telemetry/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 52, in traced_function
    return func(*args, **kwargs)
  File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_backend.py", line 253, in EvaluateJavaScript
    return self._EvaluateJavaScript(expression, context_id, timeout)
  File "/usr/local/telemetry/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 52, in traced_function
    return func(*args, **kwargs)
  File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_backend.py", line 41, in Inner
    inspector_backend._ConvertExceptionFromInspectorWebsocket(e)
  File "/usr/local/telemetry/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 52, in traced_function
    return func(*args, **kwargs)
  File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_backend.py", line 38, in Inner
    return func(inspector_backend, *args, **kwargs)
  File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_backend.py", line 540, in _EvaluateJavaScript
    self._runtime.Crash(context_id, timeout)
  File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_runtime.py", line 81, in Crash
    res = self._inspector_websocket.SyncRequest(request, timeout)
  File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_websocket.py", line 129, in SyncRequest
    self._SendRequest(req)
  File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_websocket.py", line 119, in _SendRequest
    raise WebSocketException(err)
TimeoutException:
Project Member

Comment 12 by bugdroid1@chromium.org, Sep 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/c04a4a145bf4606ab6a7dffcc98a86258b17b111

commit c04a4a145bf4606ab6a7dffcc98a86258b17b111
Author: Achuith Bhandarkar <achuith@chromium.org>
Date: Tue Sep 18 23:08:30 2018

oobe: Catch WebSocketException instead.

Stack: https://bugs.chromium.org/p/chromium/issues/detail?id=879353#c10

BUG= chromium:879353 
TBR=nednguyen

Change-Id: I296b5202a25cad8937e157db1182aa48f84676e0
Reviewed-on: https://chromium-review.googlesource.com/1230773
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Commit-Queue: Achuith Bhandarkar <achuith@chromium.org>

[modify] https://crrev.com/c04a4a145bf4606ab6a7dffcc98a86258b17b111/telemetry/telemetry/internal/backends/chrome/oobe.py
Project Member

Comment 13 by bugdroid1@chromium.org, Sep 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/20136a68eadb1aaeda4252b590f0bcc047c04ebe

commit 20136a68eadb1aaeda4252b590f0bcc047c04ebe
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Wed Sep 19 18:59:44 2018

Roll src/third_party/catapult c968ea0b6538..92ef0386b8b6 (15 commits)

https://chromium.googlesource.com/catapult.git/+log/c968ea0b6538..92ef0386b8b6


git log c968ea0b6538..92ef0386b8b6 --date=short --no-merges --format='%ad %ae %s'
2018-09-19 dtu@chromium.org [pinpoint] Data migration basic error handling.
2018-09-19 dtu@chromium.org [pinpoint] Basic stats page.
2018-09-19 dtu@chromium.org [pinpoint] Update fields in Jobs table.
2018-09-19 cbruni@chromium.org results2.html debounce search
2018-09-19 simonhatch@chromium.org Dashboard - Fix alert and comparison_magnitude.
2018-09-19 simonhatch@chromium.org Dashboard - Replace last_alerted_revision with query
2018-09-19 slobodan@google.com Fixing frames in animations following response.
2018-09-19 pasko@chromium.org androidStartupMetric: remove the FCP
2018-09-18 dtu@chromium.org [pinpoint] Remove unused <job-chart-icon> import.
2018-09-18 achuith@chromium.org oobe: Catch WebSocketException instead.
2018-09-18 dtu@chromium.org [pinpoint] Remove list of differences and reformat arguments list.
2018-09-18 sadrul@chromium.org rendering: Remove some redundant mean_ metrics.
2018-09-18 sadrul@chromium.org rendering: Remove discrepancy metrics.
2018-09-18 chiniforooshan@chromium.org Telemetry: Fix SF events
2018-09-18 mattm@chromium.org netlog_viewer/README.md: Re-order with user-focused sections at top.


Created with:
  gclient setdep -r src/third_party/catapult@92ef0386b8b6

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:878390, chromium:868073 , chromium:883079 ,chromium:883715, chromium:886621 , chromium:879353 , chromium:884950 , chromium:884950 , chromium:863926 
TBR=sullivan@chromium.org

Change-Id: I9fa8e95d9aad524c032b0bf637dfc07926ce7795
Reviewed-on: https://chromium-review.googlesource.com/1234576
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#592499}
[modify] https://crrev.com/20136a68eadb1aaeda4252b590f0bcc047c04ebe/DEPS

Comment 14 by tbroch@chromium.org, Oct 2 

Believe this failure is also affecting power_LoadTest ( b/117113236 ) results.

Comment 15 by kinaba@chromium.org, Oct 2 

ARC Constable this week:
https://stainless.corp.google.com/search?view=list&first_date=2018-09-30&last_date=2018-10-02&status=ERROR&reason=Unhandled+TimeoutException%3A&exclude_cts=true&exclude_not_run=false&exclude_non_release=true&exclude_au=true&exclude_acts=true&exclude_retried=true&exclude_non_production=false


Does it now need to be
   inspector_websocket.WebSocketException
instead of 
   WebSocketException (which is websocket.WebSocketException)
if we were to catch anything?

https://chromium-review.googlesource.com/c/catapult/+/1214865
seems converting every one of the latter to inspector_websocket.WebSocketException.


Though I'm not familiar with what this catch'em all statement is trying to achieve...

Comment 16 by kinaba@chromium.org, Oct 2 

Ah so it is waiting for self._GaiaWebviewContext() to fail returning null, to detect that the WebView is gone:
https://cs.chromium.org/chromium/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome/oobe.py?type=cs&q=gaiastaging.corp.google.com&sq=package:chromium&g=0&l=106
but instead it is failing by Exception. Yeah, I now started thinking more that #15 is the right direction.
Project Member

Comment 18 by bugdroid1@chromium.org, Oct 2 

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/48348e91f2d7f761ba62f0e40b8227c924d7d7a3

commit 48348e91f2d7f761ba62f0e40b8227c924d7d7a3
Author: Achuith Bhandarkar <achuith@chromium.org>
Date: Tue Oct 02 12:10:58 2018

oobe: Catch the right WebSocketException.

BUG= chromium:879353 
TEST=testGaiaLogin
TBR=nednguyen

Change-Id: Ia2d02d734a1e3869265a28bfc74cb25e89e7ed40
Reviewed-on: https://chromium-review.googlesource.com/1256722
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Commit-Queue: Achuith Bhandarkar <achuith@chromium.org>

[modify] https://crrev.com/48348e91f2d7f761ba62f0e40b8227c924d7d7a3/telemetry/telemetry/internal/backends/chrome/oobe.py
Project Member

Comment 19 by bugdroid1@chromium.org, Oct 2 

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/a115d8de1c986bb73971deac71ee74a5721c32de

commit a115d8de1c986bb73971deac71ee74a5721c32de
Author: Achuith Bhandarkar <achuith@chromium.org>
Date: Tue Oct 02 12:11:28 2018

cros_unittest: Update test gaia account.

Other fixes.

BUG= chromium:879353 
TEST=testGaiaLogin
TBR=nednguyen

Change-Id: Ibe0fa197af2b0a501641e741b0a3e57a781f0002
Reviewed-on: https://chromium-review.googlesource.com/1256723
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Commit-Queue: Achuith Bhandarkar <achuith@chromium.org>

[modify] https://crrev.com/a115d8de1c986bb73971deac71ee74a5721c32de/telemetry/telemetry/internal/backends/chrome/cros_unittest.py
Project Member

Comment 20 by bugdroid1@chromium.org, Oct 2 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8be012447d4cf4b24c1e8cf6de82506fb9def09b

commit 8be012447d4cf4b24c1e8cf6de82506fb9def09b
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Tue Oct 02 14:53:16 2018

Roll src/third_party/catapult 59297c6f73a6..48348e91f2d7 (1 commits)

https://chromium.googlesource.com/catapult.git/+log/59297c6f73a6..48348e91f2d7


git log 59297c6f73a6..48348e91f2d7 --date=short --no-merges --format='%ad %ae %s'
2018-10-02 achuith@chromium.org oobe: Catch the right WebSocketException.


Created with:
  gclient setdep -r src/third_party/catapult@48348e91f2d7

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:879353 
TBR=sullivan@chromium.org

Change-Id: Ie2201501881dfd170f964cf9312fecef7f48e59e
Reviewed-on: https://chromium-review.googlesource.com/1256238
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#595833}
[modify] https://crrev.com/8be012447d4cf4b24c1e8cf6de82506fb9def09b/DEPS
Project Member

Comment 21 by bugdroid1@chromium.org, Oct 2 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bff4719f8ebc8939fe3d06a05429f5e32bdbf842

commit bff4719f8ebc8939fe3d06a05429f5e32bdbf842
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Tue Oct 02 17:20:08 2018

Roll src/third_party/catapult 48348e91f2d7..a115d8de1c98 (1 commits)

https://chromium.googlesource.com/catapult.git/+log/48348e91f2d7..a115d8de1c98


git log 48348e91f2d7..a115d8de1c98 --date=short --no-merges --format='%ad %ae %s'
2018-10-02 achuith@chromium.org cros_unittest: Update test gaia account.


Created with:
  gclient setdep -r src/third_party/catapult@a115d8de1c98

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:879353 
TBR=sullivan@chromium.org

Change-Id: Ibe3bc0fe3b14f5f805d4bf4b0421dbd07a7c575d
Reviewed-on: https://chromium-review.googlesource.com/1256081
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#595889}
[modify] https://crrev.com/bff4719f8ebc8939fe3d06a05429f5e32bdbf842/DEPS

Comment 22 by khmel@chromium.org, Oct 3 

From my investigation it seems I found the problem.

It comes from:

    if wait_for_close:
      py_utils.WaitFor(lambda: not self._GaiaWebviewContext(), 20)

This part of code waits for OOBE close IIUC

However in _GaiaWebviewContext we are passing:

      except (exceptions.DevtoolsTargetCrashException,
              WebSocketException):
        pass

In some case WebSocketException is converted to TimeoutException
IIUC this may happen if webview is already closed and we are trying to check it.

...
for webview in webview_contexts:
...

I tried locally to pass TimeoutException as well and it unblocks the problem.

Comment 23 by khmel@chromium.org, Oct 3 

suggested CL: crrev.com/c/1259390
Project Member

Comment 25 by bugdroid1@chromium.org, Oct 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/0543f082e2f420a4c4f3835ef085befa326a1e4e

commit 0543f082e2f420a4c4f3835ef085befa326a1e4e
Author: khmel@chromium.org <khmel@chromium.org>
Date: Wed Oct 03 23:33:16 2018

Fix flakiness of tests, that require GAIA login.

Handle TimeoutException that is raised when the webview is closed but
we are trying to communicate. Websocket exception internally converted
to timeout exception.

Test: Flaky tests are passing.
Bug:  879353 

Change-Id: I17d4a313d6cfd809c47b101010ac6d1fe1f64faf
Reviewed-on: https://chromium-review.googlesource.com/c/1259390
Commit-Queue: Yury Khmel <khmel@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Auto-Submit: Yury Khmel <khmel@chromium.org>

[modify] https://crrev.com/0543f082e2f420a4c4f3835ef085befa326a1e4e/telemetry/telemetry/internal/backends/chrome/oobe.py
Project Member

Comment 26 by bugdroid1@chromium.org, Oct 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8fbe05fb32cf430baa5ff7f13704f6bee7abeab4

commit 8fbe05fb32cf430baa5ff7f13704f6bee7abeab4
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Thu Oct 04 03:52:41 2018

Roll src/third_party/catapult 2dd914402ebc..0543f082e2f4 (7 commits)

https://chromium.googlesource.com/catapult.git/+log/2dd914402ebc..0543f082e2f4


git log 2dd914402ebc..0543f082e2f4 --date=short --no-merges --format='%ad %ae %s'
2018-10-03 khmel@chromium.org Fix flakiness of tests, that require GAIA login.
2018-10-03 kylechar@chromium.org Support macOS 10.14 Mojave.
2018-10-03 zmo@chromium.org Revert "Wire action_runner's Click through DevTools"
2018-10-03 chiniforooshan@chromium.org Telemetry: clean up legacy surface flinger metrics
2018-10-03 pasko@chromium.org androidStartupMetric: skip the first start
2018-10-03 benjhayden@chromium.org Fix flaky cp-toast.autoclose-only-last test.
2018-10-03 zmo@chromium.org Wire action_runner's Click through DevTools


Created with:
  gclient setdep -r src/third_party/catapult@0543f082e2f4

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:879353 , chromium:890951 ,chromium:885912, chromium:890757 , chromium:881384 ,chromium:885912
TBR=sullivan@chromium.org

Change-Id: I6e2ae7a29df4dcab18c0cde1e852ee159a3f12cf
Reviewed-on: https://chromium-review.googlesource.com/c/1260146
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#596495}
[modify] https://crrev.com/8fbe05fb32cf430baa5ff7f13704f6bee7abeab4/DEPS

Comment 27 by khmel@chromium.org, Oct 9

Owner: khmel@chromium.org

Comment 29 by khmel@chromium.org, Oct 9

Status: Fixed (was: Started)

Comment 31 by khmel@chromium.org, Oct 19

Status: Fixed (was: Assigned)
I don't think it is possible to M70 merge once this requires catapult roll with cumulatively a lot of changes. M71 is fully green.

Comment 32 by khmel@chromium.org, Oct 19

Labels: M-71
►

Sign in to add a comment