Autocomplete is activating when it should not
Reported by
okaybe...@gmail.com,
Aug 30
|
||||||||||
Issue description
UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/68.0.3440.106 Safari/537.36
Steps to reproduce the problem:
1. In the JavaScript console, enter the following:
const Test = function() {
this.apple = 1;
};
Test.prototype.a = 2;
const test = new Test();
2. Try to access test.a by typing the following in the console then hitting enter/return:
test.a
What is the expected behavior?
The console logs the value of test.a.
What went wrong?
The console auto-completes to test.apple.
Did this work before? Yes I'm not sure. I believe this started sometime this month.
Chrome version: 68.0.3440.106 Channel: stable
OS Version: OS X 10.13.6
Flash Version:
,
Aug 31
okaybenji@ Thanks for the update. Able to reproduce this issue on Windows 10, Mac OS 10.13.3 and Ubuntu 17.10 on the reported version 68.0.3440.106 and latest Canary 70.0.3538.0. Bisect Information: =================== Good Build: 68.0.3417.0 Bad Build : 68.0.3418.0 By running per-revision bisect script, RunTimeError was coming up. Hence by running Chromium bisect below is the Changelog URL. https://chromium.googlesource.com/chromium/src/+log/210f7ed9add7087876cf56825cb326df73a59b4b..9cf9c0c56edce812ea5cf934aff4bbc7d571c9b6 From the above Changelog, suspecting the below change: Reviewed-on: https://chromium-review.googlesource.com/1026838 einbinder@ Please check and confirm if this issue is related to your change, else help us in assigning to the right owner. Adding 'ReleaseBlock-Stable' for M-69 as this is a recent regression. Please feel free to remove if it is not applicable. Thanks
,
Aug 31
This is regressed in M68 and we already cut M69 stable RC. Pls target fix for M70.
,
Sep 5
Friendly ping to get an update on this issue. Thanks..!
,
Sep 6
,
Sep 6
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/101464900ae8093c7a343f3a2642e8c17540f31b commit 101464900ae8093c7a343f3a2642e8c17540f31b Author: Joel Einbinder <einbinder@chromium.org> Date: Thu Sep 06 23:15:45 2018 DevTools: Select exact matches before other items in autocomplete. This makes sure that if the user types in a property exactly, it will always be the default selected suggested item. Bug: 879351 Change-Id: I4425e105ff9381e164b3455f5e727c28e3b2d931 Reviewed-on: https://chromium-review.googlesource.com/1211862 Commit-Queue: Joel Einbinder <einbinder@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#589358} [modify] https://crrev.com/101464900ae8093c7a343f3a2642e8c17540f31b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-correct-suggestions-expected.txt [modify] https://crrev.com/101464900ae8093c7a343f3a2642e8c17540f31b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-correct-suggestions.js [modify] https://crrev.com/101464900ae8093c7a343f3a2642e8c17540f31b/third_party/blink/renderer/devtools/front_end/object_ui/JavaScriptAutocomplete.js
,
Sep 28
,
Oct 1
[bulk edit] - This issue is marked as a stable blocker for M70. We are two weeks away from M70 Stable. Please take a look urgently!
,
Oct 2
We should consider merging this to M70. Joel can you please confirm if this a safe merge and do you agree we should merge this?
,
Oct 4
,
Oct 4
This bug requires manual review: We are only 11 days from stable. Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 4
,
Oct 8
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e59661c753fc93070dfac20c53b93c3928c7e003 commit e59661c753fc93070dfac20c53b93c3928c7e003 Author: Joel Einbinder <einbinder@chromium.org> Date: Tue Oct 09 18:40:41 2018 DevTools: Select exact matches before other items in autocomplete. This makes sure that if the user types in a property exactly, it will always be the default selected suggested item. Bug: 879351 Change-Id: I4425e105ff9381e164b3455f5e727c28e3b2d931 Reviewed-on: https://chromium-review.googlesource.com/1211862 Commit-Queue: Joel Einbinder <einbinder@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#589358}(cherry picked from commit 101464900ae8093c7a343f3a2642e8c17540f31b) Reviewed-on: https://chromium-review.googlesource.com/c/1271406 Reviewed-by: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#924} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/e59661c753fc93070dfac20c53b93c3928c7e003/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-correct-suggestions-expected.txt [modify] https://crrev.com/e59661c753fc93070dfac20c53b93c3928c7e003/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-correct-suggestions.js [modify] https://crrev.com/e59661c753fc93070dfac20c53b93c3928c7e003/third_party/blink/renderer/devtools/front_end/object_ui/JavaScriptAutocomplete.js
,
Oct 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e59661c753fc93070dfac20c53b93c3928c7e003 Commit: e59661c753fc93070dfac20c53b93c3928c7e003 Author: einbinder@chromium.org Commiter: einbinder@chromium.org Date: 2018-10-09 18:40:41 +0000 UTC DevTools: Select exact matches before other items in autocomplete. This makes sure that if the user types in a property exactly, it will always be the default selected suggested item. Bug: 879351 Change-Id: I4425e105ff9381e164b3455f5e727c28e3b2d931 Reviewed-on: https://chromium-review.googlesource.com/1211862 Commit-Queue: Joel Einbinder <einbinder@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#589358}(cherry picked from commit 101464900ae8093c7a343f3a2642e8c17540f31b) Reviewed-on: https://chromium-review.googlesource.com/c/1271406 Reviewed-by: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#924} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by vamshi.kommuri@chromium.org
, Aug 31