DownloadManagerTestCase/testDownloadWhileBrowsing Is flaky on iOS11 |
||
Issue descriptionI've encountered flake from this test while trying to land CLs via the CQ, but for whatever reason, it doesn't look like this is happening on the waterfall. Running the test on iPhoneX iOS 11.3 simulator at ToT seems to consistently reproduce the failure locally. Here is an example failure from trying to CQ crrev.com/c/1148596: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8936746759699251920/+/steps/ios_chrome_ui_egtests__iPhone_X_iOS_11.4__shard_0/0/logs/DownloadManagerTestCase__x2f_testDownloadWhileBrowsing/0 Inspecting the hierarchy printout, it looks like only 22KB of the file has finished downloading when the wait condition quits.
,
Aug 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/81765dd454496fa095fe0e7a5a7569f20f706356 commit 81765dd454496fa095fe0e7a5a7569f20f706356 Author: Kurt Horimoto <kkhorimoto@chromium.org> Date: Thu Aug 30 23:40:02 2018 [iOS] Increase wait time for download manager tests. This CL increases kLongDownloadTimeout from 25 to 35 seconds in order to reduce flake caued by long download times on iOS 11. Bug: 879344 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ic26dbb5ca96129e0696db4e9343fedf2a7a81b59 Reviewed-on: https://chromium-review.googlesource.com/1197762 Reviewed-by: Peter Lee <pkl@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#587846} [modify] https://crrev.com/81765dd454496fa095fe0e7a5a7569f20f706356/ios/chrome/browser/ui/download/download_manager_egtest.mm
,
Sep 4
Thanks Kurt for fixing the local failure! |
||
►
Sign in to add a comment |
||
Comment 1 by kkhorimoto@chromium.org
, Aug 30