Autofill toggles should say "Save and fill" instead of "Remember" |
||||||||||
Issue descriptionChrome Version: M70 OS: all On the Addresses autofill settings page, the toggle should be "Save and fill addresses" instead of "Remember addresses and other information". Same for the the Payment methods autofill settings page, which should have "Save and fill payment methods" instead of "Remember payment methods". Filing a separate bug in case the CL needs to be merged to M70.
,
Aug 31
These string changes was discussed with srahim@ and we'd like to use them instead for M70; they were landed a few commits after branch point.
,
Aug 31
This bug requires manual review: There is .grd file changes and we are only 45 days from stable. Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 4
Adding OS labels.
,
Sep 4
,
Sep 5
Here's a summary of the rules that were executed: - OnlyMergeApprovedChange: Rule Failed -- Revision cb768b7d9df9f5a442522f2262ecdf29d001f605 was merged to refs/branch-heads/3538 branch with no merge approval from a TPM! Please explain why this change was merged to the branch!
,
Sep 5
,
Sep 5
Merged CL: https://chromium.googlesource.com/chromium/src/+/cb768b7d9df9f5a442522f2262ecdf29d001f605 Marking this as fixed.
,
Sep 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cb768b7d9df9f5a442522f2262ecdf29d001f605 commit cb768b7d9df9f5a442522f2262ecdf29d001f605 Author: Fabio Tirelo <ftirelo@chromium.org> Date: Wed Sep 05 16:23:44 2018 [Merge M70][Autofill] Replace 'remember' with 'save and fill' on toggles Bug: 879342 Change-Id: Ic2451cdbaa221f0dcd844c29ed8b732d68dc7d76 Reviewed-on: https://chromium-review.googlesource.com/1197360 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#587854}(cherry picked from commit 32c9ffb4811bc4e0bedfcd322b69aab5301352c1) Reviewed-on: https://chromium-review.googlesource.com/1205718 Reviewed-by: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#47} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/cb768b7d9df9f5a442522f2262ecdf29d001f605/components/autofill_strings.grdp
,
Sep 6
Able to reproduce this issue on Windows 10, Mac OS 10.13.3 and Ubuntu 17.10 on the build without fix 70.0.3532.0 and the issue is fixed on the latest M-70 build 70.0.3538.9. Can observe that the toggle is displayed as "Save and fill addresses" in chrome://settings/autofill page. Attached is the screen shot for reference. Hence adding TE verified labels as the fix is working as intended. Thanks..
,
Oct 5
Tested in 70.0.3538.40 Beta in iPhone 8plus(iOS 11.4.1), iPhone 6 plus(iOS 12) and iPad Air(iOS 11.4.1) On the Addresses autofill settings page, the toggle displayed as "Save and fill addresses" and in Payment methods autofill settings page toggle displayed as "Save and fill payment methods", looks good |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by bugdroid1@chromium.org
, Aug 30