Do not show market opt-in screen for non-regular ephemeral users |
|||||
Issue descriptionPer offline chat with alemate@, we will do something similar with https://cs.chromium.org/chromium/src/chrome/browser/chromeos/login/screens/sync_consent_screen.cc?type=cs&q=ephemeral+file:%5Esrc/chrome/browser/chromeos/login/screens/+package:%5Echromium$&g=0&l=135 But we should consider another approach when rewriting OOBE.
,
Aug 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3279bfda61401e969fa047bbe002c32d46ef9735 commit 3279bfda61401e969fa047bbe002c32d46ef9735 Author: Wenzhao Zang <wzang@chromium.org> Date: Fri Aug 31 03:33:04 2018 cros: Skip market opt-in screen for non-regular ephemeral users Bug: 879310 Change-Id: I65ac6b822e1fadd9440189a3e11c6d4fa118ec8f Reviewed-on: https://chromium-review.googlesource.com/1198762 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#587934} [modify] https://crrev.com/3279bfda61401e969fa047bbe002c32d46ef9735/chrome/browser/chromeos/login/wizard_controller.cc
,
Aug 31
,
Sep 4
,
Sep 5
Your change meets the bar and is auto-approved for M70. Please go ahead and merge the CL to branch 3538 manually. Please contact milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/251584bbee7f3787097bceab04d6181920918f88 commit 251584bbee7f3787097bceab04d6181920918f88 Author: Wenzhao Zang <wzang@chromium.org> Date: Wed Sep 05 22:06:19 2018 [Merge to M70] cros: Skip market opt-in screen for non-regular ephemeral users TBR=wzang@chromium.org (cherry picked from commit 3279bfda61401e969fa047bbe002c32d46ef9735) Bug: 879310 Change-Id: I65ac6b822e1fadd9440189a3e11c6d4fa118ec8f Reviewed-on: https://chromium-review.googlesource.com/1198762 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by: Alexander Alekseev <alemate@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#587934} Reviewed-on: https://chromium-review.googlesource.com/1208813 Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#70} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/251584bbee7f3787097bceab04d6181920918f88/chrome/browser/chromeos/login/wizard_controller.cc |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by wzang@chromium.org
, Aug 30