Wire up viz hit test for ws2 |
|||||
Issue descriptionOne of the the things lost in the switch to ws2 was support for viz hit testing. We need this to properly support OOPIFs.
,
Aug 31
Sure! What's the current status with viz hit-testing on ws2? I remember we had basic cases working with mus but had some issues e.g. having multiple hit-test regions for one window. I can take a closer look next week, what's the expected timeline for ws2?
,
Aug 31
,
Aug 31
ws2 (now in services/ws) does not use viz hit testing at all, and needs to. ws2 is used for a couple of things now, but as none of them embed webcontents it's not an issue yet. The first milestone we are targetting to use webcontents is single-process-mash, which is still about a quarter away.
,
Sep 7
,
Oct 3
As content is no longer using the window service for single-process-mash, this is no longer a priority for single process mash. We will need to fix it for multi process mash though. Retargetting.
,
Oct 31
The browser test PDFExtensionHitTestTest.MouseLeave/1 still fails with --enable-features=SingleProcessMash (the 1 param means features::kEnableVizHitTestDrawQuad is enabled --- the version with it disabled works fine).
,
Oct 31
Does https://chromium-review.googlesource.com/c/chromium/src/+/1308915 impact this?
,
Nov 1
,
Nov 6
re #8: yep, seems fixed now
,
Nov 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1413cd02755ee9cb4a3ec81ed8938ff66f000186 commit 1413cd02755ee9cb4a3ec81ed8938ff66f000186 Author: Evan Stade <estade@chromium.org> Date: Wed Nov 07 01:30:54 2018 Mash: enable PDFExtensionHitTestTest.MouseLeave/1 Works after 127968d6a7627b3cd3995ee1070c03e65bd6f9f2 Bug: 879308 Change-Id: Ic49eb7e0a1af70cf0701930631c6956069d4e709 Reviewed-on: https://chromium-review.googlesource.com/c/1321572 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#605917} [modify] https://crrev.com/1413cd02755ee9cb4a3ec81ed8938ff66f000186/testing/buildbot/filters/chromeos.single_process_mash.browser_tests.filter |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by sky@chromium.org
, Aug 30