New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 879300 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 6
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

win32-rel compile flaky

Project Member Reported by martiniss@chromium.org, Aug 30

Issue description

win32-rel compile seems to be flaking some recently. Here are the flaky builds:

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/win32-rel/1796 -- error message is:
In file included from ../../chrome/services/printing/pdf_nup_converter.cc:12:
../..\components/crash/core/common/crash_key.h(16,10):  fatal error: 'components/crash/core/common/crash_buildflags.h' file not found
#include "components/crash/core/common/crash_buildflags.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

Don't see anything suspicious in the blame list.


https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/win32-rel/1755 -- error message is:
[6305/75212] LINK test_opus_api.exe test_opus_api.exe.pdb
FAILED: test_opus_api.exe test_opus_api.exe.pdb 
ninja -t msvc -e environment.x86 -- ../../third_party/llvm-build/Release+Asserts/bin/lld-link.exe /nologo /OUT:./test_opus_api.exe /PDB:./test_opus_api.exe.pdb @./test_opus_api.exe.rsp
lld-link.exe: error: ExecuteAndWait failed: C:\b\swarming\w\ir\cache\builder\src\third_party\depot_tools\win_toolchain\vs_files\3bc0ec615cf20ee342f3bc29bc991b5ad66d8d2c\win_sdk\bin\10.0.17134.0\x64\mt.exe /manifest C:\b\swarming\w\ir\tmp\t\lld-defaultxml-6e8f62.manifest /manifest ../../build/win/as_invoker.manifest /manifest ../../build/win/common_controls.manifest /manifest ../../build/win/compatibility.manifest /nologo /out:C:\b\swarming\w\ir\tmp\t\lld-user-4d9d47.manifest

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/win32-rel/1733 -- error message is:

[6431/75140] LINK glibc_x86/ppapi_ppb_core_glibc_x86_32.nexe
FAILED: glibc_x86/ppapi_ppb_core_glibc_x86_32.nexe glibc_x86/exe.unstripped/ppapi_ppb_core_glibc_x86_32.nexe 
C:/b/swarming/w/ir/cache/vpython/80ee9f/Scripts/python.exe "../../build/toolchain/gcc_link_wrapper.py" --output="glibc_x86/ppapi_ppb_core_glibc_x86_32.nexe" --strip="../../native_client/toolchain/win_x86/nacl_x86_glibc/bin/x86_64-nacl-strip.exe" --unstripped-file="glibc_x86/exe.unstripped/ppapi_ppb_core_glibc_x86_32.nexe" -- ../../native_client/toolchain/win_x86/nacl_x86_glibc/bin/x86_64-nacl-g++.exe -pthread -Wl,--fatal-warnings -m32 -Werror -Wl,-O2 -Wl,--gc-sections -o "glibc_x86/exe.unstripped/ppapi_ppb_core_glibc_x86_32.nexe" -Wl,--start-group @"glibc_x86/ppapi_ppb_core_glibc_x86_32.nexe.rsp"  -Wl,--end-group    
      0 [main] x86_64-nacl-g++ 6040 child_info_fork::abort: C:\b\swarming\w\ir\cache\builder\src\native_client\toolchain\win_x86\nacl_x86_glibc\libexec\cygiconv-2.dll: Loaded to different address: parent(0x26A0000) != child(0xCC0000)
      0 [main] x86_64-nacl-g++ 9348 child_info_fork::abort: C:\b\swarming\w\ir\cache\builder\src\native_client\toolchain\win_x86\nacl_x86_glibc\libexec\cygiconv-2.dll: Loaded to different address: parent(0x26A0000) != child(0xC80000)
      0 [main] x86_64-nacl-g++ 14688 child_info_fork::abort: C:\b\swarming\w\ir\cache\builder\src\native_client\toolchain\win_x86\nacl_x86_glibc\libexec\cygiconv-2.dll: Loaded to different address: parent(0x26A0000) != child(0x2650000)
      0 [main] x86_64-nacl-g++ 14312 child_info_fork::abort: C:\b\swarming\w\ir\cache\builder\src\native_client\toolchain\win_x86\nacl_x86_glibc\libexec\cygiconv-2.dll: Loaded to different address: parent(0x26A0000) != child(0x26B0000)
x86_64-nacl-g++: vfork: Resource temporarily unavailable
[6432/75140] LINK glibc_x86/ppapi_crash_off_main_thread_glibc_x86_32.nexe

(several instances of this)

These all seem unrelated, hopefully they don't happen again? It's mostly suspicious because they happened in fairly close proximity.
 
The one about #include "components/crash/core/common/crash_buildflags.h" is likely because the BUILD.gn doesn't list the crash target as a deps: https://cs.chromium.org/chromium/src/chrome/services/printing/BUILD.gn?sq=package:chromium&dr=C&g=0&l=18

Since the buildflag file is generated, it may not exist at the time of compile because it's not in the target dependency graph.
Cc: xlou@chromium.org
Components: Internals>Printing
Labels: Type-Bug
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2d9e0162a57cf6a94616bc6c0ae0bde269b2ce86

commit 2d9e0162a57cf6a94616bc6c0ae0bde269b2ce86
Author: Robert Sesek <rsesek@chromium.org>
Date: Fri Aug 31 17:55:38 2018

Add missing build deps for //chrome/services/printing:lib.

This uses the crash_key target but doesn't depend on it.

Bug:  879300 
Change-Id: I87be0109390b5a047679b39ede5473c2feb04ebe
Reviewed-on: https://chromium-review.googlesource.com/1197562
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588085}
[modify] https://crrev.com/2d9e0162a57cf6a94616bc6c0ae0bde269b2ce86/chrome/services/printing/BUILD.gn

Labels: -Sheriff-Chromium
Owner: rsesek@chromium.org
Status: Fixed (was: Available)

Sign in to add a comment