New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 879296 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac , Fuchsia
Pri: 2
Type: Bug


Participants' hotlists:
AudioService-FixIt


Sign in to add a comment

Unit test AudioServiceAudioProcessorProxy

Project Member Reported by maxmorin@chromium.org, Aug 30

Issue description

It's missing tests. It may also need some refactoring.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/86d4f131d29c49e761ee20d9b1c5026b1172ef50

commit 86d4f131d29c49e761ee20d9b1c5026b1172ef50
Author: Max Morin <maxmorin@chromium.org>
Date: Thu Aug 30 21:51:13 2018

APM move: Configure and use APM in Audio Service

ProcessedLocalAudioSource is changed to either create a
MediaStreamAudioProcessor or an AudioServiceAudioProcessorProxy depending
on whether the WebRtcApmInAudioService flag is set.

AudioServiceAudioProcessorProxy proxies GetStats and AECDump calls to
the remote audio processor. Although the JavaScript getStats call is
asynchronous, we currently collect stats synchronously inside Chrome.
Ideally, this would be changed. For now, the proxy overcomes this
mismatch by polling the remote audio processor for stats at regular
intervals. It uses a heuristic to determine the rate at which the user
is calling getStats and tries to match that, within some reasonable
limits. 878764 has been filed to fix this.

For AECDumps, we already get a file-handle from the browser, so it can
just be sent along to the audio service. So the audio service does not
need to be able to create files for this to work.

For an outline of the project this CL is part of, see: https://docs.google.com/document/d/1u4POff_ts_1LE3WDLA_wDDFnUswdlsuHL5DsiTE0a3U/edit?usp=sharing
It's accessible to everyone @chromium.org.

No-try since the test timing out is unrelated.

No-Try: true
Bug: 851959, 878764, 879133,  879243 , 879296
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I7473c068aa691d69f6ba90dce2550534c9cb3d8a
Reviewed-on: https://chromium-review.googlesource.com/1169471
Commit-Queue: Max Morin <maxmorin@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Olga Sharonova <olka@chromium.org>
Reviewed-by: Max Morin <maxmorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587796}
[modify] https://crrev.com/86d4f131d29c49e761ee20d9b1c5026b1172ef50/content/browser/media/media_internals.cc
[modify] https://crrev.com/86d4f131d29c49e761ee20d9b1c5026b1172ef50/content/browser/renderer_host/media/audio_output_delegate_impl_unittest.cc
[modify] https://crrev.com/86d4f131d29c49e761ee20d9b1c5026b1172ef50/content/browser/webrtc/webrtc_audio_browsertest.cc
[modify] https://crrev.com/86d4f131d29c49e761ee20d9b1c5026b1172ef50/content/renderer/BUILD.gn
[modify] https://crrev.com/86d4f131d29c49e761ee20d9b1c5026b1172ef50/content/renderer/media/audio/mojo_audio_input_ipc.cc
[add] https://crrev.com/86d4f131d29c49e761ee20d9b1c5026b1172ef50/content/renderer/media/stream/audio_service_audio_processor_proxy.cc
[add] https://crrev.com/86d4f131d29c49e761ee20d9b1c5026b1172ef50/content/renderer/media/stream/audio_service_audio_processor_proxy.h
[modify] https://crrev.com/86d4f131d29c49e761ee20d9b1c5026b1172ef50/content/renderer/media/stream/media_stream_audio_processor_options.cc
[modify] https://crrev.com/86d4f131d29c49e761ee20d9b1c5026b1172ef50/content/renderer/media/stream/media_stream_audio_processor_options.h
[modify] https://crrev.com/86d4f131d29c49e761ee20d9b1c5026b1172ef50/content/renderer/media/stream/processed_local_audio_source.cc
[modify] https://crrev.com/86d4f131d29c49e761ee20d9b1c5026b1172ef50/content/renderer/media/stream/processed_local_audio_source.h
[modify] https://crrev.com/86d4f131d29c49e761ee20d9b1c5026b1172ef50/content/renderer/media/webrtc/webrtc_audio_device_impl.cc
[modify] https://crrev.com/86d4f131d29c49e761ee20d9b1c5026b1172ef50/content/renderer/media/webrtc/webrtc_audio_device_impl.h
[modify] https://crrev.com/86d4f131d29c49e761ee20d9b1c5026b1172ef50/content/renderer/media/webrtc/webrtc_audio_renderer.cc
[modify] https://crrev.com/86d4f131d29c49e761ee20d9b1c5026b1172ef50/content/renderer/media/webrtc/webrtc_audio_renderer_unittest.cc
[modify] https://crrev.com/86d4f131d29c49e761ee20d9b1c5026b1172ef50/content/renderer/media/webrtc/webrtc_audio_sink.cc
[modify] https://crrev.com/86d4f131d29c49e761ee20d9b1c5026b1172ef50/content/renderer/media/webrtc/webrtc_audio_sink.h
[modify] https://crrev.com/86d4f131d29c49e761ee20d9b1c5026b1172ef50/content/renderer/media/webrtc/webrtc_media_stream_track_adapter.cc
[modify] https://crrev.com/86d4f131d29c49e761ee20d9b1c5026b1172ef50/content/test/BUILD.gn
[modify] https://crrev.com/86d4f131d29c49e761ee20d9b1c5026b1172ef50/media/audio/BUILD.gn
[modify] https://crrev.com/86d4f131d29c49e761ee20d9b1c5026b1172ef50/media/audio/audio_logging.h
[add] https://crrev.com/86d4f131d29c49e761ee20d9b1c5026b1172ef50/media/audio/audio_processing.cc
[modify] https://crrev.com/86d4f131d29c49e761ee20d9b1c5026b1172ef50/media/audio/audio_processing.h
[modify] https://crrev.com/86d4f131d29c49e761ee20d9b1c5026b1172ef50/media/audio/audio_source_parameters.h
[modify] https://crrev.com/86d4f131d29c49e761ee20d9b1c5026b1172ef50/media/audio/fake_audio_log_factory.cc
[modify] https://crrev.com/86d4f131d29c49e761ee20d9b1c5026b1172ef50/media/mojo/interfaces/audio_logging.mojom
[modify] https://crrev.com/86d4f131d29c49e761ee20d9b1c5026b1172ef50/services/audio/input_controller.cc
[modify] https://crrev.com/86d4f131d29c49e761ee20d9b1c5026b1172ef50/services/audio/input_stream.cc
[modify] https://crrev.com/86d4f131d29c49e761ee20d9b1c5026b1172ef50/services/audio/log_adapter.cc
[modify] https://crrev.com/86d4f131d29c49e761ee20d9b1c5026b1172ef50/services/audio/log_adapter.h
[modify] https://crrev.com/86d4f131d29c49e761ee20d9b1c5026b1172ef50/services/audio/log_factory_manager_unittest.cc
[modify] https://crrev.com/86d4f131d29c49e761ee20d9b1c5026b1172ef50/services/audio/test/mock_log.h

Sign in to add a comment