New issue
Advanced search Search tips

Issue 879291 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 28
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 812037



Sign in to add a comment

Can't enroll into Demo Mode after interrupting process

Project Member Reported by michae...@chromium.org, Aug 30

Issue description

During demo mode setup, if Chrome is shut down after selecting a network but before successfully finishing the enrollment process, then subsequent boots will skip the Welcome screen and go straight to Sign-in instead.

1. Launch chrome for first time with --enable-demo-mode --arc-availability=official-supported
2. Ctrl-Alt-D to enable demo mode, click OK, choose a network, accept ToS
3. At update screen or enrollment progress screen, shut down Chrome

Expected: Return to Welcome screen after reboot
Actual: Start at Sign-in screen after reboot, OR enter a crash loop (haven't figured out how to repro this consistently yet)
 
It looks like OOBE completed flag was set before reboot. Is there any way to preserve logs from before reboot to see how far did it go?
I think it is because I did not resume all the OOBE demo screens correctly. Will try to fix it next.

I encountered this without a reboot. I think my device temporarily disconnected from the internet during the enrollment step and went into the crash loop you mentioned.
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/126e7d72a19e66aac93fa7f4ecb6f7fee29591c5

commit 126e7d72a19e66aac93fa7f4ecb6f7fee29591c5
Author: Aga Wronska <agawronska@chromium.org>
Date: Tue Sep 25 18:27:42 2018

Do not resume demo mode setup screens in OOBE.

A few of the demo setup screens are instances of regular OOBE screens.
After resume the information about demo mode is not preserved. It
results with resuming screen in regular OOBE flow and can cause error
state.

Bug:  879291 
Test: Manuall + WizardController browser tests
Change-Id: I47176b8d0d801141ca05ee710028b9a019f77e54
Reviewed-on: https://chromium-review.googlesource.com/1232953
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594020}
[modify] https://crrev.com/126e7d72a19e66aac93fa7f4ecb6f7fee29591c5/chrome/browser/chromeos/login/wizard_controller.cc

Status: Started (was: Assigned)
This change refers to the bug to: https://chromium-review.googlesource.com/c/chromium/src/+/1235374
Forgot to add bug in description.
Status: Fixed (was: Started)
I would like to close this bug, so I did various manual tests as described below.

Manual random interruptions (restart chrome): ok

Disconnect network manually:
• on update screen - ok
• on demo setup screen during loading component - crbug.com/889683
• demo setup screen during dm server communication - ok  

Artificial chrome crash (CHECK):
• DemoSetupController: after calling load on component - ok
• DemoSetupController: after calling enroll - ok
• DemoSetupController: after device enrolled callback - ok
• EnrollmentHandlerChromeOS: before policy fetch - ok
• EnrollmentHandlerChromeOS: while fetching robot account - ok
* EnrollmentHandlerChromeOS: after locking device - ok
Labels: Merge-Request-70
Interruption of demo setup flow can put device into broken state, so I would like to merge into M70.
There are 2 very small changes, that should easy/safe to merge.
Project Member

Comment 9 by sheriffbot@chromium.org, Sep 28

Labels: -Merge-Request-70 Merge-Review-70 Hotlist-Merge-Review
This bug requires manual review: M70 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-70 Merge-Approved-70
Project Member

Comment 11 by bugdroid1@chromium.org, Sep 28

Labels: -merge-approved-70 merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c1ae5286e1824eb9c0fb79880a40a6fbb6a5fc7d

commit c1ae5286e1824eb9c0fb79880a40a6fbb6a5fc7d
Author: Aga Wronska <agawronska@chromium.org>
Date: Fri Sep 28 22:49:42 2018

Do not resume demo mode setup screens in OOBE.

A few of the demo setup screens are instances of regular OOBE screens.
After resume the information about demo mode is not preserved. It
results with resuming screen in regular OOBE flow and can cause error
state.

Bug:  879291 
Test: Manuall + WizardController browser tests
Change-Id: I47176b8d0d801141ca05ee710028b9a019f77e54
Reviewed-on: https://chromium-review.googlesource.com/1232953
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#594020}(cherry picked from commit 126e7d72a19e66aac93fa7f4ecb6f7fee29591c5)
Reviewed-on: https://chromium-review.googlesource.com/1252857
Reviewed-by: Aga Wronska <agawronska@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#757}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/c1ae5286e1824eb9c0fb79880a40a6fbb6a5fc7d/chrome/browser/chromeos/login/wizard_controller.cc

Labels: Merge-Merged-70-3538
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/c1ae5286e1824eb9c0fb79880a40a6fbb6a5fc7d

Commit: c1ae5286e1824eb9c0fb79880a40a6fbb6a5fc7d
Author: agawronska@chromium.org
Commiter: agawronska@chromium.org
Date: 2018-09-28 22:49:42 +0000 UTC

Do not resume demo mode setup screens in OOBE.

A few of the demo setup screens are instances of regular OOBE screens.
After resume the information about demo mode is not preserved. It
results with resuming screen in regular OOBE flow and can cause error
state.

Bug:  879291 
Test: Manuall + WizardController browser tests
Change-Id: I47176b8d0d801141ca05ee710028b9a019f77e54
Reviewed-on: https://chromium-review.googlesource.com/1232953
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#594020}(cherry picked from commit 126e7d72a19e66aac93fa7f4ecb6f7fee29591c5)
Reviewed-on: https://chromium-review.googlesource.com/1252857
Reviewed-by: Aga Wronska <agawronska@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#757}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}

Sign in to add a comment