Support domain name ICE candidates in Chromium |
|||
Issue descriptionThis is the Chromium companion bug to http://crbug.com/webrtc/4165 . WebRTC now supports domain names in ICE candidates, for example "your.hostname" in: a=candidate:1 1 udp 2130706431 your.hostname 11365 typ host generation 0. Chromium needs to pass an AsyncResolverFactory to PeerConnection during creation in order for the name resolution to be triggered by WebRTC. AsyncResolverFactory was introduced here: https://webrtc-review.googlesource.com/c/src/+/91300
,
Sep 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c600823b01b687f788b2cf2ade1d55c7d1c41772 commit c600823b01b687f788b2cf2ade1d55c7d1c41772 Author: Zach Stein <zstein@chromium.org> Date: Tue Sep 04 17:19:03 2018 Enable domain name ICE candidates in Chromium Adds an AsyncResolverFactory to PeerConnections created by PeerConnectionDependencyFactory. Along with webrtc-review.googlesource.com/85540, this allows ICE candidates hostnames to be resolved by WebRTC. Also moves to the new, non-deprecated CreatePeerConnection call. Bug: chromium:879271 Change-Id: I96e26d40fb7e0cfbd0eb1623bd00bb3241ca3c07 Reviewed-on: https://chromium-review.googlesource.com/1196170 Reviewed-by: Florent Castelli <orphis@chromium.org> Commit-Queue: Zach Stein <zstein@google.com> Cr-Commit-Position: refs/heads/master@{#588562} [modify] https://crrev.com/c600823b01b687f788b2cf2ade1d55c7d1c41772/content/renderer/media/webrtc/peer_connection_dependency_factory.cc
,
Sep 6
,
Sep 10
Verified by replacing the IPv4 address in an ICE candidate with my machine's hostname using a modified version of the munge SDP sample (https://steinz.github.io/samples/src/content/peerconnection/munge-sdp/). |
|||
►
Sign in to add a comment |
|||
Comment 1 by zstein@chromium.org
, Aug 31