WebAPK splash icon should have maximum size |
||
Issue descriptionRepro steps: 1) Hack Chrome to disable WebAPKs 2) Navigate to https://webapk-test.appspot.com/generated.html?manifest=%7B%0A%20%20%22name%22%3A%20%22Long%20Name%22%2C%0A%20%20%22short_name%22%3A%20%22Short%20Name%22%2C%0A%20%20%22scope%22%3A%20%22%2F%22%2C%0A%20%20%22display%22%3A%20%22standalone%22%2C%0A%20%20%22orientation%22%3A%20%22%22%2C%0A%20%20%22theme_color%22%3A%20%22purple%22%2C%0A%20%20%22background_color%22%3A%20%22teal%22%2C%0A%20%20%22icons%22%3A%20%5B%0A%20%20%20%20%7B%0A%20%20%20%20%20%20%22src%22%3A%20%22https%3A%2F%2Fwww.solidbackgrounds.com%2Fimages%2F2048x2048%2F2048x2048-rust-solid-color-background.jpg%22%2C%0A%20%20%20%20%20%20%22sizes%22%3A%20%224086x4086%22%2C%0A%20%20%20%20%20%20%22type%22%3A%20%22image%2Fpng%22%0A%20%20%20%20%7D%0A%20%20%5D%0A%7D%0A&manifest_base_url=&start_base_url= 3) Select "Add to Home screen" from the app menu 4) Launch the newly added shortcut 5) Install WebAPK for the same URL 6) Launch the WebAPK Expected: The splash screen icons for both the homescreen shortcut and the WebAPK are the same size. See splash_webapp.png Actual: The splash screen icon for the WebAPK is bigger. See splash_webapk.png
,
Aug 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f97e28e3d46daa0d399a42ff535b7ad84897bc71 commit f97e28e3d46daa0d399a42ff535b7ad84897bc71 Author: Peter Kotwicz <pkotwicz@chromium.org> Date: Fri Aug 31 21:39:08 2018 [Android WebAPK]: Downsample WebAPK splash screen icon if it is super big This CL changes the behavior of the splash icon for WebAPKs to match that of non-WebAPK homescreen shortcuts. The splash icon for non-WebAPK-homescreen-shortcuts is downsampled to 128x128dp by ManifestIconDownloader::OnIconFetched() The WebAPK Minting server generates a single WebAPK per start URL. That single WebAPK needs to work with all screen densities, thus the downsampling needs to occur on the client side. BUG= 879255 Change-Id: I5822e1c8bf3cf02d7d3935989ae4d786cc9d9bb8 Reviewed-on: https://chromium-review.googlesource.com/1197623 Reviewed-by: Yaron Friedman <yfriedman@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#588176} [modify] https://crrev.com/f97e28e3d46daa0d399a42ff535b7ad84897bc71/chrome/android/java/res/layout/webapp_splash_screen_large.xml
,
Sep 4
|
||
►
Sign in to add a comment |
||
Comment 1 by pkotw...@chromium.org
, Aug 30