browser_tests failing BrowserViewTest.GetAccessibleTabModalDialogTitle |
||
Issue descriptionFiled by sheriff-o-matic@appspot.gserviceaccount.com on behalf of nednguyen@google.com browser_tests failing BrowserViewTest.GetAccessibleTabModalDialogTitle Builders failed on: - Mac10.11 Tests: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.11%20Tests - Mac10.12 Tests: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests
,
Aug 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7fca17c1c1eb2cfa1a8a9003fe6cd2545fa34993 commit 7fca17c1c1eb2cfa1a8a9003fe6cd2545fa34993 Author: James Wallace-Lee <jamwalla@chromium.org> Date: Thu Aug 30 23:39:40 2018 Reland "Tab modal dialog title should be accessible window title" This is a reland of a6f6697e14bc8f86746d7dbdbddd52ee743dc838 The test, GetAccessibleTabModalDialogTitle, failed on OSX because tab-modal dialogs are treated as native windows in Voiceover. This fix is unnecessary on OSX so the test is now disabled there. Original change's description: > Tab modal dialog title should be accessible window title > > Tab modal dialogs (ui::MODAL_TYPE_CHILD) should report their title > to AT (insert+T on JAWS and NVDA) when active. To accomplish this, > BrowserView::GetAccessibleWindowTitle should report the title of > the dialog when one is active. > > Bug: 775680 > Test: browser_tests.exe --gtest_filter=BrowserViewTest.GetAccessibleTabModalDialogTitle > Change-Id: Ie693e1627c87e4d97eede64381d80dab31635642 > Reviewed-on: https://chromium-review.googlesource.com/1184039 > Commit-Queue: James Wallace-Lee <jamwalla@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#587371} Bug: 775680 , 879074 , 879253 Change-Id: I4351a6487a4cb582383fe18b97e825a986464f59 Reviewed-on: https://chromium-review.googlesource.com/1197333 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: James Wallace-Lee <jamwalla@chromium.org> Cr-Commit-Position: refs/heads/master@{#587845} [modify] https://crrev.com/7fca17c1c1eb2cfa1a8a9003fe6cd2545fa34993/chrome/browser/ui/views/frame/browser_view.cc [modify] https://crrev.com/7fca17c1c1eb2cfa1a8a9003fe6cd2545fa34993/chrome/browser/ui/views/frame/browser_view_browsertest.cc
,
Aug 31
|
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Aug 30