New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 879248 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 30
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"org.chromium.chrome.browser.sync.UkmTest#singleDisableHistorySyncCheck" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Aug 30

Issue description

"org.chromium.chrome.browser.sync.UkmTest#singleDisableHistorySyncCheck" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyUQsSBUZsYWtlIkZvcmcuY2hyb21pdW0uY2hyb21lLmJyb3dzZXIuc3luYy5Va21UZXN0I3NpbmdsZURpc2FibGVIaXN0b3J5U3luY0NoZWNrDA.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 
Cc: nyquist@chromium.org yfried...@chromium.org
Components: Services>Sync
Owner: mastiz@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a0a86f28e492f18ab186f05f0ee2302e583ffc30

commit a0a86f28e492f18ab186f05f0ee2302e583ffc30
Author: Oksana Zhuravlova <oksamyt@chromium.org>
Date: Fri Aug 31 20:48:56 2018

Mark UkmTest#singleDisableHistorySyncCheck as flaky

Bug:  879248 
Change-Id: Ib2ac501729e0376eb17dc467df5be849ebf416f5

TBR=mastiz@chromium.org

Change-Id: Ib2ac501729e0376eb17dc467df5be849ebf416f5
Reviewed-on: https://chromium-review.googlesource.com/1199696
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588157}
[modify] https://crrev.com/a0a86f28e492f18ab186f05f0ee2302e583ffc30/chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/UkmTest.java

Labels: -Sheriff-Chromium
Status: Assigned (was: Untriaged)
sync-triage ping
triage ping: mastiz@, any updates?
triage ping: mastiz@, any updates?
I started working on https://bugs.chromium.org/p/chromium/issues/detail?id=879246 which likely has a shared underlying issue. Expect no progress here meanwhile.
Given #7 should be bug be downprioritezed to P2? So you don't get pings every week, but every 4 weeks ;)
While I am still hoping that recent fix (https://chromium-review.googlesource.com/c/1296592) could improve things, I look into these erros and they do seem different.

Here's a recent failure: https://luci-logdog.appspot.com/logs/chromium/android/swarming/logcats/40b85a336c4b0211/+/logcat_logcat_org.chromium.chrome.browser.sync.UkmTest.testMetricConsent_20181023T061232-UTC_01e79793ca582446

The relevant stack trace:
10-23 06:12:40.952 17551 17565 I TestRunner: failed: testMetricConsent(org.chromium.chrome.browser.sync.UkmTest)
10-23 06:12:40.952 17551 17565 I TestRunner: ----- begin exception -----
10-23 06:12:40.958 17551 17565 I TestRunner: java.util.concurrent.TimeoutException: waitForCallback timed out!
10-23 06:12:40.958 17551 17565 I TestRunner: 	at org.chromium.base.test.util.CallbackHelper.waitForCallback(CallbackHelper.java:191)
10-23 06:12:40.958 17551 17565 I TestRunner: 	at org.chromium.base.test.util.CallbackHelper.waitForCallback(CallbackHelper.java:202)
10-23 06:12:40.958 17551 17565 I TestRunner: 	at org.chromium.content_public.browser.test.util.TestCallbackHelperContainer$OnEvaluateJavaScriptResultHelper.waitUntilHasValue(TestCallbackHelperContainer.java:157)
10-23 06:12:40.958 17551 17565 I TestRunner: 	at org.chromium.content_public.browser.test.util.JavaScriptUtils.executeJavaScriptAndWaitForResult(JavaScriptUtils.java:54)
10-23 06:12:40.958 17551 17565 I TestRunner: 	at org.chromium.content_public.browser.test.util.JavaScriptUtils.executeJavaScriptAndWaitForResult(JavaScriptUtils.java:30)
10-23 06:12:40.958 17551 17565 I TestRunner: 	at org.chromium.chrome.browser.sync.UkmTest.getElementContent(UkmTest.java:65)
10-23 06:12:40.958 17551 17565 I TestRunner: 	at org.chromium.chrome.browser.sync.UkmTest.isUkmEnabled(UkmTest.java:70)
10-23 06:12:40.958 17551 17565 I TestRunner: 	at org.chromium.chrome.browser.sync.UkmTest.testMetricConsent(UkmTest.java:94

I'm not very familiar with any of this code, but it feels like Site Isolation is preventing the test from executing the JavaScript it needs for sate verification.
Status: Fixed (was: Assigned)
findit reports no recent flakes so closing this bug: https://findit-for-me.appspot.com/ranked-flakes?test_filter=org.chromium.chrome.browser.sync.UkmTest%23singleDisableHistorySyncCheck

Sign in to add a comment