Chrome Version: 70.0.3538.0 (Developer Build) (64-bit)
OS: all

Let’s assume that the user has in Password Store only one form. The form origin is “http://httpbin.org/" and signon_realm is http://httpbin.org/". It can be a PasswordForm::scheme HTML or non-HTML with empty realm. Then:

1. User visit a website that has an HTTP auth form. Suppose the website is https://httpbin.org/something. The form created have origin = “https://httpbin.org/something" . Let’s suppose that auth realm is “realm”, so the  signon_realm will be “https://httpbin.org/realm”.
2. FormFetcherImpl requests credentials for https.
3. None are returned. HttpPasswordStoreMigrator is created to process the http credentials.
   It request credentials for
       PasswordForm::scheme = HTML,
       origin = “http://httpbin.org/something”,
       signon_realm = “http://httpbin.org/”.

   However, signon_realm should be “http://httpbin.org/realm”.

4. Credentials are found and they are copied (HSTS not enabled). New credentials have : 
   origin = “https://httpbin.org/something" 
   signon_realm = “https://httpbin.org/”,
   PasswordForm::scheme  the same as http credentials.

5. If http credentials from Password Store is HTML then https credentials doesn’t match because of different PasswordForm::scheme (PasswordFormManager::IsMatch).
   Even if the http credentials from Password Store has SCHEME_BASIC (the same as submitted form), the migrated https credentials doesn’t match because of different signon_realm (LoginModelObserver::OnAutofillDataAvailable):
   current signon_realm = “https://httpbin.org/realm”
   migrated HTTPS form has signon_realm = “https://httpbin.org/”. 

6. User visit https://httpbin.org/something again, steps 2-5 repeat.

Moreover, if password manager state is not inactive (ManagePasswordsState::ProcessLoginsChanged), infinite password store requests reported in  crbug.com/85235  is not solved for the scenario described above.

Expected results:

Credentials with non-empty realm should be migrated successfully.

What happens instead:

Wrong credentials are migrated without matching.






 

Chrome Version: 70.0.3538.0 (Developer Build) (64-bit)
OS: all

Let’s assume that the user has in Password Store only one form. The form origin is “http://httpbin.org/" and signon_realm is http://httpbin.org/". It can be a PasswordForm::scheme HTML or non-HTML with empty realm. Then:

1. User visit a website that has an HTTP auth form. Suppose the website is https://httpbin.org/something. The form created have origin = “https://httpbin.org/something" . Let’s suppose that auth realm is “realm”, so the  signon_realm will be “https://httpbin.org/realm”.
2. FormFetcherImpl requests credentials for https.
3. None are returned. HttpPasswordStoreMigrator is created to process the http credentials.
   It request credentials for
       PasswordForm::scheme = HTML,
       origin = “http://httpbin.org/something”,
       signon_realm = “http://httpbin.org/”.

   However, signon_realm should be “http://httpbin.org/realm”.

4. Credentials are found and they are copied (HSTS not enabled). New credentials have : 
   origin = “https://httpbin.org/something" 
   signon_realm = “https://httpbin.org/”,
   PasswordForm::scheme  the same as http credentials.

5. If http credentials from Password Store is HTML then https credentials doesn’t match because of different PasswordForm::scheme (PasswordFormManager::IsMatch).
   Even if the http credentials from Password Store has SCHEME_BASIC (the same as submitted form), the migrated https credentials doesn’t match because of different signon_realm (LoginModelObserver::OnAutofillDataAvailable):
   current signon_realm = “https://httpbin.org/realm”
   migrated HTTPS form has signon_realm = “https://httpbin.org/”. 

6. User visit https://httpbin.org/something again, steps 2-5 repeat.

Moreover, if password manager state is not inactive (ManagePasswordsState::ProcessLoginsChanged), infinite password store requests reported in crbug.com/852356  is not solved for the scenario described above.

Expected results:

Credentials with non-empty realm should be migrated successfully.

What happens instead:

Wrong credentials are migrated without matching.