New issue
Advanced search Search tips

Issue 879229 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Dashboard - Chrome Health Metrics stopped updating

Project Member Reported by simonhatch@chromium.org, Aug 30

Issue description

  File "/base/data/home/apps/s~chromeperf/clean-dtu-6be6e823.412199769425968545/dashboard/update_dashboard_stats.py", line 31, in get
    _FetchDashboardStats()
  File "/base/data/home/apps/s~chromeperf/clean-dtu-6be6e823.412199769425968545/dashboard/update_dashboard_stats.py", line 142, in _FetchDashboardStats
    datetime.datetime.now() - datetime.timedelta(days=14))
  File "/base/data/home/apps/s~chromeperf/clean-dtu-6be6e823.412199769425968545/dashboard/update_dashboard_stats.py", line 64, in _FetchCompletedPinpointJobs
    total_jobs = [(j, _GetDiffCommitTimeFromJob(j)) for j in total_jobs]
  File "/base/data/home/apps/s~chromeperf/clean-dtu-6be6e823.412199769425968545/dashboard/update_dashboard_stats.py", line 100, in _GetDiffCommitTimeFromJob
    diff = d[1].AsDict()
  File "/base/data/home/apps/s~chromeperf/clean-dtu-6be6e823.412199769425968545/dashboard/pinpoint/models/change/change.py", line 97, in AsDict
    result['patch'] = self.patch.AsDict()
  File "/base/data/home/apps/s~chromeperf/clean-dtu-6be6e823.412199769425968545/dashboard/pinpoint/models/change/patch.py", line 51, in AsDict
    self.server, self.change, fields=('ALL_REVISIONS', 'DETAILED_ACCOUNTS'))
  File "/base/data/home/apps/s~chromeperf/clean-dtu-6be6e823.412199769425968545/dashboard/services/gerrit_service.py", line 18, in GetChange
    return request.RequestJson(url, o=fields)
  File "/base/data/home/apps/s~chromeperf/clean-dtu-6be6e823.412199769425968545/dashboard/services/request.py", line 31, in RequestJson
    content = Request(*args, **kwargs)
  File "/base/data/home/apps/s~chromeperf/clean-dtu-6be6e823.412199769425968545/dashboard/services/request.py", line 80, in Request
    content = _RequestAndProcessHttpErrors(url, use_auth, scope, **kwargs)
  File "/base/data/home/apps/s~chromeperf/clean-dtu-6be6e823.412199769425968545/dashboard/services/request.py", line 109, in _RequestAndProcessHttpErrors
    'HTTP status code %s: %s' % (response['status'], content))
NotFoundError: HTTP status code 404: Not found: chromium/src~master~I30e29352fb9ba57f0b8adddbac890d5b88f26472
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 6

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/43d827d8863cabd6120b766c207a0592cd9cbc23

commit 43d827d8863cabd6120b766c207a0592cd9cbc23
Author: Simon <simonhatch@chromium.org>
Date: Thu Sep 06 16:12:30 2018

Dashboard - Fix stats generation for chrome health metrics

Some pinpoint jobs seem to be invalid and hit httplib exceptions when
requesting data from gitiles. Catch and ignore these.

Bug: chromium:879229
Change-Id: I2104fb4197b8b6f42e5d0e0df9b06f9d9713d805
Reviewed-on: https://chromium-review.googlesource.com/1197128
Commit-Queue: Simon Hatch <simonhatch@chromium.org>
Reviewed-by: Ethan Kuefner <eakuefner@chromium.org>

[modify] https://crrev.com/43d827d8863cabd6120b766c207a0592cd9cbc23/dashboard/dashboard/update_dashboard_stats.py
[modify] https://crrev.com/43d827d8863cabd6120b766c207a0592cd9cbc23/dashboard/dashboard/update_dashboard_stats_test.py

Project Member

Comment 2 by bugdroid1@chromium.org, Sep 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/79f8b4dcb67bf6bcc2f26bbae15746b90458d0c2

commit 79f8b4dcb67bf6bcc2f26bbae15746b90458d0c2
Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Fri Sep 07 18:49:21 2018

Roll src/third_party/catapult bcc3e491fb2e..32654a45d3da (16 commits)

https://chromium.googlesource.com/catapult.git/+log/bcc3e491fb2e..32654a45d3da


git log bcc3e491fb2e..32654a45d3da --date=short --no-merges --format='%ad %ae %s'
2018-09-07 nednguyen@google.com Remove common/battor/
2018-09-07 simonhatch@chromium.org Dashboard - Simplify find_anomalies by removing benchmark_duration
2018-09-07 simonhatch@chromium.org Dashboard - Generate stats on alert #'s
2018-09-07 nednguyen@google.com Fix BUILD.gn by running generate_telemetry_build.py
2018-09-07 ulan@chromium.org Add a metric that tracks the number of console error messages
2018-09-07 wangge@google.com Reformat the `run_benchmark` help message.
2018-09-06 benjhayden@chromium.org Fix flaky dashboard tests: timeseries2_test, file_bug_test, others.
2018-09-06 wangge@google.com Update help message for `run_benchmark.py`.
2018-09-06 benjhayden@chromium.org dashboard/bin/run_wct_tests
2018-09-06 nastasoiuf@google.com Stacked bar plot integration
2018-09-06 simonhatch@chromium.org Dashboard - Fix stats generation for chrome health metrics
2018-09-06 rmcilroy@chromium.org [Tracing] Add support for Optimize-Background bucket to V8's runtime call stats table
2018-09-06 anthonyalridge@google.com Add back bar chart interaction
2018-09-06 mattm@chromium.org netlog_viewer: rename |global| in cr.js to |cr_global|
2018-09-05 mattm@chromium.org netlog_viewer: Apply chromium changes up to 940b87bb7cb870e5d441
2018-09-05 jbudorick@chromium.org Fix systrace/bin/OWNERS.


Created with:
  gclient setdep -r src/third_party/catapult@32654a45d3da

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:881543 , chromium:881379 , chromium:881361 , chromium:881543 ,chromium:880432, chromium:863390 , chromium:877660 ,chromium:866423,chromium:879229,chromium:866423
TBR=sullivan@chromium.org

Change-Id: I2206a43b38a09c7427d4d4ef02fe4c820dbaee98
Reviewed-on: https://chromium-review.googlesource.com/1213476
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#589610}
[modify] https://crrev.com/79f8b4dcb67bf6bcc2f26bbae15746b90458d0c2/DEPS

Cc: -eakuefner@chromium.org

Sign in to add a comment