New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 879228 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
Last visit > 30 days ago
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android , Fuchsia
Pri: 3
Type: Bug

Blocking:
issue 882860
issue 369218



Sign in to add a comment

Add translated strings for omitted locales for Chrome on Android

Project Member Reported by digit@google.com, Aug 30

Issue description

Chrome on Android does not ship 9 locale-related .pak files in order to reduce the size of the Chrome.apk. These are listed here:

https://cs.chromium.org/chromium/src/build/config/locales.gni?type=cs&q=android_chrome_omitted_locales&sq=package:chromium&g=0&l=8

For example, The 'ka' locale corresponds to Kannada [1], spoken in India.

In the future, we will be able to support all Chrome locales on Android, when distributing it as an Android app bundle (with language-based splits).

An experimental CL [2] shows that enabling these locales breaks the build. The error comes from the fact that UI string translations are missing from our GRIT input files at the moment.

This entry is to track the issue and add the missing translations.

[1] https://en.wikipedia.org/wiki/Kannada
[2] https://chromium-review.googlesource.com/c/chromium/src/+/1196378
 
Owner: digit@chromium.org
As a first step, I've uploaded a CL that updates translation_expectations.pyl at https://chromium-review.googlesource.com/c/chromium/src/+/1203611
Blocking: 882860
Status: Assigned (was: Available)
For the record, we need 3 strings from ui/android/java/strings/android_ui_strings.grd to be translated for 9 missing locales [1].

See [2] for a CL that adds dummy translations (copied from the en-GB .xtb files) in order to enable the feature in b/886260. However, fixing this issue is required to unblock that other bug.

[1] https://cs.chromium.org/chromium/src/ui/android/java/strings/android_ui_strings.grd
[2] https://chromium-review.googlesource.com/c/chromium/src/+/1196378
An email has been sent to chrome-localization@ asking for the next steps. It looks like sending new translation requests to the Translation Console requires specific privileges.
Blocking: 369218
Cc: js...@chromium.org
Adding jungshink here (jshin@). I have heard from chrome-localization@ at all, is there someone else I could contact to ask for these translations?
Cc: melliem@chromium.org
Adding melliem@ also, which may also know how to deal with this (thanks Ben).
Cc: gov...@chromium.org
Labels: OS-Fuchsia
Adding govind@ as suggested by jshin@ by private chat, who should know about this!
Cc: melliem@google.com
melliem@google to get her attention. 

Cc: -gov...@chromium.org jdignos@chromium.org
+jdignos@chromium.org
Joshua, could you follow-up with the next steps to have these strings translated - thanks!
They're already translated. :-)   

For instance, see 

http://shortn/_2knwz0Cyl7 (inside Google: this is a shortened link to TC for 'Failed to copy to clipboard'). They're translated into Kannada, Marathi, Tamil, Malayalam, and many other languages (which is not supported by Chrome-Android). 

My understanding is that messages have been translated into 'yet-to-support' languages for a few years in anticipation of 'upcoming' support, but that 'upcoming' support has been delayed for a long while unfortunately. 

Anyway, it seems that there's an issue with getting translated strings back to Chrome's tree. 


Google Internal link for Unable to complete previous operation due to low memory : http://shortn/_XvtFYYfifs

> Anyway, it seems that there's an issue with getting translated strings back to Chrome's tree. 


govind@:  String transfer script (from TC to Chromium tree) is likely to drop 9 locales in question for messages in ui/android/java/strings/android_ui_strings.grd .  
digit@ : I think you need to update the following files in Chromium tree to get strings back from TC for 9 additional languages. 


android_chrome_strings.grd
android_content_strings.grd
android_ui_strings.grd
android_webapk_strings.grd
android_webview_strings.grd

These files will be copied to the corresponding location in Google's internal repos and 
everything may just work. See 

http://www.chromium.org/developers/design-documents/ui-localization

BTW, https://chromium-review.googlesource.com/c/chromium/src/+/1196378#message-30b20be1d1e4e5f177db61a94e8834021b4e54dc  explains why you encountered an issue with only 3 strings.  That's because you're only adding android_ui_strings while not adding others listed the above. 

If you had added them as well, you'd have found a lot more messages missing. 


I think the first thing to do is to update the following files to list 9 more languages to translate for Android (this file indicates that there are 7 grd files for Android). 

https://cs.chromium.org/chromium/src/tools/gritsettings/translation_expectations.pyl?sq=package:chromium&dr&g=0

See this doc: 
https://cs.chromium.org/chromium/src/tools/gritsettings/README.md?sq=package:chromium&dr&g=0


After that change is checked in, govind@ will make a request, but most, if not all, strings must have already been translated. So, next time translated message files (xtb files) are imported, they'd include xtb files for 9 locales ( 9 locales * 7 grd files = 63 new xtb files). 

Then, 7 grd files listed in translation_expectations.pyl can be updated to list 9 more locales along with build file changes.  


If the above steps work,  you may as well add a section to the following doc about how to add a new locale. 

http://www.chromium.org/developers/design-documents/ui-localization


Project Member

Comment 15 by bugdroid1@chromium.org, Sep 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/04c5a83e224a318822dfc687bbd99142bc7b0fed

commit 04c5a83e224a318822dfc687bbd99142bc7b0fed
Author: David 'Digit' Turner <digit@google.com>
Date: Wed Sep 26 14:42:07 2018

Add translations for Android omitted locales.

Update the translation_expecations.pyl to enable the translation
of strings to the list of 'omitted' Android locales (as defined
in build/config/locales.gni).

The corresponding strings will not be omitted from Chrome when
built as an Android app bundle, as opposed to regular APKs.

See bug for all details.

R=agrieve@chromium.org, thestig@chromium.org

Bug: 879228
Change-Id: I5bca7817e051648e3cb04f2e573064101422ed29
Reviewed-on: https://chromium-review.googlesource.com/1203611
Reviewed-by: Jungshik Shin <jshin@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: David Turner <digit@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594312}
[modify] https://crrev.com/04c5a83e224a318822dfc687bbd99142bc7b0fed/tools/gritsettings/translation_expectations.pyl

Thank you, the CL [1] that updates translation_expectations.pyl has been submitted, so we'll have to wait for the next import run by @govind.
Getting closer!

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1203611
Cc: heamy@chromium.org
digit@ : did you update grd files to list more languages ? see comment 13. 

While writing my comments here and in a chat session with you, I may have shuffled the order of things to do.  The CL recorded in comment 15 may have to be preceded by listing more languages in grd files in comment 13. 



Project Member

Comment 19 by bugdroid1@chromium.org, Oct 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/70b843c9e6284b1a95c964a81efbb4f2a67ee89d

commit 70b843c9e6284b1a95c964a81efbb4f2a67ee89d
Author: David 'Digit' Turner <digit@google.com>
Date: Fri Oct 19 16:31:39 2018

build: Add android_debug_resources_temp_dir

Normally, compiling Android resources requires unpacking
and processing resource dependencies into a temporary
directory before sending the result to 'aapt2 compile',
then getting rid of these intermediate files.

To help debug issues related to Android resource compilation,
this CL introduces a new GN variable that can be set in your
args.gn, to force the build to put all such build directories
under a top-level directory, and not removing intermediate
files in it.

This should allow inspecting the intermediate files to better
understand what's going on.

This is needed to debug issues that appeared in my attempt
to change the resources stored in APKs versus bundles, e.g.:
https://chromium-review.googlesource.com/c/chromium/src/+/1270947

BUG=879228,882860,897056
R=agrieve@chromium.org, estevenson@chromium.org,yfriedman@chromium.org

Change-Id: I76c79a893b0bbdb56ba685f4304da929d11c7e05
Reviewed-on: https://chromium-review.googlesource.com/c/1288436
Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: David Turner <digit@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601178}
[modify] https://crrev.com/70b843c9e6284b1a95c964a81efbb4f2a67ee89d/build/android/gyp/compile_resources.py
[modify] https://crrev.com/70b843c9e6284b1a95c964a81efbb4f2a67ee89d/build/android/gyp/util/resource_utils.py

Please take a look at the candidate CL [1] I just uploaded. Cherry-picking or submitting should be enough to get the import process to work correctly for @govind.

Once this is completed and we get the right .xtb file content, we should be able to fix the build rules related to omitted locales (which are currently broken, but see http://crbug.com/897056 for more details.


[1] https://chromium-review.googlesource.com/c/chromium/src/+/1297364
Project Member

Comment 21 by bugdroid1@chromium.org, Oct 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bed2fe29f5758e6958d312b96dbc3edd9cafeb47

commit bed2fe29f5758e6958d312b96dbc3edd9cafeb47
Author: David 'Digit' Turner <digit@google.com>
Date: Thu Oct 25 16:01:58 2018

android: Add missing translations in grit input files.

This is a preparatory CL to allow importing missing Android
specific translations for the following 9 locales:

  bn: Bengali
  et: Estonian
  gu: Gujarati
  kn: Kannada
  ml: Malaylam
  mr: Marathi
  ms: Malay
  ta: Tamil
  te: Tegulu

Its purpose is to:

- Add fake missing .xtb translation files, populated by copying
  the content of the en-GB version and updating the locale
  tag inside the copies. See below for the source of the small
  Python script that was used to do that.

- Update the .grd files so they associate with the new .xtb
  files, but do *not* output corresponding Android resource
  .xml files.

  This ensures that the Android build is left untouched and
  doesn't include said fake translations into its final binaries
  (APKs and App Bundles).

- Update the translation_expectations.pyl configuration file
  that drives the import script, moving all .grd files to the
  single "desktop_grds" group. This ensures that all these
  .grd will get additional translations as well whenever
  Chrome supports more locales in the future.

After submitting this CL, it should be possible to run the
locale import process to update the content of the .xtb files
properly.

Then, another CL will modify the build rules to
generate Android resource .xml files for the new translations
and integrate them into the Android build.

BUG=882860,879228
R=govind@chromium.org,jshin@chromium.org,abdulsyed@chromium.org

For the record, the Python script used to create the fake .xtb copies:
--------------------- cut here ---------------------------
import os
import re
import shutil

SRC_LOCALE = 'en-GB'
DST_LOCALES = [ 'bn', 'et', 'gu', 'kn', 'ml', 'mr', 'ms', 'ta', 'te' ]
GRD_INPUTS = [
  'android_webview/java/strings/android_webview_strings.grd',
  'chrome/android/java/strings/android_chrome_strings.grd',
  'chrome/android/webapk/strings/android_webapk_strings.grd',
  'components/autofill/android/java/strings/autofill_strings.grd',
  'components/embedder_support/android/java/strings/web_contents_delegate_android_strings.grd',
  'content/public/android/java/strings/android_content_strings.grd',
  'ui/android/java/strings/android_ui_strings.grd',
]

RE_TRANSLATIONBUNDLE = re.compile('<translationbundle lang="(.*)">')

def _GrdToXtb(grd_path, translation_locale):
  """Convert a .grd input path into the equivalent translation .xtb file.

  Args:
    grd_path: Input .grd file path.
    translation_locale: Chromium locale name (e.g. 'bn')
  Returns:
    Path of the corresponding .xtb translation path.
  """
  grd_base = os.path.basename(grd_path)
  return os.path.join(os.path.dirname(grd_path), 'translations',
                      '%s_%s.xtb' % (grd_base[:-4], translation_locale))

for grd_path in GRD_INPUTS:
  src_file = _GrdToXtb(grd_path, SRC_LOCALE)
  with open(src_file) as f:
    src_data = f.read()

  m = RE_TRANSLATIONBUNDLE.search(src_data)
  assert m is not None

  for locale in DST_LOCALES:
    dst_file = _GrdToXtb(grd_path, locale)
    dst_data = src_data[:m.start(1)] + locale + src_data[m.end(1):]
    with open(dst_file, "wt") as f:
      f.write(dst_data)
------------------------ cut here --------------------------

Change-Id: I886d81d21826a36d1261a16052c3e3ca1561c7d2
Reviewed-on: https://chromium-review.googlesource.com/c/1297364
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Krishna Govind <govind@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: David Turner <digit@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602725}
[modify] https://crrev.com/bed2fe29f5758e6958d312b96dbc3edd9cafeb47/android_webview/java/strings/android_webview_strings.grd
[add] https://crrev.com/bed2fe29f5758e6958d312b96dbc3edd9cafeb47/android_webview/java/strings/translations/android_webview_strings_bn.xtb
[add] https://crrev.com/bed2fe29f5758e6958d312b96dbc3edd9cafeb47/android_webview/java/strings/translations/android_webview_strings_et.xtb
[add] https://crrev.com/bed2fe29f5758e6958d312b96dbc3edd9cafeb47/android_webview/java/strings/translations/android_webview_strings_gu.xtb
[add] https://crrev.com/bed2fe29f5758e6958d312b96dbc3edd9cafeb47/android_webview/java/strings/translations/android_webview_strings_kn.xtb
[add] https://crrev.com/bed2fe29f5758e6958d312b96dbc3edd9cafeb47/android_webview/java/strings/translations/android_webview_strings_ml.xtb
[add] https://crrev.com/bed2fe29f5758e6958d312b96dbc3edd9cafeb47/android_webview/java/strings/translations/android_webview_strings_mr.xtb
[add] https://crrev.com/bed2fe29f5758e6958d312b96dbc3edd9cafeb47/android_webview/java/strings/translations/android_webview_strings_ms.xtb
[add] https://crrev.com/bed2fe29f5758e6958d312b96dbc3edd9cafeb47/android_webview/java/strings/translations/android_webview_strings_ta.xtb
[add] https://crrev.com/bed2fe29f5758e6958d312b96dbc3edd9cafeb47/android_webview/java/strings/translations/android_webview_strings_te.xtb
[modify] https://crrev.com/bed2fe29f5758e6958d312b96dbc3edd9cafeb47/chrome/android/java/strings/android_chrome_strings.grd
[add] https://crrev.com/bed2fe29f5758e6958d312b96dbc3edd9cafeb47/chrome/android/java/strings/translations/android_chrome_strings_bn.xtb
[add] https://crrev.com/bed2fe29f5758e6958d312b96dbc3edd9cafeb47/chrome/android/java/strings/translations/android_chrome_strings_et.xtb
[add] https://crrev.com/bed2fe29f5758e6958d312b96dbc3edd9cafeb47/chrome/android/java/strings/translations/android_chrome_strings_gu.xtb
[add] https://crrev.com/bed2fe29f5758e6958d312b96dbc3edd9cafeb47/chrome/android/java/strings/translations/android_chrome_strings_kn.xtb
[add] https://crrev.com/bed2fe29f5758e6958d312b96dbc3edd9cafeb47/chrome/android/java/strings/translations/android_chrome_strings_ml.xtb
[add] https://crrev.com/bed2fe29f5758e6958d312b96dbc3edd9cafeb47/chrome/android/java/strings/translations/android_chrome_strings_mr.xtb
[add] https://crrev.com/bed2fe29f5758e6958d312b96dbc3edd9cafeb47/chrome/android/java/strings/translations/android_chrome_strings_ms.xtb
[add] https://crrev.com/bed2fe29f5758e6958d312b96dbc3edd9cafeb47/chrome/android/java/strings/translations/android_chrome_strings_ta.xtb
[add] https://crrev.com/bed2fe29f5758e6958d312b96dbc3edd9cafeb47/chrome/android/java/strings/translations/android_chrome_strings_te.xtb
[modify] https://crrev.com/bed2fe29f5758e6958d312b96dbc3edd9cafeb47/chrome/android/webapk/strings/android_webapk_strings.grd
[add] https://crrev.com/bed2fe29f5758e6958d312b96dbc3edd9cafeb47/chrome/android/webapk/strings/translations/android_webapk_strings_bn.xtb
[add] https://crrev.com/bed2fe29f5758e6958d312b96dbc3edd9cafeb47/chrome/android/webapk/strings/translations/android_webapk_strings_et.xtb
[add] https://crrev.com/bed2fe29f5758e6958d312b96dbc3edd9cafeb47/chrome/android/webapk/strings/translations/android_webapk_strings_gu.xtb
[add] https://crrev.com/bed2fe29f5758e6958d312b96dbc3edd9cafeb47/chrome/android/webapk/strings/translations/android_webapk_strings_kn.xtb
[add] https://crrev.com/bed2fe29f5758e6958d312b96dbc3edd9cafeb47/chrome/android/webapk/strings/translations/android_webapk_strings_ml.xtb
[add] https://crrev.com/bed2fe29f5758e6958d312b96dbc3edd9cafeb47/chrome/android/webapk/strings/translations/android_webapk_strings_mr.xtb
[add] https://crrev.com/bed2fe29f5758e6958d312b96dbc3edd9cafeb47/chrome/android/webapk/strings/translations/android_webapk_strings_ms.xtb
[add] https://crrev.com/bed2fe29f5758e6958d312b96dbc3edd9cafeb47/chrome/android/webapk/strings/translations/android_webapk_strings_ta.xtb
[add] https://crrev.com/bed2fe29f5758e6958d312b96dbc3edd9cafeb47/chrome/android/webapk/strings/translations/android_webapk_strings_te.xtb
[modify] https://crrev.com/bed2fe29f5758e6958d312b96dbc3edd9cafeb47/components/autofill/android/java/strings/autofill_strings.grd
[add] https://crrev.com/bed2fe29f5758e6958d312b96dbc3edd9cafeb47/components/autofill/android/java/strings/translations/autofill_strings_bn.xtb
[add] https://crrev.com/bed2fe29f5758e6958d312b96dbc3edd9cafeb47/components/autofill/android/java/strings/translations/autofill_strings_et.xtb
[add] https://crrev.com/bed2fe29f5758e6958d312b96dbc3edd9cafeb47/components/autofill/android/java/strings/translations/autofill_strings_gu.xtb
[add] https://crrev.com/bed2fe29f5758e6958d312b96dbc3edd9cafeb47/components/autofill/android/java/strings/translations/autofill_strings_kn.xtb
[add] https://crrev.com/bed2fe29f5758e6958d312b96dbc3edd9cafeb47/components/autofill/android/java/strings/translations/autofill_strings_ml.xtb
[add] https://crrev.com/bed2fe29f5758e6958d312b96dbc3edd9cafeb47/components/autofill/android/java/strings/translations/autofill_strings_mr.xtb
[add] https://crrev.com/bed2fe29f5758e6958d312b96dbc3edd9cafeb47/components/autofill/android/java/strings/translations/autofill_strings_ms.xtb
[add] https://crrev.com/bed2fe29f5758e6958d312b96dbc3edd9cafeb47/components/autofill/android/java/strings/translations/autofill_strings_ta.xtb
[add] https://crrev.com/bed2fe29f5758e6958d312b96dbc3edd9cafeb47/components/autofill/android/java/strings/translations/autofill_strings_te.xtb
[add] https://crrev.com/bed2fe29f5758e6958d312b96dbc3edd9cafeb47/components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_bn.xtb
[add] https://crrev.com/bed2fe29f5758e6958d312b96dbc3edd9cafeb47/components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_et.xtb
[add] https://crrev.com/bed2fe29f5758e6958d312b96dbc3edd9cafeb47/components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_gu.xtb
[add] https://crrev.com/bed2fe29f5758e6958d312b96dbc3edd9cafeb47/components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_kn.xtb
[add] https://crrev.com/bed2fe29f5758e6958d312b96dbc3edd9cafeb47/components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_ml.xtb
[add] https://crrev.com/bed2fe29f5758e6958d312b96dbc3edd9cafeb47/components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_mr.xtb
[add] https://crrev.com/bed2fe29f5758e6958d312b96dbc3edd9cafeb47/components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_ms.xtb
[add] https://crrev.com/bed2fe29f5758e6958d312b96dbc3edd9cafeb47/components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_ta.xtb
[add] https://crrev.com/bed2fe29f5758e6958d312b96dbc3edd9cafeb47/components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_te.xtb
[modify] https://crrev.com/bed2fe29f5758e6958d312b96dbc3edd9cafeb47/components/embedder_support/android/java/strings/web_contents_delegate_android_strings.grd
[modify] https://crrev.com/bed2fe29f5758e6958d312b96dbc3edd9cafeb47/content/public/android/java/strings/android_content_strings.grd
[add] https://crrev.com/bed2fe29f5758e6958d312b96dbc3edd9cafeb47/content/public/android/java/strings/translations/android_content_strings_bn.xtb
[add] https://crrev.com/bed2fe29f5758e6958d312b96dbc3edd9cafeb47/content/public/android/java/strings/translations/android_content_strings_et.xtb
[add] https://crrev.com/bed2fe29f5758e6958d312b96dbc3edd9cafeb47/content/public/android/java/strings/translations/android_content_strings_gu.xtb
[add] https://crrev.com/bed2fe29f5758e6958d312b96dbc3edd9cafeb47/content/public/android/java/strings/translations/android_content_strings_kn.xtb
[add] https://crrev.com/bed2fe29f5758e6958d312b96dbc3edd9cafeb47/content/public/android/java/strings/translations/android_content_strings_ml.xtb
[add] https://crrev.com/bed2fe29f5758e6958d312b96dbc3edd9cafeb47/content/public/android/java/strings/translations/android_content_strings_mr.xtb
[add] https://crrev.com/bed2fe29f5758e6958d312b96dbc3edd9cafeb47/content/public/android/java/strings/translations/android_content_strings_ms.xtb
[add] https://crrev.com/bed2fe29f5758e6958d312b96dbc3edd9cafeb47/content/public/android/java/strings/translations/android_content_strings_ta.xtb
[add] https://crrev.com/bed2fe29f5758e6958d312b96dbc3edd9cafeb47/content/public/android/java/strings/translations/android_content_strings_te.xtb
[modify] https://crrev.com/bed2fe29f5758e6958d312b96dbc3edd9cafeb47/tools/gritsettings/translation_expectations.pyl
[modify] https://crrev.com/bed2fe29f5758e6958d312b96dbc3edd9cafeb47/ui/android/java/strings/android_ui_strings.grd
[add] https://crrev.com/bed2fe29f5758e6958d312b96dbc3edd9cafeb47/ui/android/java/strings/translations/android_ui_strings_bn.xtb
[add] https://crrev.com/bed2fe29f5758e6958d312b96dbc3edd9cafeb47/ui/android/java/strings/translations/android_ui_strings_et.xtb
[add] https://crrev.com/bed2fe29f5758e6958d312b96dbc3edd9cafeb47/ui/android/java/strings/translations/android_ui_strings_gu.xtb
[add] https://crrev.com/bed2fe29f5758e6958d312b96dbc3edd9cafeb47/ui/android/java/strings/translations/android_ui_strings_kn.xtb
[add] https://crrev.com/bed2fe29f5758e6958d312b96dbc3edd9cafeb47/ui/android/java/strings/translations/android_ui_strings_ml.xtb
[add] https://crrev.com/bed2fe29f5758e6958d312b96dbc3edd9cafeb47/ui/android/java/strings/translations/android_ui_strings_mr.xtb
[add] https://crrev.com/bed2fe29f5758e6958d312b96dbc3edd9cafeb47/ui/android/java/strings/translations/android_ui_strings_ms.xtb
[add] https://crrev.com/bed2fe29f5758e6958d312b96dbc3edd9cafeb47/ui/android/java/strings/translations/android_ui_strings_ta.xtb
[add] https://crrev.com/bed2fe29f5758e6958d312b96dbc3edd9cafeb47/ui/android/java/strings/translations/android_ui_strings_te.xtb

Owner: gov...@chromium.org
First CL submitted, now it's up to govind@ to run the import process to update the .xtb files.

Once this is done, please re-assign the bug to me so I can adjust the build system appropriately. And let me know of any issues.
Project Member

Comment 23 by bugdroid1@chromium.org, Nov 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3811952f87994f70f31416a6cac89236d606d3f5

commit 3811952f87994f70f31416a6cac89236d606d3f5
Author: David 'Digit' Turner <digit@google.com>
Date: Tue Nov 06 15:43:40 2018

build: Better temporary resources directory.

Ensure that compile_resources.py will put temporary
resource directories under

  $ANDROID_DEBUG_TEM_RESOURCES_DIR/<target_name>/

This makes it easier to distinguish between temp resources
of different packages, as discussed in a previous CL [1],
which was merged too soon by mistake (it was supposed to
include this change).

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1288436/

BUG=879228
R=agrieve@chromium.org, estevenson@chromium.org, yfriedman@chromium.org

Change-Id: I0cc7e2f675e70ddc5cb23c270a801a5c2655e023
Reviewed-on: https://chromium-review.googlesource.com/c/1318912
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Commit-Queue: David Turner <digit@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605688}
[modify] https://crrev.com/3811952f87994f70f31416a6cac89236d606d3f5/build/android/gyp/compile_resources.py

Owner: digit@chromium.org
Translation run on master/trunk has been passing without any issues. Assigning back to digit@ per comment #22.

Sign in to add a comment