New issue
Advanced search Search tips

Issue 879227 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Mojo should support math expressions in embedded constants

Project Member Reported by c...@chromium.org, Aug 30

Issue description

Updating "third_party/blink/public/mojom/indexeddb/indexeddb.mojom" with this line:

  const int32 kIDBMaxMessageOverhead = 1024 * 1024;

fails compile with:

[926/11336] ACTION //third_party/blink/public/mojom:mojom_platform__parser(//build/toolchain/linux:clang_x64) ...
python ../../mojo/public/tools/bindings/mojom_bindings_generator.py parse --filelist=__third_party_blink_public_mojom_mojom_platform__parser___build_toolchain_linux_clang_x64__rule..rsp -o gen -d ../../ --enable_feature is_posix --enable_feature is_linux
../../third_party/blink/public/mojom/indexeddb/indexeddb.mojom: Error: ../../third_party/blink/public/mojom/indexeddb/indexeddb.mojom:22: Error: Illegal character '*'

Instead of the 1024 * 1024 math expression, I used the following as a workaround:

  const int32 kIDBMaxMessageOverhead = 1048576;

However, this is not as readable as the original and could lead to later incorrect changes.  I've added comments to explain what the intent is on the line, but if I could use the original math expression, instead, that would be a lot better.
 

Sign in to add a comment