New issue
Advanced search Search tips

Issue 879222 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

better handling of large IDB Mojo messages

Project Member Reported by c...@chromium.org, Aug 30

Issue description

Currently we use a hard-coded limit to ensure we don't pass any args through a Mojo interface that would serialize to a size larger than Mojo's limits.  This has the following issues:

- our limit is based on a hard-coded value that doesn't represent what Mojo may use, which could also be dynamic depending on the case
- our limit uses static_asserts to ensure it's sane
- our checking is done on a single arg and guesses at the overall message size, so we may actually exceed the limit in certain cases
- there are no tests around the boundary conditions

A nice overall solution would be to share the data in some other way rather than being serialized, such as a shared memory segment passed across the Mojo call that's copied in-process for web page access.  This is the solution other systems use to pass large data through Mojo, though most users don't also have the requirement of making that data available to the web page.  If this works, that would be a great way to wrap this up.

If that approach doesn't work, we should investigate splitting/chunking our calls so we avoid hitting the limit in the first place.
 

Comment 1 Deleted

Also related to issue 868177 I believe?
Cc: mek@chromium.org
Status: Available (was: Untriaged)
Agree this is related to issue 868177.  Not exactly a duplicate, and that issue isn't exactly a duplicate of this one.  They both seem valid to me.

Marking this Available for now.

Sign in to add a comment