New issue
Advanced search Search tips

Issue 879208 link

Starred by 3 users
Status: Started
Owner:
carai...@chromium.org
Cc:
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac , Fuchsia
Pri: 3
Type: Feature

Blocked on:
issue 922842
Blocking:
issue 786559



Sign in to add a comment

Cronet Native API should implement RequestFinishedInfo Metrics

Project Member Reported by mef@chromium.org, Aug 30 
Cronet Java API provides detailed RequestFinishedInfo Metrics API with time and byte count information.

The native API should provide the same.

Design doc: http://docs.google.com/document/d/1DkJ4mV6niyLbGLW1J7N8E288Qt_kwVuuiqnq_z_Xjlg

Comment 1 by mef@chromium.org, Aug 30 

We need to define RequestFinishedInfo.Metrics in cronet.idl and populate one in  Cronet_UrlRequestImpl::NetworkTasks::OnMetricsCollected().

Comment 2 by mef@chromium.org, Aug 30

Blocking: 786559

Comment 3 by olivierrobin@chromium.org, Aug 31

Owner: mef@chromium.org
Status: Assigned (was: Untriaged)

Comment 4 by mef@chromium.org, Dec 5

Owner: carai...@chromium.org
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 2 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1206d95090d6bc8ac1faa566d4fbfd90e27ba50e

commit 1206d95090d6bc8ac1faa566d4fbfd90e27ba50e
Author: Caleb Raitto <caraitto@chromium.org>
Date: Wed Jan 02 18:04:20 2019

[Cronet] Add support for constants in cronet idl.

This adds support needed by crrev.com/c/1374158.

Bug: 879208
Change-Id: I80894a166cf4233087b81a455cfc22a106f724e6
Reviewed-on: https://chromium-review.googlesource.com/c/1382694
Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Reviewed-by: Misha Efimov <mef@chromium.org>
Commit-Queue: Caleb Raitto <caraitto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619429}
[modify] https://crrev.com/1206d95090d6bc8ac1faa566d4fbfd90e27ba50e/components/cronet/tools/generators/c_templates/module_c.h.tmpl
[modify] https://crrev.com/1206d95090d6bc8ac1faa566d4fbfd90e27ba50e/components/cronet/tools/generators/cronet_c_generator.py

Comment 9 by carai...@chromium.org, Jan 2

Description: Show this description

Comment 12 by carai...@chromium.org, Jan 10

Status: Started (was: Assigned)
Project Member

Comment 13 by bugdroid1@chromium.org, Jan 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6399502af5ae7c39b93ab9a47bb22de03c42d55f

commit 6399502af5ae7c39b93ab9a47bb22de03c42d55f
Author: Misha Efimov <mef@chromium.org>
Date: Mon Jan 14 18:20:04 2019

[Cronet] Add support of struct within a struct in Native API.

Uses base::Optional<StructType> to store StructType.

Bug:879208

Change-Id: Ib3a6389dcd10035122a0a504398192434fa94da4
Reviewed-on: https://chromium-review.googlesource.com/c/1405287
Commit-Queue: Misha Efimov <mef@chromium.org>
Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622515}
[modify] https://crrev.com/6399502af5ae7c39b93ab9a47bb22de03c42d55f/components/cronet/native/cronet.idl
[modify] https://crrev.com/6399502af5ae7c39b93ab9a47bb22de03c42d55f/components/cronet/native/generated/cronet.idl_c.h
[modify] https://crrev.com/6399502af5ae7c39b93ab9a47bb22de03c42d55f/components/cronet/native/generated/cronet.idl_impl_struct.cc
[modify] https://crrev.com/6399502af5ae7c39b93ab9a47bb22de03c42d55f/components/cronet/native/generated/cronet.idl_impl_struct.h
[modify] https://crrev.com/6399502af5ae7c39b93ab9a47bb22de03c42d55f/components/cronet/native/generated/cronet.idl_impl_struct_unittest.cc
[modify] https://crrev.com/6399502af5ae7c39b93ab9a47bb22de03c42d55f/components/cronet/tools/generators/c_templates/module_c.h.tmpl
[modify] https://crrev.com/6399502af5ae7c39b93ab9a47bb22de03c42d55f/components/cronet/tools/generators/c_templates/module_impl_struct.cc.tmpl
[modify] https://crrev.com/6399502af5ae7c39b93ab9a47bb22de03c42d55f/components/cronet/tools/generators/c_templates/module_impl_struct.h.tmpl
[modify] https://crrev.com/6399502af5ae7c39b93ab9a47bb22de03c42d55f/components/cronet/tools/generators/c_templates/module_impl_struct_unittest.cc.tmpl
Project Member

Comment 14 by bugdroid1@chromium.org, Jan 16 (6 days ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/51cd7d34327cab71ca77228ee5270da4fe0c1751

commit 51cd7d34327cab71ca77228ee5270da4fe0c1751
Author: Caleb Raitto <caraitto@chromium.org>
Date: Wed Jan 16 18:13:10 2019

[Cronet] Move the metrics back into their own struct.

http://crrev.com/c/1405287 added C generator support for structs-in-struct --
with this, we can move the metrics back into their own struct like the
Java API.

Bug: 879208
Change-Id: Ib5dada64b4a674a275d18eeb013e946480fc9435
Reviewed-on: https://chromium-review.googlesource.com/c/1407638
Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Reviewed-by: Misha Efimov <mef@chromium.org>
Commit-Queue: Caleb Raitto <caraitto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623295}
[modify] https://crrev.com/51cd7d34327cab71ca77228ee5270da4fe0c1751/components/cronet/native/cronet.idl
[modify] https://crrev.com/51cd7d34327cab71ca77228ee5270da4fe0c1751/components/cronet/native/generated/cronet.idl_c.h
[modify] https://crrev.com/51cd7d34327cab71ca77228ee5270da4fe0c1751/components/cronet/native/generated/cronet.idl_impl_struct.cc
[modify] https://crrev.com/51cd7d34327cab71ca77228ee5270da4fe0c1751/components/cronet/native/generated/cronet.idl_impl_struct.h
[modify] https://crrev.com/51cd7d34327cab71ca77228ee5270da4fe0c1751/components/cronet/native/generated/cronet.idl_impl_struct_unittest.cc
Project Member

Comment 16 by bugdroid1@chromium.org, Jan 17 (6 days ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/451c922ea1dac592af1a8723e6f999125bf6f6c3

commit 451c922ea1dac592af1a8723e6f999125bf6f6c3
Author: Caleb Raitto <caraitto@chromium.org>
Date: Thu Jan 17 01:11:50 2019

[Cronet] Add API methods to attach RequestFinishedInfoListeners.

For now, I'm only focusing on defining the API contract --
implementation will come in a follow-up CL.

Bug: 879208
Change-Id: I6b0acc5b9a54d0096ce766ec26958785a12db447
Reviewed-on: https://chromium-review.googlesource.com/c/1399511
Commit-Queue: Caleb Raitto <caraitto@chromium.org>
Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Reviewed-by: Misha Efimov <mef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623490}
[modify] https://crrev.com/451c922ea1dac592af1a8723e6f999125bf6f6c3/components/cronet/native/cronet.idl
[modify] https://crrev.com/451c922ea1dac592af1a8723e6f999125bf6f6c3/components/cronet/native/engine.cc
[modify] https://crrev.com/451c922ea1dac592af1a8723e6f999125bf6f6c3/components/cronet/native/engine.h
[modify] https://crrev.com/451c922ea1dac592af1a8723e6f999125bf6f6c3/components/cronet/native/generated/cronet.idl_c.h
[modify] https://crrev.com/451c922ea1dac592af1a8723e6f999125bf6f6c3/components/cronet/native/generated/cronet.idl_impl_interface.cc
[modify] https://crrev.com/451c922ea1dac592af1a8723e6f999125bf6f6c3/components/cronet/native/generated/cronet.idl_impl_interface.h
[modify] https://crrev.com/451c922ea1dac592af1a8723e6f999125bf6f6c3/components/cronet/native/generated/cronet.idl_impl_interface_unittest.cc
[modify] https://crrev.com/451c922ea1dac592af1a8723e6f999125bf6f6c3/components/cronet/native/generated/cronet.idl_impl_struct.cc
[modify] https://crrev.com/451c922ea1dac592af1a8723e6f999125bf6f6c3/components/cronet/native/generated/cronet.idl_impl_struct.h
[modify] https://crrev.com/451c922ea1dac592af1a8723e6f999125bf6f6c3/components/cronet/native/generated/cronet.idl_impl_struct_unittest.cc

Comment 17 by ksakamoto@chromium.org, Jan 17 (6 days ago)

Blockedon: 922842
Project Member

Comment 18 by bugdroid1@chromium.org, Jan 17 (5 days ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b95baa036400de1918372682d0343c7204fbee23

commit b95baa036400de1918372682d0343c7204fbee23
Author: Caleb Raitto <caraitto@chromium.org>
Date: Thu Jan 17 23:10:06 2019

[Cronet] Default DateTime.value to 0 to fix MSAN issue.

Bug:  922842 ,879208
Change-Id: I44a70473504c9e32f4bc45520f5c2ef213388787
Reviewed-on: https://chromium-review.googlesource.com/c/1418877
Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Commit-Queue: Caleb Raitto <caraitto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623893}
[modify] https://crrev.com/b95baa036400de1918372682d0343c7204fbee23/components/cronet/native/cronet.idl
[modify] https://crrev.com/b95baa036400de1918372682d0343c7204fbee23/components/cronet/native/generated/cronet.idl_impl_struct.h
[modify] https://crrev.com/b95baa036400de1918372682d0343c7204fbee23/components/cronet/native/generated/cronet.idl_impl_struct_unittest.cc
►

Sign in to add a comment