New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 879167 link

Starred by 1 user
Status: Fixed
Owner:
█ sweilun@chromium.org
Last visit 18 days ago
Closed: Sep 4
Cc:
yyushkina@chromium.org
nyerramilli@chromium.org
rbasuvula@chromium.org
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug



Sign in to add a comment

[NTP] "Add shortcut" overlay opens up before releasing the 'Spacebar' key hold

Reported by khushal....@etouch.net, Aug 30 
Chrome Version: 70.0.3537.0 (Official Build) Revision 57f65e033d6d9160457a612f5033171bdfeaca42-refs/branch-heads/3537@{#1} (32/64-bit)
OS: Mac (10.12.6, 10.13.1, 10.13.6, 10.14), Win (7, 8, 8.1, 10) & Linux (14.04 LTS)

Pre-condition: Enable the flag 'Enable using the Google local NTP' and 'New Tab Page Custom Links' from chrome://flags/

What steps will reproduce the problem?
(1) Launch chrome and open NTP.
(2) Traverse the focus using 'Tab' key on 'Add shortcut'.
(3) Now hold the 'Spacebar' key and Observe.

Actual Result:
1) 'Add shortcut' overlay opens up before releasing the 'Spacebar' key hold.
2) Unnecessary spaces are entered on holding the 'Spacebar' key on "Add shortcut" overlay.

Expected Result:
1) 'Add shortcut' overlay should open after releasing the 'Spacebar' key hold.
2) Unnecessary spaces should not get entered on holding the 'Spacebar' key on "Add shortcut" overlay.

This is a Non-Regression issue seen from ‘M-70'.

NOTE: Issue is also seen on M-70 Dev (build #70.0.3534.4).

Kindly refer the attached screen-cast.

Thank You..!!
Actual Video.mov
5.0 MB View Download

Comment 1 by rbasuvula@chromium.org, Aug 30

Status: Untriaged (was: Unconfirmed)
As this being a Non-Regression issue, changing the status to Untriaged so that the issue would get addressed.

Thank You!

Comment 2 by yyushkina@chromium.org, Aug 30

Cc: yyushkina@chromium.org
Labels: -Pri-2 Pri-3
Owner: sweilun@chromium.org
Status: Assigned (was: Untriaged)
Lowering priority due to obscure action and assigning to Weilun to PTAL

Comment 3 by sweilun@chromium.org, Sep 1

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 1 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/00717c1f6d2147000e4e4d47b0d7545b8de476bf

commit 00717c1f6d2147000e4e4d47b0d7545b8de476bf
Author: Weilun Shi <sweilun@chromium.org>
Date: Sat Sep 01 01:27:46 2018

[NTP] Open/Activate tile after spacebar/enter release

Listen on the tile's keyup event instead of keydown event to prevent
opening "Add shortcut" dialog before releasing the spacebar.

Bug:  879167 
Change-Id: Id7668562db1f3db47f5f484670f06b9080b34c6d
Reviewed-on: https://chromium-review.googlesource.com/1200403
Commit-Queue: Weilun Shi <sweilun@chromium.org>
Reviewed-by: Kristi Park <kristipark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588241}
[modify] https://crrev.com/00717c1f6d2147000e4e4d47b0d7545b8de476bf/chrome/browser/resources/local_ntp/most_visited_single.js

Comment 5 by khushal....@etouch.net, Sep 3

Labels: TE-Verified-M71 TE-Verified-71.0.3541.0
Update:

Rechecked the above issue on Mac (10.12.6, 10.13.1, 10.13.6, 10.14), Win (7, 8, 8.1, 10) & Linux (14.04 LTS) using latest canary version #71.0.3541.0 and the issue is found FIXED.
Hence, adding respective labels.

Please refer the attached screen-cast.

Thank You..!!
Fixed Video.mov
4.1 MB View Download

Comment 6 by twelling...@chromium.org, Sep 4

Labels: zine-triaged

Comment 7 by sweilun@chromium.org, Sep 4

Status: Fixed (was: Started)
►

Sign in to add a comment